* [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
@ 2022-10-27 13:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_mlc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c
index 306e2c2165011769..ae7f6429a5f64254 100644
--- a/drivers/mtd/nand/raw/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c
@@ -850,7 +850,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -882,11 +881,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-mlc" },
{ /* sentinel */ },
@@ -896,8 +890,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = DRV_NAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
@ 2022-10-27 13:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_mlc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c
index 306e2c2165011769..ae7f6429a5f64254 100644
--- a/drivers/mtd/nand/raw/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c
@@ -850,7 +850,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -882,11 +881,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-mlc" },
{ /* sentinel */ },
@@ -896,8 +890,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = DRV_NAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
@ 2022-10-27 13:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_mlc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c
index 306e2c2165011769..ae7f6429a5f64254 100644
--- a/drivers/mtd/nand/raw/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c
@@ -850,7 +850,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -882,11 +881,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-mlc" },
{ /* sentinel */ },
@@ -896,8 +890,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = DRV_NAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
2022-10-27 13:10 ` Geert Uytterhoeven
(?)
@ 2022-10-27 13:10 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_slc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
index 4702577f74e5dae4..6918737346c95c8a 100644
--- a/drivers/mtd/nand/raw/lpc32xx_slc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
@@ -969,7 +969,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -1008,11 +1007,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-slc" },
{ /* sentinel */ },
@@ -1022,8 +1016,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = LPC32XX_MODNAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
@ 2022-10-27 13:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_slc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
index 4702577f74e5dae4..6918737346c95c8a 100644
--- a/drivers/mtd/nand/raw/lpc32xx_slc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
@@ -969,7 +969,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -1008,11 +1007,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-slc" },
{ /* sentinel */ },
@@ -1022,8 +1016,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = LPC32XX_MODNAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
@ 2022-10-27 13:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2022-10-27 13:10 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, Geert Uytterhoeven, noreply
The switch to using the gpiod API removed the last user of
lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
CONFIG_PM=n:
drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
| ^~~~~~~~~~~~~~~~~~
Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
compile-coverage as a side-effect.
Reported-by: noreply@ellerman.id.au
Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/raw/lpc32xx_slc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
index 4702577f74e5dae4..6918737346c95c8a 100644
--- a/drivers/mtd/nand/raw/lpc32xx_slc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
@@ -969,7 +969,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM
static int lpc32xx_nand_resume(struct platform_device *pdev)
{
struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
@@ -1008,11 +1007,6 @@ static int lpc32xx_nand_suspend(struct platform_device *pdev, pm_message_t pm)
return 0;
}
-#else
-#define lpc32xx_nand_resume NULL
-#define lpc32xx_nand_suspend NULL
-#endif
-
static const struct of_device_id lpc32xx_nand_match[] = {
{ .compatible = "nxp,lpc3220-slc" },
{ /* sentinel */ },
@@ -1022,8 +1016,8 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match);
static struct platform_driver lpc32xx_nand_driver = {
.probe = lpc32xx_nand_probe,
.remove = lpc32xx_nand_remove,
- .resume = lpc32xx_nand_resume,
- .suspend = lpc32xx_nand_suspend,
+ .resume = pm_ptr(lpc32xx_nand_resume),
+ .suspend = pm_ptr(lpc32xx_nand_suspend),
.driver = {
.name = LPC32XX_MODNAME,
.of_match_table = lpc32xx_nand_match,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
2022-10-27 13:10 ` Geert Uytterhoeven
(?)
@ 2022-11-07 16:23 ` Miquel Raynal
-1 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:28 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
@ 2022-11-07 16:23 ` Miquel Raynal
0 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:28 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] mtd: rawnand: lpc32xx_slc: Switch to using pm_ptr()
@ 2022-11-07 16:23 ` Miquel Raynal
0 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:28 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_slc.c:318:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 318 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 6b923db2867cb5e1 ("mtd: rawnand: lpc32xx_slc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
2022-10-27 13:10 ` Geert Uytterhoeven
(?)
@ 2022-11-07 16:23 ` Miquel Raynal
-1 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:27 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
@ 2022-11-07 16:23 ` Miquel Raynal
0 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:27 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr()
@ 2022-11-07 16:23 ` Miquel Raynal
0 siblings, 0 replies; 12+ messages in thread
From: Miquel Raynal @ 2022-11-07 16:23 UTC (permalink / raw)
To: Geert Uytterhoeven, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Vladimir Zapolskiy, Dmitry Torokhov
Cc: linux-mtd, linux-arm-kernel, linux-kernel, noreply
On Thu, 2022-10-27 at 13:10:27 UTC, Geert Uytterhoeven wrote:
> The switch to using the gpiod API removed the last user of
> lpc32xx_wp_disable() outside #ifdef CONFIG_PM, causing build failures if
> CONFIG_PM=n:
>
> drivers/mtd/nand/raw/lpc32xx_mlc.c:380:13: error: ‘lpc32xx_wp_disable’ defined but not used [-Werror=unused-function]
> 380 | static void lpc32xx_wp_disable(struct lpc32xx_nand_host *host)
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by switching from #ifdef CONFIG_PM to pm_ptr(), increasing
> compile-coverage as a side-effect.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 782e32a990d9d702 ("mtd: rawnand: lpc32xx_mlc: switch to using gpiod API")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-11-07 16:38 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 13:10 [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: Switch to using pm_ptr() Geert Uytterhoeven
2022-10-27 13:10 ` Geert Uytterhoeven
2022-10-27 13:10 ` Geert Uytterhoeven
2022-10-27 13:10 ` [PATCH 2/2] mtd: rawnand: lpc32xx_slc: " Geert Uytterhoeven
2022-10-27 13:10 ` Geert Uytterhoeven
2022-10-27 13:10 ` Geert Uytterhoeven
2022-11-07 16:23 ` Miquel Raynal
2022-11-07 16:23 ` Miquel Raynal
2022-11-07 16:23 ` Miquel Raynal
2022-11-07 16:23 ` [PATCH 1/2] mtd: rawnand: lpc32xx_mlc: " Miquel Raynal
2022-11-07 16:23 ` Miquel Raynal
2022-11-07 16:23 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.