* [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs
@ 2022-10-26 19:05 Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
This series containes firmware, SoC, rpmpd, and tz-log bindings as
well as pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
Changes from v2:
- Dropped qru compat strings
- Marked no clocks on qdu/qru scm device
- Revised rpmhpd constants
- Updated socinfo driver to new format
Melody Olvera (5):
dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000
soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table
.../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
.../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
drivers/soc/qcom/rpmhpd.c | 14 ++++++++++++++
drivers/soc/qcom/socinfo.c | 6 ++++++
include/dt-bindings/arm/qcom,ids.h | 6 ++++++
include/dt-bindings/power/qcom-rpmpd.h | 6 ++++++
6 files changed, 48 insertions(+)
base-commit: 60eac8672b5b6061ec07499c0f1b79f6d94311ce
--
2.25.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-27 15:24 ` Krzysztof Kozlowski
2022-11-07 17:38 ` Bjorn Andersson
2022-10-26 19:05 ` [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
` (5 subsequent siblings)
6 siblings, 2 replies; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
.../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index be1b5746eddb..5352181aa393 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -38,6 +38,7 @@ properties:
- qcom,scm-msm8994
- qcom,scm-msm8996
- qcom,scm-msm8998
+ - qcom,scm-qdu1000
- qcom,scm-sc7180
- qcom,scm-sc7280
- qcom,scm-sc8280xp
@@ -81,6 +82,20 @@ properties:
description: TCSR hardware block
allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,scm-qdu1000
+ then:
+ properties:
+ '#reset-cells':
+ maxItems: 1
+ clocks: false
+ clock-names: false
+
+ required:
+ - '#reset-cells'
- if:
properties:
compatible:
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-27 15:25 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 3/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains Melody Olvera
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
Add compatible and constants for the power domains exposed by the RPMH
in the Qualcomm QDU1000 and QRU1000 platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 2ca98bad2d35..c0bee4e8a9db 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -28,6 +28,7 @@ properties:
- qcom,msm8998-rpmpd
- qcom,qcm2290-rpmpd
- qcom,qcs404-rpmpd
+ - qcom,qdu1000-rpmhpd
- qcom,sa8540p-rpmhpd
- qcom,sdm660-rpmpd
- qcom,sc7180-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 578e060890dd..7b2e4b66419a 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -113,6 +113,12 @@
#define SM8450_MXC_AO 11
#define SM8450_MSS 12
+/* QDU1000/QRU1000 Power Domain Indexes */
+#define QDU1000_EBI 0
+#define QDU1000_MSS 1
+#define QDU1000_CX 2
+#define QDU1000_MX 3
+
/* SC7180 Power Domain Indexes */
#define SC7180_CX 0
#define SC7180_CX_AO 1
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 3/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
2022-10-26 19:05 ` [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-26 19:05 ` [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000 Melody Olvera
` (3 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
Add the power domains exposed by RPMH in the Qualcomm QDU1000
and QRU1000 platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
drivers/soc/qcom/rpmhpd.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index b0c0e151c80a..7af68cd720f5 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -372,6 +372,19 @@ static const struct rpmhpd_desc sm8450_desc = {
.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
};
+/* QDU1000/QRU1000 RPMH powerdomains */
+static struct rpmhpd *qdu1000_rpmhpds[] = {
+ [QDU1000_CX] = &cx,
+ [QDU1000_EBI] = &ebi,
+ [QDU1000_MSS] = &mss,
+ [QDU1000_MX] = &mx,
+};
+
+static const struct rpmhpd_desc qdu1000_desc = {
+ .rpmhpds = qdu1000_rpmhpds,
+ .num_pds = ARRAY_SIZE(qdu1000_rpmhpds),
+};
+
/* SC7180 RPMH powerdomains */
static struct rpmhpd *sc7180_rpmhpds[] = {
[SC7180_CX] = &cx_w_mx_parent,
@@ -449,6 +462,7 @@ static const struct rpmhpd_desc sc8280xp_desc = {
};
static const struct of_device_id rpmhpd_match_table[] = {
+ { .compatible = "qcom,qdu1000-rpmhpd", .data = &qdu1000_desc },
{ .compatible = "qcom,sa8540p-rpmhpd", .data = &sa8540p_desc },
{ .compatible = "qcom,sc7180-rpmhpd", .data = &sc7180_desc },
{ .compatible = "qcom,sc7280-rpmhpd", .data = &sc7280_desc },
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
` (2 preceding siblings ...)
2022-10-26 19:05 ` [PATCH v3 3/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-27 16:41 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table Melody Olvera
` (2 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
Add SoC IDs for Qualcomm QDU1000 and QRU1000 platforms and their
variants.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
include/dt-bindings/arm/qcom,ids.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 755e08d494c5..8b1a0f43bd93 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -140,6 +140,12 @@
#define QCOM_ID_SC7280 487
#define QCOM_ID_SC7180P 495
#define QCOM_ID_SM6375 507
+#define QCOM_ID_QRU1000 539
+#define QCOM_ID_QDU1000 545
+#define QCOM_ID_QDU1010 587
+#define QCOM_ID_QRU1032 588
+#define QCOM_ID_QRU1052 589
+#define QCOM_ID_QRU1062 590
/*
* The board type and revision information, used by Qualcomm bootloaders and
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
` (3 preceding siblings ...)
2022-10-26 19:05 ` [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000 Melody Olvera
@ 2022-10-26 19:05 ` Melody Olvera
2022-10-27 15:23 ` [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Krzysztof Kozlowski
2022-11-08 1:27 ` (subset) " Bjorn Andersson
6 siblings, 0 replies; 16+ messages in thread
From: Melody Olvera @ 2022-10-26 19:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel, Melody Olvera
Add SoC ID table entries for the QDU1000 and QRU1000 platforms and
their variants.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
drivers/soc/qcom/socinfo.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 7ddcfc3e5076..545934aead43 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -343,6 +343,12 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(SC7280) },
{ qcom_board_id(SC7180P) },
{ qcom_board_id(SM6375) },
+ { qcom_board_id(QRU1000) },
+ { qcom_board_id(QDU1000) },
+ { qcom_board_id(QDU1010) },
+ { qcom_board_id(QRU1032) },
+ { qcom_board_id(QRU1052) },
+ { qcom_board_id(QRU1062) },
};
static const char *socinfo_machine(struct device *dev, unsigned int id)
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
` (4 preceding siblings ...)
2022-10-26 19:05 ` [PATCH v3 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table Melody Olvera
@ 2022-10-27 15:23 ` Krzysztof Kozlowski
2022-11-08 1:27 ` (subset) " Bjorn Andersson
6 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-27 15:23 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 26/10/2022 15:05, Melody Olvera wrote:
> This series containes firmware, SoC, rpmpd, and tz-log bindings as
> well as pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
@ 2022-10-27 15:24 ` Krzysztof Kozlowski
2022-11-07 23:14 ` Melody Olvera
2022-11-07 17:38 ` Bjorn Andersson
1 sibling, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-27 15:24 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 26/10/2022 15:05, Melody Olvera wrote:
> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index be1b5746eddb..5352181aa393 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -38,6 +38,7 @@ properties:
> - qcom,scm-msm8994
> - qcom,scm-msm8996
> - qcom,scm-msm8998
> + - qcom,scm-qdu1000
> - qcom,scm-sc7180
> - qcom,scm-sc7280
> - qcom,scm-sc8280xp
> @@ -81,6 +82,20 @@ properties:
> description: TCSR hardware block
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,scm-qdu1000
> + then:
> + properties:
> + '#reset-cells':
> + maxItems: 1
This is wrong... how can you have here more items?
> + clocks: false
> + clock-names: false
> +
> + required:
> + - '#reset-cells'
Missing blank line.
> - if:
> properties:
> compatible:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
2022-10-26 19:05 ` [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
@ 2022-10-27 15:25 ` Krzysztof Kozlowski
2022-11-07 17:48 ` Bjorn Andersson
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-27 15:25 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 26/10/2022 15:05, Melody Olvera wrote:
> Add compatible and constants for the power domains exposed by the RPMH
> in the Qualcomm QDU1000 and QRU1000 platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
Looks good, but you did not Cc maintainers and they must see this patch.
Who do you think will review and pick up this patch?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000
2022-10-26 19:05 ` [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000 Melody Olvera
@ 2022-10-27 16:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-27 16:41 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 26/10/2022 15:05, Melody Olvera wrote:
> Add SoC IDs for Qualcomm QDU1000 and QRU1000 platforms and their
> variants.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
Looks good, just CC of maintainers is missing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
2022-10-27 15:24 ` Krzysztof Kozlowski
@ 2022-11-07 17:38 ` Bjorn Andersson
2022-11-07 23:12 ` Melody Olvera
1 sibling, 1 reply; 16+ messages in thread
From: Bjorn Andersson @ 2022-11-07 17:38 UTC (permalink / raw)
To: Melody Olvera
Cc: Andy Gross, Rob Herring, Krzysztof Kozlowski, Robert Marko,
Guru Das Srinagesh, linux-arm-msm, devicetree, linux-kernel
On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote:
> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index be1b5746eddb..5352181aa393 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -38,6 +38,7 @@ properties:
> - qcom,scm-msm8994
> - qcom,scm-msm8996
> - qcom,scm-msm8998
> + - qcom,scm-qdu1000
> - qcom,scm-sc7180
> - qcom,scm-sc7280
> - qcom,scm-sc8280xp
> @@ -81,6 +82,20 @@ properties:
> description: TCSR hardware block
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,scm-qdu1000
> + then:
> + properties:
> + '#reset-cells':
> + maxItems: 1
> + clocks: false
> + clock-names: false
> +
> + required:
> + - '#reset-cells'
Please document what this reset is expected to be wired to, and write a
sentence or two in the commit message how the QDU differs from existing
platforms supported by the binding.
Thanks,
Bjorn
> - if:
> properties:
> compatible:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
2022-10-27 15:25 ` Krzysztof Kozlowski
@ 2022-11-07 17:48 ` Bjorn Andersson
2022-11-07 18:18 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Bjorn Andersson @ 2022-11-07 17:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Melody Olvera, Andy Gross, Rob Herring, Krzysztof Kozlowski,
Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On Thu, Oct 27, 2022 at 11:25:42AM -0400, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
> > Add compatible and constants for the power domains exposed by the RPMH
> > in the Qualcomm QDU1000 and QRU1000 platforms.
> >
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>
> Looks good, but you did not Cc maintainers and they must see this patch.
>
$ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/power/qcom,rpmpd.yaml include/dt-bindings/power/qcom-rpmpd.h
Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT)
Bjorn Andersson <andersson@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT,in file)
Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)
So you're right; Melody did miss Konrad in the recipients list. But he's
typically doing a very good job of keeping an eye on the list - and both
you and I got the patch.
Why didn't you add your R-b if you think it looks good?
> Who do you think will review and pick up this patch?
>
Per the maintainers file that would be me, and as you don't seem to
object to the content of the patch I'm queueing this now.
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
2022-11-07 17:48 ` Bjorn Andersson
@ 2022-11-07 18:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-07 18:18 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Melody Olvera, Andy Gross, Rob Herring, Krzysztof Kozlowski,
Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 07/11/2022 18:48, Bjorn Andersson wrote:
> On Thu, Oct 27, 2022 at 11:25:42AM -0400, Krzysztof Kozlowski wrote:
>> On 26/10/2022 15:05, Melody Olvera wrote:
>>> Add compatible and constants for the power domains exposed by the RPMH
>>> in the Qualcomm QDU1000 and QRU1000 platforms.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>
>> Looks good, but you did not Cc maintainers and they must see this patch.
>>
>
> $ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/power/qcom,rpmpd.yaml include/dt-bindings/power/qcom-rpmpd.h
> Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT)
> Bjorn Andersson <andersson@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT,in file)
> Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
> Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT)
> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
>
> So you're right; Melody did miss Konrad in the recipients list. But he's
> typically doing a very good job of keeping an eye on the list - and both
> you and I got the patch.
>
>
> Why didn't you add your R-b if you think it looks good?
Because then you would pick it up and that I did not want. It shall be
resent so all maintainers get it. I did not check though how many of
people were missing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
2022-11-07 17:38 ` Bjorn Andersson
@ 2022-11-07 23:12 ` Melody Olvera
0 siblings, 0 replies; 16+ messages in thread
From: Melody Olvera @ 2022-11-07 23:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Rob Herring, Krzysztof Kozlowski, Robert Marko,
Guru Das Srinagesh, linux-arm-msm, devicetree, linux-kernel
On 11/7/2022 9:38 AM, Bjorn Andersson wrote:
> On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote:
>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index be1b5746eddb..5352181aa393 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -38,6 +38,7 @@ properties:
>> - qcom,scm-msm8994
>> - qcom,scm-msm8996
>> - qcom,scm-msm8998
>> + - qcom,scm-qdu1000
>> - qcom,scm-sc7180
>> - qcom,scm-sc7280
>> - qcom,scm-sc8280xp
>> @@ -81,6 +82,20 @@ properties:
>> description: TCSR hardware block
>>
>> allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,scm-qdu1000
>> + then:
>> + properties:
>> + '#reset-cells':
>> + maxItems: 1
>> + clocks: false
>> + clock-names: false
>> +
>> + required:
>> + - '#reset-cells'
> Please document what this reset is expected to be wired to, and write a
> sentence or two in the commit message how the QDU differs from existing
> platforms supported by the binding.
>
Honestly, I can't remember what this is here for. Will remove from here and DT.
Will also add a quick blurb about not needing clocks.
Thanks,
Melody
>
>> - if:
>> properties:
>> compatible:
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
2022-10-27 15:24 ` Krzysztof Kozlowski
@ 2022-11-07 23:14 ` Melody Olvera
0 siblings, 0 replies; 16+ messages in thread
From: Melody Olvera @ 2022-11-07 23:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Robert Marko, Guru Das Srinagesh, linux-arm-msm, devicetree,
linux-kernel
On 10/27/2022 8:24 AM, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index be1b5746eddb..5352181aa393 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -38,6 +38,7 @@ properties:
>> - qcom,scm-msm8994
>> - qcom,scm-msm8996
>> - qcom,scm-msm8998
>> + - qcom,scm-qdu1000
>> - qcom,scm-sc7180
>> - qcom,scm-sc7280
>> - qcom,scm-sc8280xp
>> @@ -81,6 +82,20 @@ properties:
>> description: TCSR hardware block
>>
>> allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: qcom,scm-qdu1000
>> + then:
>> + properties:
>> + '#reset-cells':
>> + maxItems: 1
> This is wrong... how can you have here more items?
Being removed anyways.
>
>> + clocks: false
>> + clock-names: false
>> +
>> + required:
>> + - '#reset-cells'
> Missing blank line.
Ack.
Thanks,
Melody
>
>> - if:
>> properties:
>> compatible:
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
` (5 preceding siblings ...)
2022-10-27 15:23 ` [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Krzysztof Kozlowski
@ 2022-11-08 1:27 ` Bjorn Andersson
6 siblings, 0 replies; 16+ messages in thread
From: Bjorn Andersson @ 2022-11-08 1:27 UTC (permalink / raw)
To: robh+dt, quic_molvera, krzysztof.kozlowski+dt, agross
Cc: robimarko, devicetree, quic_gurus, linux-kernel, linux-arm-msm
On Wed, 26 Oct 2022 12:05:44 -0700, Melody Olvera wrote:
> This series containes firmware, SoC, rpmpd, and tz-log bindings as
> well as pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
> [...]
Applied, thanks!
[2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
commit: 8aa5cac4a2e05019fed4cb7187829add0c5aded6
[3/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
commit: 94949a014fac048591dd478a4126ce8cca6f8123
[4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000
commit: 3b1611f252bb8871f2e171758f8462704b7d8d52
[5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table
commit: 759dcdf24903f61bc46064e0f7dd8a68ea1a6376
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-11-08 1:28 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 19:05 [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-26 19:05 ` [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
2022-10-27 15:24 ` Krzysztof Kozlowski
2022-11-07 23:14 ` Melody Olvera
2022-11-07 17:38 ` Bjorn Andersson
2022-11-07 23:12 ` Melody Olvera
2022-10-26 19:05 ` [PATCH v3 2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
2022-10-27 15:25 ` Krzysztof Kozlowski
2022-11-07 17:48 ` Bjorn Andersson
2022-11-07 18:18 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 3/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains Melody Olvera
2022-10-26 19:05 ` [PATCH v3 4/5] dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000 Melody Olvera
2022-10-27 16:41 ` Krzysztof Kozlowski
2022-10-26 19:05 ` [PATCH v3 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table Melody Olvera
2022-10-27 15:23 ` [PATCH v3 0/5] Add misc support for QDU1000/QRU1000 SoCs Krzysztof Kozlowski
2022-11-08 1:27 ` (subset) " Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.