* [PATCH v1 0/1] baseband/acc100: fix for RC2
@ 2022-11-07 23:45 Nicolas Chautru
2022-11-07 23:45 ` [PATCH v1 1/1] baseband/acc100: fix to input error related to padding Nicolas Chautru
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Chautru @ 2022-11-07 23:45 UTC (permalink / raw)
To: dev, gakhil, maxime.coquelin, hernan.vargas; +Cc: Nicolas Chautru
Bug introduced in 22.11. The change to padding can lead to
reporting input size mismatch which is not a problem and
should not be considered as an error.
Nicolas Chautru (1):
baseband/acc100: fix to input error related to padding
drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
1 file changed, 3 deletions(-)
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] baseband/acc100: fix to input error related to padding
2022-11-07 23:45 [PATCH v1 0/1] baseband/acc100: fix for RC2 Nicolas Chautru
@ 2022-11-07 23:45 ` Nicolas Chautru
2022-11-08 5:41 ` [EXT] " Akhil Goyal
2022-11-08 13:41 ` Maxime Coquelin
0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Chautru @ 2022-11-07 23:45 UTC (permalink / raw)
To: dev, gakhil, maxime.coquelin, hernan.vargas; +Cc: Nicolas Chautru
Previous commit includes some padding for some cases,
which may cause input warning from the HW
which should be safely ignored to avoid false alarm.
Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index 96daef87bc..ba8247d47e 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
/* Clearing status, it will be set based on response */
op->status = 0;
- op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
@@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
desc, rsp.val, descs_in_tb, desc->req.numCBs);
- op->status |= ((rsp.input_err)
- ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH v1 1/1] baseband/acc100: fix to input error related to padding
2022-11-07 23:45 ` [PATCH v1 1/1] baseband/acc100: fix to input error related to padding Nicolas Chautru
@ 2022-11-08 5:41 ` Akhil Goyal
2022-11-08 13:41 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2022-11-08 5:41 UTC (permalink / raw)
To: Nicolas Chautru, dev, maxime.coquelin, hernan.vargas
> Previous commit includes some padding for some cases,
> which may cause input warning from the HW
> which should be safely ignored to avoid false alarm.
>
> Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
Applied to dpdk-next-crypto.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding
2022-11-07 23:45 ` [PATCH v1 1/1] baseband/acc100: fix to input error related to padding Nicolas Chautru
2022-11-08 5:41 ` [EXT] " Akhil Goyal
@ 2022-11-08 13:41 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2022-11-08 13:41 UTC (permalink / raw)
To: Nicolas Chautru, dev, gakhil, hernan.vargas
On 11/8/22 00:45, Nicolas Chautru wrote:
> Previous commit includes some padding for some cases,
> which may cause input warning from the HW
> which should be safely ignored to avoid false alarm.
>
> Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 96daef87bc..ba8247d47e 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
> /* Clearing status, it will be set based on response */
> op->status = 0;
>
> - op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
> op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
> op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>
> @@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
> rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
> desc, rsp.val, descs_in_tb, desc->req.numCBs);
>
> - op->status |= ((rsp.input_err)
> - ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
> op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
> op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-08 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 23:45 [PATCH v1 0/1] baseband/acc100: fix for RC2 Nicolas Chautru
2022-11-07 23:45 ` [PATCH v1 1/1] baseband/acc100: fix to input error related to padding Nicolas Chautru
2022-11-08 5:41 ` [EXT] " Akhil Goyal
2022-11-08 13:41 ` Maxime Coquelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.