[meta-oe][master][kirkstone][PATCH] psplash: delay the psplash service

[meta-oe][master][kirkstone][PATCH] psplash: delay the psplash service

[Wentao Zhang]

psplash starts too early to open /dev/fb0 correctly on
some types of machines.
Starting this service until /dev/fb0 is found.

Signed-off-by: Wentao Zhang <wentao.zhang@windriver.com>
---
 meta/recipes-core/psplash/files/psplash-start.service | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
index 36c2bb38e0..555ad5e387 100644
--- a/meta/recipes-core/psplash/files/psplash-start.service
+++ b/meta/recipes-core/psplash/files/psplash-start.service
@@ -7,6 +7,8 @@ RequiresMountsFor=/run
 Type=notify
 ExecStart=/usr/bin/psplash
 RemainAfterExit=yes
+ExecStartPre=bash -c "while [ ! -e /dev/fb0 ]; do sleep 0.01; done"
+TimeoutStartSec=100
 
 [Install]
 WantedBy=sysinit.target
-- 
2.25.1

Re: [oe] [meta-oe][master][kirkstone][PATCH] psplash: delay the psplash service

[Mikko Rapeli]

Hi,

On Tue, Nov 08, 2022 at 04:36:41PM +0800, Wentao Zhang wrote:
> psplash starts too early to open /dev/fb0 correctly on
> some types of machines.
> Starting this service until /dev/fb0 is found.
> 
> Signed-off-by: Wentao Zhang <wentao.zhang@windriver.com>
> ---
>  meta/recipes-core/psplash/files/psplash-start.service | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
> index 36c2bb38e0..555ad5e387 100644
> --- a/meta/recipes-core/psplash/files/psplash-start.service
> +++ b/meta/recipes-core/psplash/files/psplash-start.service
> @@ -7,6 +7,8 @@ RequiresMountsFor=/run
>  Type=notify
>  ExecStart=/usr/bin/psplash
>  RemainAfterExit=yes
> +ExecStartPre=bash -c "while [ ! -e /dev/fb0 ]; do sleep 0.01; done"
> +TimeoutStartSec=100

This isn't correct with systemd. If a .service depends on a device node,
just express the dependency:

Requires=dev-fb0.device
After=dev-fb0.device

Cheers,

-Mikko

>  [Install]
>  WantedBy=sysinit.target
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#99488): https://lists.openembedded.org/g/openembedded-devel/message/99488
> Mute This Topic: https://lists.openembedded.org/mt/94886380/7159507
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

[meta-oe][master][kirkstone][PATCH] psplash: delay the psplash service

[Wentao Zhang]

psplash starts too early to start on some types of
machines. Fix this problem by delaying this service.

Signed-off-by: Wentao Zhang <wentao.zhang@windriver.com>
---
 meta/recipes-core/psplash/files/psplash-start.service | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/psplash/files/psplash-start.service b/meta/recipes-core/psplash/files/psplash-start.service
index 36c2bb38e0..9eaf2658a5 100644
--- a/meta/recipes-core/psplash/files/psplash-start.service
+++ b/meta/recipes-core/psplash/files/psplash-start.service
@@ -2,6 +2,8 @@
 Description=Start psplash boot splash screen
 DefaultDependencies=no
 RequiresMountsFor=/run
+After=systemd-timesyncd.service
+
 
 [Service]
 Type=notify
-- 
2.25.1