* [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
@ 2022-11-08 20:16 Alex Elder
2022-11-08 20:47 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alex Elder @ 2022-11-08 20:16 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, andersson, konrad.dybcio, agross
Cc: devicetree, linux-arm-msm, linux-kernel
In "sc7280-idp.dts", the IPA node is modified after being defined.
However that file includes "sc7280-idp.dtsi", which also modifies
the IPA node (in the same way). This only needs to be done in
"sc7280-idp.dtsi".
Signed-off-by: Alex Elder <elder@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 7559164cdda08..9ddfdfdd354ee 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -61,11 +61,6 @@ &bluetooth {
vddio-supply = <&vreg_l19b_1p8>;
};
-&ipa {
- status = "okay";
- modem-init;
-};
-
&pmk8350_rtc {
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
2022-11-08 20:16 [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice Alex Elder
@ 2022-11-08 20:47 ` Konrad Dybcio
2022-11-08 20:52 ` Krzysztof Kozlowski
2022-11-10 4:09 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-11-08 20:47 UTC (permalink / raw)
To: Alex Elder, robh+dt, krzysztof.kozlowski+dt, andersson, agross
Cc: devicetree, linux-arm-msm, linux-kernel
On 08/11/2022 21:16, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 7559164cdda08..9ddfdfdd354ee 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -61,11 +61,6 @@ &bluetooth {
> vddio-supply = <&vreg_l19b_1p8>;
> };
>
> -&ipa {
> - status = "okay";
> - modem-init;
> -};
> -
> &pmk8350_rtc {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
2022-11-08 20:16 [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice Alex Elder
2022-11-08 20:47 ` Konrad Dybcio
@ 2022-11-08 20:52 ` Krzysztof Kozlowski
2022-11-10 4:09 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-08 20:52 UTC (permalink / raw)
To: Alex Elder, robh+dt, krzysztof.kozlowski+dt, andersson,
konrad.dybcio, agross
Cc: devicetree, linux-arm-msm, linux-kernel
On 08/11/2022 21:16, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
2022-11-08 20:16 [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice Alex Elder
2022-11-08 20:47 ` Konrad Dybcio
2022-11-08 20:52 ` Krzysztof Kozlowski
@ 2022-11-10 4:09 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-11-10 4:09 UTC (permalink / raw)
To: robh+dt, agross, konrad.dybcio, elder, krzysztof.kozlowski+dt
Cc: linux-kernel, devicetree, linux-arm-msm
On Tue, 8 Nov 2022 14:16:25 -0600, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way). This only needs to be done in
> "sc7280-idp.dtsi".
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice
commit: d4d4a7c4fd5f1b802ccf329edf11a3ade69b55e0
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-10 4:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 20:16 [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice Alex Elder
2022-11-08 20:47 ` Konrad Dybcio
2022-11-08 20:52 ` Krzysztof Kozlowski
2022-11-10 4:09 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.