[PATCH net] cxgb4vf: shut down the adapter when t4vf_update_port_info() failed in cxgb4vf_open()

[PATCH net] cxgb4vf: shut down the adapter when t4vf_update_port_info() failed in cxgb4vf_open()

[Zhengchao Shao]

When t4vf_update_port_info() failed in cxgb4vf_open(), resources applied
during adapter goes up are not cleared. Fix it. Only be compiled, not be
tested.

Fixes: 18d79f721e0a ("cxgb4vf: Update port information in cxgb4vf_open()")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 54db79f4dcfe..63b2bd084130 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -858,7 +858,7 @@ static int cxgb4vf_open(struct net_device *dev)
 	 */
 	err = t4vf_update_port_info(pi);
 	if (err < 0)
-		return err;
+		goto err_unwind;
 
 	/*
 	 * Note that this interface is up and start everything up ...
-- 
2.17.1

Re: [PATCH net] cxgb4vf: shut down the adapter when t4vf_update_port_info() failed in cxgb4vf_open()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 9 Nov 2022 09:21:00 +0800 you wrote:
> When t4vf_update_port_info() failed in cxgb4vf_open(), resources applied
> during adapter goes up are not cleared. Fix it. Only be compiled, not be
> tested.
> 
> Fixes: 18d79f721e0a ("cxgb4vf: Update port information in cxgb4vf_open()")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net] cxgb4vf: shut down the adapter when t4vf_update_port_info() failed in cxgb4vf_open()
    https://git.kernel.org/netdev/net/c/c6092ea1e6d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html