* Re: [PATCH] Classification of BSS with different frequencies in KHz.
@ 2022-11-10 1:58 JUN-KYU SHIN
0 siblings, 0 replies; 2+ messages in thread
From: JUN-KYU SHIN @ 2022-11-10 1:58 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, JUN-KYU SHIN
Hi johannes,
First of all, thank you very much for the review and feedback.
This mail is corrected part of your feedback.
"freq_offset" also needs to be compared on S1G Band.
If freq_offset comparison is omitted in cmp_bss,
other bss cannot be distinguished in units of khz.
Signed-off-by: JUN-KYU SHIN <jk.shin@newratek.com>
---
net/wireless/scan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index 3cfc668c4189..22ae8996ada3 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1289,8 +1289,8 @@ static int cmp_bss(struct cfg80211_bss *a,
int i, r;
if (a->channel != b->channel)
- return ((b->channel->center_freq + b->channel->freq_offset) -
- (a->channel->center_freq + a->channel->freq_offset));
+ return ((b->channel->center_freq + (u32)b->channel->freq_offset) -
+ (a->channel->center_freq + (u32)a->channel->freq_offset));
a_ies = rcu_access_pointer(a->ies);
if (!a_ies)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Classification of BSS with different frequencies in KHz.
2022-11-09 9:13 Johannes Berg
@ 2022-11-10 2:20 ` JUN-KYU SHIN
0 siblings, 0 replies; 2+ messages in thread
From: JUN-KYU SHIN @ 2022-11-10 2:20 UTC (permalink / raw)
To: johannes; +Cc: jk.shin, linux-wireless
Hi johannes,
First of all, thank you very much for the review and feedback.
This mail is corrected part of your feedback.
Signed-off-by: JUN-KYU SHIN <jk.shin@newratek.com>
---
net/wireless/scan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index 3cfc668c4189..22ae8996ada3 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1289,8 +1289,8 @@ static int cmp_bss(struct cfg80211_bss *a,
int i, r;
if (a->channel != b->channel)
- return ((b->channel->center_freq + b->channel->freq_offset) -
- (a->channel->center_freq + a->channel->freq_offset));
+ return ((b->channel->center_freq + (u32)b->channel->freq_offset) -
+ (a->channel->center_freq + (u32)a->channel->freq_offset));
a_ies = rcu_access_pointer(a->ies);
if (!a_ies)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-10 2:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 1:58 [PATCH] Classification of BSS with different frequencies in KHz JUN-KYU SHIN
-- strict thread matches above, loose matches on Subject: below --
2022-11-09 9:13 Johannes Berg
2022-11-10 2:20 ` [PATCH] " JUN-KYU SHIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.