All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/qtest/libqos/e1000e: Remove "other" interrupts
@ 2022-11-10 11:40 Akihiko Odaki
  2022-12-12 11:43 ` Thomas Huth
  0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2022-11-10 11:40 UTC (permalink / raw)
  Cc: qemu-devel, Thomas Huth, Laurent Vivier, Paolo Bonzini, Akihiko Odaki

The "other" kind of interrupts are not used in the tests.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/qtest/libqos/e1000e.h | 1 -
 tests/qtest/libqos/e1000e.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/tests/qtest/libqos/e1000e.h b/tests/qtest/libqos/e1000e.h
index a22f5fdbad..3bf285af42 100644
--- a/tests/qtest/libqos/e1000e.h
+++ b/tests/qtest/libqos/e1000e.h
@@ -24,7 +24,6 @@
 
 #define E1000E_RX0_MSG_ID           (0)
 #define E1000E_TX0_MSG_ID           (1)
-#define E1000E_OTHER_MSG_ID         (2)
 
 #define E1000E_TDLEN    (0x3808)
 #define E1000E_TDT      (0x3818)
diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
index 80b3e3db90..3b51bafcb7 100644
--- a/tests/qtest/libqos/e1000e.c
+++ b/tests/qtest/libqos/e1000e.c
@@ -32,7 +32,6 @@
 #define E1000E_IVAR_TEST_CFG \
     (((E1000E_RX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_RXQ0_SHIFT) | \
      ((E1000E_TX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_TXQ0_SHIFT) | \
-     ((E1000E_OTHER_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_OTHER_SHIFT) | \
      E1000_IVAR_TX_INT_EVERY_WB)
 
 #define E1000E_RING_LEN (0x1000)
-- 
2.38.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests/qtest/libqos/e1000e: Remove "other" interrupts
  2022-11-10 11:40 [PATCH] tests/qtest/libqos/e1000e: Remove "other" interrupts Akihiko Odaki
@ 2022-12-12 11:43 ` Thomas Huth
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2022-12-12 11:43 UTC (permalink / raw)
  To: Akihiko Odaki; +Cc: qemu-devel, Laurent Vivier, Paolo Bonzini

On 10/11/2022 12.40, Akihiko Odaki wrote:
> The "other" kind of interrupts are not used in the tests.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   tests/qtest/libqos/e1000e.h | 1 -
>   tests/qtest/libqos/e1000e.c | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/tests/qtest/libqos/e1000e.h b/tests/qtest/libqos/e1000e.h
> index a22f5fdbad..3bf285af42 100644
> --- a/tests/qtest/libqos/e1000e.h
> +++ b/tests/qtest/libqos/e1000e.h
> @@ -24,7 +24,6 @@
>   
>   #define E1000E_RX0_MSG_ID           (0)
>   #define E1000E_TX0_MSG_ID           (1)
> -#define E1000E_OTHER_MSG_ID         (2)
>   
>   #define E1000E_TDLEN    (0x3808)
>   #define E1000E_TDT      (0x3818)
> diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
> index 80b3e3db90..3b51bafcb7 100644
> --- a/tests/qtest/libqos/e1000e.c
> +++ b/tests/qtest/libqos/e1000e.c
> @@ -32,7 +32,6 @@
>   #define E1000E_IVAR_TEST_CFG \
>       (((E1000E_RX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_RXQ0_SHIFT) | \
>        ((E1000E_TX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_TXQ0_SHIFT) | \
> -     ((E1000E_OTHER_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_OTHER_SHIFT) | \
>        E1000_IVAR_TX_INT_EVERY_WB)

Thanks, queued to my testing-next branch now:

  https://gitlab.com/thuth/qemu/-/commits/testing-next/

  Thomas



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-12 11:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:40 [PATCH] tests/qtest/libqos/e1000e: Remove "other" interrupts Akihiko Odaki
2022-12-12 11:43 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.