* [PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses
@ 2022-11-10 11:45 Akihiko Odaki
2022-12-12 11:59 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2022-11-10 11:45 UTC (permalink / raw)
Cc: qemu-devel, Thomas Huth, Laurent Vivier, Paolo Bonzini,
Yuri Benditovich, Yan Vugenfirer, Akihiko Odaki
Add a newline after E1000_TCTL write and make it clear that E1000_TCTL
write is what enabling transmit.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
tests/qtest/libqos/e1000e.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
index 80b3e3db90..0e5cceafe4 100644
--- a/tests/qtest/libqos/e1000e.c
+++ b/tests/qtest/libqos/e1000e.c
@@ -152,6 +152,7 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)
/* Enable transmit */
e1000e_macreg_write(&d->e1000e, E1000_TCTL, E1000_TCTL_EN);
+
e1000e_macreg_write(&d->e1000e, E1000_RDBAL,
(uint32_t)d->e1000e.rx_ring);
e1000e_macreg_write(&d->e1000e, E1000_RDBAH,
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses
2022-11-10 11:45 [PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses Akihiko Odaki
@ 2022-12-12 11:59 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2022-12-12 11:59 UTC (permalink / raw)
To: Akihiko Odaki
Cc: qemu-devel, Laurent Vivier, Paolo Bonzini, Yuri Benditovich,
Yan Vugenfirer
On 10/11/2022 12.45, Akihiko Odaki wrote:
> Add a newline after E1000_TCTL write and make it clear that E1000_TCTL
> write is what enabling transmit.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> tests/qtest/libqos/e1000e.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
> index 80b3e3db90..0e5cceafe4 100644
> --- a/tests/qtest/libqos/e1000e.c
> +++ b/tests/qtest/libqos/e1000e.c
> @@ -152,6 +152,7 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)
>
> /* Enable transmit */
> e1000e_macreg_write(&d->e1000e, E1000_TCTL, E1000_TCTL_EN);
> +
> e1000e_macreg_write(&d->e1000e, E1000_RDBAL,
> (uint32_t)d->e1000e.rx_ring);
> e1000e_macreg_write(&d->e1000e, E1000_RDBAH,
Thanks, queued:
https://gitlab.com/thuth/qemu/-/commits/testing-next/
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:45 [PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses Akihiko Odaki
2022-12-12 11:59 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.