* [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec
@ 2022-11-10 12:12 Konrad Dybcio
2022-11-10 12:31 ` Mark Brown
2022-11-10 15:18 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-11-10 12:12 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: patches, Konrad Dybcio, Konrad Dybcio, Liam Girdwood, Mark Brown,
linux-kernel
PMR735a has a wider range than previously defined. Fix it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
No Fixes tag, as the patch is only in -next, so the hash will change.
drivers/regulator/qcom_smd-regulator.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 9eaae13fd385..9f2b58458841 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -686,6 +686,15 @@ static const struct regulator_desc pmic5_ftsmps520 = {
.ops = &rpm_smps_ldo_ops,
};
+static const struct regulator_desc pmic5_hfsmps515 = {
+ .linear_ranges = (struct linear_range[]) {
+ REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+ },
+ .n_linear_ranges = 1,
+ .n_voltages = 236,
+ .ops = &rpm_smps_ldo_ops,
+};
+
static const struct regulator_desc pms405_hfsmps3 = {
.linear_ranges = (struct linear_range[]) {
REGULATOR_LINEAR_RANGE(320000, 0, 215, 8000),
@@ -1277,7 +1286,7 @@ static const struct rpm_regulator_data rpm_pmi8998_regulators[] = {
static const struct rpm_regulator_data rpm_pmr735a_regulators[] = {
{ "s1", QCOM_SMD_RPM_SMPE, 1, &pmic5_ftsmps520, "vdd_s1"},
{ "s2", QCOM_SMD_RPM_SMPE, 2, &pmic5_ftsmps520, "vdd_s2"},
- { "s3", QCOM_SMD_RPM_SMPE, 3, &pms405_hfsmps3, "vdd_s3"},
+ { "s3", QCOM_SMD_RPM_SMPE, 3, &pmic5_hfsmps515, "vdd_s3"},
{ "l1", QCOM_SMD_RPM_LDOE, 1, &pm660_nldo660, "vdd_l1_l2"},
{ "l2", QCOM_SMD_RPM_LDOE, 2, &pm660_nldo660, "vdd_l1_l2"},
{ "l3", QCOM_SMD_RPM_LDOE, 3, &pm660_nldo660, "vdd_l3"},
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec
2022-11-10 12:12 [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec Konrad Dybcio
@ 2022-11-10 12:31 ` Mark Brown
2022-11-10 12:48 ` Konrad Dybcio
2022-11-10 15:18 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2022-11-10 12:31 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, patches, Konrad Dybcio,
Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
On Thu, Nov 10, 2022 at 01:12:25PM +0100, Konrad Dybcio wrote:
> PMR735a has a wider range than previously defined. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> No Fixes tag, as the patch is only in -next, so the hash will change.
No, it won't.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec
2022-11-10 12:31 ` Mark Brown
@ 2022-11-10 12:48 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-11-10 12:48 UTC (permalink / raw)
To: Mark Brown, Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, patches, Liam Girdwood, linux-kernel
On 10/11/2022 13:31, Mark Brown wrote:
> On Thu, Nov 10, 2022 at 01:12:25PM +0100, Konrad Dybcio wrote:
>> PMR735a has a wider range than previously defined. Fix it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> No Fixes tag, as the patch is only in -next, so the hash will change.
>
> No, it won't
Fixes: 0cda8c43aa24 ("regulator: qcom_smd: Add PMR735a regulators")
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec
2022-11-10 12:12 [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec Konrad Dybcio
2022-11-10 12:31 ` Mark Brown
@ 2022-11-10 15:18 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-11-10 15:18 UTC (permalink / raw)
To: andersson, agross, linux-arm-msm, Konrad Dybcio
Cc: linux-kernel, Konrad Dybcio, Liam Girdwood, patches
On Thu, 10 Nov 2022 13:12:25 +0100, Konrad Dybcio wrote:
> PMR735a has a wider range than previously defined. Fix it.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: qcom_smd: Fix PMR735a S3 regulator spec
commit: 91016037216b3aaa0fa1b616d388053fb4202835
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-10 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 12:12 [PATCH] regulator: qcom_smd: Fix PMR735a S3 regulator spec Konrad Dybcio
2022-11-10 12:31 ` Mark Brown
2022-11-10 12:48 ` Konrad Dybcio
2022-11-10 15:18 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.