* [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 9:23 ` ye.xingchen
0 siblings, 0 replies; 8+ messages in thread
From: ye.xingchen @ 2022-11-10 9:23 UTC (permalink / raw)
To: linux
Cc: kernel, shawnguo, linux-i2c, linux-arm-kernel, linux-kernel, chi.minghao
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/i2c/busses/i2c-imx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 3082183bd66a..1ce0cf7a323f 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1449,8 +1449,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 9:23 ` ye.xingchen
0 siblings, 0 replies; 8+ messages in thread
From: ye.xingchen @ 2022-11-10 9:23 UTC (permalink / raw)
To: linux
Cc: kernel, shawnguo, linux-i2c, linux-arm-kernel, linux-kernel, chi.minghao
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/i2c/busses/i2c-imx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 3082183bd66a..1ce0cf7a323f 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1449,8 +1449,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
2022-11-10 9:23 ` ye.xingchen
@ 2022-11-10 11:55 ` Mukesh Ojha
-1 siblings, 0 replies; 8+ messages in thread
From: Mukesh Ojha @ 2022-11-10 11:55 UTC (permalink / raw)
To: ye.xingchen, linux
Cc: kernel, shawnguo, linux-i2c, linux-arm-kernel, linux-kernel, chi.minghao
Hi,
On 11/10/2022 2:53 PM, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/i2c/busses/i2c-imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 3082183bd66a..1ce0cf7a323f 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1449,8 +1449,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> if (irq < 0)
> return irq;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
_Mukesh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 11:55 ` Mukesh Ojha
0 siblings, 0 replies; 8+ messages in thread
From: Mukesh Ojha @ 2022-11-10 11:55 UTC (permalink / raw)
To: ye.xingchen, linux
Cc: kernel, shawnguo, linux-i2c, linux-arm-kernel, linux-kernel, chi.minghao
Hi,
On 11/10/2022 2:53 PM, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/i2c/busses/i2c-imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 3082183bd66a..1ce0cf7a323f 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1449,8 +1449,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
> if (irq < 0)
> return irq;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
_Mukesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
2022-11-10 9:23 ` ye.xingchen
@ 2022-11-10 14:57 ` Uwe Kleine-König
-1 siblings, 0 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2022-11-10 14:57 UTC (permalink / raw)
To: ye.xingchen
Cc: linux, linux-kernel, chi.minghao, linux-i2c, kernel, shawnguo,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Thu, Nov 10, 2022 at 05:23:42PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
As res is used later, we cannot switch to
devm_platform_ioremap_resource(), so the patch is fine.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 14:57 ` Uwe Kleine-König
0 siblings, 0 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2022-11-10 14:57 UTC (permalink / raw)
To: ye.xingchen
Cc: linux, linux-kernel, chi.minghao, linux-i2c, kernel, shawnguo,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
On Thu, Nov 10, 2022 at 05:23:42PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
As res is used later, we cannot switch to
devm_platform_ioremap_resource(), so the patch is fine.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
2022-11-10 9:23 ` ye.xingchen
@ 2022-11-12 20:25 ` Wolfram Sang
-1 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2022-11-12 20:25 UTC (permalink / raw)
To: ye.xingchen
Cc: linux, kernel, shawnguo, linux-i2c, linux-arm-kernel,
linux-kernel, chi.minghao
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Thu, Nov 10, 2022 at 05:23:42PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource()
@ 2022-11-12 20:25 ` Wolfram Sang
0 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2022-11-12 20:25 UTC (permalink / raw)
To: ye.xingchen
Cc: linux, kernel, shawnguo, linux-i2c, linux-arm-kernel,
linux-kernel, chi.minghao
[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]
On Thu, Nov 10, 2022 at 05:23:42PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-12 20:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 9:23 [PATCH] i2c: imx: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-10 9:23 ` ye.xingchen
2022-11-10 11:55 ` Mukesh Ojha
2022-11-10 11:55 ` Mukesh Ojha
2022-11-10 14:57 ` Uwe Kleine-König
2022-11-10 14:57 ` Uwe Kleine-König
2022-11-12 20:25 ` Wolfram Sang
2022-11-12 20:25 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.