* [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: kherbst, lyude, airlied, daniel, dri-devel, nouveau,
linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of acr.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
index 83a9c48bc58c..7ac90c495737 100644
--- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
+++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
@@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
}
-void
+static void
wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
{
nvkm_debug(subdev, "wprGenericHeader\n");
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
This symbol is not used outside of acr.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
index 83a9c48bc58c..7ac90c495737 100644
--- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
+++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
@@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
}
-void
+static void
wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
{
nvkm_debug(subdev, "wprGenericHeader\n");
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
This symbol is not used outside of acr.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
index 83a9c48bc58c..7ac90c495737 100644
--- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
+++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
@@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
}
-void
+static void
wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
{
nvkm_debug(subdev, "wprGenericHeader\n");
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/5] drm/nouveau/acr: remove the unused variable loc
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 9:11 ` Jiapeng Chong
-1 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: kherbst, lyude, airlied, daniel, dri-devel, nouveau,
linux-kernel, Jiapeng Chong, Abaci Robot
The variable loc is not effectively used in the function, so delete it.
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable ‘loc’ set but not used.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3024
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531..bd104a030243 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/5] drm/nouveau/acr: remove the unused variable loc
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
The variable loc is not effectively used in the function, so delete it.
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable ‘loc’ set but not used.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3024
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531..bd104a030243 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Nouveau] [PATCH 2/5] drm/nouveau/acr: remove the unused variable loc
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
The variable loc is not effectively used in the function, so delete it.
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable ‘loc’ set but not used.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3024
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index f36a359d4531..bd104a030243 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
const struct firmware *hsbl;
const struct nvfw_ls_hsbl_bin_hdr *hdr;
const struct nvfw_ls_hsbl_hdr *hshdr;
- u32 loc, sig, cnt, *meta;
+ u32 sig, cnt, *meta;
ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
- loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/5] drm/nouveau/fifo: make nvkm_engn_cgrp_get static
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 9:11 ` Jiapeng Chong
-1 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
This symbol is not used outside of runl.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for ‘nvkm_engn_cgrp_get’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3022
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
index b5836cbc29aa..93d628d7d508 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
@@ -30,7 +30,7 @@
#include <subdev/timer.h>
#include <subdev/top.h>
-struct nvkm_cgrp *
+static struct nvkm_cgrp *
nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags)
{
struct nvkm_cgrp *cgrp = NULL;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/5] drm/nouveau/fifo: make nvkm_engn_cgrp_get static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: kherbst, lyude, airlied, daniel, dri-devel, nouveau,
linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of runl.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for ‘nvkm_engn_cgrp_get’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3022
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
index b5836cbc29aa..93d628d7d508 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
@@ -30,7 +30,7 @@
#include <subdev/timer.h>
#include <subdev/top.h>
-struct nvkm_cgrp *
+static struct nvkm_cgrp *
nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags)
{
struct nvkm_cgrp *cgrp = NULL;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Nouveau] [PATCH 3/5] drm/nouveau/fifo: make nvkm_engn_cgrp_get static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
This symbol is not used outside of runl.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for ‘nvkm_engn_cgrp_get’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3022
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
index b5836cbc29aa..93d628d7d508 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c
@@ -30,7 +30,7 @@
#include <subdev/timer.h>
#include <subdev/top.h>
-struct nvkm_cgrp *
+static struct nvkm_cgrp *
nvkm_engn_cgrp_get(struct nvkm_engn *engn, unsigned long *pirqflags)
{
struct nvkm_cgrp *cgrp = NULL;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 4/5] drm/nouveau/fifo/gf100-: make gf100_fifo_nonstall_block() static
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 9:11 ` Jiapeng Chong
-1 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: kherbst, lyude, airlied, daniel, dri-devel, nouveau,
linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of gf100.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for ‘gf100_fifo_nonstall_block’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3021
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
index 5bb65258c36d..6c94451d0faa 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
@@ -447,7 +447,7 @@ gf100_fifo_nonstall_allow(struct nvkm_event *event, int type, int index)
spin_unlock_irqrestore(&fifo->lock, flags);
}
-void
+static void
gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index)
{
struct nvkm_fifo *fifo = container_of(event, typeof(*fifo), nonstall.event);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 4/5] drm/nouveau/fifo/gf100-: make gf100_fifo_nonstall_block() static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
This symbol is not used outside of gf100.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for ‘gf100_fifo_nonstall_block’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3021
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
index 5bb65258c36d..6c94451d0faa 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
@@ -447,7 +447,7 @@ gf100_fifo_nonstall_allow(struct nvkm_event *event, int type, int index)
spin_unlock_irqrestore(&fifo->lock, flags);
}
-void
+static void
gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index)
{
struct nvkm_fifo *fifo = container_of(event, typeof(*fifo), nonstall.event);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Nouveau] [PATCH 4/5] drm/nouveau/fifo/gf100-: make gf100_fifo_nonstall_block() static
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
This symbol is not used outside of gf100.c, so marks it static.
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for ‘gf100_fifo_nonstall_block’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3021
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
index 5bb65258c36d..6c94451d0faa 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c
@@ -447,7 +447,7 @@ gf100_fifo_nonstall_allow(struct nvkm_event *event, int type, int index)
spin_unlock_irqrestore(&fifo->lock, flags);
}
-void
+static void
gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index)
{
struct nvkm_fifo *fifo = container_of(event, typeof(*fifo), nonstall.event);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 5/5] drm/nouveau/gr/tu102: Remove the unused function tu102_gr_load()
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 9:11 ` Jiapeng Chong
-1 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: kherbst, lyude, airlied, daniel, dri-devel, nouveau,
linux-kernel, Jiapeng Chong, Abaci Robot
The function tu102_gr_load() is defined in the tu102.c file, but
not called elsewhere, so remove this unused function.
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no
previous prototype for ‘tu102_gr_load’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3020
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
index 3b6c8100a242..a7775aa18541 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
@@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)
return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack);
}
-int
-tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif)
-{
- int ret;
-
- ret = gm200_gr_load(gr, ver, fwif);
- if (ret)
- return ret;
-
- return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102_gr_av_to_init_veid,
- &gr->bundle_veid);
-}
-
static const struct gf100_gr_fwif
tu102_gr_fwif[] = {
{ 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr },
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 5/5] drm/nouveau/gr/tu102: Remove the unused function tu102_gr_load()
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
The function tu102_gr_load() is defined in the tu102.c file, but
not called elsewhere, so remove this unused function.
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no
previous prototype for ‘tu102_gr_load’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3020
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
index 3b6c8100a242..a7775aa18541 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
@@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)
return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack);
}
-int
-tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif)
-{
- int ret;
-
- ret = gm200_gr_load(gr, ver, fwif);
- if (ret)
- return ret;
-
- return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102_gr_av_to_init_veid,
- &gr->bundle_veid);
-}
-
static const struct gf100_gr_fwif
tu102_gr_fwif[] = {
{ 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr },
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Nouveau] [PATCH 5/5] drm/nouveau/gr/tu102: Remove the unused function tu102_gr_load()
@ 2022-11-11 9:11 ` Jiapeng Chong
0 siblings, 0 replies; 21+ messages in thread
From: Jiapeng Chong @ 2022-11-11 9:11 UTC (permalink / raw)
To: bskeggs
Cc: Jiapeng Chong, nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
The function tu102_gr_load() is defined in the tu102.c file, but
not called elsewhere, so remove this unused function.
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no
previous prototype for ‘tu102_gr_load’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3020
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
index 3b6c8100a242..a7775aa18541 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c
@@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)
return gk20a_gr_av_to_init_(blob, 64, 0x00100000, ppack);
}
-int
-tu102_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif)
-{
- int ret;
-
- ret = gm200_gr_load(gr, ver, fwif);
- if (ret)
- return ret;
-
- return gk20a_gr_load_net(gr, "gr/", "sw_veid_bundle_init", ver, tu102_gr_av_to_init_veid,
- &gr->bundle_veid);
-}
-
static const struct gf100_gr_fwif
tu102_gr_fwif[] = {
{ 0, gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr },
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 22:35 ` Lyude Paul
-1 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:35 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
For the whole series:
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to drm-misc-next in a bit
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 22:35 ` Lyude Paul
0 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:35 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: kherbst, airlied, daniel, dri-devel, nouveau, linux-kernel, Abaci Robot
For the whole series:
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to drm-misc-next in a bit
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 22:35 ` Lyude Paul
0 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:35 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
For the whole series:
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to drm-misc-next in a bit
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
2022-11-11 9:11 ` Jiapeng Chong
(?)
@ 2022-11-11 22:45 ` Lyude Paul
-1 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:45 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: nouveau, Abaci Robot, linux-kernel, dri-devel, daniel
Actually hm, I think ben will need to consider pulling these into his branch
since these don't seem to apply to drm-misc-next - so presumably they're
related to some of the work that's been getting pushed recently for GSP prep
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 22:45 ` Lyude Paul
0 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:45 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: kherbst, nouveau, Abaci Robot, linux-kernel, dri-devel
Actually hm, I think ben will need to consider pulling these into his branch
since these don't seem to apply to drm-misc-next - so presumably they're
related to some of the work that's been getting pushed recently for GSP prep
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
@ 2022-11-11 22:45 ` Lyude Paul
0 siblings, 0 replies; 21+ messages in thread
From: Lyude Paul @ 2022-11-11 22:45 UTC (permalink / raw)
To: Jiapeng Chong, bskeggs
Cc: kherbst, airlied, daniel, dri-devel, nouveau, linux-kernel, Abaci Robot
Actually hm, I think ben will need to consider pulling these into his branch
since these don't seem to apply to drm-misc-next - so presumably they're
related to some of the work that's been getting pushed recently for GSP prep
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus : %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-05-04 12:34 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 9:11 [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static Jiapeng Chong
2022-11-11 9:11 ` [Nouveau] " Jiapeng Chong
2022-11-11 9:11 ` Jiapeng Chong
2022-11-11 9:11 ` [PATCH 2/5] drm/nouveau/acr: remove the unused variable loc Jiapeng Chong
2022-11-11 9:11 ` [Nouveau] " Jiapeng Chong
2022-11-11 9:11 ` Jiapeng Chong
2022-11-11 9:11 ` [PATCH 3/5] drm/nouveau/fifo: make nvkm_engn_cgrp_get static Jiapeng Chong
2022-11-11 9:11 ` [Nouveau] " Jiapeng Chong
2022-11-11 9:11 ` Jiapeng Chong
2022-11-11 9:11 ` [PATCH 4/5] drm/nouveau/fifo/gf100-: make gf100_fifo_nonstall_block() static Jiapeng Chong
2022-11-11 9:11 ` [Nouveau] " Jiapeng Chong
2022-11-11 9:11 ` Jiapeng Chong
2022-11-11 9:11 ` [PATCH 5/5] drm/nouveau/gr/tu102: Remove the unused function tu102_gr_load() Jiapeng Chong
2022-11-11 9:11 ` [Nouveau] " Jiapeng Chong
2022-11-11 9:11 ` Jiapeng Chong
2022-11-11 22:35 ` [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static Lyude Paul
2022-11-11 22:35 ` Lyude Paul
2022-11-11 22:35 ` Lyude Paul
2022-11-11 22:45 ` [Nouveau] " Lyude Paul
2022-11-11 22:45 ` Lyude Paul
2022-11-11 22:45 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.