[PATCH net v2] net: mhi: Fix memory leak in mhi_net_dellink()

[PATCH net v2] net: mhi: Fix memory leak in mhi_net_dellink()

[Wei Yongjun]

From: Wei Yongjun <weiyongjun1@huawei.com>

MHI driver registers network device without setting the
needs_free_netdev flag, and does NOT call free_netdev() when
unregisters network device, which causes a memory leak.

This patch calls free_netdev() to fix it since netdev_priv
is used after unregister.

Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: fix 'Fixes' tag

 drivers/net/mhi_net.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
index ff302144029d..3d322ac4f6a5 100644
--- a/drivers/net/mhi_net.c
+++ b/drivers/net/mhi_net.c
@@ -343,6 +343,8 @@ static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev)
 
 	kfree_skb(mhi_netdev->skbagg_head);
 
+	free_netdev(ndev);
+
 	dev_set_drvdata(&mhi_dev->dev, NULL);
 }
 
-- 
2.34.1

Re: [PATCH net v2] net: mhi: Fix memory leak in mhi_net_dellink()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 11 Nov 2022 09:20:44 +0000 you wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> MHI driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
> 
> This patch calls free_netdev() to fix it since netdev_priv
> is used after unregister.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: mhi: Fix memory leak in mhi_net_dellink()
    https://git.kernel.org/netdev/net/c/f7c125bd79f5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html