[Buildroot] [PATCH v3] package/udisks: add config option to support mounting in /media

[Buildroot] [PATCH v3] package/udisks: add config option to support mounting in /media

[Wolfgang Grandegger]

Support mounting in /media instead of /run/media for compatibility
with the Filesystem Hierarchy Standard (FHS). This is also required
for backward compatibility with udisks1.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>

---
Changes since v1:
- explicitly disable the option if not selected

Changes since v2:
- fix typo in subject

  package/udisks/Config.in | 10 ++++++++++
  package/udisks/udisks.mk |  7 ++++++-
  2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/package/udisks/Config.in b/package/udisks/Config.in
index 4804c0eba0..480d988857 100644
--- a/package/udisks/Config.in
+++ b/package/udisks/Config.in
@@ -49,3 +49,13 @@ comment "udisks needs a toolchain with dynamic library, locale, wchar, threads,
  
  comment "udisks can't be built with Optimize for fast"
  	depends on BR2_OPTIMIZE_FAST
+
+if BR2_PACKAGE_UDISKS
+
+config BR2_PACKAGE_UDISKS_FHS_MEDIA
+	bool "Mount devices in /media instead of /run/media"
+	help
+	  Support mounting in /media for compatibility with the
+	  Filesystem Hierarchy Standard (FHS)
+
+endif
diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
index 2bf519a2cc..db5a76105f 100644
--- a/package/udisks/udisks.mk
+++ b/package/udisks/udisks.mk
@@ -28,7 +28,6 @@ UDISKS_CONF_OPTS = \
  	--disable-acl \
  	--disable-bcache \
  	--disable-btrfs \
-	--disable-fhs-media \
  	--disable-introspection \
  	--disable-iscsi \
  	--disable-lsm \
@@ -39,4 +38,10 @@ UDISKS_CONF_OPTS = \
  	--disable-vdo \
  	--disable-zram
  
+ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
+UDISKS_CONF_OPTS += --enable-fhs-media
+else
+UDISKS_CONF_OPTS += --disable-fhs-media
+endif
+
  $(eval $(autotools-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3] package/udisks: add config option to support mounting in /media

[Thomas Petazzoni via buildroot]

On Thu, 10 Nov 2022 09:38:02 +0100
Wolfgang Grandegger <wg@grandegger.com> wrote:

> Support mounting in /media instead of /run/media for compatibility
> with the Filesystem Hierarchy Standard (FHS). This is also required
> for backward compatibility with udisks1.
> 
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> ---
> Changes since v1:
> - explicitly disable the option if not selected

I'm not sure exactly why, but your patch didn't apply cleanly. Maybe
some whitespace damage caused by your e-mail client (we recommend using
git send-email to submit patches). Anyway, I fixed up the conflicts,
and pushed your commit to our next branch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3] package/udisks: add config option to support mounting in /media

[Wolfgang Grandegger]

Hello Thomas,

On 13.11.22 22:55, Thomas Petazzoni wrote:
> On Thu, 10 Nov 2022 09:38:02 +0100
> Wolfgang Grandegger <wg@grandegger.com> wrote:
>
>> Support mounting in /media instead of /run/media for compatibility
>> with the Filesystem Hierarchy Standard (FHS). This is also required
>> for backward compatibility with udisks1.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>
>> ---
>> Changes since v1:
>> - explicitly disable the option if not selected
> I'm not sure exactly why, but your patch didn't apply cleanly. Maybe
> some whitespace damage caused by your e-mail client (we recommend using
> git send-email to submit patches). Anyway, I fixed up the conflicts,
> and pushed your commit to our next branch. Thanks!
>
Thanks! Obviously, this simple patch was prepared and sent in a hurry, 
sorry!
I will try to be more carefully next time to avoid extra work!

Wolfgang

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3] package/udisks: add config option to support mounting in /media

[Wolfgang Grandegger]

Support mounting in /media instead of /run/media for compatibility
with the Filesystem Hierarchy Standard (FHS). This is also required
for backward compatibility with udisks1.
---

Changes since v1:
- explicitly disable the option if not selected

Changes since v2:
- fix typo in subject

  package/udisks/Config.in | 10 ++++++++++
  package/udisks/udisks.mk |  7 ++++++-
  2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/package/udisks/Config.in b/package/udisks/Config.in
index 4804c0eba0..480d988857 100644
--- a/package/udisks/Config.in
+++ b/package/udisks/Config.in
@@ -49,3 +49,13 @@ comment "udisks needs a toolchain with dynamic library, locale, wchar, threads,
  
  comment "udisks can't be built with Optimize for fast"
  	depends on BR2_OPTIMIZE_FAST
+
+if BR2_PACKAGE_UDISKS
+
+config BR2_PACKAGE_UDISKS_FHS_MEDIA
+	bool "Mount devices in /media instead of /run/media"
+	help
+	  Support mounting in /media for compatibility with the
+	  Filesystem Hierarchy Standard (FHS)
+
+endif
diff --git a/package/udisks/udisks.mk b/package/udisks/udisks.mk
index 2bf519a2cc..db5a76105f 100644
--- a/package/udisks/udisks.mk
+++ b/package/udisks/udisks.mk
@@ -28,7 +28,6 @@ UDISKS_CONF_OPTS = \
  	--disable-acl \
  	--disable-bcache \
  	--disable-btrfs \
-	--disable-fhs-media \
  	--disable-introspection \
  	--disable-iscsi \
  	--disable-lsm \
@@ -39,4 +38,10 @@ UDISKS_CONF_OPTS = \
  	--disable-vdo \
  	--disable-zram
  
+ifeq ($(BR2_PACKAGE_UDISKS_FHS_MEDIA),y)
+UDISKS_CONF_OPTS += --enable-fhs-media
+else
+UDISKS_CONF_OPTS += --disable-fhs-media
+endif
+
  $(eval $(autotools-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot