* [PATCH] ccid-card-emulated: fix cast warning
@ 2022-11-14 13:22 marcandre.lureau
2023-01-02 14:44 ` Marc-André Lureau
0 siblings, 1 reply; 2+ messages in thread
From: marcandre.lureau @ 2022-11-14 13:22 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel, Marc-André Lureau
From: Marc-André Lureau <marcandre.lureau@redhat.com>
../hw/usb/ccid-card-emulated.c: In function 'handle_apdu_thread':
../hw/usb/ccid-card-emulated.c:251:24: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
251 | assert((unsigned long)event > 1000);
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/usb/ccid-card-emulated.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
index ee41a81801..c328660075 100644
--- a/hw/usb/ccid-card-emulated.c
+++ b/hw/usb/ccid-card-emulated.c
@@ -248,7 +248,7 @@ static void *handle_apdu_thread(void* arg)
WITH_QEMU_LOCK_GUARD(&card->vreader_mutex) {
while (!QSIMPLEQ_EMPTY(&card->guest_apdu_list)) {
event = QSIMPLEQ_FIRST(&card->guest_apdu_list);
- assert((unsigned long)event > 1000);
+ assert(event != NULL);
QSIMPLEQ_REMOVE_HEAD(&card->guest_apdu_list, entry);
if (event->p.data.type != EMUL_GUEST_APDU) {
DPRINTF(card, 1, "unexpected message in handle_apdu_thread\n");
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ccid-card-emulated: fix cast warning
2022-11-14 13:22 [PATCH] ccid-card-emulated: fix cast warning marcandre.lureau
@ 2023-01-02 14:44 ` Marc-André Lureau
0 siblings, 0 replies; 2+ messages in thread
From: Marc-André Lureau @ 2023-01-02 14:44 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
On Mon, Nov 14, 2022 at 5:22 PM <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ../hw/usb/ccid-card-emulated.c: In function 'handle_apdu_thread':
> ../hw/usb/ccid-card-emulated.c:251:24: error: cast from pointer to integer
> of different size [-Werror=pointer-to-int-cast]
> 251 | assert((unsigned long)event > 1000);
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
ping
> ---
> hw/usb/ccid-card-emulated.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
> index ee41a81801..c328660075 100644
> --- a/hw/usb/ccid-card-emulated.c
> +++ b/hw/usb/ccid-card-emulated.c
> @@ -248,7 +248,7 @@ static void *handle_apdu_thread(void* arg)
> WITH_QEMU_LOCK_GUARD(&card->vreader_mutex) {
> while (!QSIMPLEQ_EMPTY(&card->guest_apdu_list)) {
> event = QSIMPLEQ_FIRST(&card->guest_apdu_list);
> - assert((unsigned long)event > 1000);
> + assert(event != NULL);
> QSIMPLEQ_REMOVE_HEAD(&card->guest_apdu_list, entry);
> if (event->p.data.type != EMUL_GUEST_APDU) {
> DPRINTF(card, 1, "unexpected message in
> handle_apdu_thread\n");
> --
> 2.38.1
>
>
[-- Attachment #2: Type: text/html, Size: 2177 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-02 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 13:22 [PATCH] ccid-card-emulated: fix cast warning marcandre.lureau
2023-01-02 14:44 ` Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.