* [PATCH] hwmon: (i5500_temp): fix missing pci_disable_device()
@ 2022-11-12 12:56 Yang Yingliang
2022-11-14 23:19 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-11-12 12:56 UTC (permalink / raw)
To: linux-hwmon; +Cc: jdelvare, linux, yangyingliang
pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release().
Fixes: ada072816be1 ("hwmon: (i5500_temp) New driver for the Intel 5500/5520/X58 chipsets")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/hwmon/i5500_temp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/i5500_temp.c b/drivers/hwmon/i5500_temp.c
index 05f68e9c9477..23b9f94fe0a9 100644
--- a/drivers/hwmon/i5500_temp.c
+++ b/drivers/hwmon/i5500_temp.c
@@ -117,7 +117,7 @@ static int i5500_temp_probe(struct pci_dev *pdev,
u32 tstimer;
s8 tsfsc;
- err = pci_enable_device(pdev);
+ err = pcim_enable_device(pdev);
if (err) {
dev_err(&pdev->dev, "Failed to enable device\n");
return err;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (i5500_temp): fix missing pci_disable_device()
2022-11-12 12:56 [PATCH] hwmon: (i5500_temp): fix missing pci_disable_device() Yang Yingliang
@ 2022-11-14 23:19 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-11-14 23:19 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-hwmon, jdelvare
On Sat, Nov 12, 2022 at 08:56:06PM +0800, Yang Yingliang wrote:
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release().
>
> Fixes: ada072816be1 ("hwmon: (i5500_temp) New driver for the Intel 5500/5520/X58 chipsets")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/i5500_temp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/i5500_temp.c b/drivers/hwmon/i5500_temp.c
> index 05f68e9c9477..23b9f94fe0a9 100644
> --- a/drivers/hwmon/i5500_temp.c
> +++ b/drivers/hwmon/i5500_temp.c
> @@ -117,7 +117,7 @@ static int i5500_temp_probe(struct pci_dev *pdev,
> u32 tstimer;
> s8 tsfsc;
>
> - err = pci_enable_device(pdev);
> + err = pcim_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "Failed to enable device\n");
> return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 12:56 [PATCH] hwmon: (i5500_temp): fix missing pci_disable_device() Yang Yingliang
2022-11-14 23:19 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.