All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: ltp@lists.linux.it
Cc: Jan Kara <jack@suse.cz>
Subject: [LTP] [PATCH 0/3] Make fanotify10 test yet more reliable
Date: Tue, 15 Nov 2022 13:47:35 +0100	[thread overview]
Message-ID: <20221115123721.12176-1-jack@suse.cz> (raw)

Hello!

I was debugging with Pengfei Xu why fanotify10 testcase still occasionally
fails in his test setup. After a lot of back and forth we have identified two
causes. One lies within the kernel slab reclaim itself (fix submitted), the
other one is the inherent problem that slab reclaim needs to first reclaim
dentries (which means going through round of LRU aging before dentry is
reclaimed) and then inodes have to go through LRU aging before they are
reclaimed. As a result code dropping slab caches can decide there's not enough
forward progress and stop before the inodes we are interested in are evicted.

This patch modifies fanotify10 testcase to create multiple files / dirs with
ignore marks and return success if at least half of ignore marks got reclaimed.
This both gives slab reclaim code better feel of forward progress as well as
provides some robustness against some inode not being reclaimed for some random
reason.

With the kernel fix and this modification to fanotify10 testcase, Xu cannot
trigger the failure anymore.

								Honza

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

             reply	other threads:[~2022-11-15 12:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 12:47 Jan Kara [this message]
2022-11-15 12:47 ` [LTP] [PATCH 1/3] fanotify10: Use named initializers Jan Kara
2022-11-15 12:47 ` [LTP] [PATCH 2/3] fanotify10: Add support for multiple event files Jan Kara
2022-11-17 15:58   ` Petr Vorel
2022-11-21  9:14     ` Jan Kara
2022-11-21  9:33       ` Petr Vorel
2022-11-21  9:39         ` Cyril Hrubis
2022-11-22  8:19           ` Petr Vorel
2022-11-22 10:10             ` Petr Vorel
2022-11-21  9:53         ` Jan Kara
2022-11-21 14:24           ` Richard Palethorpe
2022-11-22  8:17             ` Petr Vorel
2022-11-22  8:57               ` Richard Palethorpe
2022-11-21 15:04   ` Cyril Hrubis
2022-11-22 12:10     ` Richard Palethorpe
2022-11-22 12:56       ` Cyril Hrubis
2022-11-15 12:47 ` [LTP] [PATCH 3/3] fanotify10: Make evictable marks tests more reliable Jan Kara
2022-11-16  2:17   ` Pengfei Xu
2022-11-16 10:58     ` Jan Kara
2022-11-16 16:32       ` Amir Goldstein
2022-11-17 15:50         ` Petr Vorel
2022-11-21 15:09   ` Cyril Hrubis
2022-11-22 10:30     ` Petr Vorel
2022-11-22 12:42       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115123721.12176-1-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.