* [igt-dev] [i-g-t v5 01/52] lib/igt_kms: Add a helper for valid pipe/output constraint
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t] tests/kms_vrr: Add Negative tests to validate VRR Bhanuprakash Modem
` (54 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
Add an IGT helper to check the given pipe/output combo is valid to decide
whether to run/skip the subtest.
Example:
* Pipe-D can't support mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
* MSO is supported only on PIPE_A/PIPE_B.
This helper is supposed to be a superset of all constraints of pipe/output
combo. But as of now, this helper supports only Bigjoiner.
V2:
- Rename the helper
- Add is_i915 constraint
- Add pre-condition check (igt_output_set_pipe called)
- Update documentaion
- Minor cleanup in Bigjoiner helper
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_kms.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++---
lib/igt_kms.h | 1 +
2 files changed, 47 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 921a623d..38aa85d1 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5824,6 +5824,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
{
uint8_t i, total_pipes = 0, pipes_in_use = 0;
enum pipe p;
+ igt_output_t *output;
struct {
enum pipe idx;
drmModeModeInfo *mode;
@@ -5837,9 +5838,7 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
* Get list of pipes in use those were set by igt_output_set_pipe()
* just before calling this function.
*/
- for (i = 0 ; i < display->n_outputs; i++) {
- igt_output_t *output = &display->outputs[i];
-
+ for_each_connected_output(display, output) {
if (output->pending_pipe == PIPE_NONE)
continue;
@@ -5905,3 +5904,47 @@ bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode)
return true;
}
+
+/*
+ * i915_pipe_output_combo_valid:
+ * @display: a pointer to an #igt_display_t structure
+ *
+ * Every individual test must use igt_output_set_pipe() before calling this
+ * helper, so that this function will get all active pipes from connected
+ * outputs (i.e. pending_pipe != PIPE_NONE) and check the selected combo is
+ * valid or not.
+ *
+ * This helper is supposed to be a superset of all constraints of pipe/output
+ * combo.
+ *
+ * Example:
+ * * Pipe-D can't support mode > 5K
+ * * To use 8K mode on a pipe then consecutive pipe must be free.
+ * * MSO is supported only on PIPE_A/PIPE_B.
+ *
+ * Returns: true if a valid pipe/output mode combo found, else false
+ */
+bool i915_pipe_output_combo_valid(igt_display_t *display)
+{
+ int combo = 0;
+ igt_output_t *output;
+
+ if (!is_i915_device(display->drm_fd))
+ return true;
+
+ for_each_connected_output(display, output) {
+ if (output->pending_pipe == PIPE_NONE)
+ continue;
+
+ combo++;
+ }
+
+ igt_assert_f(combo, "At least one pipe/output combo needed.\n");
+
+ /*
+ * Check the given pipe/output combo is valid for Bigjoiner.
+ *
+ * TODO: Update this helper to support other features like MSO.
+ */
+ return igt_check_bigjoiner_support(display);
+}
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index b09441d0..0c4ab7ae 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -999,5 +999,6 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
igt_output_t *output, int bpc);
bool igt_check_bigjoiner_support(igt_display_t *display);
bool igt_parse_mode_string(const char *mode_string, drmModeModeInfo *mode);
+bool i915_pipe_output_combo_valid(igt_display_t *display);
#endif /* __IGT_KMS_H__ */
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t] tests/kms_vrr: Add Negative tests to validate VRR
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 01/52] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 02/52] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
` (53 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will try to enable VRR on Non-VRR panel. VRR should
not be enabled on the Non-VRR panel. It is unlikely to reject the
commit/modeset. And the expected behavior is the same as disabling
VRR on a VRR capable panel.
V2, V3:
- Fix the condition check to run basic tests
V4:
- Fix the crash in CI (devided by zero)
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
---
tests/kms_vrr.c | 70 ++++++++++++++++++++++++++++++++++++-------------
1 file changed, 52 insertions(+), 18 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 8976d4a6..68c4f264 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -41,10 +41,11 @@
(m)->type, (m)->flags
enum {
- TEST_NONE = 0,
- TEST_DPMS = 1 << 0,
- TEST_SUSPEND = 1 << 1,
- TEST_FLIPLINE = 1 << 2,
+ TEST_BASIC = 1 << 0,
+ TEST_DPMS = 1 << 1,
+ TEST_SUSPEND = 1 << 2,
+ TEST_FLIPLINE = 1 << 3,
+ TEST_NEGATIVE = 1 << 4,
};
typedef struct range {
@@ -116,7 +117,7 @@ static uint64_t get_time_ns(void)
/* Returns the rate duration in nanoseconds for the given refresh rate. */
static uint64_t rate_from_refresh(uint64_t refresh)
{
- return NSECS_PER_SEC / refresh;
+ return refresh ? (NSECS_PER_SEC / refresh) : 0;
}
/* Instead of running on default mode, loop through the connector modes
@@ -179,11 +180,16 @@ static vtest_ns_t get_test_rate_ns(range_t range)
return vtest_ns;
}
-/* Returns true if an output supports VRR. */
+/* Returns true if driver supports VRR. */
static bool has_vrr(igt_output_t *output)
{
- return igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
- igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE);
+ return igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE);
+}
+
+/* Returns true if an output supports VRR. */
+static bool vrr_capable(igt_output_t *output)
+{
+ return igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE);
}
/* Toggles variable refresh rate on the pipe. */
@@ -398,7 +404,8 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
* Flip will happen right away so returned refresh rate is 50Hz.
* if refresh_rate < 40Hz:
* h/w will terminate the vblank at Vmax which is obvious.
- * So, for now we can safely ignore the lower refresh rates
+ * So, vblank termination should happen at Vmax, and flip done at
+ * next Vmin.
*/
if (flags & TEST_FLIPLINE) {
rate = rate_from_refresh(range.max + 5);
@@ -408,17 +415,33 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
(range.max + 5), rate, result);
}
- rate = vtest_ns.mid;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
- igt_assert_f(result > 75,
- "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
- ((range.max + range.min) / 2), rate, result);
+ if (flags & ~TEST_NEGATIVE) {
+ rate = vtest_ns.mid;
+ result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ igt_assert_f(result > 75,
+ "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
+ ((range.max + range.min) / 2), rate, result);
+ }
- set_vrr_on_pipe(data, pipe, false);
+ if (flags & TEST_FLIPLINE) {
+ rate = rate_from_refresh(range.min - 5);
+ result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ igt_assert_f(result < 50,
+ "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
+ (range.min - 5), rate, result);
+ }
+
+ /*
+ * If we request VRR on a non-VRR panel, it is unlikely to reject the
+ * modeset. And the expected behavior is the same as disabling VRR on
+ * a VRR capable panel.
+ */
+ set_vrr_on_pipe(data, pipe, (flags & TEST_NEGATIVE)? true : false);
+ rate = vtest_ns.mid;
result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
igt_assert_f(result < 10,
- "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
- ((range.max + range.min) / 2), rate, result);
+ "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold exceeded, result was %u%%\n",
+ ((range.max + range.min) / 2), rate, (flags & TEST_NEGATIVE)? "on" : "off", result);
/* Clean-up */
igt_plane_set_fb(data->primary, NULL);
@@ -442,6 +465,13 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
if (!has_vrr(output))
continue;
+ /* For Negative tests, panel should be non-vrr. */
+ if ((flags & TEST_NEGATIVE) && vrr_capable(output))
+ continue;
+
+ if ((flags & ~TEST_NEGATIVE) && !vrr_capable(output))
+ continue;
+
for_each_pipe(&data->display, pipe) {
if (igt_pipe_connector_valid(pipe, output)) {
igt_dynamic_f("pipe-%s-%s",
@@ -470,7 +500,7 @@ igt_main
igt_describe("Tests that VRR is enabled and that the difference between flip "
"timestamps converges to the requested rate");
igt_subtest_with_dynamic("flip-basic")
- run_vrr_test(&data, test_basic, 0);
+ run_vrr_test(&data, test_basic, TEST_BASIC);
igt_describe("Tests with DPMS that VRR is enabled and that the difference between flip "
"timestamps converges to the requested rate.");
@@ -486,6 +516,10 @@ igt_main
igt_subtest_with_dynamic("flipline")
run_vrr_test(&data, test_basic, TEST_FLIPLINE);
+ igt_describe("Make sure that VRR should not be enabled on the Non-VRR panel.");
+ igt_subtest_with_dynamic("negative-basic")
+ run_vrr_test(&data, test_basic, TEST_NEGATIVE);
+
igt_fixture {
igt_display_fini(&data.display);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 02/52] lib/igt_kms: Bigjoiner check in max_bpc constraint
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 01/52] lib/igt_kms: Add a helper for valid pipe/output constraint Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t] tests/kms_vrr: Add Negative tests to validate VRR Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
` (52 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
There is a possibility of commit failure if the selected pipe/output
won't support Bigjoiner or 8K. So we need to handle this case.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
lib/igt_kms.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 38aa85d1..86049cb7 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5794,6 +5794,11 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
for_each_connector_mode(output) {
igt_output_override_mode(output, &connector->modes[j__]);
+
+ if (is_i915_device(display->drm_fd) &&
+ !igt_check_bigjoiner_support(display))
+ continue;
+
igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
if (!igt_check_output_bpc_equal(display->drm_fd, pipe,
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (2 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 02/52] lib/igt_kms: Bigjoiner check in max_bpc constraint Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-12-23 6:20 ` Karthik B S
2022-12-23 6:24 ` Karthik B S
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 04/52] tests/kms_atomic: " Bhanuprakash Modem
` (51 subsequent siblings)
55 siblings, 2 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_async_flips.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 7cb71f6b..674fcb5a 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -330,15 +330,6 @@ static void test_cursor(data_t *data)
struct igt_fb cursor_fb;
struct drm_mode_cursor cur;
- /*
- * Intel's PSR2 selective fetch adds other planes to state when
- * necessary, causing the async flip to fail because async flip is not
- * supported in cursor plane.
- */
- igt_skip_on_f(i915_psr2_selective_fetch_check(data->drm_fd),
- "PSR2 sel fetch causes cursor to be added to primary plane " \
- "pages flips and async flip is not supported in cursor\n");
-
do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &width));
do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &height));
@@ -380,12 +371,12 @@ static void test_invalid(data_t *data)
struct igt_fb fb;
drmModeModeInfo *mode;
+ test_init(data);
+
mode = igt_output_get_mode(data->output);
width = mode->hdisplay;
height = mode->vdisplay;
- test_init(data);
-
igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
I915_FORMAT_MOD_Y_TILED, &fb);
@@ -542,9 +533,16 @@ static void run_test(data_t *data, void (*test)(data_t *))
{
igt_output_t *output;
enum pipe pipe;
+ igt_display_t *display = &data->display;
+
+ for_each_pipe(display, pipe) {
+ for_each_valid_output_on_pipe(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
- for_each_pipe(&data->display, pipe) {
- for_each_valid_output_on_pipe(&data->display, pipe, output) {
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
data->output = output;
data->pipe = pipe;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* Re: [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
@ 2022-12-23 6:20 ` Karthik B S
2022-12-23 6:24 ` Karthik B S
1 sibling, 0 replies; 61+ messages in thread
From: Karthik B S @ 2022-12-23 6:20 UTC (permalink / raw)
To: Bhanuprakash Modem, igt-dev
On 11/15/2022 10:28 PM, Bhanuprakash Modem wrote:
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_async_flips.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 7cb71f6b..674fcb5a 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -330,15 +330,6 @@ static void test_cursor(data_t *data)
> struct igt_fb cursor_fb;
> struct drm_mode_cursor cur;
>
> - /*
> - * Intel's PSR2 selective fetch adds other planes to state when
> - * necessary, causing the async flip to fail because async flip is not
> - * supported in cursor plane.
> - */
> - igt_skip_on_f(i915_psr2_selective_fetch_check(data->drm_fd),
> - "PSR2 sel fetch causes cursor to be added to primary plane " \
> - "pages flips and async flip is not supported in cursor\n");
> -
Hi,
This change looks unrelated, could you please move this to a separate patch.
> do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &width));
> do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &height));
>
> @@ -380,12 +371,12 @@ static void test_invalid(data_t *data)
> struct igt_fb fb;
> drmModeModeInfo *mode;
>
> + test_init(data);
> +
> mode = igt_output_get_mode(data->output);
> width = mode->hdisplay;
> height = mode->vdisplay;
>
> - test_init(data);
> -
Same as above.
> igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
> I915_FORMAT_MOD_Y_TILED, &fb);
>
> @@ -542,9 +533,16 @@ static void run_test(data_t *data, void (*test)(data_t *))
> {
> igt_output_t *output;
> enum pipe pipe;
> + igt_display_t *display = &data->display;
> +
> + for_each_pipe(display, pipe) {
> + for_each_valid_output_on_pipe(display, pipe, output) {
> + igt_display_reset(display);
> +
> + igt_output_set_pipe(output, pipe);
> + if (!i915_pipe_output_combo_valid(display))
> + continue;
>
> - for_each_pipe(&data->display, pipe) {
> - for_each_valid_output_on_pipe(&data->display, pipe, output) {
With those changes, the patch LGTM.
Thanks,
Karthik.B.S
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
> data->output = output;
> data->pipe = pipe;
^ permalink raw reply [flat|nested] 61+ messages in thread* Re: [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
2022-12-23 6:20 ` Karthik B S
@ 2022-12-23 6:24 ` Karthik B S
1 sibling, 0 replies; 61+ messages in thread
From: Karthik B S @ 2022-12-23 6:24 UTC (permalink / raw)
To: Bhanuprakash Modem, igt-dev
On 11/15/2022 10:28 PM, Bhanuprakash Modem wrote:
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
>
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>
> V2: - Use updated helper name
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_async_flips.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 7cb71f6b..674fcb5a 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -330,15 +330,6 @@ static void test_cursor(data_t *data)
> struct igt_fb cursor_fb;
> struct drm_mode_cursor cur;
>
> - /*
> - * Intel's PSR2 selective fetch adds other planes to state when
> - * necessary, causing the async flip to fail because async flip is not
> - * supported in cursor plane.
> - */
> - igt_skip_on_f(i915_psr2_selective_fetch_check(data->drm_fd),
> - "PSR2 sel fetch causes cursor to be added to primary plane " \
> - "pages flips and async flip is not supported in cursor\n");
> -
Hi,
This change looks unrelated, could you please move this to a separate patch.
> do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &width));
> do_or_die(drmGetCap(data->drm_fd, DRM_CAP_CURSOR_WIDTH, &height));
>
> @@ -380,12 +371,12 @@ static void test_invalid(data_t *data)
> struct igt_fb fb;
> drmModeModeInfo *mode;
>
> + test_init(data);
> +
> mode = igt_output_get_mode(data->output);
> width = mode->hdisplay;
> height = mode->vdisplay;
>
> - test_init(data);
> -
Same as above.
> igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
> I915_FORMAT_MOD_Y_TILED, &fb);
>
> @@ -542,9 +533,16 @@ static void run_test(data_t *data, void (*test)(data_t *))
> {
> igt_output_t *output;
> enum pipe pipe;
> + igt_display_t *display = &data->display;
> +
> + for_each_pipe(display, pipe) {
> + for_each_valid_output_on_pipe(display, pipe, output) {
> + igt_display_reset(display);
> +
> + igt_output_set_pipe(output, pipe);
> + if (!i915_pipe_output_combo_valid(display))
> + continue;
>
> - for_each_pipe(&data->display, pipe) {
> - for_each_valid_output_on_pipe(&data->display, pipe, output) {
With those changes, the patch LGTM.
Thanks,
Karthik.B.S
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
> data->output = output;
> data->pipe = pipe;
^ permalink raw reply [flat|nested] 61+ messages in thread
* [igt-dev] [i-g-t v5 04/52] tests/kms_atomic: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (3 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 03/52] tests/kms_async_flips: Add support for Bigjoiner Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 05/52] tests/kms_atomic_interruptible: " Bhanuprakash Modem
` (50 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_atomic.c | 32 ++++++++++++++++++++++++++++----
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 2a3fb74b..61117a3f 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -1265,6 +1265,10 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
static void atomic_setup(igt_display_t *display, enum pipe pipe, igt_output_t *output, igt_plane_t *primary, struct igt_fb *fb)
{
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(display);
igt_output_set_pipe(output, pipe);
igt_plane_set_fb(primary, fb);
@@ -1293,6 +1297,7 @@ igt_main
igt_plane_t *primary = NULL;
drmModeModeInfo *mode;
struct igt_fb fb;
+ bool valid_config = false;
igt_fixture {
display.drm_fd = drm_open_driver_master(DRIVER_ANY);
@@ -1303,8 +1308,16 @@ igt_main
igt_require(display.is_atomic);
igt_display_require_output(&display);
- for_each_pipe_with_valid_output(&display, pipe, output)
- break;
+ for_each_pipe_with_valid_output(&display, pipe, output) {
+ igt_display_reset(&display);
+
+ igt_output_set_pipe(output, pipe);
+ if (i915_pipe_output_combo_valid(&display)) {
+ valid_config = true;
+ break;
+ }
+ }
+ igt_require(valid_config);
pipe_obj = &display.pipes[pipe];
primary = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_PRIMARY);
@@ -1342,9 +1355,13 @@ igt_main
igt_subtest("plane-primary-overlay-mutable-zpos") {
uint32_t format_primary = DRM_FORMAT_ARGB8888;
uint32_t format_overlay = DRM_FORMAT_ARGB1555;
+ igt_plane_t *overlay;
- igt_plane_t *overlay =
- igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_OVERLAY);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(&display);
+ overlay = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_OVERLAY);
igt_require(overlay);
igt_require(igt_plane_has_prop(primary, IGT_PLANE_ZPOS));
@@ -1361,6 +1378,10 @@ igt_main
igt_describe("Verify the reported zpos property of planes by making sure "\
"only higher zpos planes cover the lower zpos ones.");
igt_subtest("plane-immutable-zpos") {
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(&display);
igt_output_set_pipe(output, pipe);
plane_immutable_zpos(&display, pipe_obj, output);
}
@@ -1370,6 +1391,9 @@ igt_main
igt_subtest("test-only") {
atomic_clear(&display, pipe, primary, output);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
test_only(pipe_obj, primary, output);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 05/52] tests/kms_atomic_interruptible: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (4 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 04/52] tests/kms_atomic: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 06/52] tests/kms_atomic_transition: " Bhanuprakash Modem
` (49 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_atomic_interruptible.c | 40 ++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index f461a15c..74b2e246 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -82,11 +82,15 @@ static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_t
igt_plane_t *primary, *plane;
int block;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
/*
* Make sure we start with everything disabled to force a real modeset.
* igt_display_require only sets sw state, and assumes the first test
* doesn't care about hw state.
*/
+ igt_display_reset(display);
igt_display_commit2(display, COMMIT_ATOMIC);
igt_output_set_pipe(output, pipe);
@@ -265,6 +269,21 @@ static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_t
igt_remove_fb(display->drm_fd, &fb);
}
+static bool pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
igt_main
{
igt_display_t display;
@@ -286,6 +305,9 @@ igt_main
igt_describe("Tests the interrupt properties of legacy modeset");
igt_subtest_with_dynamic("legacy-setmode") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -295,6 +317,9 @@ igt_main
igt_describe("Tests the interrupt properties of atomic modeset");
igt_subtest_with_dynamic("atomic-setmode") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_atomic_modeset, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -304,6 +329,9 @@ igt_main
igt_describe("Tests the interrupt properties for DPMS");
igt_subtest_with_dynamic("legacy-dpms") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_dpms, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -313,6 +341,9 @@ igt_main
igt_describe("Tests the interrupt properties for pageflip");
igt_subtest_with_dynamic("legacy-pageflip") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_pageflip, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -322,6 +353,9 @@ igt_main
igt_describe("Tests the interrupt properties for cursor");
igt_subtest_with_dynamic("legacy-cursor") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setcursor, DRM_PLANE_TYPE_CURSOR);
break;
@@ -331,6 +365,9 @@ igt_main
igt_describe("Tests the interrupt properties for primary plane");
igt_subtest_with_dynamic("universal-setplane-primary") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_PRIMARY);
break;
@@ -340,6 +377,9 @@ igt_main
igt_describe("Tests the interrupt properties for cursor plane");
igt_subtest_with_dynamic("universal-setplane-cursor") {
for_each_pipe_with_valid_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, pipe, output))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_CURSOR);
break;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 06/52] tests/kms_atomic_transition: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (5 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 05/52] tests/kms_atomic_interruptible: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 07/52] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
` (48 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_atomic_transition.c | 50 ++++++++++++++++++++++++++++++++---
1 file changed, 46 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 6d2ebbbf..5285585f 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -68,6 +68,10 @@ run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)
unsigned flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET;
igt_display_reset(&data->display);
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -487,6 +491,9 @@ run_transition_test(data_t *data, enum pipe pipe, igt_output_t *output,
unsigned flags = 0;
int ret;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
if (fencing)
prepare_fencing(data, pipe);
else
@@ -753,8 +760,13 @@ static unsigned set_combinations(data_t *data, unsigned mask, struct igt_fb *fb)
if (output->pending_pipe != PIPE_NONE)
continue;
- mode = igt_output_get_mode(output);
- break;
+ igt_output_set_pipe(output, pipe);
+ if (i915_pipe_output_combo_valid(&data->display)) {
+ mode = igt_output_get_mode(output);
+ break;
+ } else {
+ igt_output_set_pipe(output, PIPE_NONE);
+ }
}
if (!mode)
@@ -840,8 +852,17 @@ retry:
continue;
igt_output_set_pipe(output, i);
- mode = igt_output_get_mode(output);
- break;
+ if (i915_pipe_output_combo_valid(&data->display)) {
+ mode = igt_output_get_mode(output);
+
+ igt_info("(pipe %s + %s), mode:",
+ kmstest_pipe_name(i), igt_output_name(output));
+ kmstest_dump_mode(mode);
+
+ break;
+ } else {
+ igt_output_set_pipe(output, PIPE_NONE);
+ }
}
if (mode) {
@@ -980,6 +1001,21 @@ static void run_modeset_transition(data_t *data, int requested_outputs, bool non
igt_remove_fb(data->drm_fd, &data->fbs[1]);
}
+static bool pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static int opt_handler(int opt, int opt_index, void *_data)
{
data_t *data = _data;
@@ -1079,6 +1115,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
if (pipe_count == 2 * count && !data.extended)
break;
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
pipe_count++;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
run_primary_test(&data, pipe, output);
@@ -1108,6 +1147,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
if (pipe_count == 2 * count && !data.extended)
break;
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
pipe_count++;
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe),
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 07/52] tests/kms_color_helper: Helper to check Bigjoiner constraint
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (6 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 06/52] tests/kms_atomic_transition: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 08/52] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
` (47 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
Add a helper to Skip the subtest if a selected pipe/output combo
won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_color_helper.c | 12 ++++++++++++
tests/kms_color_helper.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/tests/kms_color_helper.c b/tests/kms_color_helper.c
index 55f3e409..2f9950f8 100644
--- a/tests/kms_color_helper.c
+++ b/tests/kms_color_helper.c
@@ -24,6 +24,18 @@
#include "kms_color_helper.h"
+bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
+{
+ bool ret = true;
+
+ igt_output_set_pipe(data->output, pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ ret = false;
+ igt_output_set_pipe(data->output, PIPE_NONE);
+
+ return ret;
+}
+
bool
panel_supports_deep_color(int drm_fd, char *output_name)
{
diff --git a/tests/kms_color_helper.h b/tests/kms_color_helper.h
index f0ae30e3..bfed2fb8 100644
--- a/tests/kms_color_helper.h
+++ b/tests/kms_color_helper.h
@@ -69,6 +69,7 @@ typedef struct {
color_t coeffs[];
} gamma_lut_t;
+bool pipe_output_combo_valid(data_t *data, enum pipe pipe);
bool panel_supports_deep_color(int fd, char *output_name);
uint64_t get_max_bpc(igt_output_t *output);
void paint_gradient_rectangles(data_t *data,
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 08/52] tests/kms_color: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (7 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 07/52] tests/kms_color_helper: Helper to check Bigjoiner constraint Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 09/52] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
` (46 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_color.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index d016cefb..5d53b441 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -725,9 +725,13 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
data->drm_format = DRM_FORMAT_XRGB8888;
data->mode = igt_output_get_mode(data->output);
+ if (!pipe_output_combo_valid(data, p))
+ goto out;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
igt_assert(test_t(data, data->primary));
+out:
test_cleanup(data);
}
@@ -755,6 +759,9 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
data->drm_format = DRM_FORMAT_XRGB8888;
data->mode = igt_output_get_mode(data->output);
+ if (!pipe_output_combo_valid(data, p))
+ goto out;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name) {
bool success = false;
int i;
@@ -783,6 +790,7 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
igt_assert(success);
}
+out:
test_cleanup(data);
}
@@ -823,7 +831,6 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
igt_display_reset(&data->display);
igt_output_set_prop_value(output, IGT_CONNECTOR_MAX_BPC, 10);
igt_output_set_pipe(output, p);
- igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
if (is_i915_device(data->drm_fd) &&
!igt_max_bpc_constraint(&data->display, p, output, 10))
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 09/52] tests/chamelium/kms_color_chamelium: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (8 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 08/52] tests/kms_color: Add support for Bigjoiner Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 10/52] tests/kms_concurrent: " Bhanuprakash Modem
` (45 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/chamelium/kms_color_chamelium.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/chamelium/kms_color_chamelium.c b/tests/chamelium/kms_color_chamelium.c
index 907f4dd5..b7c84ae4 100644
--- a/tests/chamelium/kms_color_chamelium.c
+++ b/tests/chamelium/kms_color_chamelium.c
@@ -458,6 +458,9 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
data->drm_format = DRM_FORMAT_XRGB8888;
data->mode = igt_output_get_mode(data->output);
+ if (!pipe_output_combo_valid(data, p))
+ return;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
igt_assert(test_t(data, data->primary, data->ports[port_idx]));
}
@@ -493,6 +496,9 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
data->drm_format = DRM_FORMAT_XRGB8888;
data->mode = igt_output_get_mode(data->output);
+ if (!pipe_output_combo_valid(data, p))
+ return;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name) {
bool success = false;
int i;
@@ -538,6 +544,9 @@ run_limited_range_ctm_test_for_pipe(data_t *data, enum pipe p,
data->drm_format = DRM_FORMAT_XRGB8888;
data->mode = igt_output_get_mode(data->output);
+ if (!pipe_output_combo_valid(data, p))
+ return;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
igt_assert(test_t(data, data->primary, data->ports[port_idx]));
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 10/52] tests/kms_concurrent: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (9 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 09/52] tests/chamelium/kms_color_chamelium: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 11/52] tests/kms_content_protection: " Bhanuprakash Modem
` (44 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_concurrent.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 6f8ffd4a..e6d61a84 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -330,9 +330,17 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_describe("Test atomic mode setting concurrently with multiple planes and screen "
"resolution.");
igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
+ igt_output_set_pipe(output, PIPE_NONE);
igt_dynamic_f("%s", igt_output_name(output))
run_test(data, pipe, output);
+ }
}
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 11/52] tests/kms_content_protection: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (10 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 10/52] tests/kms_concurrent: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 12/52] tests/kms_cursor_crc: " Bhanuprakash Modem
` (43 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_content_protection.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index aa28b7bf..0aa2a8a2 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -502,6 +502,13 @@ test_content_protection(enum igt_commit_style s, int content_type)
continue;
igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
+
modeset_with_fb(pipe, output, s);
if (!output_hdcp_capable(output, content_type))
@@ -623,6 +630,14 @@ test_content_protection_mst(int content_type)
igt_assert_f(pipe_found, "No valid pipe found for %s\n", output->name);
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display)){
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
prepare_modeset_on_mst_output(output);
mst_output[dp_mst_outputs++] = output;
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 12/52] tests/kms_cursor_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (11 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 11/52] tests/kms_content_protection: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 13/52] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
` (42 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_cursor_crc.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 68bed666..99a7c717 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -700,6 +700,21 @@ static void test_rapid_movement(data_t *data)
igt_assert_lt(usec, 0.9 * 400 * 1000000 / data->refresh);
}
+static bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
+{
+ bool ret = true;
+ igt_display_t *display = &data->display;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(data->output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(data->output, PIPE_NONE);
+
+ return ret;
+}
+
static void run_size_tests(data_t *data, int w, int h)
{
enum pipe pipe;
@@ -757,6 +772,9 @@ static void run_size_tests(data_t *data, int w, int h)
continue;
}
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe), igt_output_name(data->output))
run_test(data, size_tests[i].testfunc, w, h);
@@ -787,6 +805,9 @@ static void run_tests_on_pipe(data_t *data)
for_each_pipe(&data->display, pipe) {
data->pipe = pipe;
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe),
data->output->name)
@@ -801,6 +822,9 @@ static void run_tests_on_pipe(data_t *data)
for_each_pipe(&data->display, pipe) {
data->pipe = pipe;
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe),
data->output->name)
@@ -815,6 +839,9 @@ static void run_tests_on_pipe(data_t *data)
for_each_pipe(&data->display, pipe) {
data->pipe = pipe;
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe),
data->output->name)
@@ -833,6 +860,9 @@ static void run_tests_on_pipe(data_t *data)
data->pipe = pipe;
data->flags = TEST_DPMS;
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
if (require_cursor_size(data, data->cursor_max_w, data->cursor_max_h)) {
igt_debug("Cursor size %dx%d not supported by driver\n",
data->cursor_max_w, data->cursor_max_h);
@@ -854,6 +884,9 @@ static void run_tests_on_pipe(data_t *data)
data->pipe = pipe;
data->flags = TEST_SUSPEND;
+ if (!pipe_output_combo_valid(data, pipe))
+ continue;
+
if (require_cursor_size(data, data->cursor_max_w, data->cursor_max_h)) {
igt_debug("Cursor size %dx%d not supported by driver\n",
data->cursor_max_w, data->cursor_max_h);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 13/52] tests/kms_cursor_edge_walk: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (12 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 12/52] tests/kms_cursor_crc: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 14/52] tests/kms_cursor_legacy: " Bhanuprakash Modem
` (41 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_cursor_edge_walk.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
index e653b9ab..86b880d8 100644
--- a/tests/kms_cursor_edge_walk.c
+++ b/tests/kms_cursor_edge_walk.c
@@ -351,6 +351,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
data.curh = data.curw;
igt_require(data.curw <= max_curw && data.curh <= max_curh);
+ igt_display_reset(&data.display);
+ igt_output_set_pipe(data.output, data.pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
+ igt_output_set_pipe(data.output, PIPE_NONE);
igt_dynamic_f("pipe-%s-%s-%dx%d",
kmstest_pipe_name(data.pipe),
data.output->name,
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 14/52] tests/kms_cursor_legacy: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (13 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 13/52] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 15/52] tests/kms_display_modes: " Bhanuprakash Modem
` (40 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
As many 2x tests are currently running on Pipe-A & B only, those
tests will always SKIP if there is any 8K supported panel in the
config. Instead of Skipping the test, add some intelligence to
the subtest to identify the valid pipe/output combo to execute
the subtest.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_cursor_legacy.c | 202 +++++++++++++++++++++++---------------
1 file changed, 124 insertions(+), 78 deletions(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 6b75e98c..acba3561 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -177,31 +177,21 @@ static void stress(igt_display_t *display,
munmap(results, PAGE_SIZE);
}
-static igt_output_t *set_fb_on_crtc(igt_display_t *display, enum pipe pipe, struct igt_fb *fb_info)
+static void set_fb_on_crtc(igt_display_t *display, enum pipe pipe,
+ igt_output_t *output, struct igt_fb *fb_info)
{
- igt_output_t *output;
-
- for_each_valid_output_on_pipe(display, pipe, output) {
- drmModeModeInfoPtr mode;
- igt_plane_t *primary;
-
- if (output->pending_pipe != PIPE_NONE)
- continue;
-
- igt_output_set_pipe(output, pipe);
- mode = igt_output_get_mode(output);
+ drmModeModeInfoPtr mode;
+ igt_plane_t *primary;
- igt_create_pattern_fb(display->drm_fd,
- mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
+ igt_output_set_pipe(output, pipe);
+ mode = igt_output_get_mode(output);
- primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
- igt_plane_set_fb(primary, fb_info);
+ igt_create_pattern_fb(display->drm_fd,
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
- return output;
- }
-
- return NULL;
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(primary, fb_info);
}
static igt_plane_t
@@ -236,36 +226,44 @@ static void populate_cursor_args(igt_display_t *display, enum pipe pipe,
arg[1] = *arg;
}
-static enum pipe find_connected_pipe(igt_display_t *display, bool second)
+static enum pipe
+find_connected_pipe(igt_display_t *display, bool second, igt_output_t **output)
{
- enum pipe pipe, first = PIPE_NONE;
- igt_output_t *output;
- igt_output_t *first_output = NULL;
+ enum pipe pipe;
+ bool first_output = false;
bool found = false;
if (!second) {
igt_pipe_crc_free(pipe_crc);
pipe_crc = NULL;
-
- /* Clear display, events will be eaten by commit.. */
- igt_display_reset(display);
}
- for_each_pipe_with_valid_output(display, pipe, output) {
- if (first == pipe || output == first_output)
- continue;
+ /* Clear display, events will be eaten by commit.. */
+ igt_display_reset(display);
- if (second) {
- first = pipe;
- first_output = output;
- second = false;
- continue;
- }
+ for_each_pipe(display, pipe) {
+ for_each_valid_output_on_pipe(display, pipe, *output) {
+ if((*output)->pending_pipe != PIPE_NONE)
+ continue;
- found = true;
- break;
+ igt_output_set_pipe(*output, pipe);
+ if (i915_pipe_output_combo_valid(display)) {
+ found = true;
+
+ if (second) {
+ first_output = true;
+ second = false;
+ found = false;
+ }
+ break;
+ }
+ igt_output_set_pipe(*output, PIPE_NONE);
+ }
+ if (found)
+ break;
}
+ igt_display_reset(display);
if (first_output)
igt_require_f(found, "No second valid output found\n");
else
@@ -429,10 +427,9 @@ static void flip(igt_display_t *display,
results = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
igt_assert(results != MAP_FAILED);
- igt_display_reset(display);
-
- flip_pipe = find_connected_pipe(display, !!flip_pipe);
- cursor_pipe = find_connected_pipe(display, !!cursor_pipe);
+ flip_pipe = find_connected_pipe(display, !!flip_pipe, &output);
+ cursor_pipe = find_connected_pipe(display, !!cursor_pipe, &output2);
+ igt_skip_on(!output || !output2);
igt_info("Using pipe %s for page flip, pipe %s for cursor\n",
kmstest_pipe_name(flip_pipe), kmstest_pipe_name(cursor_pipe));
@@ -446,15 +443,15 @@ static void flip(igt_display_t *display,
DRM_PLANE_TYPE_OVERLAY));
}
- igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
+ set_fb_on_crtc(display, flip_pipe, output, &fb_info);
if (flip_pipe != cursor_pipe) {
- igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+ set_fb_on_crtc(display, cursor_pipe, output2, &fb_info2);
if (try_commit(display)) {
override_output_modes(display, output, output2);
- igt_require((output = set_fb_on_crtc(display, flip_pipe, &fb_info)));
- igt_require((output2 = set_fb_on_crtc(display, cursor_pipe, &fb_info2)));
+ set_fb_on_crtc(display, flip_pipe, output, &fb_info);
+ set_fb_on_crtc(display, cursor_pipe, output2, &fb_info2);
}
}
@@ -546,7 +543,7 @@ static void basic_flip_cursor(igt_display_t *display,
struct drm_event_vblank vbl;
struct igt_fb fb_info, cursor_fb, cursor_fb2, argb_fb;
unsigned vblank_start;
- enum pipe pipe = find_connected_pipe(display, false);
+ enum pipe pipe;
uint64_t ahnd = 0;
igt_spin_t *spin;
int i, miss1 = 0, miss2 = 0, delta;
@@ -562,7 +559,13 @@ static void basic_flip_cursor(igt_display_t *display,
if (mode >= flip_test_atomic)
igt_require(display->is_atomic);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ set_fb_on_crtc(display, pipe, output, &fb_info);
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
@@ -717,7 +720,7 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
struct igt_fb fb_info, cursor_fb, cursor_fb2, argb_fb;
unsigned vblank_start;
int target, cpu;
- enum pipe pipe = find_connected_pipe(display, false);
+ enum pipe pipe;
volatile unsigned long *shared;
cpu_set_t mask, oldmask;
igt_output_t *output;
@@ -726,7 +729,13 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
if (mode >= flip_test_atomic)
igt_require(display->is_atomic);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ set_fb_on_crtc(display, pipe, output, &fb_info);
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
@@ -845,12 +854,18 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
{
struct igt_fb fb_info, cursor_fb;
igt_output_t *output;
- enum pipe pipe = find_connected_pipe(display, false);
+ enum pipe pipe;
struct drm_mode_cursor arg[2];
igt_plane_t *primary, *cursor = NULL;
igt_require(display->is_atomic);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ set_fb_on_crtc(display, pipe, output, &fb_info);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
@@ -937,8 +952,7 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
{
struct drm_mode_cursor arg1[2], arg2[2];
struct igt_fb fb_info, fb2_info, cursor_fb;
- enum pipe pipe = find_connected_pipe(display, false);
- enum pipe pipe2 = find_connected_pipe(display, true);
+ enum pipe pipe, pipe2;
igt_output_t *output, *output2;
bool enabled = false;
volatile unsigned long *shared;
@@ -954,22 +968,28 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
igt_require(drmGetCap(display->drm_fd, DRM_CAP_CRTC_IN_VBLANK_EVENT, &val) == 0);
}
+ if (atomic)
+ igt_require(display->is_atomic);
+
shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
igt_assert(shared != MAP_FAILED);
- igt_fail_on(modeset && !atomic);
+ pipe = find_connected_pipe(display, false, &output);
+ pipe2 = find_connected_pipe(display, true, &output2);
+ igt_skip_on(!output || !output2);
- if (atomic)
- igt_require(display->is_atomic);
+ igt_info("Using pipe %s & %s and pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output),
+ kmstest_pipe_name(pipe2), igt_output_name(output2));
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
- igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
+ set_fb_on_crtc(display, pipe, output, &fb_info);
+ set_fb_on_crtc(display, pipe2, output2, &fb2_info);
if (try_commit(display)) {
override_output_modes(display, output, output2);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
- igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
+ set_fb_on_crtc(display, pipe, output, &fb_info);
+ set_fb_on_crtc(display, pipe2, output2, &fb2_info);
}
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
@@ -1122,7 +1142,7 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
unsigned vblank_start, vblank_last;
volatile unsigned long *shared;
long target;
- enum pipe pipe = find_connected_pipe(display, false);
+ enum pipe pipe;
igt_output_t *output;
uint32_t vrefresh;
int fail_count;
@@ -1134,7 +1154,13 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
shared = mmap(NULL, PAGE_SIZE, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
igt_assert(shared != MAP_FAILED);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ set_fb_on_crtc(display, pipe, output, &fb_info);
vrefresh = igt_output_get_mode(output)->vrefresh;
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
@@ -1226,10 +1252,7 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
struct igt_fb fb_info[2], cursor_fb;
volatile unsigned long *shared;
int target[2];
- enum pipe pipe[2] = {
- find_connected_pipe(display, false),
- find_connected_pipe(display, true)
- };
+ enum pipe pipe[2];
igt_output_t *outputs[2];
igt_plane_t *cursors[2];
@@ -1239,14 +1262,22 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
if (atomic)
igt_require(display->is_atomic);
- igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
- igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
+ pipe[0] = find_connected_pipe(display, false, &outputs[0]);
+ pipe[1] = find_connected_pipe(display, true, &outputs[1]);
+ igt_skip_on(!outputs[0] || !outputs[1]);
+
+ igt_info("Using pipe %s & %s and pipe %s & %s\n",
+ kmstest_pipe_name(pipe[0]), igt_output_name(outputs[0]),
+ kmstest_pipe_name(pipe[1]), igt_output_name(outputs[1]));
+
+ set_fb_on_crtc(display, pipe[0], outputs[0], &fb_info[0]);
+ set_fb_on_crtc(display, pipe[1], outputs[1], &fb_info[1]);
if (try_commit(display)) {
override_output_modes(display, outputs[0], outputs[1]);
- igt_require((outputs[0] = set_fb_on_crtc(display, pipe[0], &fb_info[0])));
- igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
+ set_fb_on_crtc(display, pipe[0], outputs[0], &fb_info[0]);
+ set_fb_on_crtc(display, pipe[1], outputs[1], &fb_info[1]);
}
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
@@ -1347,7 +1378,7 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
struct drm_event_vblank vbl;
struct igt_fb fb_info, cursor_fb;
unsigned vblank_start;
- enum pipe pipe = find_connected_pipe(display, false);
+ enum pipe pipe;
igt_crc_t crcs[3];
igt_output_t *output;
igt_plane_t *cursor;
@@ -1355,7 +1386,13 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
if (atomic)
igt_require(display->is_atomic);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ set_fb_on_crtc(display, pipe, output, &fb_info);
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
populate_cursor_args(display, pipe, arg, &cursor_fb);
@@ -1412,9 +1449,9 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
struct drm_event_vblank vbl;
struct igt_fb fb_info[2], cursor_fb;
unsigned vblank_start;
- enum pipe pipe = find_connected_pipe(display, false);
- igt_pipe_t *pipe_connected = &display->pipes[pipe];
- igt_plane_t *plane_primary = igt_pipe_get_plane_type(pipe_connected, DRM_PLANE_TYPE_PRIMARY);
+ enum pipe pipe;
+ igt_pipe_t *pipe_connected;
+ igt_plane_t *plane_primary;
igt_crc_t crcs[2], test_crc;
uint64_t ahnd;
igt_output_t *output;
@@ -1426,7 +1463,16 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
if (atomic)
igt_require(display->is_atomic);
- igt_require((output = set_fb_on_crtc(display, pipe, &fb_info[0])));
+ pipe = find_connected_pipe(display, false, &output);
+ igt_require(output);
+
+ igt_info("Using pipe %s & %s\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ pipe_connected = &display->pipes[pipe];
+ plane_primary = igt_pipe_get_plane_type(pipe_connected, DRM_PLANE_TYPE_PRIMARY);
+
+ set_fb_on_crtc(display, pipe, output, &fb_info[0]);
igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 15/52] tests/kms_display_modes: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (14 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 14/52] tests/kms_cursor_legacy: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 16/52] tests/kms_dp_tiled_display: " Bhanuprakash Modem
` (39 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
As many 2x tests are currently running on Pipe-A & B only, those
tests will always SKIP if there is any 8K supported panel in the
config. Instead of Skipping the test, add some intelligence to
the subtest to identify the valid pipe/output combo to execute
the subtest.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_display_modes.c | 104 +++++++++++++++++++++++---------------
1 file changed, 62 insertions(+), 42 deletions(-)
diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index e4191811..02fee317 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -34,31 +34,26 @@ typedef struct {
int n_pipes;
} data_t;
-static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
+static void run_extendedmode_basic(data_t *data,
+ enum pipe pipe1, igt_output_t *output1,
+ enum pipe pipe2, igt_output_t *output2)
{
struct igt_fb fb, fbs[2];
drmModeModeInfo *mode[2];
- igt_output_t *output, *extended_output[2];
igt_display_t *display = &data->display;
igt_plane_t *plane[2];
igt_pipe_crc_t *pipe_crc[2] = { 0 };
igt_crc_t ref_crc[2], crc[2];
- int count = 0, width, height;
+ int width, height;
cairo_t *cr;
- for_each_connected_output(display, output) {
- extended_output[count] = output;
- count++;
+ igt_display_reset(display);
- if (count > 1)
- break;
- }
-
- igt_output_set_pipe(extended_output[0], pipe1);
- igt_output_set_pipe(extended_output[1], pipe2);
+ igt_output_set_pipe(output1, pipe1);
+ igt_output_set_pipe(output2, pipe2);
- mode[0] = igt_output_get_mode(extended_output[0]);
- mode[1] = igt_output_get_mode(extended_output[1]);
+ mode[0] = igt_output_get_mode(output1);
+ mode[1] = igt_output_get_mode(output2);
pipe_crc[0] = igt_pipe_crc_new(data->drm_fd, pipe1, IGT_PIPE_CRC_SOURCE_AUTO);
pipe_crc[1] = igt_pipe_crc_new(data->drm_fd, pipe2, IGT_PIPE_CRC_SOURCE_AUTO);
@@ -115,8 +110,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
igt_pipe_crc_free(pipe_crc[0]);
igt_pipe_crc_free(pipe_crc[1]);
- igt_output_set_pipe(extended_output[0], PIPE_NONE);
- igt_output_set_pipe(extended_output[1], PIPE_NONE);
+ igt_output_set_pipe(output1, PIPE_NONE);
+ igt_output_set_pipe(output2, PIPE_NONE);
igt_plane_set_fb(igt_pipe_get_plane_type(&display->pipes[pipe1],
DRM_PLANE_TYPE_PRIMARY), NULL);
@@ -129,43 +124,68 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
igt_assert_crc_equal(&crc[1], &ref_crc[1]);
}
+#define for_each_connected_output_local(display, output) \
+ for (int j__ = 0; assert(igt_can_fail()), j__ < (display)->n_outputs; j__++) \
+ for_each_if ((((output) = &(display)->outputs[j__]), \
+ igt_output_is_connected((output))))
+
+#define for_each_valid_output_on_pipe_local(display, pipe, output) \
+ for_each_connected_output_local((display), (output)) \
+ for_each_if (igt_pipe_connector_valid((pipe), (output)))
+
+static void run_extendedmode_test(data_t *data) {
+ enum pipe pipe1, pipe2;
+ igt_output_t *output1, *output2;
+ igt_display_t *display = &data->display;
+
+ igt_display_reset(display);
+
+ for_each_pipe(display, pipe1) {
+ for_each_valid_output_on_pipe(display, pipe1, output1) {
+ for_each_pipe(display, pipe2) {
+ if (pipe1 == pipe2)
+ continue;
+
+ for_each_valid_output_on_pipe_local(display, pipe2, output2) {
+ if (output1 == output2)
+ continue;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output1, pipe1);
+ igt_output_set_pipe(output2, pipe2);
+
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
+ kmstest_pipe_name(pipe1),
+ igt_output_name(output1),
+ kmstest_pipe_name(pipe2),
+ igt_output_name(output2))
+ run_extendedmode_basic(data,
+ pipe1, output1,
+ pipe2, output2);
+ }
+ }
+ }
+ }
+}
+
igt_main
{
data_t data;
- int valid_output = 0, i, j = 0;
- igt_output_t *output;
- int pipe[IGT_MAX_PIPES];
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_ANY);
kmstest_set_vt_graphics_mode();
igt_display_require(&data.display, data.drm_fd);
-
- for_each_connected_output(&data.display, output) {
- valid_output++;
-
- if (valid_output > 1)
- break;
- }
-
- data.n_pipes = 0;
- for_each_pipe(&data.display, i) {
- data.n_pipes++;
- pipe[j] = i;
- j++;
- }
-
- igt_require_f(valid_output > 1, "No valid second output found\n");
+ igt_display_require_output(&data.display);
}
igt_describe("Test for validating display extended mode with a pair of connected displays");
- igt_subtest_with_dynamic("extended-mode-basic") {
- for (i = 0; i < data.n_pipes - 1; i++) {
- igt_dynamic_f("pipe-%s%s", kmstest_pipe_name(pipe[i]),
- kmstest_pipe_name(pipe[i+1]));
- run_extendedmode_basic(&data, pipe[i], pipe[i+1]);
- }
- }
+ igt_subtest_with_dynamic("extended-mode-basic")
+ run_extendedmode_test(&data);
igt_fixture {
igt_display_fini(&data.display);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 16/52] tests/kms_dp_tiled_display: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (15 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 15/52] tests/kms_display_modes: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 17/52] tests/kms_flip_event_leak: " Bhanuprakash Modem
` (38 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_dp_tiled_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kms_dp_tiled_display.c b/tests/kms_dp_tiled_display.c
index bb638050..07b803a5 100644
--- a/tests/kms_dp_tiled_display.c
+++ b/tests/kms_dp_tiled_display.c
@@ -272,6 +272,7 @@ static void setup_mode(data_t *data)
igt_require(found);
igt_output_override_mode(output, mode);
}
+ igt_require(i915_pipe_output_combo_valid(data->display));
igt_display_commit_atomic(data->display, DRM_MODE_ATOMIC_ALLOW_MODESET,
NULL);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 17/52] tests/kms_flip_event_leak: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (16 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 16/52] tests/kms_dp_tiled_display: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 18/52] tests/kms_invalid_mode: " Bhanuprakash Modem
` (37 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_flip_event_leak.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
index 56ff2af2..75206ee6 100644
--- a/tests/kms_flip_event_leak.c
+++ b/tests/kms_flip_event_leak.c
@@ -48,10 +48,6 @@ static void test(data_t *data, enum pipe pipe, igt_output_t *output)
struct igt_fb fb[2];
int fd, ret;
- igt_display_reset(&data->display);
- /* select the pipe we want to use */
- igt_output_set_pipe(output, pipe);
-
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
mode = igt_output_get_mode(output);
@@ -104,9 +100,14 @@ igt_main
igt_display_require_output(&data.display);
}
-
igt_subtest_with_dynamic("basic") {
for_each_pipe_with_valid_output(&data.display, pipe, output) {
+ igt_display_reset(&data.display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
test(&data, pipe, output);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 18/52] tests/kms_invalid_mode: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (17 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 17/52] tests/kms_flip_event_leak: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 19/52] tests/kms_lease: " Bhanuprakash Modem
` (36 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_invalid_mode.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 40042d4e..86f529e8 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -301,6 +301,12 @@ igt_main
for (int i = 0; i < ARRAY_SIZE(subtests); i++) {
igt_subtest_with_dynamic(subtests[i].name) {
for_each_pipe_with_valid_output(&data.display, pipe, output) {
+ igt_display_reset(&data.display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe)) {
data.output = output;
data.pipe = pipe;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 19/52] tests/kms_lease: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (18 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 18/52] tests/kms_invalid_mode: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default Bhanuprakash Modem
` (35 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/kms_lease.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 67e8d3be..a52d8bfc 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -1213,10 +1213,14 @@ igt_main
igt_describe(f->desc);
igt_subtest_with_dynamic_f("%s", f->name) {
for_each_pipe_with_valid_output(display, data.pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, data.pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data.pipe),
igt_output_name(output)) {
- igt_display_reset(display);
- igt_display_commit(display);
data.crtc_id = display->pipes[data.pipe].crtc_id;
data.connector_id = output->id;
data.plane_id =
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (19 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 19/52] tests/kms_lease: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 21/52] tests/kms_pipe_crc_basic: Add support for Bigjoiner Bhanuprakash Modem
` (34 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
As we are trying to run this subtest on all pipes + all outputs, It is not
possible to use 8K mode. To use 8K mode on a pipe then the consecutive pipe
must be free which is not true here.
Instead, reduce the resolution from 8K and run the test otherwise we'll endup
with the test failures.
V2:
- Fix commit message
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_multipipe_modeset.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/kms_multipipe_modeset.c b/tests/kms_multipipe_modeset.c
index 1fdfb9a9..5c26165a 100644
--- a/tests/kms_multipipe_modeset.c
+++ b/tests/kms_multipipe_modeset.c
@@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs)
drmModeModeInfo *mode;
int i = 0;
+ /* Find suitable mode/resolution combo */
+ for_each_connected_output(display, output) {
+ pipe = &display->pipes[i];
+ igt_output_set_pipe(output, i);
+
+ i++;
+ }
+ igt_require(igt_override_all_active_output_modes_to_fit_bw(display));
+
for_each_connected_output(display, output) {
mode = igt_output_get_mode(output);
igt_assert(mode);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 21/52] tests/kms_pipe_crc_basic: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (20 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 22/52] tests/kms_plane: " Bhanuprakash Modem
` (33 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_pipe_crc_basic.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 91a1b8ab..ffc77eb3 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -274,6 +274,21 @@ static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,
igt_remove_fb(data->drm_fd, &data->fb);
}
+static bool pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
data_t data = {0, };
igt_main
@@ -322,6 +337,9 @@ igt_main
igt_describe(tests[i].desc);
igt_subtest_with_dynamic(tests[i].name) {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
if (tests[i].flags & TEST_SUSPEND) {
test_read_crc(&data, pipe, output, 0);
@@ -350,6 +368,9 @@ igt_main
"does not cause issues.");
igt_subtest_with_dynamic("disable-crc-after-crtc") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
test_disable_crc_after_crtc(&data, pipe, output);
}
@@ -358,6 +379,9 @@ igt_main
igt_describe("Basic sanity check for CRC mismatches");
igt_subtest_with_dynamic("compare-crc-sanitycheck") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
test_compare_crc(&data, pipe, output);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 22/52] tests/kms_plane: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (21 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 21/52] tests/kms_pipe_crc_basic: Add support for Bigjoiner Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 23/52] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
` (32 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_plane.c | 30 +++++++++++++++++++-----------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 8a54ba66..58951b80 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -56,6 +56,7 @@ typedef struct {
typedef struct {
int drm_fd;
igt_display_t display;
+ igt_output_t *output;
igt_pipe_crc_t *pipe_crc;
const color_t *colors;
int num_colors;
@@ -274,11 +275,11 @@ static void
test_plane_position(data_t *data, enum pipe pipe)
{
int n_planes = data->display.pipes[pipe].n_planes;
- igt_output_t *output;
+ igt_output_t *output = data->output;
igt_crc_t reference_crc;
- output = igt_get_single_output_for_pipe(&data->display, pipe);
- igt_require(output);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
test_init(data, pipe);
test_grab_crc(data, output, pipe, &green, data->flags, &reference_crc);
@@ -381,11 +382,11 @@ test_plane_panning_with_output(data_t *data,
static void
test_plane_panning(data_t *data, enum pipe pipe)
{
- igt_output_t *output;
+ igt_output_t *output = data->output;
igt_crc_t ref_crc;
- output = igt_get_single_output_for_pipe(&data->display, pipe);
- igt_require(output);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
test_init(data, pipe);
@@ -1051,7 +1052,7 @@ test_pixel_formats(data_t *data, enum pipe pipe)
igt_plane_t *primary;
drmModeModeInfo *mode;
bool result;
- igt_output_t *output;
+ igt_output_t *output = data->output;
igt_plane_t *plane;
if (data->extended) {
@@ -1062,10 +1063,10 @@ test_pixel_formats(data_t *data, enum pipe pipe)
data->num_colors = ARRAY_SIZE(colors_reduced);
}
- test_init(data, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
- output = igt_get_single_output_for_pipe(&data->display, pipe);
- igt_require(output);
+ test_init(data, pipe);
mode = igt_output_get_mode(output);
@@ -1109,7 +1110,14 @@ static void run_test(data_t *data, void (*test)(data_t *, enum pipe))
enum pipe pipe;
int count = 0;
- for_each_pipe(&data->display, pipe) {
+ for_each_pipe_with_single_output(&data->display, pipe, data->output) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(data->output, pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
+ igt_output_set_pipe(data->output, PIPE_NONE);
igt_dynamic_f("pipe-%s-planes", kmstest_pipe_name(pipe))
test(data, pipe);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 23/52] tests/kms_plane_alpha_blend: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (22 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 22/52] tests/kms_plane: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 24/52] tests/kms_plane_cursor: " Bhanuprakash Modem
` (31 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
V3: - Rebase
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_plane_alpha_blend.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index ccf1d657..1c5ab920 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -171,9 +171,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
int w, h;
igt_plane_t *primary = igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY);
- igt_display_reset(display);
- igt_output_set_pipe(output, pipe);
-
/* create the pipe_crc object for this pipe */
igt_pipe_crc_free(data->pipe_crc);
data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe,
@@ -617,6 +614,12 @@ static void run_subtests(data_t *data)
igt_subtest_with_dynamic(subtests[i].name) {
for_each_pipe_with_single_output(&data->display, pipe, output) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
prepare_crtc(data, output, pipe);
if (!pipe_check(data, pipe, subtests[i].blend, subtests[i].must_multiply))
continue;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 24/52] tests/kms_plane_cursor: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (23 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 23/52] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 25/52] tests/kms_plane_lowres: " Bhanuprakash Modem
` (30 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_plane_cursor.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 9b27586c..9e317cbf 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -85,6 +85,12 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
data->overlay = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_OVERLAY);
data->cursor = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_CURSOR);
+ igt_output_set_pipe(data->output, data->pipe_id);
+ igt_require(i915_pipe_output_combo_valid(display));
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(data->pipe_id), igt_output_name(data->output));
+
igt_require_pipe_crc(data->drm_fd);
data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe_id,
IGT_PIPE_CRC_SOURCE_AUTO);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 25/52] tests/kms_plane_lowres: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (24 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 24/52] tests/kms_plane_cursor: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 26/52] tests/kms_plane_multiple: " Bhanuprakash Modem
` (29 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_plane_lowres.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
index 6dfc147c..958d3ec6 100644
--- a/tests/kms_plane_lowres.c
+++ b/tests/kms_plane_lowres.c
@@ -277,6 +277,9 @@ static void run_test(data_t *data, uint64_t modifier)
igt_display_reset(&data->display);
igt_output_set_pipe(data->output, data->pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
IGT_PIPE_CRC_SOURCE_AUTO);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 26/52] tests/kms_plane_multiple: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (25 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 25/52] tests/kms_plane_lowres: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 27/52] tests/kms_plane_scaling: " Bhanuprakash Modem
` (28 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_plane_multiple.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 75659015..7dd9d586 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -103,6 +103,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
igt_plane_t *primary;
int ret;
+ igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -290,6 +291,9 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
bool loop_forever;
char info[256];
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
if (opt.iterations == LOOP_FOREVER) {
loop_forever = true;
sprintf(info, "forever");
@@ -373,12 +377,17 @@ static void run_test(data_t *data, uint64_t modifier)
{
enum pipe pipe;
igt_output_t *output;
+ igt_display_t *display = &data->display;
- if (!igt_display_has_format_mod(&data->display, DRM_FORMAT_XRGB8888, modifier))
+ if (!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier))
return;
- for_each_pipe_with_valid_output(&data->display, pipe, output) {
- igt_display_reset(&data->display);
+ for_each_pipe_with_valid_output(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
test_plane_position(data, pipe, output, modifier);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 27/52] tests/kms_plane_scaling: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (26 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 26/52] tests/kms_plane_multiple: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 28/52] tests/kms_prime: " Bhanuprakash Modem
` (27 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
As many 2x tests are currently running on Pipe-A & B only, those
tests will always SKIP if there is any 8K supported panel in the
config. Instead of Skipping the test, add some intelligence to
the subtest to identify the valid pipe/output combo to execute
the subtest.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_plane_scaling.c | 218 +++++++++++++++++++++++++-------------
1 file changed, 145 insertions(+), 73 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4c621cce..49a194e1 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -546,30 +546,45 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height,
}
}
-static void find_connected_pipe(igt_display_t *display, bool second, enum pipe *pipe, igt_output_t **output)
+static enum pipe
+find_connected_pipe(igt_display_t *display, bool second, igt_output_t **output)
{
- enum pipe first = PIPE_NONE;
- igt_output_t *first_output = NULL;
+ enum pipe pipe;
+ bool first_output = false;
bool found = false;
- for_each_pipe_with_valid_output(display, *pipe, *output) {
- if (first == *pipe || *output == first_output)
- continue;
+ igt_display_reset(display);
- if (second) {
- first = *pipe;
- first_output = *output;
- second = false;
- continue;
- }
+ for_each_pipe(display, pipe) {
+ for_each_valid_output_on_pipe(display, pipe, *output) {
+ if((*output)->pending_pipe != PIPE_NONE)
+ continue;
- return;
+ igt_output_set_pipe(*output, pipe);
+ if (i915_pipe_output_combo_valid(display)) {
+ found = true;
+
+ if (second) {
+ first_output = true;
+ second = false;
+ found = false;
+ }
+ break;
+ }
+ igt_output_set_pipe(*output, PIPE_NONE);
+ }
+ if (found)
+ break;
}
+ igt_display_reset(display);
+
if (first_output)
igt_require_f(found, "No second valid output found\n");
else
igt_require_f(found, "No valid outputs found\n");
+
+ return pipe;
}
static void
@@ -749,13 +764,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
enum pipe pipe1, pipe2;
int ret1, ret2;
- cleanup_crtc(d);
-
- find_connected_pipe(display, false, &pipe1, &output1);
- find_connected_pipe(display, true, &pipe2, &output2);
+ cleanup_fbs(d);
+ pipe1 = find_connected_pipe(display, false, &output1);
+ pipe2 = find_connected_pipe(display, true, &output2);
igt_skip_on(!output1 || !output2);
+ igt_info("Using (pipe %s + %s) and (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe1), igt_output_name(output1),
+ kmstest_pipe_name(pipe2), igt_output_name(output2));
+
igt_output_set_pipe(output1, pipe1);
igt_output_set_pipe(output2, pipe2);
@@ -820,6 +838,22 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
igt_assert_eq(ret1 && ret2, 0);
}
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static int opt_handler(int opt, int opt_index, void *_data)
{
data_t *data = _data;
@@ -861,17 +895,22 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
for (int index = 0; index < ARRAY_SIZE(scaler_with_pixel_format_tests); index++) {
igt_describe(scaler_with_pixel_format_tests[index].describe);
igt_subtest_with_dynamic(scaler_with_pixel_format_tests[index].name) {
- for_each_pipe_with_single_output(&data.display, pipe, output)
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
- drmModeModeInfo *mode;
-
- mode = igt_output_get_mode(output);
-
- test_scaler_with_pixel_format_pipe(&data,
- get_width(mode, scaler_with_pixel_format_tests[index].sf),
- get_height(mode, scaler_with_pixel_format_tests[index].sf),
- scaler_with_pixel_format_tests[index].is_upscale,
- pipe, output);
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
+
+ test_scaler_with_pixel_format_pipe(&data,
+ get_width(mode, scaler_with_pixel_format_tests[index].sf),
+ get_height(mode, scaler_with_pixel_format_tests[index].sf),
+ scaler_with_pixel_format_tests[index].is_upscale,
+ pipe, output);
+ }
+ break;
+ }
}
}
}
@@ -879,17 +918,22 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
for (int index = 0; index < ARRAY_SIZE(scaler_with_rotation_tests); index++) {
igt_describe(scaler_with_rotation_tests[index].describe);
igt_subtest_with_dynamic(scaler_with_rotation_tests[index].name) {
- for_each_pipe_with_single_output(&data.display, pipe, output)
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
- drmModeModeInfo *mode;
-
- mode = igt_output_get_mode(output);
-
- test_scaler_with_rotation_pipe(&data,
- get_width(mode, scaler_with_rotation_tests[index].sf),
- get_height(mode, scaler_with_rotation_tests[index].sf),
- scaler_with_rotation_tests[index].is_upscale,
- pipe, output);
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
+
+ test_scaler_with_rotation_pipe(&data,
+ get_width(mode, scaler_with_rotation_tests[index].sf),
+ get_height(mode, scaler_with_rotation_tests[index].sf),
+ scaler_with_rotation_tests[index].is_upscale,
+ pipe, output);
+ }
+ break;
+ }
}
}
}
@@ -897,85 +941,113 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
for (int index = 0; index < ARRAY_SIZE(scaler_with_modifiers_tests); index++) {
igt_describe(scaler_with_modifiers_tests[index].describe);
igt_subtest_with_dynamic(scaler_with_modifiers_tests[index].name) {
- for_each_pipe_with_single_output(&data.display, pipe, output)
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
- drmModeModeInfo *mode;
-
- mode = igt_output_get_mode(output);
-
- test_scaler_with_modifier_pipe(&data,
- get_width(mode, scaler_with_rotation_tests[index].sf),
- get_height(mode, scaler_with_rotation_tests[index].sf),
- scaler_with_rotation_tests[index].is_upscale,
- pipe, output);
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
+
+ test_scaler_with_modifier_pipe(&data,
+ get_width(mode, scaler_with_rotation_tests[index].sf),
+ get_height(mode, scaler_with_rotation_tests[index].sf),
+ scaler_with_rotation_tests[index].is_upscale,
+ pipe, output);
+ }
+ break;
+ }
}
}
}
igt_describe("Tests scaling with clipping and clamping, pixel formats.");
igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-pixel-formats") {
- for_each_pipe_with_single_output(&data.display, pipe, output) {
- drmModeModeInfo *mode;
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
- mode = igt_output_get_mode(output);
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
- test_scaler_with_pixel_format_pipe(&data, mode->hdisplay + 100,
+ test_scaler_with_pixel_format_pipe(&data, mode->hdisplay + 100,
mode->vdisplay + 100, false, pipe, output);
+ }
+ break;
+ }
}
}
igt_describe("Tests scaling with clipping and clamping, rotation.");
igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-rotation") {
- for_each_pipe_with_single_output(&data.display, pipe, output) {
- drmModeModeInfo *mode;
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
- mode = igt_output_get_mode(output);
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
- test_scaler_with_rotation_pipe(&data, mode->hdisplay + 100,
+ test_scaler_with_rotation_pipe(&data, mode->hdisplay + 100,
mode->vdisplay + 100, false, pipe, output);
+ }
+ break;
+ }
}
}
igt_describe("Tests scaling with clipping and clamping, modifiers.");
igt_subtest_with_dynamic("plane-scaler-with-clipping-clamping-modifiers") {
- for_each_pipe_with_single_output(&data.display, pipe, output) {
- drmModeModeInfo *mode;
-
- mode = igt_output_get_mode(output);
-
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
- test_scaler_with_modifier_pipe(&data, mode->hdisplay + 100,
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
+ test_scaler_with_modifier_pipe(&data, mode->hdisplay + 100,
mode->vdisplay + 100, false, pipe, output);
+ }
+ break;
+ }
}
}
for (int index = 0; index < ARRAY_SIZE(scaler_with_2_planes_tests); index++) {
igt_describe(scaler_with_2_planes_tests[index].describe);
igt_subtest_with_dynamic(scaler_with_2_planes_tests[index].name) {
- for_each_pipe_with_single_output(&data.display, pipe, output)
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
- drmModeModeInfo *mode;
+ for_each_pipe(&data.display, pipe) {
+ for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
- mode = igt_output_get_mode(output);
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ drmModeModeInfo *mode = igt_output_get_mode(output);
- test_planes_scaling_combo(&data,
+ test_planes_scaling_combo(&data,
get_width(mode, scaler_with_2_planes_tests[index].sf_plane1),
get_height(mode, scaler_with_2_planes_tests[index].sf_plane1),
get_width(mode, scaler_with_2_planes_tests[index].sf_plane2),
get_height(mode, scaler_with_2_planes_tests[index].sf_plane2),
pipe, output, scaler_with_2_planes_tests[index].test_type);
+ }
+ break;
}
}
+ }
}
igt_describe("Negative test for number of scalers per pipe.");
igt_subtest_with_dynamic("invalid-num-scalers") {
- for_each_pipe_with_valid_output(&data.display, pipe, output)
+ for_each_pipe_with_valid_output(&data.display, pipe, output) {
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
igt_dynamic_f("pipe-%s-%s-invalid-num-scalers",
kmstest_pipe_name(pipe), igt_output_name(output))
test_invalid_num_scalers(&data, pipe, output);
+ }
}
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 28/52] tests/kms_prime: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (27 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 27/52] tests/kms_plane_scaling: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 29/52] tests/kms_properties: " Bhanuprakash Modem
` (26 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_prime.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/kms_prime.c b/tests/kms_prime.c
index 097c2f2a..d4a92651 100644
--- a/tests/kms_prime.c
+++ b/tests/kms_prime.c
@@ -89,14 +89,17 @@ static igt_output_t *setup_display(int importer_fd, igt_display_t *display,
bool found = false;
for_each_pipe_with_valid_output(display, *pipe, output) {
- found = true;
- break;
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, *pipe);
+ if (i915_pipe_output_combo_valid(display)) {
+ found = true;
+ break;
+ }
}
igt_require_f(found, "No valid connector/pipe found\n");
- igt_display_reset(display);
- igt_output_set_pipe(output, *pipe);
return output;
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 29/52] tests/kms_properties: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (28 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 28/52] tests/kms_prime: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 30/52] tests/kms_rmfb: " Bhanuprakash Modem
` (25 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/kms_properties.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index 2958efac..2fe8dfa6 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -241,6 +241,12 @@ static void plane_properties(igt_display_t *display, bool atomic)
found = false;
for_each_valid_output_on_pipe(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
found_any = found = true;
run_plane_property_tests(display, pipe, output, atomic);
@@ -264,6 +270,12 @@ static void crtc_properties(igt_display_t *display, bool atomic)
found = false;
for_each_valid_output_on_pipe(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
found_any_valid_pipe = found = true;
run_crtc_property_tests(display, pipe, output, atomic);
@@ -290,6 +302,12 @@ static void connector_properties(igt_display_t *display, bool atomic)
if (!igt_pipe_connector_valid(pipe, output))
continue;
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
found = true;
run_connector_property_tests(display, pipe, output, atomic);
break;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 30/52] tests/kms_rmfb: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (29 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 29/52] tests/kms_properties: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 31/52] tests/kms_rotation_crc: " Bhanuprakash Modem
` (24 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/kms_rmfb.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
index 7e43e1bd..50df4295 100644
--- a/tests/kms_rmfb.c
+++ b/tests/kms_rmfb.c
@@ -155,8 +155,15 @@ run_rmfb_test(struct rmfb_data *data, bool reopen)
{
igt_output_t *output;
enum pipe pipe;
+ igt_display_t *display = &data->display;
+
+ for_each_pipe_with_single_output(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
- for_each_pipe_with_single_output(&data->display, pipe, output) {
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
igt_output_name(output))
test_rmfb(data, output, pipe, reopen);
@@ -192,7 +199,6 @@ igt_main
igt_describe(tests[i].description);
igt_subtest_with_dynamic(tests[i].name) {
run_rmfb_test(&data, tests[i].reopen);
-
}
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 31/52] tests/kms_rotation_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (30 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 30/52] tests/kms_rmfb: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 32/52] tests/kms_scaling_modes: " Bhanuprakash Modem
` (23 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_rotation_crc.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 72c20d5a..295aed76 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -215,6 +215,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
cleanup_crtc(data);
igt_output_set_pipe(output, pipe);
+ igt_require(i915_pipe_output_combo_valid(display));
+
igt_plane_set_rotation(plane, IGT_ROTATION_0);
/* create the pipe_crc object for this pipe */
@@ -479,6 +481,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_output_t *output;
enum pipe pipe;
int pipe_count = 0, connected_outputs = 0;
+ bool found = false;
if (is_amdgpu_device(data->gfx_fd))
igt_require(plane_type != DRM_PLANE_TYPE_OVERLAY &&
@@ -496,6 +499,13 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_plane_t *plane;
int i, j, c;
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
+ found = true;
mode = igt_output_get_mode(output);
/*
@@ -586,6 +596,7 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
igt_pipe_crc_stop(data->pipe_crc);
}
}
+ igt_require_f(found, "No valid pipe/output combo found.\n");
}
typedef struct {
@@ -804,12 +815,22 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
{IGT_ROTATION_270, .2f, .4f, I915_FORMAT_MOD_Y_TILED },
{IGT_ROTATION_270, .2f, .4f, I915_FORMAT_MOD_Yf_TILED },
};
+ bool found = false;
+
+ igt_display_require_output(display);
for_each_valid_output_on_pipe(display, pipe, output) {
int i, j, k, l, flipsw, fliphw;
+
+ igt_display_reset(display);
+
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
+ found = true;
+
mode = igt_output_get_mode(output);
- igt_display_require_output(display);
igt_display_commit2(display, COMMIT_ATOMIC);
p[0].plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -952,6 +973,8 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
igt_remove_fb(data->gfx_fd, &planeconfigs[c].fbs[d][MULTIPLANE_ROTATED]);
}
}
+
+ igt_require_f(found, "No valid pipe/output combo found.\n");
}
static void test_plane_rotation_exhaust_fences(data_t *data,
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 32/52] tests/kms_scaling_modes: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (31 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 31/52] tests/kms_rotation_crc: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 33/52] tests/kms_sequence: " Bhanuprakash Modem
` (22 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_scaling_modes.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
index 039e4a8d..cf637712 100644
--- a/tests/kms_scaling_modes.c
+++ b/tests/kms_scaling_modes.c
@@ -93,13 +93,17 @@ static void test_scaling_mode(data_t *data, uint32_t flags)
enum pipe pipe;
for_each_pipe_with_valid_output(display, pipe, output) {
+ igt_display_reset(display);
+
if (!has_scaling_mode(output))
continue;
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe))
test_scaling_mode_on_output(display, pipe, output, flags);
-
- igt_display_reset(display);
}
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 33/52] tests/kms_sequence: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (32 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 32/52] tests/kms_scaling_modes: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 34/52] tests/kms_universal_plane: " Bhanuprakash Modem
` (21 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_sequence.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
index c72857a3..c8a3d6bb 100644
--- a/tests/kms_sequence.c
+++ b/tests/kms_sequence.c
@@ -285,6 +285,12 @@ igt_main
"drmCrtcQueueSequence");
igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {
for_each_pipe_with_valid_output(&data.display, p, output) {
+ igt_display_reset(&data.display);
+
+ igt_output_set_pipe(output, p);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(p)) {
data.pipe = p;
data.output = output;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 34/52] tests/kms_universal_plane: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (33 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 33/52] tests/kms_sequence: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 35/52] tests/kms_vblank: " Bhanuprakash Modem
` (20 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_universal_plane.c | 94 +++++++++++++++++++++++++++++++++----
1 file changed, 84 insertions(+), 10 deletions(-)
diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index dd8fa193..2a9eb021 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -381,6 +381,9 @@ sanity_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -494,6 +497,9 @@ pageflip_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
pageflip_test_init(&test, output, pipe);
@@ -604,6 +610,9 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_require(display->has_cursor_plane);
igt_require_intel(data->drm_fd);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -731,6 +740,9 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
igt_skip_on(is_i915_device(data->drm_fd) && data->display_ver < 9);
igt_require_pipe(&data->display, pipe);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
gen9_test_init(&test, output, pipe);
@@ -766,6 +778,22 @@ pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
gen9_test_fini(&test, output);
}
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static void
run_tests_for_pipe(data_t *data, enum pipe pipe)
{
@@ -784,34 +812,79 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
igt_describe("Check the switching between different primary plane fbs with CRTC off");
igt_subtest_f("universal-plane-pipe-%s-functional",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
functional_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Test for scale-up or scale-down using universal plane API without covering CRTC");
igt_subtest_f("universal-plane-pipe-%s-sanity",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
sanity_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check pageflips while primary plane is disabled before IOCTL or between IOCTL"
" and pageflip execution");
igt_subtest_f("disable-primary-vs-flip-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
pageflip_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check for cursor leaks after performing cursor operations");
igt_subtest_f("cursor-fb-leak-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
cursor_leak_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
igt_describe("Check if pageflip succeeds in windowed setting");
igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",
- kmstest_pipe_name(pipe))
- for_each_valid_output_on_pipe(&data->display, pipe, output)
+ kmstest_pipe_name(pipe)) {
+ bool found = false;
+
+ for_each_valid_output_on_pipe(&data->display, pipe, output) {
+ if (!pipe_output_combo_valid(&data->display, pipe, output))
+ continue;
+
+ found = true;
pageflip_win_test_pipe(data, pipe, output);
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
+ }
}
static data_t data;
@@ -829,6 +902,7 @@ igt_main
igt_require_pipe_crc(data.drm_fd);
igt_display_require(&data.display, data.drm_fd);
+ igt_display_require_output(&data.display);
}
for_each_pipe_static(pipe) {
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 35/52] tests/kms_vblank: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (34 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 34/52] tests/kms_universal_plane: " Bhanuprakash Modem
@ 2022-11-15 16:58 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 36/52] tests/kms_vrr: " Bhanuprakash Modem
` (19 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:58 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vblank.c | 54 ++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 5bd3fefe..f6863af0 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -175,6 +175,22 @@ static void run_test(data_t *data, void (*testfunc)(data_t *, int, int))
cleanup_crtc(data, fd, output);
}
+static bool
+pipe_output_combo_valid(igt_display_t *display,
+ enum pipe pipe, igt_output_t *output)
+{
+ bool ret = true;
+
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static void crtc_id_subtest(data_t *data, int fd)
{
igt_display_t *display = &data->display;
@@ -188,6 +204,15 @@ static void crtc_id_subtest(data_t *data, int fd)
uint64_t val;
union drm_wait_vblank vbl;
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, p);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(p), igt_output_name(output));
+
crtc_id = display->pipes[p].crtc_id;
if (drmGetCap(display->drm_fd, DRM_CAP_CRTC_IN_VBLANK_EVENT, &val) == 0)
expected_crtc_id = crtc_id;
@@ -449,10 +474,18 @@ static void run_subtests_for_pipe(data_t *data)
igt_subtest_f("pipe-%s-%s-%s",
kmstest_pipe_name(data->pipe),
f->name, m->name) {
+ int found = 0;
+
for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
+ if (!pipe_output_combo_valid(&data->display, data->pipe, data->output))
+ continue;
+
data->flags = m->flags | NOHANG;
run_test(data, f->func);
+
+ found++;
}
+ igt_require_f(found, "No valid pipe/output combo found.\n");
}
/* Skip the -hang version if NOHANG flag is set */
@@ -464,13 +497,20 @@ static void run_subtests_for_pipe(data_t *data)
kmstest_pipe_name(data->pipe),
f->name, m->name) {
igt_hang_t hang;
+ int found = 0;
hang = igt_allow_hang(data->display.drm_fd, 0, 0);
for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
+ if (!pipe_output_combo_valid(&data->display, data->pipe, data->output))
+ continue;
+
data->flags = m->flags;
run_test(data, f->func);
+
+ found++;
}
igt_disallow_hang(data->display.drm_fd, hang);
+ igt_require_f(found, "No valid pipe/output combo found.\n");
}
}
}
@@ -482,12 +522,22 @@ static void invalid_subtest(data_t *data, int fd)
unsigned long valid_flags;
igt_display_t* display = &data->display;
enum pipe pipe = 0;
- igt_output_t* output = igt_get_single_output_for_pipe(display, pipe);
+ igt_output_t *output;
+
+ igt_display_reset(display);
+
+ output = igt_get_single_output_for_pipe(display, pipe);
+ igt_require(output);
data->pipe = pipe;
data->output = output;
+
igt_output_set_pipe(output, pipe);
- igt_display_require_output_on_pipe(display, pipe);
+ igt_require(i915_pipe_output_combo_valid(display));
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
prepare_crtc(data, fd, output);
/* First check all is well with a simple query */
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 36/52] tests/kms_vrr: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (35 preceding siblings ...)
2022-11-15 16:58 ` [igt-dev] [i-g-t v5 35/52] tests/kms_vblank: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 37/52] tests/i915/kms_big_fb: " Bhanuprakash Modem
` (18 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/kms_vrr.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 8976d4a6..619b3789 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -444,6 +444,12 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
for_each_pipe(&data->display, pipe) {
if (igt_pipe_connector_valid(pipe, output)) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe), output->name)
test(data, pipe, output, flags);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 37/52] tests/i915/kms_big_fb: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (36 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 36/52] tests/kms_vrr: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 38/52] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
` (17 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_big_fb.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 0beba0e1..a29a05a2 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -406,6 +406,9 @@ static bool test_pipe(data_t *data)
igt_plane_t *primary;
bool ret = false;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(data->pipe), igt_output_name(data->output));
+
if (data->format == DRM_FORMAT_C8 &&
!igt_pipe_obj_has_prop(&data->display.pipes[data->pipe],
IGT_CRTC_GAMMA_LUT))
@@ -481,6 +484,10 @@ max_hw_stride_async_flip_test(data_t *data)
igt_crc_t compare_crc, async_crc;
igt_require(data->display.is_atomic);
+
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(data->pipe), igt_output_name(data->output));
+
igt_output_set_pipe(data->output, data->pipe);
primary = igt_output_get_plane_type(data->output, DRM_PLANE_TYPE_PRIMARY);
@@ -592,6 +599,12 @@ static void test_scanout(data_t *data)
data->format, data->modifier);
for_each_pipe_with_valid_output(&data->display, data->pipe, data->output) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(data->output, data->pipe);
+ if (!i915_pipe_output_combo_valid(&data->display))
+ continue;
+
if (data->async_flip_test) {
if (max_hw_stride_async_flip_test(data))
return;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 38/52] tests/i915/kms_big_joiner: Negative tests for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (37 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 37/52] tests/i915/kms_big_fb: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 39/52] tests/i915/kms_busy: Add support " Bhanuprakash Modem
` (16 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
Add negative tests to validate Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
Kernel should reject the commit/modeset if above conditions won't met.
V2:
- Fix redundant negative tests
V3:
- Drop duplicate logic
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/i915/kms_big_joiner.c | 187 +++++++++++++++---------------------
1 file changed, 79 insertions(+), 108 deletions(-)
diff --git a/tests/i915/kms_big_joiner.c b/tests/i915/kms_big_joiner.c
index 71b2526d..e7a139b3 100644
--- a/tests/i915/kms_big_joiner.c
+++ b/tests/i915/kms_big_joiner.c
@@ -45,111 +45,42 @@ typedef struct {
static void test_invalid_modeset(data_t *data)
{
- drmModeModeInfo *mode;
+ igt_output_t *output;
igt_display_t *display = &data->display;
- igt_output_t *output, *big_joiner_output = NULL, *second_output = NULL;
int ret;
- igt_pipe_t *pipe;
- igt_plane_t *plane;
-
- igt_display_reset(display);
- for_each_connected_output(display, output) {
- mode = &output->config.connector->modes[0];
+ igt_info("Bigjoiner test on ");
+ for_each_connected_output(display, output){
+ enum pipe p = output->pending_pipe;
+ drmModeModeInfo *mode;
+ igt_pipe_t *pipe;
+ igt_plane_t *plane;
- if (data->big_joiner_output[0].id == output->id) {
- big_joiner_output = output;
- } else if (second_output == NULL) {
- second_output = output;
- }
- }
+ if (p == PIPE_NONE)
+ continue;
- igt_output_set_pipe(big_joiner_output, data->pipe1);
+ mode = igt_output_get_mode(output);
+ igt_info("pipe:%s, output:%s, mode:", kmstest_pipe_name(p), igt_output_name(output));
+ kmstest_dump_mode(mode);
- mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0].mode_number];
- igt_output_override_mode(big_joiner_output, mode);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
-
- igt_display_commit2(display, COMMIT_ATOMIC);
+ pipe = &display->pipes[p];
+ plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
- igt_output_set_pipe(second_output, data->pipe2);
-
- mode = igt_output_get_mode(second_output);
+ igt_plane_set_fb(plane, &data->fb);
+ igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
+ igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ }
- pipe = &display->pipes[data->pipe2];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ igt_assert(!igt_check_bigjoiner_support(display));
/* This commit is expectd to fail as this pipe is being used for big joiner */
ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
- igt_assert_lt(ret, 0);
-
- igt_output_set_pipe(big_joiner_output, PIPE_NONE);
- igt_output_set_pipe(second_output, PIPE_NONE);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- /*
- * Do not explicitly set the plane of the second output to NULL,
- * as it is the adjacent pipe to the big joiner output and
- * setting the big joiner plane to NULL will take care of this.
- */
- igt_plane_set_fb(plane, NULL);
- igt_display_commit2(display, COMMIT_ATOMIC);
- igt_output_override_mode(big_joiner_output, NULL);
-
- igt_output_set_pipe(second_output, data->pipe2);
-
- mode = igt_output_get_mode(second_output);
-
- pipe = &display->pipes[data->pipe2];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ igt_display_reset(&data->display);
igt_display_commit2(display, COMMIT_ATOMIC);
- igt_output_set_pipe(big_joiner_output, data->pipe1);
-
- mode = &big_joiner_output->config.connector->modes[data->big_joiner_output[0].mode_number];
- igt_output_override_mode(big_joiner_output, mode);
-
- pipe = &display->pipes[data->pipe1];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
-
- igt_plane_set_fb(plane, &data->fb);
- igt_fb_set_size(&data->fb, plane, mode->hdisplay, mode->vdisplay);
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
-
- /* This commit is expected to fail as the adjacent pipe is already in use*/
- ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
igt_assert_lt(ret, 0);
-
- igt_output_set_pipe(big_joiner_output, PIPE_NONE);
- igt_output_set_pipe(second_output, PIPE_NONE);
- igt_plane_set_fb(plane, NULL);
-
- pipe = &display->pipes[data->pipe2];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
- igt_plane_set_fb(plane, NULL);
-
- igt_display_commit2(display, COMMIT_ATOMIC);
-
- igt_output_override_mode(big_joiner_output, NULL);
}
static void test_basic_modeset(data_t *data)
@@ -261,19 +192,17 @@ igt_main
igt_require(data.display.is_atomic);
for_each_connected_output(&data.display, output) {
- if (count < 2) {
- for (i = 0; i < output->config.connector->count_modes; i++) {
- mode = &output->config.connector->modes[i];
- if (mode->hdisplay > MAX_HDISPLAY_PER_PIPE) {
- data.big_joiner_output[count].mode_number = i;
- data.big_joiner_output[count].id = output->id;
- count++;
-
- width = max(width, mode->hdisplay);
- height = max(height, mode->vdisplay);
- break;
- }
- }
+ igt_sort_connector_modes(output->config.connector,
+ sort_drm_modes_by_res_dsc);
+
+ mode = &output->config.connector->modes[0];
+ if (mode->hdisplay > MAX_HDISPLAY_PER_PIPE) {
+ data.big_joiner_output[count].mode_number = i;
+ data.big_joiner_output[count].id = output->id;
+ count++;
+
+ width = max(width, mode->hdisplay);
+ height = max(height, mode->vdisplay);
}
valid_output++;
}
@@ -303,14 +232,56 @@ igt_main
igt_describe("Verify if the modeset on the adjoining pipe is rejected "
"when the pipe is active with a big joiner modeset");
igt_subtest_with_dynamic("invalid-modeset") {
- igt_require_f(valid_output > 1, "No valid Second output found\n");
- for (i = 0; i < data.n_pipes - 1; i++) {
- data.pipe1 = pipe_seq[i];
- data.pipe2 = pipe_seq[i + 1];
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe_seq[i]),
- kmstest_pipe_name(pipe_seq[i + 1]))
+ data.pipe1 = pipe_seq[j - 1];
+
+ igt_display_reset(&data.display);
+ for_each_connected_output(&data.display, output) {
+ if (data.big_joiner_output[0].id != output->id)
+ continue;
+
+ igt_sort_connector_modes(output->config.connector,
+ sort_drm_modes_by_res_dsc);
+
+ igt_output_set_pipe(output, data.pipe1);
+ igt_output_override_mode(output, &output->config.connector->modes[0]);
+
+ igt_dynamic_f("pipe-%s-%s",
+ kmstest_pipe_name(data.pipe1),
+ igt_output_name(output))
test_invalid_modeset(&data);
}
+
+ if(valid_output > 1) {
+ for (i = 0; i < data.n_pipes - 1; i++) {
+ igt_output_t *first_output = NULL, *second_output = NULL;
+
+ data.pipe1 = pipe_seq[i];
+ data.pipe2 = pipe_seq[i + 1];
+
+ igt_display_reset(&data.display);
+ for_each_connected_output(&data.display, output) {
+ igt_sort_connector_modes(output->config.connector,
+ sort_drm_modes_by_res_dsc);
+
+ if (data.big_joiner_output[0].id == output->id) {
+ first_output = output;
+ igt_output_set_pipe(output, data.pipe1);
+ igt_output_override_mode(output, &output->config.connector->modes[0]);
+ } else if (second_output == NULL) {
+ second_output = output;
+ igt_output_set_pipe(output, data.pipe2);
+ igt_output_override_mode(output, &output->config.connector->modes[0]);
+ }
+ }
+
+ igt_dynamic_f("pipe-%s-%s-pipe-%s-%s",
+ kmstest_pipe_name(data.pipe1),
+ igt_output_name(first_output),
+ kmstest_pipe_name(data.pipe2),
+ igt_output_name(second_output))
+ test_invalid_modeset(&data);
+ }
+ }
}
igt_describe("Verify simultaneous modeset on 2 big joiner outputs");
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 39/52] tests/i915/kms_busy: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (38 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 38/52] tests/i915/kms_big_joiner: Negative tests " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 40/52] tests/i915/kms_ccs: " Bhanuprakash Modem
` (15 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_busy.c | 106 ++++++++++++++++++++++++++++--------------
1 file changed, 71 insertions(+), 35 deletions(-)
diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
index b0642612..20d3058f 100644
--- a/tests/i915/kms_busy.c
+++ b/tests/i915/kms_busy.c
@@ -32,15 +32,12 @@ IGT_TEST_DESCRIPTION("Basic check of KMS ABI with busy framebuffers.");
static bool all_pipes = false;
-static igt_output_t *
-set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)
+static void
+set_fb_on_crtc(igt_display_t *dpy, int pipe,
+ igt_output_t *output, struct igt_fb *fb)
{
drmModeModeInfoPtr mode;
igt_plane_t *primary;
- igt_output_t *output;
-
- output = igt_get_single_output_for_pipe(dpy, pipe);
- igt_require(output);
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -51,8 +48,6 @@ set_fb_on_crtc(igt_display_t *dpy, int pipe, struct igt_fb *fb)
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_plane_set_fb(primary, fb);
-
- return output;
}
static void do_cleanup_display(igt_display_t *dpy)
@@ -136,18 +131,23 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,
put_ahnd(ahnd);
}
-static void test_flip(igt_display_t *dpy, int pipe, bool modeset)
+static void test_flip(igt_display_t *dpy, int pipe,
+ igt_output_t *output, bool modeset)
{
struct igt_fb fb[2];
int warmup[] = { 0, 1, 0, -1 };
struct timespec tv = {};
- igt_output_t *output;
int timeout;
if (modeset)
igt_require(dpy->is_atomic);
- output = set_fb_on_crtc(dpy, pipe, &fb[0]);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(dpy);
+
+ set_fb_on_crtc(dpy, pipe, output, &fb[0]);
igt_display_commit2(dpy, COMMIT_LEGACY);
igt_create_pattern_fb(dpy->drm_fd,
@@ -224,13 +224,18 @@ static void test_atomic_commit_hang(igt_display_t *dpy, igt_plane_t *primary,
}
static void test_hang(igt_display_t *dpy,
- enum pipe pipe, bool modeset, bool hang_newfb)
+ enum pipe pipe, igt_output_t *output,
+ bool modeset, bool hang_newfb)
{
struct igt_fb fb[2];
- igt_output_t *output;
igt_plane_t *primary;
- output = set_fb_on_crtc(dpy, pipe, &fb[0]);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(dpy);
+
+ set_fb_on_crtc(dpy, pipe, output, &fb[0]);
igt_display_commit2(dpy, COMMIT_ATOMIC);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -265,16 +270,22 @@ static void test_hang(igt_display_t *dpy,
igt_remove_fb(dpy->drm_fd, &fb[0]);
}
-static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)
+static void
+test_pageflip_modeset_hang(igt_display_t *dpy,
+ igt_output_t *output, enum pipe pipe)
{
struct igt_fb fb;
struct drm_event_vblank ev;
- igt_output_t *output;
igt_plane_t *primary;
igt_spin_t *t;
uint64_t ahnd = get_reloc_ahnd(dpy->drm_fd, 0);
- output = set_fb_on_crtc(dpy, pipe, &fb);
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
+ igt_display_reset(dpy);
+
+ set_fb_on_crtc(dpy, pipe, output, &fb);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_display_commit2(dpy, dpy->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
@@ -299,6 +310,22 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)
igt_remove_fb(dpy->drm_fd, &fb);
}
+static bool
+pipe_output_combo_valid(igt_display_t *dpy,
+ igt_output_t *output, enum pipe pipe)
+{
+ bool ret = true;
+
+ igt_display_reset(dpy);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(dpy))
+ ret = false;
+ igt_output_set_pipe(output, PIPE_NONE);
+
+ return ret;
+}
+
static int opt_handler(int opt, int opt_index, void *data)
{
switch (opt) {
@@ -346,7 +373,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
{
igt_display_t display = { .drm_fd = -1, .n_pipes = IGT_MAX_PIPES };
- enum pipe active_pipes[IGT_MAX_PIPES];
+ enum pipe pipe, active_pipes[IGT_MAX_PIPES];
+ igt_output_t *output;
uint32_t last_pipe = 0;
int i;
struct {
@@ -367,8 +395,6 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
int fd;
igt_fixture {
- enum pipe pipe;
-
fd = drm_open_driver_master(DRIVER_INTEL);
igt_require_gem(fd);
@@ -391,63 +417,72 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
igt_describe("Test for basic check of KMS ABI with busy framebuffers.");
igt_subtest_with_dynamic("basic") { /* just run on the first pipe */
- enum pipe pipe;
+ for_each_pipe_with_single_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, output, pipe))
+ continue;
- for_each_pipe(&display, pipe) {
igt_dynamic("flip")
- test_flip(&display, pipe, false);
+ test_flip(&display, pipe, output, false);
igt_dynamic("modeset")
- test_flip(&display, pipe, true);
+ test_flip(&display, pipe, output, true);
break;
}
}
igt_subtest_with_dynamic("basic-hang") {
- enum pipe pipe;
igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
errno = 0;
- for_each_pipe(&display, pipe) {
+ for_each_pipe_with_single_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, output, pipe))
+ continue;
+
if (!all_pipes && pipe != active_pipes[0] &&
pipe != active_pipes[last_pipe])
continue;
igt_dynamic_f("flip-pipe-%s", kmstest_pipe_name(pipe))
- test_flip(&display, pipe, false);
+ test_flip(&display, pipe, output, false);
igt_dynamic_f("modeset-pipe-%s", kmstest_pipe_name(pipe))
- test_flip(&display, pipe, true);
+ test_flip(&display, pipe, output, true);
}
igt_disallow_hang(display.drm_fd, hang);
}
igt_subtest_with_dynamic("extended-pageflip-modeset-hang-oldfb") {
- enum pipe pipe;
igt_hang_t hang = igt_allow_hang(display.drm_fd, 0, 0);
errno = 0;
- for_each_pipe(&display, pipe) {
+ for_each_pipe_with_single_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, output, pipe))
+ continue;
+
if (!all_pipes && pipe != active_pipes[0] &&
pipe != active_pipes[last_pipe])
continue;
igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe))
- test_pageflip_modeset_hang(&display, pipe);
+ test_pageflip_modeset_hang(&display, output, pipe);
}
igt_disallow_hang(display.drm_fd, hang);
}
for (i = 0; i < sizeof(tests) / sizeof (tests[0]); i++) {
+ igt_fixture
+ igt_require(display.is_atomic);
+
igt_subtest_with_dynamic(tests[i].name) {
- enum pipe pipe;
igt_hang_t hang;
errno = 0;
- igt_require(display.is_atomic);
hang = igt_allow_hang(display.drm_fd, 0, 0);
- for_each_pipe(&display, pipe) {
+ for_each_pipe_with_single_output(&display, pipe, output) {
+ if (!pipe_output_combo_valid(&display, output, pipe))
+ continue;
+
if (!all_pipes && pipe != active_pipes[0] &&
pipe != active_pipes[last_pipe])
continue;
@@ -456,7 +491,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
if (tests[i].reset)
igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 1);
- test_hang(&display, pipe, tests[i].modeset, tests[i].hang_newfb);
+ test_hang(&display, pipe, output,
+ tests[i].modeset, tests[i].hang_newfb);
if (tests[i].reset)
igt_set_module_param_int(display.drm_fd, "force_reset_modeset_test", 0);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 40/52] tests/i915/kms_ccs: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (39 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 39/52] tests/i915/kms_busy: Add support " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 41/52] tests/i915/kms_cdclk: " Bhanuprakash Modem
` (14 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_ccs.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
index 9be3fa25..40f05278 100644
--- a/tests/i915/kms_ccs.c
+++ b/tests/i915/kms_ccs.c
@@ -590,12 +590,21 @@ static int test_ccs(data_t *data)
static void test_output(data_t *data, const int testnum)
{
igt_fixture {
+ bool found = false;
+
data->flags = tests[testnum].flags;
- data->output = igt_get_single_output_for_pipe(&data->display,
- data->pipe);
- igt_require(data->output);
- igt_output_set_pipe(data->output, data->pipe);
+ for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
+ igt_display_reset(&data->display);
+
+ igt_output_set_pipe(data->output, data->pipe);
+ if (i915_pipe_output_combo_valid(&data->display)) {
+ found = true;
+ break;
+ }
+
+ }
+ igt_require_f(found, "No valid pipe/output combo found.\n");
}
for (int i = 0; i < ARRAY_SIZE(ccs_modifiers); i++) {
@@ -611,7 +620,6 @@ static void test_output(data_t *data, const int testnum)
igt_subtest_f("pipe-%s-%s-%s", kmstest_pipe_name(data->pipe),
tests[testnum].testname, ccs_modifiers[i].str) {
int valid_tests = 0;
- igt_require(data->output);
if (data->flags == TEST_RANDOM)
igt_info("Testing with seed %d\n", data->seed);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 41/52] tests/i915/kms_cdclk: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (40 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 40/52] tests/i915/kms_ccs: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 42/52] tests/i915/kms_draw_crc: " Bhanuprakash Modem
` (13 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
As many 2x tests are currently running on Pipe-A & B only, those
tests will always SKIP if there is any 8K supported panel in the
config. Instead of Skipping the test, add some intelligence to
the subtest to identify the valid pipe/output combo to execute
the subtest.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_cdclk.c | 93 +++++++++++++++++++++++-------------------
1 file changed, 51 insertions(+), 42 deletions(-)
diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
index 991a7c50..ce945623 100644
--- a/tests/i915/kms_cdclk.c
+++ b/tests/i915/kms_cdclk.c
@@ -243,20 +243,17 @@ static void test_mode_transition_on_all_outputs(data_t *data)
int debugfs_fd = data->debugfs_fd;
drmModeModeInfo *mode, *mode_hi, *mode_lo;
igt_output_t *output;
- int valid_outputs = 0;
int cdclk_ref, cdclk_new;
uint16_t width = 0, height = 0;
struct igt_fb fb;
igt_pipe_t *pipe;
igt_plane_t *plane;
- int i = 0, j = 0;
+ enum pipe p, active_pipes[IGT_MAX_PIPES];
+ int i = 0, active_pipe_count = 0;
do_cleanup_display(display);
igt_display_reset(display);
- for_each_connected_output(&data->display, output)
- valid_outputs++;
-
for_each_connected_output(display, output) {
mode = igt_output_get_mode(output);
igt_assert(mode);
@@ -269,52 +266,59 @@ static void test_mode_transition_on_all_outputs(data_t *data)
igt_create_pattern_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR, &fb);
- i = 0;
+
for_each_connected_output(display, output) {
- pipe = &display->pipes[i];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ for_each_pipe(display, p) {
+ mode = NULL;
- mode = NULL;
+ igt_output_set_pipe(output, p);
+ mode = igt_output_get_mode(output);
+ igt_assert(mode);
- igt_output_set_pipe(output, i);
- mode = igt_output_get_mode(output);
- igt_assert(mode);
+ mode_hi = get_highres_mode(output);
+ igt_require(mode_hi != NULL);
+
+ igt_output_override_mode(output, mode_hi);
+ if (!i915_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
- mode_lo = get_lowres_mode(output);
+ active_pipes[active_pipe_count++] = p;
+ pipe = &display->pipes[p];
+ plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(plane, &fb);
+ igt_fb_set_size(&fb, plane, mode_hi->hdisplay, mode_hi->vdisplay);
+ igt_plane_set_size(plane, mode_hi->hdisplay, mode_hi->vdisplay);
- igt_output_override_mode(output, mode_lo);
- igt_plane_set_fb(plane, &fb);
- igt_fb_set_size(&fb, plane, mode_lo->hdisplay, mode_lo->vdisplay);
- igt_plane_set_size(plane, mode_lo->hdisplay, mode_lo->vdisplay);
- i++;
+ break;
+ }
}
igt_display_commit2(display, COMMIT_ATOMIC);
- cdclk_ref = get_current_cdclk_freq(debugfs_fd);
+ cdclk_new = get_current_cdclk_freq(debugfs_fd);
- j = 0;
for_each_connected_output(display, output) {
- pipe = &display->pipes[j];
- plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ for (i = 0; i < active_pipe_count; i++) {
+ pipe = &display->pipes[active_pipes[i]];
+ plane = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
- mode = NULL;
+ mode = NULL;
+ igt_output_set_pipe(output, i);
+ mode = igt_output_get_mode(output);
+ igt_assert(mode);
- igt_output_set_pipe(output, j);
- mode = igt_output_get_mode(output);
- igt_assert(mode);
-
- mode_hi = get_highres_mode(output);
- igt_require(mode_hi != NULL);
+ mode_lo = get_lowres_mode(output);
- igt_output_override_mode(output, mode_hi);
- igt_plane_set_fb(plane, &fb);
- igt_fb_set_size(&fb, plane, mode_hi->hdisplay, mode_hi->vdisplay);
- igt_plane_set_size(plane, mode_hi->hdisplay, mode_hi->vdisplay);
- j++;
+ igt_output_override_mode(output, mode_lo);
+ igt_plane_set_fb(plane, &fb);
+ igt_fb_set_size(&fb, plane, mode_lo->hdisplay, mode_lo->vdisplay);
+ igt_plane_set_size(plane, mode_lo->hdisplay, mode_lo->vdisplay);
+ }
}
igt_display_commit2(display, COMMIT_ATOMIC);
- cdclk_new = get_current_cdclk_freq(debugfs_fd);
+ cdclk_ref = get_current_cdclk_freq(debugfs_fd);
igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
/* cdclk should bump */
@@ -332,13 +336,18 @@ static void run_cdclk_test(data_t *data, uint32_t flags)
enum pipe pipe;
for_each_pipe_with_valid_output(display, pipe, output) {
- igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
- if (igt_pipe_connector_valid(pipe, output)) {
- if (flags & TEST_PLANESCALING)
- test_plane_scaling(data, pipe, output);
- if (flags & TEST_MODETRANSITION)
- test_mode_transition(data, pipe, output);
- }
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
+ if (flags & TEST_PLANESCALING)
+ test_plane_scaling(data, pipe, output);
+ if (flags & TEST_MODETRANSITION)
+ test_mode_transition(data, pipe, output);
+ }
}
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 42/52] tests/i915/kms_draw_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (41 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 41/52] tests/i915/kms_cdclk: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 43/52] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
` (12 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_draw_crc.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
index c2ac4721..01c3808c 100644
--- a/tests/i915/kms_draw_crc.c
+++ b/tests/i915/kms_draw_crc.c
@@ -59,16 +59,14 @@ static void find_modeset_params(void)
{
enum pipe pipe;
- igt_display_reset(&display);
- igt_display_commit(&display);
-
for_each_pipe_with_valid_output(&display, pipe, output) {
- igt_output_set_pipe(output, pipe);
+ igt_display_reset(&display);
- mode = igt_output_get_mode(output);
- if (!mode)
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&display))
continue;
+ mode = igt_output_get_mode(output);
pipe_crc = igt_pipe_crc_new(drm_fd, pipe, IGT_PIPE_CRC_SOURCE_AUTO);
/*Only one pipe/output is enough*/
break;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 43/52] tests/i915/kms_fence_pin_leak: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (42 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 42/52] tests/i915/kms_draw_crc: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 44/52] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
` (11 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_fence_pin_leak.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/i915/kms_fence_pin_leak.c b/tests/i915/kms_fence_pin_leak.c
index 1972a699..63657a74 100644
--- a/tests/i915/kms_fence_pin_leak.c
+++ b/tests/i915/kms_fence_pin_leak.c
@@ -124,6 +124,9 @@ static void run_single_test(data_t *data, enum pipe pipe, igt_output_t *output)
struct igt_fb fb[2];
int i;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
igt_output_set_pipe(output, pipe);
mode = igt_output_get_mode(output);
@@ -196,6 +199,12 @@ static void run_test(data_t *data)
enum pipe p;
for_each_pipe_with_valid_output(display, p, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, p);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
run_single_test(data, p, output);
return; /* one time ought to be enough */
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 44/52] tests/i915/kms_flip_scaled_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (43 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 43/52] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
` (10 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_flip_scaled_crc.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c
index 10465ca7..1b497dcc 100644
--- a/tests/i915/kms_flip_scaled_crc.c
+++ b/tests/i915/kms_flip_scaled_crc.c
@@ -648,8 +648,13 @@ igt_main
for_each_pipe(&data.display, pipe) {
bool found = false;
for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ igt_display_reset(&data.display);
+
modetoset = find_mode(&data, output);
- if (modetoset) {
+ igt_output_set_pipe(output, pipe);
+ igt_output_override_mode(output, modetoset);
+
+ if (modetoset && i915_pipe_output_combo_valid(&data.display)) {
found = true;
igt_dynamic_f("pipe-%s-valid-mode", kmstest_pipe_name(pipe))
run_tests(&data, index, pipe, output, modetoset);
@@ -658,6 +663,12 @@ igt_main
}
if (!found) {
for_each_valid_output_on_pipe(&data.display, pipe, output) {
+ igt_display_reset(&data.display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
igt_dynamic_f("pipe-%s-default-mode", kmstest_pipe_name(pipe))
run_tests(&data, index, pipe, output, modetoset);
}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (44 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 44/52] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 46/52] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
` (9 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_flip_tiling.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c
index 1183feb6..2e2b9511 100644
--- a/tests/i915/kms_flip_tiling.c
+++ b/tests/i915/kms_flip_tiling.c
@@ -79,6 +79,9 @@ test_flip_tiling(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t mo
igt_crc_t reference_crc, crc;
int fb_id, ret;
+ igt_info("Using (pipe %s + %s) to run the subtest.\n",
+ kmstest_pipe_name(pipe), igt_output_name(output));
+
memcpy(&data->old_fb, &data->fb, sizeof(data->fb));
mode = igt_output_get_mode(output);
@@ -195,8 +198,12 @@ igt_main
for_each_pipe_with_valid_output(&data.display, pipe, output) {
igt_plane_t *plane;
+ igt_display_reset(&data.display);
pipe_crc_free(&data);
+
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 46/52] tests/i915/kms_frontbuffer_tracking: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (45 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 47/52] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
` (8 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
As many 2x tests are currently running on Pipe-A & B only, those
tests will always SKIP if there is any 8K supported panel in the
config. Instead of Skipping the test, add some intelligence to
the subtest to identify the valid pipe/output combo to execute
the subtest.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/i915/kms_frontbuffer_tracking.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
index 5b47999e..650e14a7 100644
--- a/tests/i915/kms_frontbuffer_tracking.c
+++ b/tests/i915/kms_frontbuffer_tracking.c
@@ -403,15 +403,23 @@ static bool find_connector(bool edp_only, bool pipe_a,
if (pipe_a && pipe != PIPE_A)
continue;
- if (output == forbidden_output || pipe == forbidden_pipe)
+ if (output == forbidden_output || pipe == forbidden_pipe) {
+ igt_output_set_pipe(output, pipe);
+ igt_output_override_mode(output, connector_get_mode(output));
+
continue;
+ }
if (c->connector_type == DRM_MODE_CONNECTOR_eDP && opt.no_edp)
continue;
- *ret_output = output;
- *ret_pipe = pipe;
- return true;
+ igt_output_set_pipe(output, pipe);
+ igt_output_override_mode(output, connector_get_mode(output));
+ if (i915_pipe_output_combo_valid(&drm.display)) {
+ *ret_output = output;
+ *ret_pipe = pipe;
+ return true;
+ }
}
return false;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 47/52] tests/i915/kms_mmap_write_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (46 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 46/52] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 48/52] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
` (7 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/i915/kms_mmap_write_crc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
index 96ddac11..4f7a86bf 100644
--- a/tests/i915/kms_mmap_write_crc.c
+++ b/tests/i915/kms_mmap_write_crc.c
@@ -277,6 +277,12 @@ igt_main_args("n", NULL, NULL, opt_handler, NULL)
igt_subtest_with_dynamic("main") {
for_each_pipe_with_valid_output(&data.display, pipe, output) {
+ igt_display_reset(&data.display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(&data.display))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
igt_output_name(output)) {
data.output = output;
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 48/52] tests/i915/kms_psr2_sf: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (47 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 47/52] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 49/52] tests/i915/kms_psr2_su: " Bhanuprakash Modem
` (6 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr2_sf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index cfde6cfc..2b2f6166 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -115,7 +115,11 @@ static void setup_output(data_t *data)
if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
+ igt_display_reset(display);
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
data->output = output;
data->mode = igt_output_get_mode(output);
@@ -127,6 +131,9 @@ static void display_init(data_t *data)
{
igt_display_require(&data->display, data->drm_fd);
setup_output(data);
+
+ igt_require_f(data->output, "No available output found\n");
+ igt_require_f(data->mode, "No available mode found on %s\n", data->output->name);
}
static void display_fini(data_t *data)
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 49/52] tests/i915/kms_psr2_su: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (48 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 48/52] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 50/52] tests/i915/kms_psr: " Bhanuprakash Modem
` (5 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr2_su.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
index 84dc30c3..3e0a78f2 100644
--- a/tests/i915/kms_psr2_su.c
+++ b/tests/i915/kms_psr2_su.c
@@ -104,7 +104,11 @@ static void setup_output(data_t *data)
if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
+ igt_display_reset(display);
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
data->output = output;
data->mode = igt_output_get_mode(output);
@@ -116,6 +120,9 @@ static void display_init(data_t *data)
{
igt_display_require(&data->display, data->drm_fd);
setup_output(data);
+
+ igt_require_f(data->output, "No available output found\n");
+ igt_require_f(data->mode, "No available mode found on %s\n", data->output->name);
}
static void display_fini(data_t *data)
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 50/52] tests/i915/kms_psr: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (49 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 49/52] tests/i915/kms_psr2_su: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 51/52] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
` (4 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
index 59f38e20..c9290234 100644
--- a/tests/i915/kms_psr.c
+++ b/tests/i915/kms_psr.c
@@ -102,7 +102,11 @@ static void setup_output(data_t *data)
if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
+ igt_display_reset(display);
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
+
data->crtc_id = output->config.crtc->crtc_id;
data->output = output;
data->mode = igt_output_get_mode(output);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 51/52] tests/i915/kms_psr_stress_test: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (50 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 50/52] tests/i915/kms_psr: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 52/52] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
` (3 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr_stress_test.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
index daac41d4..26e222a2 100644
--- a/tests/i915/kms_psr_stress_test.c
+++ b/tests/i915/kms_psr_stress_test.c
@@ -72,7 +72,13 @@ static void setup_output(data_t *data)
if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
continue;
+ igt_display_reset(display);
igt_output_set_pipe(output, pipe);
+ if (!i915_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
+
data->output = output;
data->mode = igt_output_get_mode(output);
@@ -374,4 +380,4 @@ igt_main
close(data.debugfs_fd);
close(data.drm_fd);
}
-}
\ No newline at end of file
+}
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 52/52] tests/i915/kms_pwrite_crc: Add support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (51 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 51/52] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
@ 2022-11-15 16:59 ` Bhanuprakash Modem
2022-11-15 17:06 ` [igt-dev] [i-g-t v5 00/52] Add IGT " Bhanuprakash Modem
` (2 subsequent siblings)
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 16:59 UTC (permalink / raw)
To: igt-dev
This patch will add a check to Skip the subtest if a selected pipe/output
combo won't support Bigjoiner or 8K mode.
Example:
* Pipe-D wont support a mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Use updated helper name
V3: - Fix the usage of pipe & output
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/i915/kms_pwrite_crc.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c
index c84a184d..3278d876 100644
--- a/tests/i915/kms_pwrite_crc.c
+++ b/tests/i915/kms_pwrite_crc.c
@@ -110,6 +110,7 @@ static void prepare_crtc(data_t *data)
igt_output_t *output = data->output;
drmModeModeInfo *mode;
+ igt_display_reset(display);
/* select the pipe we want to use */
igt_output_set_pipe(output, data->pipe);
@@ -156,12 +157,13 @@ static void cleanup_crtc(data_t *data)
static void run_test(data_t *data)
{
igt_display_t *display = &data->display;
- igt_output_t *output;
- enum pipe pipe;
- for_each_pipe_with_valid_output(display, pipe, output) {
- data->output = output;
- data->pipe = pipe;
+ for_each_pipe_with_valid_output(display, data->pipe, data->output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(data->output, data->pipe);
+ if (!i915_pipe_output_combo_valid(display))
+ continue;
prepare_crtc(data);
test(data);
--
2.38.0
^ permalink raw reply related [flat|nested] 61+ messages in thread* [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (52 preceding siblings ...)
2022-11-15 16:59 ` [igt-dev] [i-g-t v5 52/52] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
@ 2022-11-15 17:06 ` Bhanuprakash Modem
2022-11-15 20:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: Add Negative tests to validate VRR (rev2) Patchwork
2022-11-16 2:59 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
55 siblings, 0 replies; 61+ messages in thread
From: Bhanuprakash Modem @ 2022-11-15 17:06 UTC (permalink / raw)
To: igt-dev
Add IGT support for bigjoiner:
* Pipe-D won't support mode > 5K
* To use 8K mode on a pipe then consecutive pipe must be available & free.
V2: - Rebase
V3: - Optimizations in helper
V4, V5: - Rebase
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Bhanuprakash Modem (52):
lib/igt_kms: Add a helper for valid pipe/output constraint
lib/igt_kms: Bigjoiner check in max_bpc constraint
tests/kms_async_flips: Add support for Bigjoiner
tests/kms_atomic: Add support for Bigjoiner
tests/kms_atomic_interruptible: Add support for Bigjoiner
tests/kms_atomic_transition: Add support for Bigjoiner
tests/kms_color_helper: Helper to check Bigjoiner constraint
tests/kms_color: Add support for Bigjoiner
tests/chamelium/kms_color_chamelium: Add support for Bigjoiner
tests/kms_concurrent: Add support for Bigjoiner
tests/kms_content_protection: Add support for Bigjoiner
tests/kms_cursor_crc: Add support for Bigjoiner
tests/kms_cursor_edge_walk: Add support for Bigjoiner
tests/kms_cursor_legacy: Add support for Bigjoiner
tests/kms_display_modes: Add support for Bigjoiner
tests/kms_dp_tiled_display: Add support for Bigjoiner
tests/kms_flip_event_leak: Add support for Bigjoiner
tests/kms_invalid_mode: Add support for Bigjoiner
tests/kms_lease: Add support for Bigjoiner
tests/kms_multipipe_modeset: Find the suitable mode instead of using
default
tests/kms_pipe_crc_basic: Add support for Bigjoiner
tests/kms_plane: Add support for Bigjoiner
tests/kms_plane_alpha_blend: Add support for Bigjoiner
tests/kms_plane_cursor: Add support for Bigjoiner
tests/kms_plane_lowres: Add support for Bigjoiner
tests/kms_plane_multiple: Add support for Bigjoiner
tests/kms_plane_scaling: Add support for Bigjoiner
tests/kms_prime: Add support for Bigjoiner
tests/kms_properties: Add support for Bigjoiner
tests/kms_rmfb: Add support for Bigjoiner
tests/kms_rotation_crc: Add support for Bigjoiner
tests/kms_scaling_modes: Add support for Bigjoiner
tests/kms_sequence: Add support for Bigjoiner
tests/kms_universal_plane: Add support for Bigjoiner
tests/kms_vblank: Add support for Bigjoiner
tests/kms_vrr: Add support for Bigjoiner
tests/i915/kms_big_fb: Add support for Bigjoiner
tests/i915/kms_big_joiner: Negative tests for Bigjoiner
tests/i915/kms_busy: Add support for Bigjoiner
tests/i915/kms_ccs: Add support for Bigjoiner
tests/i915/kms_cdclk: Add support for Bigjoiner
tests/i915/kms_draw_crc: Add support for Bigjoiner
tests/i915/kms_fence_pin_leak: Add support for Bigjoiner
tests/i915/kms_flip_scaled_crc: Add support for Bigjoiner
tests/i915/kms_flip_tiling: Add support for Bigjoiner
tests/i915/kms_frontbuffer_tracking: Add support for Bigjoiner
tests/i915/kms_mmap_write_crc: Add support for Bigjoiner
tests/i915/kms_psr2_sf: Add support for Bigjoiner
tests/i915/kms_psr2_su: Add support for Bigjoiner
tests/i915/kms_psr: Add support for Bigjoiner
tests/i915/kms_psr_stress_test: Add support for Bigjoiner
tests/i915/kms_pwrite_crc: Add support for Bigjoiner
lib/igt_kms.c | 54 ++++++-
lib/igt_kms.h | 1 +
tests/chamelium/kms_color_chamelium.c | 9 ++
tests/i915/kms_big_fb.c | 13 ++
tests/i915/kms_big_joiner.c | 187 ++++++++++------------
tests/i915/kms_busy.c | 106 ++++++++-----
tests/i915/kms_ccs.c | 18 ++-
tests/i915/kms_cdclk.c | 93 ++++++-----
tests/i915/kms_draw_crc.c | 10 +-
tests/i915/kms_fence_pin_leak.c | 9 ++
tests/i915/kms_flip_scaled_crc.c | 13 +-
tests/i915/kms_flip_tiling.c | 7 +
tests/i915/kms_frontbuffer_tracking.c | 16 +-
tests/i915/kms_mmap_write_crc.c | 6 +
tests/i915/kms_psr.c | 4 +
tests/i915/kms_psr2_sf.c | 7 +
tests/i915/kms_psr2_su.c | 7 +
tests/i915/kms_psr_stress_test.c | 8 +-
tests/i915/kms_pwrite_crc.c | 12 +-
tests/kms_async_flips.c | 24 ++-
tests/kms_atomic.c | 32 +++-
tests/kms_atomic_interruptible.c | 40 +++++
tests/kms_atomic_transition.c | 50 +++++-
tests/kms_color.c | 9 +-
tests/kms_color_helper.c | 12 ++
tests/kms_color_helper.h | 1 +
tests/kms_concurrent.c | 10 +-
tests/kms_content_protection.c | 15 ++
tests/kms_cursor_crc.c | 33 ++++
tests/kms_cursor_edge_walk.c | 6 +
tests/kms_cursor_legacy.c | 202 +++++++++++++++---------
tests/kms_display_modes.c | 104 +++++++-----
tests/kms_dp_tiled_display.c | 1 +
tests/kms_flip_event_leak.c | 11 +-
tests/kms_invalid_mode.c | 6 +
tests/kms_lease.c | 8 +-
tests/kms_multipipe_modeset.c | 9 ++
tests/kms_pipe_crc_basic.c | 24 +++
tests/kms_plane.c | 30 ++--
tests/kms_plane_alpha_blend.c | 9 +-
tests/kms_plane_cursor.c | 6 +
tests/kms_plane_lowres.c | 3 +
tests/kms_plane_multiple.c | 15 +-
tests/kms_plane_scaling.c | 218 +++++++++++++++++---------
tests/kms_prime.c | 11 +-
tests/kms_properties.c | 18 +++
tests/kms_rmfb.c | 10 +-
tests/kms_rotation_crc.c | 25 ++-
tests/kms_scaling_modes.c | 8 +-
tests/kms_sequence.c | 6 +
tests/kms_universal_plane.c | 94 +++++++++--
tests/kms_vblank.c | 54 ++++++-
tests/kms_vrr.c | 6 +
53 files changed, 1219 insertions(+), 471 deletions(-)
--
2.38.0
^ permalink raw reply [flat|nested] 61+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: Add Negative tests to validate VRR (rev2)
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (53 preceding siblings ...)
2022-11-15 17:06 ` [igt-dev] [i-g-t v5 00/52] Add IGT " Bhanuprakash Modem
@ 2022-11-15 20:16 ` Patchwork
2022-11-16 2:59 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
55 siblings, 0 replies; 61+ messages in thread
From: Patchwork @ 2022-11-15 20:16 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8790 bytes --]
== Series Details ==
Series: tests/kms_vrr: Add Negative tests to validate VRR (rev2)
URL : https://patchwork.freedesktop.org/series/110860/
State : success
== Summary ==
CI Bug Log - changes from IGT_7059 -> IGTPW_8107
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
Participating hosts (37 -> 40)
------------------------------
Additional (3): bat-kbl-2 bat-dg1-6 fi-pnv-d510
Known issues
------------
Here are the changes found in IGTPW_8107 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: NOTRUN -> [FAIL][1] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_mmap@basic:
- bat-dg1-6: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][3] ([i915#4079]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#4077]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][5] ([i915#1155])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: NOTRUN -> [SKIP][6] ([i915#6621])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-bxt-dsi: [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
- fi-apl-guc: [PASS][9] -> [DMESG-FAIL][10] ([i915#5334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [PASS][11] -> [INCOMPLETE][12] ([i915#7308] / [i915#7348])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/bat-adlp-4/igt@i915_selftest@live@migrate.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4215])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#4212]) +7 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_chamelium@hdmi-crc-fast:
- bat-dg1-6: NOTRUN -> [SKIP][15] ([fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-6: NOTRUN -> [SKIP][16] ([i915#4103] / [i915#4213])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-6: NOTRUN -> [SKIP][17] ([fdo#109285])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][18] ([fdo#109271]) +43 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#1072] / [i915#4078]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-6: NOTRUN -> [SKIP][20] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][21] ([i915#3708] / [i915#4077]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-dg1-6: NOTRUN -> [SKIP][22] ([i915#3708]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][23] ([i915#3708] / [i915#4873])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-dg1-6/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][24] ([i915#4312])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-adlp-4/igt@runner@aborted.html
#### Possible fixes ####
* igt@fbdev@read:
- {bat-rpls-2}: [SKIP][25] ([i915#2582]) -> [PASS][26] +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/bat-rpls-2/igt@fbdev@read.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-rpls-2/igt@fbdev@read.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][27] ([i915#2867]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7355]: https://gitlab.freedesktop.org/drm/intel/issues/7355
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7059 -> IGTPW_8107
CI-20190529: 20190529
CI_DRM_12382: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8107: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
IGT_7059: 89c5c56dfde602d54eefa301e9887eff8bcda0e8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
[-- Attachment #2: Type: text/html, Size: 9959 bytes --]
^ permalink raw reply [flat|nested] 61+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_vrr: Add Negative tests to validate VRR (rev2)
2022-11-15 16:58 [igt-dev] [i-g-t v5 00/52] Add IGT support for Bigjoiner Bhanuprakash Modem
` (54 preceding siblings ...)
2022-11-15 20:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vrr: Add Negative tests to validate VRR (rev2) Patchwork
@ 2022-11-16 2:59 ` Patchwork
55 siblings, 0 replies; 61+ messages in thread
From: Patchwork @ 2022-11-16 2:59 UTC (permalink / raw)
To: Bhanuprakash Modem; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 52100 bytes --]
== Series Details ==
Series: tests/kms_vrr: Add Negative tests to validate VRR (rev2)
URL : https://patchwork.freedesktop.org/series/110860/
State : failure
== Summary ==
CI Bug Log - changes from IGT_7059_full -> IGTPW_8107_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8107_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8107_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8107_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb5/igt@gem_ctx_isolation@preservation-s3@vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb5/igt@gem_ctx_isolation@preservation-s3@vcs1.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][3] +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs.html
#### Warnings ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs:
- shard-iclb: [SKIP][4] ([fdo#109278]) -> [SKIP][5] +70 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: [SKIP][6] ([fdo#109274]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb8/igt@kms_display_modes@extended-mode-basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb6/igt@kms_display_modes@extended-mode-basic.html
- shard-iclb: [SKIP][8] ([fdo#109274]) -> [SKIP][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb6/igt@kms_display_modes@extended-mode-basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb5/igt@kms_display_modes@extended-mode-basic.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- {shard-rkl}: NOTRUN -> [SKIP][10] +5 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
- {shard-rkl}: [SKIP][11] ([i915#4098]) -> [SKIP][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-5/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][13] ([i915#1845] / [i915#4098]) -> [SKIP][14] +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-3/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@forked-bo@pipe-c:
- {shard-rkl}: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-5/igt@kms_cursor_legacy@forked-bo@pipe-c.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-5/igt@kms_cursor_legacy@forked-bo@pipe-c.html
* igt@kms_display_modes@extended-mode-basic:
- {shard-dg1}: [SKIP][17] ([fdo#109274]) -> [SKIP][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-dg1-17/igt@kms_display_modes@extended-mode-basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-dg1-13/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-dg1}: [PASS][19] -> [FAIL][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-dg1-12/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-dg1-15/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
New tests
---------
New tests have been introduced between IGT_7059_full and IGTPW_8107_full:
### New IGT tests (12) ###
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-c-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-2-pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-2-pipe-c-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-1-pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-1-pipe-c-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-2-pipe-a-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-b-hdmi-a-2-pipe-c-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-1-pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-1-pipe-b-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-2-pipe-a-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_display_modes@extended-mode-basic@pipe-c-hdmi-a-2-pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8107_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-2x:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#1839])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@feature_discovery@display-2x.html
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][22] -> [SKIP][23] ([i915#658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb2/igt@feature_discovery@psr2.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb5/igt@feature_discovery@psr2.html
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#6335])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb1/igt@gem_create@create-ext-cpu-access-sanity-check.html
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#6335])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@gem_create@create-ext-cpu-access-sanity-check.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#1099]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][27] ([i915#3354])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][28] -> [FAIL][29] ([i915#2842])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][30] -> [FAIL][31] ([i915#2842])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2190])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl1/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#4613]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#4613]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl3/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#4613]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb8/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
- shard-glk: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#4613]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk3/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#4270])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@gem_pxp@reject-modify-context-protection-off-1.html
* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][38] ([i915#768])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@gem_render_copy@linear-to-vebox-yf-tiled.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109312])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb8/igt@gem_softpin@evict-snoop-interruptible.html
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109312])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109290])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@gem_userptr_blits@coherency-sync.html
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#110542])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb6/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#3297]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb5/igt@gem_userptr_blits@unsync-overlap.html
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3297])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb8/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#109289])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@gen7_exec_parse@basic-allowed.html
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109289]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@gen7_exec_parse@basic-allowed.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][47] -> [DMESG-WARN][48] ([i915#5566] / [i915#716])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl3/igt@gen9_exec_parse@allowed-single.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_module_load@resize-bar:
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#6412])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@i915_module_load@resize-bar.html
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#6590])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@i915_pm_freq_mult@media-freq@gt0.html
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#6590])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@i915_pm_freq_mult@media-freq@gt0.html
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3826])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb3/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
- shard-iclb: NOTRUN -> [SKIP][53] ([i915#3826])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
* igt@kms_atomic@atomic_plane_damage:
- shard-iclb: NOTRUN -> [SKIP][54] ([i915#4765])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#5286])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb1/igt@kms_big_fb@4-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-iclb: NOTRUN -> [SKIP][56] ([i915#5286])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#111614]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb6/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271]) +84 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk1/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#110725] / [fdo#111614]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@kms_big_fb@y-tiled-8bpp-rotate-90.html
* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][60] ([i915#2705])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3689] / [i915#3886]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#3886]) +6 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#3886]) +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk7/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#3886]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#6095]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#3689])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278]) +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium@dp-crc-single:
- shard-snb: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +4 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-snb2/igt@kms_chamelium@dp-crc-single.html
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl3/igt@kms_chamelium@hdmi-audio.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk7/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-fast:
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109284] / [fdo#111827]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb1/igt@kms_chamelium@vga-hpd-fast.html
* igt@kms_color_chamelium@ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109284] / [fdo#111827]) +4 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_color_chamelium@ctm-0-75.html
* igt@kms_content_protection@atomic-dpms:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#7118])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@atomic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][74] ([i915#7173])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl2/igt@kms_content_protection@atomic@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109279] / [i915#3359])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@kms_cursor_crc@cursor-offscreen-512x170.html
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109279] / [i915#3359])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271]) +99 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#3359])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_cursor_crc@cursor-sliding-512x512.html
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#3359])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@cursorb-vs-flipa@atomic-transitions-varying-size:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#109274] / [fdo#111825]) +6 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_cursor_legacy@cursorb-vs-flipa@atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@cursorb-vs-flipa@legacy:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109274]) +17 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@kms_cursor_legacy@cursorb-vs-flipa@legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][82] -> [FAIL][83] ([i915#2346])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
- shard-iclb: [PASS][84] -> [FAIL][85] ([i915#2346])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#3528])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb8/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#3528])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#3840])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [FAIL][89] ([i915#4767])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-tglb: NOTRUN -> [FAIL][90] ([i915#2411] / [i915#4767])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-glk: NOTRUN -> [FAIL][91] ([i915#4767])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk3/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-iclb: NOTRUN -> [FAIL][92] ([i915#4767])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][93] -> [FAIL][94] ([i915#79]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][96] -> [DMESG-WARN][97] ([i915#180]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@b-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2587] / [i915#2672])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#2672]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][100] ([i915#2672] / [i915#3555]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109280] / [fdo#111825]) +8 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#6497]) +3 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109280]) +14 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][104] ([i915#4573]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl2/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html
* igt@kms_plane_multiple@tiling-4:
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#3555]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_plane_multiple@tiling-4.html
* igt@kms_prime@d3hot:
- shard-iclb: NOTRUN -> [SKIP][106] ([i915#6524])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_prime@d3hot.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-tglb: NOTRUN -> [SKIP][107] ([i915#2920])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#658])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk8/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
- shard-iclb: NOTRUN -> [SKIP][109] ([i915#658])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_su@page_flip-p010:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#658]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][111] ([fdo#109642] / [fdo#111068] / [i915#658])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][112] ([i915#132] / [i915#3467])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][113] -> [SKIP][114] ([fdo#109441]) +3 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109441]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][116] -> [SKIP][117] ([i915#5519])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb8/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-iclb: NOTRUN -> [SKIP][118] ([i915#5289])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@kms_rotation_crc@primary-4-tiled-reflect-x-0.html
* igt@kms_tv_load_detect@load-detect:
- shard-snb: NOTRUN -> [SKIP][119] ([fdo#109271]) +143 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-snb7/igt@kms_tv_load_detect@load-detect.html
* igt@kms_writeback@writeback-check-output:
- shard-iclb: NOTRUN -> [SKIP][120] ([i915#2437])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_writeback@writeback-check-output.html
* igt@sysfs_clients@recycle-many:
- shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl1/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@sema-10:
- shard-glk: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk8/igt@sysfs_clients@sema-10.html
- shard-iclb: NOTRUN -> [SKIP][123] ([i915#2994])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb6/igt@sysfs_clients@sema-10.html
- shard-tglb: NOTRUN -> [SKIP][124] ([i915#2994])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb2/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][125] ([fdo#103375]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-3/igt@gem_eio@in-flight-suspend.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-5/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_balancer@full-late-pulse:
- {shard-dg1}: [FAIL][127] ([i915#6032]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-dg1-15/igt@gem_exec_balancer@full-late-pulse.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-dg1-15/igt@gem_exec_balancer@full-late-pulse.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][129] ([i915#2842]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-glk2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][131] ([i915#2842]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb5/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_reloc@basic-gtt-read-active:
- {shard-rkl}: [SKIP][133] ([i915#3281]) -> [PASS][134] +3 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read-active.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-active.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][135] ([i915#3282]) -> [PASS][136] +3 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-4/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [FAIL][137] ([i915#4171]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb8/igt@gem_softpin@evict-single-offset.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@gem_softpin@evict-single-offset.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][139] ([i915#180] / [i915#1982]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][141] ([fdo#109271]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][143] ([i915#3591]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: [SKIP][145] ([fdo#109308]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-3/igt@i915_pm_rpm@system-suspend-modeset.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][147] ([i915#5334]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@perf@engine_cs:
- shard-snb: [SKIP][149] ([fdo#109271]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-snb7/igt@i915_selftest@perf@engine_cs.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-snb2/igt@i915_selftest@perf@engine_cs.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- {shard-rkl}: [SKIP][151] ([i915#1845] / [i915#4098]) -> [PASS][152] +9 similar issues
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][153] ([i915#79]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-tglb: [DMESG-WARN][155] ([i915#2411] / [i915#2867]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb7/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- {shard-rkl}: [SKIP][157] ([i915#1849] / [i915#4098]) -> [PASS][158] +6 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][159] ([i915#5235]) -> [PASS][160] +2 similar issues
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_properties@crtc-properties-atomic:
- {shard-rkl}: [SKIP][161] ([i915#1849]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-rkl-4/igt@kms_properties@crtc-properties-atomic.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-rkl-6/igt@kms_properties@crtc-properties-atomic.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][163] ([fdo#109441]) -> [PASS][164]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][165] ([i915#5519]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][167] ([i915#180]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-tglb: [WARN][169] ([i915#2658]) -> [INCOMPLETE][170] ([i915#7248]) +1 similar issue
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb7/igt@gem_pread@exhaustion.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb5/igt@gem_pread@exhaustion.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- shard-iclb: [FAIL][171] ([i915#2684]) -> [WARN][172] ([i915#2684])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: [SKIP][173] ([fdo#109278] / [i915#3886]) -> [SKIP][174] ([i915#3886]) +48 similar issues
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_content_protection@mei_interface:
- shard-tglb: [SKIP][175] ([i915#7118]) -> [SKIP][176] ([fdo#109300])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-tglb1/igt@kms_content_protection@mei_interface.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-tglb3/igt@kms_content_protection@mei_interface.html
- shard-iclb: [SKIP][177] ([i915#7118]) -> [SKIP][178] ([fdo#109300])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb1/igt@kms_content_protection@mei_interface.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb7/igt@kms_content_protection@mei_interface.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][179] ([i915#658]) -> [SKIP][180] ([i915#2920])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7059/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4765]: https://gitlab.freedesktop.org/drm/intel/issues/4765
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7059 -> IGTPW_8107
CI-20190529: 20190529
CI_DRM_12382: cb74864693414b221b3601572e75449558126e8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8107: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
IGT_7059: 89c5c56dfde602d54eefa301e9887eff8bcda0e8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8107/index.html
[-- Attachment #2: Type: text/html, Size: 56990 bytes --]
^ permalink raw reply [flat|nested] 61+ messages in thread