* [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test
@ 2022-11-16 8:23 Anshuman Gupta
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Anshuman Gupta @ 2022-11-16 8:23 UTC (permalink / raw)
To: igt-dev; +Cc: badal.nilawar, rodrigo.vivi
Adding Cold Reset IGT support
v2:
- Address some review comments from Kamil and Badal
Anshuman Gupta (3):
lib/igt_pm: Refactor get firmware_node fd
test/device_reset: Refactor initiate_device_reset
tests/device_reset: Add cold reset IGT test
lib/igt_pm.c | 76 ++++++++++++++++++++----
lib/igt_pm.h | 1 +
tests/device_reset.c | 138 +++++++++++++++++++++++++++++++++++++++----
3 files changed, 191 insertions(+), 24 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
@ 2022-11-16 8:23 ` Anshuman Gupta
2022-11-23 12:55 ` Kamil Konieczny
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset Anshuman Gupta
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Anshuman Gupta @ 2022-11-16 8:23 UTC (permalink / raw)
To: igt-dev; +Cc: badal.nilawar, rodrigo.vivi
Created igt_pm_open_pci_firmware_node() to refactor
the retrieving the firmware_node fd code.
igt_pm_open_pci_firmware_node() will be used by other
firmware_node consumers.
While doing that fixed the leaked fd as well.
v2:
- return false instead of igt_require on no firmware_node_fd. [Kamil]
- use igt_assert() when failed to open 'real_power_state' on error
other then ENONET.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
lib/igt_pm.c | 36 +++++++++++++++++++++++++-----------
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 1e6e9ed3ff..4f0cfbdd10 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -863,6 +863,20 @@ bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output)
return strstr(buf, "LPSP: capable");
}
+static int igt_pm_open_pci_firmware_node(struct pci_device *pci_dev)
+{
+ char name[PATH_MAX];
+ int dir;
+
+ snprintf(name, PATH_MAX,
+ "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/firmware_node",
+ pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
+
+ dir = open(name, O_RDONLY);
+
+ return dir;
+}
+
/**
* igt_pm_acpi_d3cold_supported:
* @pci_dev: root port pci_dev.
@@ -873,23 +887,23 @@ bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output)
*/
bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev)
{
- char name[PATH_MAX];
- int dir, fd;
-
- snprintf(name, PATH_MAX,
- "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/firmware_node",
- pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
+ int firmware_node_fd, fd;
- dir = open(name, O_RDONLY);
- igt_require(dir > 0);
+ firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
+ if (firmware_node_fd < 0)
+ return false;
/* BIOS need to enable ACPI D3Cold Support.*/
- fd = openat(dir, "real_power_state", O_RDONLY);
- if (fd < 0 && errno == ENOENT)
+ fd = openat(firmware_node_fd, "real_power_state", O_RDONLY);
+ if (fd < 0 && errno == ENOENT) {
+ close(firmware_node_fd);
return false;
+ }
- igt_require(fd > 0);
+ igt_assert(errno > 0);
+ close(firmware_node_fd);
+ close(fd);
return true;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
@ 2022-11-16 8:23 ` Anshuman Gupta
2022-11-16 19:58 ` Rodrigo Vivi
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test Anshuman Gupta
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Anshuman Gupta @ 2022-11-16 8:23 UTC (permalink / raw)
To: igt-dev; +Cc: badal.nilawar, rodrigo.vivi
Added a reset type enum to support multiple types
of reset like WARM, COLD and FLR reset.
No functional change.
v2:
- Removed WARM_RESET enum as not used yet. [Badal]
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/device_reset.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/tests/device_reset.c b/tests/device_reset.c
index e60d4c7fde..0c477a02c0 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -19,6 +19,11 @@ IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
#define DEV_PATH_LEN 80
#define DEV_BUS_ADDR_LEN 13 /* addr has form 0000:00:00.0 */
+enum reset {
+ COLD_RESET,
+ FLR_RESET
+};
+
/**
* Helper structure containing file descriptors
* and bus address related to tested device
@@ -222,10 +227,13 @@ static void driver_bind(struct device_fds *dev)
}
/* Initiate device reset */
-static void initiate_device_reset(struct device_fds *dev)
+static void initiate_device_reset(struct device_fds *dev, enum reset type)
{
igt_debug("reset device\n");
- igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
+
+ if (type == FLR_RESET)
+ igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
+
}
static bool is_i915_wedged(int i915)
@@ -274,14 +282,14 @@ static void set_device_filter(const char* dev_path)
igt_assert_eq(igt_device_filter_add(filter), 1);
}
-static void unbind_reset_rebind(struct device_fds *dev)
+static void unbind_reset_rebind(struct device_fds *dev, enum reset type)
{
igt_debug("close the device\n");
close_if_opened(&dev->fds.dev);
driver_unbind(dev);
- initiate_device_reset(dev);
+ initiate_device_reset(dev, type);
driver_bind(dev);
}
@@ -306,13 +314,13 @@ igt_main
igt_describe("Unbinds driver from device, initiates reset"
" then rebinds driver to device");
igt_subtest("unbind-reset-rebind") {
- unbind_reset_rebind(&dev);
+ unbind_reset_rebind(&dev, FLR_RESET);
healthcheck(&dev);
}
igt_describe("Resets device with bound driver");
igt_subtest("reset-bound") {
- initiate_device_reset(&dev);
+ initiate_device_reset(&dev, FLR_RESET);
healthcheck(&dev);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset Anshuman Gupta
@ 2022-11-16 8:23 ` Anshuman Gupta
2022-11-17 9:43 ` Iddamsetty, Aravind
2022-11-17 10:31 ` Iddamsetty, Aravind
2022-11-16 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test (rev2) Patchwork
2022-11-16 18:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 2 replies; 11+ messages in thread
From: Anshuman Gupta @ 2022-11-16 8:23 UTC (permalink / raw)
To: igt-dev; +Cc: badal.nilawar, rodrigo.vivi
Add cold-reset IGT subtest, IGT subtest will use
/sys/bus/pci/slots/$SUN/power sysfs in order to
initiate a cold reset sequence. $SUN value will be
retrieved from PCIe device ACPI firmware node.
v2:
- %s/igt_require(fd > 0)/igt_assert(errno >0)
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
---
lib/igt_pm.c | 40 ++++++++++++++
lib/igt_pm.h | 1 +
tests/device_reset.c | 124 +++++++++++++++++++++++++++++++++++++++----
3 files changed, 155 insertions(+), 10 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 4f0cfbdd10..9b7ed4be64 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -877,6 +877,46 @@ static int igt_pm_open_pci_firmware_node(struct pci_device *pci_dev)
return dir;
}
+/**
+ * igt_pm_get_pcie_acpihp_slot:
+ * @pci_dev: pci bridge device.
+ * Get pci bridge acpi hotplug slot number, if bridge's ACPI firmware_node
+ * handle supports _SUN method.
+ *
+ * Returns:
+ * PCIe bridge Slot number.
+ * Returns -ENOENT number in case firmware_node/sun is not supported by the
+ * bridge.
+ */
+int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev)
+{
+ int firmware_node_fd, fd, n_read;
+ char sun[8];
+
+ firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
+
+ if (firmware_node_fd < 0 && errno == ENOENT)
+ return -ENOENT;
+
+ igt_require(firmware_node_fd > 0);
+
+ fd = openat(firmware_node_fd, "sun", O_RDONLY);
+ if (fd < 0 && errno == ENOENT) {
+ close(firmware_node_fd);
+ return -ENOENT;
+ }
+
+ igt_assert(errno > 0);
+
+ n_read = read(fd, sun, sizeof(sun));
+ igt_assert(n_read > 0);
+
+ close(firmware_node_fd);
+ close(fd);
+
+ return strtol(sun, NULL, 10);
+}
+
/**
* igt_pm_acpi_d3cold_supported:
* @pci_dev: root port pci_dev.
diff --git a/lib/igt_pm.h b/lib/igt_pm.h
index e81fceb897..f65b960c38 100644
--- a/lib/igt_pm.h
+++ b/lib/igt_pm.h
@@ -73,6 +73,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
bool igt_pm_dmc_loaded(int debugfs);
bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output);
+int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev);
bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev);
enum igt_acpi_d_state
igt_pm_get_acpi_real_d_state(struct pci_device *pci_dev);
diff --git a/tests/device_reset.c b/tests/device_reset.c
index 0c477a02c0..427ea0b09f 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -9,6 +9,7 @@
#include "i915/gem.h"
#include "igt.h"
+#include "igt_device.h"
#include "igt_device_scan.h"
#include "igt_sysfs.h"
#include "igt_kmod.h"
@@ -33,6 +34,7 @@ struct device_fds {
int dev;
int dev_dir;
int drv_dir;
+ int slot_dir; /* pci hotplug slots fd */
} fds;
char dev_bus_addr[DEV_BUS_ADDR_LEN];
bool snd_unload;
@@ -62,6 +64,45 @@ static int open_driver_sysfs_dir(int fd)
return __open_sysfs_dir(fd, "device/driver");
}
+static int open_slot_sysfs_dir(int fd)
+{
+ struct pci_device *pci_dev = NULL;
+ int slot_fd = -1, slot;
+ char slot_fd_path[PATH_MAX];
+
+ pci_dev = igt_device_get_pci_device(fd);
+ igt_require(pci_dev);
+
+ while ((pci_dev = pci_device_get_parent_bridge(pci_dev))) {
+ slot = igt_pm_get_pcie_acpihp_slot(pci_dev);
+ if (slot == -ENOENT) {
+ igt_debug("Bridge PCI device %04x:%02x:%02x.%01x does not support acpihp slot\n",
+ pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
+ continue;
+ }
+
+ /*
+ * Upon getting the valid acpihp slot number break the loop.
+ * It is the desired acpihp slot for gfx card.
+ */
+ if (slot > 0) {
+ igt_debug("Bridge PCI device %04x:%02x:%02x.%01x associated acpihp slot %d\n",
+ pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func, slot);
+ break;
+ }
+ }
+
+ if (!pci_dev)
+ return slot_fd;
+
+ snprintf(slot_fd_path, PATH_MAX, "/sys/bus/pci/slots/%d", slot);
+ slot_fd = open(slot_fd_path, O_RDONLY);
+ if (slot_fd < 0)
+ return -errno;
+
+ return slot_fd;
+}
+
/**
* device_sysfs_path:
* @fd: opened device file descriptor
@@ -124,6 +165,8 @@ static void init_device_fds(struct device_fds *dev)
dev->fds.drv_dir = open_driver_sysfs_dir(dev->fds.dev);
igt_assert_fd(dev->fds.drv_dir);
+
+ dev->fds.slot_dir = open_slot_sysfs_dir(dev->fds.dev);
}
static int close_if_opened(int *fd)
@@ -142,6 +185,7 @@ static void cleanup_device_fds(struct device_fds *dev)
igt_ignore_warn(close_if_opened(&dev->fds.dev));
igt_ignore_warn(close_if_opened(&dev->fds.dev_dir));
igt_ignore_warn(close_if_opened(&dev->fds.drv_dir));
+ igt_ignore_warn(close_if_opened(&dev->fds.slot_dir));
}
/**
@@ -179,6 +223,34 @@ static bool is_sysfs_reset_supported(int fd)
return true;
}
+/**
+ * is_sysfs_cold_reset_supported:
+ * @fd: opened device file descriptor
+ *
+ * Check if device supports cold reset based on sysfs file presence.
+ *
+ * Returns:
+ * True if device supports reset, false otherwise.
+ */
+static bool is_sysfs_cold_reset_supported(int slot_fd)
+{
+ struct stat st;
+ int rc;
+ int cold_reset_fd = -1;
+
+ cold_reset_fd = openat(slot_fd, "power", O_WRONLY);
+
+ if (cold_reset_fd < 0)
+ return false;
+
+ rc = fstat(cold_reset_fd, &st);
+ close(cold_reset_fd);
+
+ if (rc || !S_ISREG(st.st_mode))
+ return false;
+
+ return true;
+}
/* Unbind the driver from the device */
static void driver_unbind(struct device_fds *dev)
{
@@ -231,8 +303,12 @@ static void initiate_device_reset(struct device_fds *dev, enum reset type)
{
igt_debug("reset device\n");
- if (type == FLR_RESET)
+ if (type == FLR_RESET) {
igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
+ } else if (type == COLD_RESET) {
+ igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "0"));
+ igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "1"));
+ }
}
@@ -311,17 +387,45 @@ igt_main
igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
}
- igt_describe("Unbinds driver from device, initiates reset"
- " then rebinds driver to device");
- igt_subtest("unbind-reset-rebind") {
- unbind_reset_rebind(&dev, FLR_RESET);
- healthcheck(&dev);
+ igt_subtest_group {
+ igt_describe("Unbinds driver from device, initiates reset"
+ " then rebinds driver to device");
+ igt_subtest("unbind-reset-rebind") {
+ unbind_reset_rebind(&dev, FLR_RESET);
+ healthcheck(&dev);
+ }
+
+ igt_describe("Resets device with bound driver");
+ igt_subtest("reset-bound") {
+ initiate_device_reset(&dev, FLR_RESET);
+ /*
+ * Cold reset will initiate card boot sequence again,
+ * therefore let healthcheck() re-epen the dev fd.
+ */
+ dev.fds.dev = -1;
+ healthcheck(&dev);
+ }
}
- igt_describe("Resets device with bound driver");
- igt_subtest("reset-bound") {
- initiate_device_reset(&dev, FLR_RESET);
- healthcheck(&dev);
+ igt_subtest_group {
+ igt_fixture {
+ igt_skip_on_f(dev.fds.slot_dir < 0, "Gfx Card does not support any "
+ "pcie slot for cold reset\n");
+ igt_skip_on(!is_sysfs_cold_reset_supported(dev.fds.slot_dir));
+ }
+
+ igt_describe("Unbinds driver from device, initiates cold reset"
+ " then rebinds driver to device");
+ igt_subtest("unbind-cold-reset-rebind") {
+ unbind_reset_rebind(&dev, COLD_RESET);
+ healthcheck(&dev);
+ }
+
+ igt_describe("Cold Resets device with bound driver");
+ igt_subtest("cold-reset-bound") {
+ initiate_device_reset(&dev, COLD_RESET);
+ healthcheck(&dev);
+ }
}
igt_fixture {
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test (rev2)
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
` (2 preceding siblings ...)
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test Anshuman Gupta
@ 2022-11-16 12:47 ` Patchwork
2022-11-16 18:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-11-16 12:47 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8495 bytes --]
== Series Details ==
Series: Cold Reset IGT Test (rev2)
URL : https://patchwork.freedesktop.org/series/110600/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12386 -> IGTPW_8114
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
Participating hosts (38 -> 40)
------------------------------
Additional (2): bat-kbl-2 bat-jsl-3
Known issues
------------
Here are the changes found in IGTPW_8114 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_engines:
- bat-dg1-6: [PASS][1] -> [INCOMPLETE][2] ([i915#4418])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-dg1-6/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][3] -> [INCOMPLETE][4] ([i915#4785])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-adlp-4/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-kbl-7567u: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][7] -> [FAIL][8] ([i915#6298])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([i915#3546])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-adlp-4/igt@kms_pipe_crc_basic@suspend-read-crc.html
- fi-kbl-7567u: NOTRUN -> [SKIP][10] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][11] ([fdo#109271] / [i915#4312] / [i915#5594])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-hsw-4770/igt@runner@aborted.html
- bat-dg1-6: NOTRUN -> [FAIL][12] ([i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-dg1-6/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][13] ([i915#2867]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@dmabuf:
- fi-bxt-dsi: [DMESG-FAIL][15] -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-bxt-dsi/igt@i915_selftest@live@dmabuf.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-bxt-dsi/igt@i915_selftest@live@dmabuf.html
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [INCOMPLETE][17] ([i915#7308] / [i915#7348]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/bat-adlp-4/igt@i915_selftest@live@migrate.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- {bat-adlp-6}: [INCOMPLETE][19] ([i915#6257]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/bat-adlp-6/igt@i915_selftest@live@requests.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-adlp-6/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@workarounds:
- {bat-adlm-1}: [INCOMPLETE][21] ([i915#4983]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/bat-adlm-1/igt@i915_selftest@live@workarounds.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/bat-adlm-1/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-7567u: [INCOMPLETE][23] ([i915#4817]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [SKIP][25] ([fdo#109271]) -> [FAIL][26] ([i915#7229])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [FAIL][27] ([fdo#103375]) -> [INCOMPLETE][28] ([i915#4817])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7328]: https://gitlab.freedesktop.org/drm/intel/issues/7328
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7061 -> IGTPW_8114
CI-20190529: 20190529
CI_DRM_12386: 8686f82d0ad206d538fbf928760e914f108257c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8114: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
IGT_7061: d16e679b99d43643c3a0bcc34ec4c4f001dbbbb4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@device_reset@cold-reset-bound
+igt@device_reset@unbind-cold-reset-rebind
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
[-- Attachment #2: Type: text/html, Size: 8950 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Cold Reset IGT Test (rev2)
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
` (3 preceding siblings ...)
2022-11-16 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test (rev2) Patchwork
@ 2022-11-16 18:16 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-11-16 18:16 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 42404 bytes --]
== Series Details ==
Series: Cold Reset IGT Test (rev2)
URL : https://patchwork.freedesktop.org/series/110600/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12386_full -> IGTPW_8114_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
Participating hosts (9 -> 8)
------------------------------
Additional (2): shard-rkl shard-dg1
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8114_full:
### IGT changes ###
#### Possible regressions ####
* {igt@device_reset@cold-reset-bound} (NEW):
- shard-tglb: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb1/igt@device_reset@cold-reset-bound.html
- shard-iclb: NOTRUN -> [SKIP][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@device_reset@cold-reset-bound.html
- {shard-rkl}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-rkl-1/igt@device_reset@cold-reset-bound.html
* {igt@device_reset@unbind-cold-reset-rebind} (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-dg1-17/igt@device_reset@unbind-cold-reset-rebind.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_prime@basic-modeset-hybrid:
- {shard-rkl}: NOTRUN -> [SKIP][5] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-rkl-5/igt@kms_prime@basic-modeset-hybrid.html
New tests
---------
New tests have been introduced between CI_DRM_12386_full and IGTPW_8114_full:
### New IGT tests (2) ###
* igt@device_reset@cold-reset-bound:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@device_reset@unbind-cold-reset-rebind:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8114_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ccs@suspend-resume:
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#5327])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@gem_ccs@suspend-resume.html
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-tglb: NOTRUN -> [DMESG-WARN][7] ([i915#2411] / [i915#2867]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@gem_ctx_isolation@preservation-s3@vecs0.html
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][8] ([fdo#109314])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb6/igt@gem_ctx_param@set-priority-not-supported.html
- shard-iclb: NOTRUN -> [SKIP][9] ([fdo#109314])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: NOTRUN -> [FAIL][10] ([i915#2410])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][11] -> [SKIP][12] ([i915#4525]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#4525])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb8/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2842]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@massive:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#4613]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb1/igt@gem_lmem_swapping@massive.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl2/igt@gem_lmem_swapping@verify-random-ccs.html
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#4613]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb5/igt@gem_lmem_swapping@verify-random-ccs.html
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk8/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][23] ([i915#2658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-regular-context-1:
- shard-iclb: NOTRUN -> [SKIP][24] ([i915#4270]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@gem_pxp@create-regular-context-1.html
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#4270])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb5/igt@gem_pxp@create-regular-context-1.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271]) +50 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk6/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#768])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#3323])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb5/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271]) +39 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl1/igt@gen7_exec_parse@oacontrol-tracking.html
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109289]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@gen7_exec_parse@oacontrol-tracking.html
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109289]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][32] -> [DMESG-WARN][33] ([i915#5566] / [i915#716])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl2/igt@gen9_exec_parse@allowed-single.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl1/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@batch-zero-length:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#2527] / [i915#2856])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb5/igt@gen9_exec_parse@batch-zero-length.html
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#2856])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@gen9_exec_parse@batch-zero-length.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: NOTRUN -> [WARN][36] ([i915#2684])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
- shard-tglb: NOTRUN -> [WARN][37] ([i915#2681])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109293] / [fdo#109506])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@i915_pm_rpm@pc8-residency.html
* igt@kms_atomic_transition@modeset-transition@1x-outputs:
- shard-tglb: [PASS][39] -> [INCOMPLETE][40] ([i915#7512])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb7/igt@kms_atomic_transition@modeset-transition@1x-outputs.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb8/igt@kms_atomic_transition@modeset-transition@1x-outputs.html
* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#5286])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@kms_big_fb@4-tiled-addfb-size-offset-overflow.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#5286]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110725] / [fdo#111614]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111614]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#110723]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#111615])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109278]) +10 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#6095]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [i915#3886]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb8/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3886])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3689])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb2/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html
* igt@kms_cdclk@mode-transition:
- shard-iclb: NOTRUN -> [SKIP][53] ([i915#3742])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@kms_cdclk@mode-transition.html
* igt@kms_chamelium@dp-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl7/igt@kms_chamelium@dp-hpd-storm.html
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-snb4/igt@kms_chamelium@dp-hpd-storm.html
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb1/igt@kms_chamelium@dp-hpd-storm.html
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk5/igt@kms_chamelium@dp-hpd-storm.html
* igt@kms_color@ctm-0-25@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][58] ([i915#315] / [i915#6946]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@kms_color@ctm-0-25@pipe-b-edp-1.html
* igt@kms_color@ctm-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [FAIL][59] ([i915#315] / [i915#6946]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb6/igt@kms_color@ctm-0-25@pipe-c-edp-1.html
* igt@kms_color_chamelium@ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@kms_color_chamelium@ctm-negative.html
* igt@kms_content_protection@atomic-dpms:
- shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271]) +59 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-snb7/igt@kms_content_protection@atomic-dpms.html
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#7118])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb2/igt@kms_content_protection@atomic-dpms.html
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#7118]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb8/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][64] ([i915#7173])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl3/igt@kms_content_protection@atomic-dpms@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-onscreen-max-size:
- shard-iclb: NOTRUN -> [SKIP][65] ([i915#3555]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@kms_cursor_crc@cursor-onscreen-max-size.html
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#3555])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@kms_cursor_crc@cursor-onscreen-max-size.html
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109274]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#2346])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-iclb: [PASS][70] -> [FAIL][71] ([i915#2346]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#2587] / [i915#2672]) +5 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#2672]) +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109280] / [fdo#111825]) +8 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#6497]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109280]) +18 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][77] -> [SKIP][78] ([i915#433])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb2/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#1839])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][80] -> [SKIP][81] ([i915#5176]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#5176]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb3/igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-c-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#5235]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb8/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1.html
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#5235]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1.html
* igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][85] ([i915#5939]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109441]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109441]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_primary_render:
- shard-tglb: NOTRUN -> [FAIL][89] ([i915#132] / [i915#3467])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@kms_psr@psr2_primary_render.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][90] -> [SKIP][91] ([i915#5519])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@prime_udl:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#109291])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb1/igt@prime_udl.html
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109291])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb8/igt@prime_udl.html
* igt@sysfs_clients@sema-10:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#2994]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb5/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][95] ([i915#2842]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][97] ([i915#2842]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk1/igt@gem_exec_fair@basic-pace@rcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][99] ([i915#2190]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb5/igt@gem_huc_copy@huc-copy.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][101] ([i915#5566] / [i915#716]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk7/igt@gen9_exec_parse@allowed-single.html
* igt@kms_dp_aux_dev:
- shard-iclb: [DMESG-WARN][103] ([i915#4391]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb7/igt@kms_dp_aux_dev.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb5/igt@kms_dp_aux_dev.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][105] ([i915#2122]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [FAIL][107] ([i915#79]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][109] ([i915#5235]) -> [PASS][110] +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][111] ([i915#5213]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-glk7/igt@perf@stress-open-close.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-glk8/igt@perf@stress-open-close.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-tglb: [WARN][113] ([i915#2658]) -> [INCOMPLETE][114] ([i915#7248])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb2/igt@gem_pread@exhaustion.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb6/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][115] ([i915#7248]) -> [WARN][116] ([i915#2658])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-tglb6/igt@gem_pwrite@basic-exhaustion.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-tglb3/igt@gem_pwrite@basic-exhaustion.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][117] ([i915#588]) -> [SKIP][118] ([i915#658])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [DMESG-FAIL][119] ([IGT#6]) -> [FAIL][120] ([i915#4573]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl2/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl7/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][121] ([fdo#111068] / [i915#658]) -> [SKIP][122] ([i915#2920])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-iclb6/igt@kms_psr2_sf@cursor-plane-update-sf.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][123], [FAIL][124]) ([i915#3002] / [i915#4312]) -> ([FAIL][125], [FAIL][126], [FAIL][127]) ([fdo#109271] / [i915#3002] / [i915#4312])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl2/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12386/shard-apl8/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl1/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl3/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/shard-apl7/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6914]: https://gitlab.freedesktop.org/drm/intel/issues/6914
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7468]: https://gitlab.freedesktop.org/drm/intel/issues/7468
[i915#7512]: https://gitlab.freedesktop.org/drm/intel/issues/7512
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7061 -> IGTPW_8114
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12386: 8686f82d0ad206d538fbf928760e914f108257c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8114: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
IGT_7061: d16e679b99d43643c3a0bcc34ec4c4f001dbbbb4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8114/index.html
[-- Attachment #2: Type: text/html, Size: 40185 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset Anshuman Gupta
@ 2022-11-16 19:58 ` Rodrigo Vivi
0 siblings, 0 replies; 11+ messages in thread
From: Rodrigo Vivi @ 2022-11-16 19:58 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: igt-dev, badal.nilawar
On Wed, Nov 16, 2022 at 01:53:34PM +0530, Anshuman Gupta wrote:
> Added a reset type enum to support multiple types
> of reset like WARM, COLD and FLR reset.
>
> No functional change.
>
> v2:
> - Removed WARM_RESET enum as not used yet. [Badal]
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/device_reset.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index e60d4c7fde..0c477a02c0 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -19,6 +19,11 @@ IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
> #define DEV_PATH_LEN 80
> #define DEV_BUS_ADDR_LEN 13 /* addr has form 0000:00:00.0 */
>
> +enum reset {
> + COLD_RESET,
> + FLR_RESET
> +};
> +
> /**
> * Helper structure containing file descriptors
> * and bus address related to tested device
> @@ -222,10 +227,13 @@ static void driver_bind(struct device_fds *dev)
> }
>
> /* Initiate device reset */
> -static void initiate_device_reset(struct device_fds *dev)
> +static void initiate_device_reset(struct device_fds *dev, enum reset type)
> {
> igt_debug("reset device\n");
> - igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
> +
> + if (type == FLR_RESET)
> + igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
> +
> }
>
> static bool is_i915_wedged(int i915)
> @@ -274,14 +282,14 @@ static void set_device_filter(const char* dev_path)
> igt_assert_eq(igt_device_filter_add(filter), 1);
> }
>
> -static void unbind_reset_rebind(struct device_fds *dev)
> +static void unbind_reset_rebind(struct device_fds *dev, enum reset type)
> {
> igt_debug("close the device\n");
> close_if_opened(&dev->fds.dev);
>
> driver_unbind(dev);
>
> - initiate_device_reset(dev);
> + initiate_device_reset(dev, type);
>
> driver_bind(dev);
> }
> @@ -306,13 +314,13 @@ igt_main
> igt_describe("Unbinds driver from device, initiates reset"
> " then rebinds driver to device");
> igt_subtest("unbind-reset-rebind") {
> - unbind_reset_rebind(&dev);
> + unbind_reset_rebind(&dev, FLR_RESET);
> healthcheck(&dev);
> }
>
> igt_describe("Resets device with bound driver");
> igt_subtest("reset-bound") {
> - initiate_device_reset(&dev);
> + initiate_device_reset(&dev, FLR_RESET);
> healthcheck(&dev);
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test Anshuman Gupta
@ 2022-11-17 9:43 ` Iddamsetty, Aravind
2022-11-17 10:31 ` Iddamsetty, Aravind
1 sibling, 0 replies; 11+ messages in thread
From: Iddamsetty, Aravind @ 2022-11-17 9:43 UTC (permalink / raw)
To: Anshuman Gupta, igt-dev; +Cc: badal.nilawar, rodrigo.vivi
On 16-11-2022 13:53, Anshuman Gupta wrote:
> Add cold-reset IGT subtest, IGT subtest will use
> /sys/bus/pci/slots/$SUN/power sysfs in order to
> initiate a cold reset sequence. $SUN value will be
> retrieved from PCIe device ACPI firmware node.
>
> v2:
> - %s/igt_require(fd > 0)/igt_assert(errno >0)
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> lib/igt_pm.c | 40 ++++++++++++++
> lib/igt_pm.h | 1 +
> tests/device_reset.c | 124 +++++++++++++++++++++++++++++++++++++++----
> 3 files changed, 155 insertions(+), 10 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 4f0cfbdd10..9b7ed4be64 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -877,6 +877,46 @@ static int igt_pm_open_pci_firmware_node(struct pci_device *pci_dev)
> return dir;
> }
>
> +/**
> + * igt_pm_get_pcie_acpihp_slot:
> + * @pci_dev: pci bridge device.
> + * Get pci bridge acpi hotplug slot number, if bridge's ACPI firmware_node
> + * handle supports _SUN method.
> + *
> + * Returns:
> + * PCIe bridge Slot number.
> + * Returns -ENOENT number in case firmware_node/sun is not supported by the
> + * bridge.
> + */
> +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev)
> +{
> + int firmware_node_fd, fd, n_read;
> + char sun[8];
> +
> + firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
> +
> + if (firmware_node_fd < 0 && errno == ENOENT)
> + return -ENOENT;
> +
> + igt_require(firmware_node_fd > 0);
> +
> + fd = openat(firmware_node_fd, "sun", O_RDONLY);
> + if (fd < 0 && errno == ENOENT) {
> + close(firmware_node_fd);
> + return -ENOENT;
> + }
> +
> + igt_assert(errno > 0);
> +
> + n_read = read(fd, sun, sizeof(sun));
> + igt_assert(n_read > 0);
> +
> + close(firmware_node_fd);
> + close(fd);
> +
> + return strtol(sun, NULL, 10);
> +}
> +
> /**
> * igt_pm_acpi_d3cold_supported:
> * @pci_dev: root port pci_dev.
> diff --git a/lib/igt_pm.h b/lib/igt_pm.h
> index e81fceb897..f65b960c38 100644
> --- a/lib/igt_pm.h
> +++ b/lib/igt_pm.h
> @@ -73,6 +73,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
> bool igt_pm_dmc_loaded(int debugfs);
> bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
> bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output);
> +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev);
> bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev);
> enum igt_acpi_d_state
> igt_pm_get_acpi_real_d_state(struct pci_device *pci_dev);
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 0c477a02c0..427ea0b09f 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -9,6 +9,7 @@
>
> #include "i915/gem.h"
> #include "igt.h"
> +#include "igt_device.h"
> #include "igt_device_scan.h"
> #include "igt_sysfs.h"
> #include "igt_kmod.h"
> @@ -33,6 +34,7 @@ struct device_fds {
> int dev;
> int dev_dir;
> int drv_dir;
> + int slot_dir; /* pci hotplug slots fd */
> } fds;
> char dev_bus_addr[DEV_BUS_ADDR_LEN];
> bool snd_unload;
> @@ -62,6 +64,45 @@ static int open_driver_sysfs_dir(int fd)
> return __open_sysfs_dir(fd, "device/driver");
> }
>
> +static int open_slot_sysfs_dir(int fd)
> +{
> + struct pci_device *pci_dev = NULL;
> + int slot_fd = -1, slot;
> + char slot_fd_path[PATH_MAX];
> +
> + pci_dev = igt_device_get_pci_device(fd);
> + igt_require(pci_dev);
> +
> + while ((pci_dev = pci_device_get_parent_bridge(pci_dev))) {
> + slot = igt_pm_get_pcie_acpihp_slot(pci_dev);
> + if (slot == -ENOENT) {
> + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x does not support acpihp slot\n",
> + pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
> + continue;
> + }
> +
> + /*
> + * Upon getting the valid acpihp slot number break the loop.
> + * It is the desired acpihp slot for gfx card.
> + */
> + if (slot > 0) {
> + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x associated acpihp slot %d\n",
> + pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func, slot);
> + break;
> + }
> + }
> +
> + if (!pci_dev)
> + return slot_fd;
> +
> + snprintf(slot_fd_path, PATH_MAX, "/sys/bus/pci/slots/%d", slot);
> + slot_fd = open(slot_fd_path, O_RDONLY);
> + if (slot_fd < 0)
> + return -errno;
> +
> + return slot_fd;
> +}
> +
> /**
> * device_sysfs_path:
> * @fd: opened device file descriptor
> @@ -124,6 +165,8 @@ static void init_device_fds(struct device_fds *dev)
>
> dev->fds.drv_dir = open_driver_sysfs_dir(dev->fds.dev);
> igt_assert_fd(dev->fds.drv_dir);
> +
> + dev->fds.slot_dir = open_slot_sysfs_dir(dev->fds.dev);
> }
>
> static int close_if_opened(int *fd)
> @@ -142,6 +185,7 @@ static void cleanup_device_fds(struct device_fds *dev)
> igt_ignore_warn(close_if_opened(&dev->fds.dev));
> igt_ignore_warn(close_if_opened(&dev->fds.dev_dir));
> igt_ignore_warn(close_if_opened(&dev->fds.drv_dir));
> + igt_ignore_warn(close_if_opened(&dev->fds.slot_dir));
> }
>
> /**
> @@ -179,6 +223,34 @@ static bool is_sysfs_reset_supported(int fd)
> return true;
> }
>
> +/**
> + * is_sysfs_cold_reset_supported:
> + * @fd: opened device file descriptor
> + *
> + * Check if device supports cold reset based on sysfs file presence.
> + *
> + * Returns:
> + * True if device supports reset, false otherwise.
> + */
I do not think just with the presence of power sysfs entry we can
confirm that slot supports cold reset or in fact it can be powered
down/up. we should even check for slot capabilites register for Power
Controller Present bit.
Thanks,
Aravind.
> +static bool is_sysfs_cold_reset_supported(int slot_fd)
> +{
> + struct stat st;
> + int rc;
> + int cold_reset_fd = -1;
> +
> + cold_reset_fd = openat(slot_fd, "power", O_WRONLY);
> +
> + if (cold_reset_fd < 0)
> + return false;
> +
> + rc = fstat(cold_reset_fd, &st);
> + close(cold_reset_fd);
> +
> + if (rc || !S_ISREG(st.st_mode))
> + return false;
> +
> + return true;
> +}
> /* Unbind the driver from the device */
> static void driver_unbind(struct device_fds *dev)
> {
> @@ -231,8 +303,12 @@ static void initiate_device_reset(struct device_fds *dev, enum reset type)
> {
> igt_debug("reset device\n");
>
> - if (type == FLR_RESET)
> + if (type == FLR_RESET) {
> igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
> + } else if (type == COLD_RESET) {
> + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "0"));
> + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "1"));
> + }
>
> }
>
> @@ -311,17 +387,45 @@ igt_main
> igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
> }
>
> - igt_describe("Unbinds driver from device, initiates reset"
> - " then rebinds driver to device");
> - igt_subtest("unbind-reset-rebind") {
> - unbind_reset_rebind(&dev, FLR_RESET);
> - healthcheck(&dev);
> + igt_subtest_group {
> + igt_describe("Unbinds driver from device, initiates reset"
> + " then rebinds driver to device");
> + igt_subtest("unbind-reset-rebind") {
> + unbind_reset_rebind(&dev, FLR_RESET);
> + healthcheck(&dev);
> + }
> +
> + igt_describe("Resets device with bound driver");
> + igt_subtest("reset-bound") {
> + initiate_device_reset(&dev, FLR_RESET);
> + /*
> + * Cold reset will initiate card boot sequence again,
> + * therefore let healthcheck() re-epen the dev fd.
> + */
> + dev.fds.dev = -1;
> + healthcheck(&dev);
> + }
> }
>
> - igt_describe("Resets device with bound driver");
> - igt_subtest("reset-bound") {
> - initiate_device_reset(&dev, FLR_RESET);
> - healthcheck(&dev);
> + igt_subtest_group {
> + igt_fixture {
> + igt_skip_on_f(dev.fds.slot_dir < 0, "Gfx Card does not support any "
> + "pcie slot for cold reset\n");
> + igt_skip_on(!is_sysfs_cold_reset_supported(dev.fds.slot_dir));
> + }
> +
> + igt_describe("Unbinds driver from device, initiates cold reset"
> + " then rebinds driver to device");
> + igt_subtest("unbind-cold-reset-rebind") {
> + unbind_reset_rebind(&dev, COLD_RESET);
> + healthcheck(&dev);
> + }
> +
> + igt_describe("Cold Resets device with bound driver");
> + igt_subtest("cold-reset-bound") {
> + initiate_device_reset(&dev, COLD_RESET);
> + healthcheck(&dev);
> + }
> }
>
> igt_fixture {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test Anshuman Gupta
2022-11-17 9:43 ` Iddamsetty, Aravind
@ 2022-11-17 10:31 ` Iddamsetty, Aravind
2022-11-17 12:09 ` Gupta, Anshuman
1 sibling, 1 reply; 11+ messages in thread
From: Iddamsetty, Aravind @ 2022-11-17 10:31 UTC (permalink / raw)
To: Anshuman Gupta, igt-dev; +Cc: badal.nilawar, rodrigo.vivi
On 16-11-2022 13:53, Anshuman Gupta wrote:
> Add cold-reset IGT subtest, IGT subtest will use
> /sys/bus/pci/slots/$SUN/power sysfs in order to
> initiate a cold reset sequence. $SUN value will be
> retrieved from PCIe device ACPI firmware node.
>
> v2:
> - %s/igt_require(fd > 0)/igt_assert(errno >0)
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> lib/igt_pm.c | 40 ++++++++++++++
> lib/igt_pm.h | 1 +
> tests/device_reset.c | 124 +++++++++++++++++++++++++++++++++++++++----
> 3 files changed, 155 insertions(+), 10 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 4f0cfbdd10..9b7ed4be64 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -877,6 +877,46 @@ static int igt_pm_open_pci_firmware_node(struct pci_device *pci_dev)
> return dir;
> }
>
> +/**
> + * igt_pm_get_pcie_acpihp_slot:
> + * @pci_dev: pci bridge device.
> + * Get pci bridge acpi hotplug slot number, if bridge's ACPI firmware_node
> + * handle supports _SUN method.
> + *
> + * Returns:
> + * PCIe bridge Slot number.
> + * Returns -ENOENT number in case firmware_node/sun is not supported by the
> + * bridge.
> + */
> +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev)
> +{
> + int firmware_node_fd, fd, n_read;
> + char sun[8];
> +
> + firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
> +
> + if (firmware_node_fd < 0 && errno == ENOENT)
> + return -ENOENT;
> +
> + igt_require(firmware_node_fd > 0);
> +
> + fd = openat(firmware_node_fd, "sun", O_RDONLY);
> + if (fd < 0 && errno == ENOENT) {
> + close(firmware_node_fd);
> + return -ENOENT;
> + }
> +
> + igt_assert(errno > 0);
> +
> + n_read = read(fd, sun, sizeof(sun));
> + igt_assert(n_read > 0);
> +
> + close(firmware_node_fd);
> + close(fd);
> +
> + return strtol(sun, NULL, 10);
> +}
> +
> /**
> * igt_pm_acpi_d3cold_supported:
> * @pci_dev: root port pci_dev.
> diff --git a/lib/igt_pm.h b/lib/igt_pm.h
> index e81fceb897..f65b960c38 100644
> --- a/lib/igt_pm.h
> +++ b/lib/igt_pm.h
> @@ -73,6 +73,7 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
> bool igt_pm_dmc_loaded(int debugfs);
> bool igt_pm_pc8_plus_residencies_enabled(int msr_fd);
> bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output);
> +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev);
> bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev);
> enum igt_acpi_d_state
> igt_pm_get_acpi_real_d_state(struct pci_device *pci_dev);
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 0c477a02c0..427ea0b09f 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -9,6 +9,7 @@
>
> #include "i915/gem.h"
> #include "igt.h"
> +#include "igt_device.h"
> #include "igt_device_scan.h"
> #include "igt_sysfs.h"
> #include "igt_kmod.h"
> @@ -33,6 +34,7 @@ struct device_fds {
> int dev;
> int dev_dir;
> int drv_dir;
> + int slot_dir; /* pci hotplug slots fd */
> } fds;
> char dev_bus_addr[DEV_BUS_ADDR_LEN];
> bool snd_unload;
> @@ -62,6 +64,45 @@ static int open_driver_sysfs_dir(int fd)
> return __open_sysfs_dir(fd, "device/driver");
> }
>
> +static int open_slot_sysfs_dir(int fd)
> +{
> + struct pci_device *pci_dev = NULL;
> + int slot_fd = -1, slot;
> + char slot_fd_path[PATH_MAX];
> +
> + pci_dev = igt_device_get_pci_device(fd);
> + igt_require(pci_dev);
> +
> + while ((pci_dev = pci_device_get_parent_bridge(pci_dev))) {
> + slot = igt_pm_get_pcie_acpihp_slot(pci_dev);
> + if (slot == -ENOENT) {
> + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x does not support acpihp slot\n",
> + pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
> + continue;
> + }
> +
> + /*
> + * Upon getting the valid acpihp slot number break the loop.
> + * It is the desired acpihp slot for gfx card.
> + */
> + if (slot > 0) {
> + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x associated acpihp slot %d\n",
> + pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func, slot);
> + break;
> + }
> + }
> +
> + if (!pci_dev)
> + return slot_fd;
> +
> + snprintf(slot_fd_path, PATH_MAX, "/sys/bus/pci/slots/%d", slot);
> + slot_fd = open(slot_fd_path, O_RDONLY);
> + if (slot_fd < 0)
> + return -errno;
> +
> + return slot_fd;
> +}
> +
> /**
> * device_sysfs_path:
> * @fd: opened device file descriptor
> @@ -124,6 +165,8 @@ static void init_device_fds(struct device_fds *dev)
>
> dev->fds.drv_dir = open_driver_sysfs_dir(dev->fds.dev);
> igt_assert_fd(dev->fds.drv_dir);
> +
> + dev->fds.slot_dir = open_slot_sysfs_dir(dev->fds.dev);
> }
>
> static int close_if_opened(int *fd)
> @@ -142,6 +185,7 @@ static void cleanup_device_fds(struct device_fds *dev)
> igt_ignore_warn(close_if_opened(&dev->fds.dev));
> igt_ignore_warn(close_if_opened(&dev->fds.dev_dir));
> igt_ignore_warn(close_if_opened(&dev->fds.drv_dir));
> + igt_ignore_warn(close_if_opened(&dev->fds.slot_dir));
> }
>
> /**
> @@ -179,6 +223,34 @@ static bool is_sysfs_reset_supported(int fd)
> return true;
> }
>
> +/**
> + * is_sysfs_cold_reset_supported:
> + * @fd: opened device file descriptor
> + *
> + * Check if device supports cold reset based on sysfs file presence.
> + *
> + * Returns:
> + * True if device supports reset, false otherwise.
> + */
> +static bool is_sysfs_cold_reset_supported(int slot_fd)
> +{
> + struct stat st;
> + int rc;
> + int cold_reset_fd = -1;
> +
> + cold_reset_fd = openat(slot_fd, "power", O_WRONLY);
> +
> + if (cold_reset_fd < 0)
> + return false;
> +
> + rc = fstat(cold_reset_fd, &st);
> + close(cold_reset_fd);
> +
> + if (rc || !S_ISREG(st.st_mode))
> + return false;
> +
> + return true;
> +}
> /* Unbind the driver from the device */
> static void driver_unbind(struct device_fds *dev)
> {
> @@ -231,8 +303,12 @@ static void initiate_device_reset(struct device_fds *dev, enum reset type)
> {
> igt_debug("reset device\n");
>
> - if (type == FLR_RESET)
> + if (type == FLR_RESET) {
> igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
> + } else if (type == COLD_RESET) {
> + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "0"));
> + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "1"));
you need to confirm whether slot is powered down before powering up
again, otherwise COLD reset is not guaranteed.
Thanks,
Aravind.
> + }
>
> }
>
> @@ -311,17 +387,45 @@ igt_main
> igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
> }
>
> - igt_describe("Unbinds driver from device, initiates reset"
> - " then rebinds driver to device");
> - igt_subtest("unbind-reset-rebind") {
> - unbind_reset_rebind(&dev, FLR_RESET);
> - healthcheck(&dev);
> + igt_subtest_group {
> + igt_describe("Unbinds driver from device, initiates reset"
> + " then rebinds driver to device");
> + igt_subtest("unbind-reset-rebind") {
> + unbind_reset_rebind(&dev, FLR_RESET);
> + healthcheck(&dev);
> + }
> +
> + igt_describe("Resets device with bound driver");
> + igt_subtest("reset-bound") {
> + initiate_device_reset(&dev, FLR_RESET);
> + /*
> + * Cold reset will initiate card boot sequence again,
> + * therefore let healthcheck() re-epen the dev fd.
> + */
> + dev.fds.dev = -1;
> + healthcheck(&dev);
> + }
> }
>
> - igt_describe("Resets device with bound driver");
> - igt_subtest("reset-bound") {
> - initiate_device_reset(&dev, FLR_RESET);
> - healthcheck(&dev);
> + igt_subtest_group {
> + igt_fixture {
> + igt_skip_on_f(dev.fds.slot_dir < 0, "Gfx Card does not support any "
> + "pcie slot for cold reset\n");
> + igt_skip_on(!is_sysfs_cold_reset_supported(dev.fds.slot_dir));
> + }
> +
> + igt_describe("Unbinds driver from device, initiates cold reset"
> + " then rebinds driver to device");
> + igt_subtest("unbind-cold-reset-rebind") {
> + unbind_reset_rebind(&dev, COLD_RESET);
> + healthcheck(&dev);
> + }
> +
> + igt_describe("Cold Resets device with bound driver");
> + igt_subtest("cold-reset-bound") {
> + initiate_device_reset(&dev, COLD_RESET);
> + healthcheck(&dev);
> + }
> }
>
> igt_fixture {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test
2022-11-17 10:31 ` Iddamsetty, Aravind
@ 2022-11-17 12:09 ` Gupta, Anshuman
0 siblings, 0 replies; 11+ messages in thread
From: Gupta, Anshuman @ 2022-11-17 12:09 UTC (permalink / raw)
To: Iddamsetty, Aravind, igt-dev; +Cc: Nilawar, Badal, Vivi, Rodrigo
> -----Original Message-----
> From: Iddamsetty, Aravind <aravind.iddamsetty@intel.com>
> Sent: Thursday, November 17, 2022 4:02 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; igt-
> dev@lists.freedesktop.org
> Cc: Nilawar, Badal <badal.nilawar@intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT
> test
>
>
>
> On 16-11-2022 13:53, Anshuman Gupta wrote:
> > Add cold-reset IGT subtest, IGT subtest will use
> > /sys/bus/pci/slots/$SUN/power sysfs in order to initiate a cold reset
> > sequence. $SUN value will be retrieved from PCIe device ACPI firmware
> > node.
> >
> > v2:
> > - %s/igt_require(fd > 0)/igt_assert(errno >0)
> >
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
> > ---
> > lib/igt_pm.c | 40 ++++++++++++++
> > lib/igt_pm.h | 1 +
> > tests/device_reset.c | 124
> > +++++++++++++++++++++++++++++++++++++++----
> > 3 files changed, 155 insertions(+), 10 deletions(-)
> >
> > diff --git a/lib/igt_pm.c b/lib/igt_pm.c index 4f0cfbdd10..9b7ed4be64
> > 100644
> > --- a/lib/igt_pm.c
> > +++ b/lib/igt_pm.c
> > @@ -877,6 +877,46 @@ static int igt_pm_open_pci_firmware_node(struct
> pci_device *pci_dev)
> > return dir;
> > }
> >
> > +/**
> > + * igt_pm_get_pcie_acpihp_slot:
> > + * @pci_dev: pci bridge device.
> > + * Get pci bridge acpi hotplug slot number, if bridge's ACPI
> > +firmware_node
> > + * handle supports _SUN method.
> > + *
> > + * Returns:
> > + * PCIe bridge Slot number.
> > + * Returns -ENOENT number in case firmware_node/sun is not supported
> > +by the
> > + * bridge.
> > + */
> > +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev) {
> > + int firmware_node_fd, fd, n_read;
> > + char sun[8];
> > +
> > + firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
> > +
> > + if (firmware_node_fd < 0 && errno == ENOENT)
> > + return -ENOENT;
> > +
> > + igt_require(firmware_node_fd > 0);
> > +
> > + fd = openat(firmware_node_fd, "sun", O_RDONLY);
> > + if (fd < 0 && errno == ENOENT) {
> > + close(firmware_node_fd);
> > + return -ENOENT;
> > + }
> > +
> > + igt_assert(errno > 0);
> > +
> > + n_read = read(fd, sun, sizeof(sun));
> > + igt_assert(n_read > 0);
> > +
> > + close(firmware_node_fd);
> > + close(fd);
> > +
> > + return strtol(sun, NULL, 10);
> > +}
> > +
> > /**
> > * igt_pm_acpi_d3cold_supported:
> > * @pci_dev: root port pci_dev.
> > diff --git a/lib/igt_pm.h b/lib/igt_pm.h index e81fceb897..f65b960c38
> > 100644
> > --- a/lib/igt_pm.h
> > +++ b/lib/igt_pm.h
> > @@ -73,6 +73,7 @@ bool igt_wait_for_pm_status(enum
> > igt_runtime_pm_status status); bool igt_pm_dmc_loaded(int debugfs);
> > bool igt_pm_pc8_plus_residencies_enabled(int msr_fd); bool
> > i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output);
> > +int igt_pm_get_pcie_acpihp_slot(struct pci_device *pci_dev);
> > bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev); enum
> > igt_acpi_d_state igt_pm_get_acpi_real_d_state(struct pci_device
> > *pci_dev); diff --git a/tests/device_reset.c b/tests/device_reset.c
> > index 0c477a02c0..427ea0b09f 100644
> > --- a/tests/device_reset.c
> > +++ b/tests/device_reset.c
> > @@ -9,6 +9,7 @@
> >
> > #include "i915/gem.h"
> > #include "igt.h"
> > +#include "igt_device.h"
> > #include "igt_device_scan.h"
> > #include "igt_sysfs.h"
> > #include "igt_kmod.h"
> > @@ -33,6 +34,7 @@ struct device_fds {
> > int dev;
> > int dev_dir;
> > int drv_dir;
> > + int slot_dir; /* pci hotplug slots fd */
> > } fds;
> > char dev_bus_addr[DEV_BUS_ADDR_LEN];
> > bool snd_unload;
> > @@ -62,6 +64,45 @@ static int open_driver_sysfs_dir(int fd)
> > return __open_sysfs_dir(fd, "device/driver"); }
> >
> > +static int open_slot_sysfs_dir(int fd) {
> > + struct pci_device *pci_dev = NULL;
> > + int slot_fd = -1, slot;
> > + char slot_fd_path[PATH_MAX];
> > +
> > + pci_dev = igt_device_get_pci_device(fd);
> > + igt_require(pci_dev);
> > +
> > + while ((pci_dev = pci_device_get_parent_bridge(pci_dev))) {
> > + slot = igt_pm_get_pcie_acpihp_slot(pci_dev);
> > + if (slot == -ENOENT) {
> > + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x
> does not support acpihp slot\n",
> > + pci_dev->domain, pci_dev->bus, pci_dev-
> >dev, pci_dev->func);
> > + continue;
> > + }
> > +
> > + /*
> > + * Upon getting the valid acpihp slot number break the loop.
> > + * It is the desired acpihp slot for gfx card.
> > + */
> > + if (slot > 0) {
> > + igt_debug("Bridge PCI device %04x:%02x:%02x.%01x
> associated acpihp slot %d\n",
> > + pci_dev->domain, pci_dev->bus, pci_dev-
> >dev, pci_dev->func, slot);
> > + break;
> > + }
> > + }
> > +
> > + if (!pci_dev)
> > + return slot_fd;
> > +
> > + snprintf(slot_fd_path, PATH_MAX, "/sys/bus/pci/slots/%d", slot);
> > + slot_fd = open(slot_fd_path, O_RDONLY);
> > + if (slot_fd < 0)
> > + return -errno;
> > +
> > + return slot_fd;
> > +}
> > +
> > /**
> > * device_sysfs_path:
> > * @fd: opened device file descriptor @@ -124,6 +165,8 @@ static void
> > init_device_fds(struct device_fds *dev)
> >
> > dev->fds.drv_dir = open_driver_sysfs_dir(dev->fds.dev);
> > igt_assert_fd(dev->fds.drv_dir);
> > +
> > + dev->fds.slot_dir = open_slot_sysfs_dir(dev->fds.dev);
> > }
> >
> > static int close_if_opened(int *fd)
> > @@ -142,6 +185,7 @@ static void cleanup_device_fds(struct device_fds *dev)
> > igt_ignore_warn(close_if_opened(&dev->fds.dev));
> > igt_ignore_warn(close_if_opened(&dev->fds.dev_dir));
> > igt_ignore_warn(close_if_opened(&dev->fds.drv_dir));
> > + igt_ignore_warn(close_if_opened(&dev->fds.slot_dir));
> > }
> >
> > /**
> > @@ -179,6 +223,34 @@ static bool is_sysfs_reset_supported(int fd)
> > return true;
> > }
> >
> > +/**
> > + * is_sysfs_cold_reset_supported:
> > + * @fd: opened device file descriptor
> > + *
> > + * Check if device supports cold reset based on sysfs file presence.
> > + *
> > + * Returns:
> > + * True if device supports reset, false otherwise.
> > + */
> > +static bool is_sysfs_cold_reset_supported(int slot_fd) {
> > + struct stat st;
> > + int rc;
> > + int cold_reset_fd = -1;
> > +
> > + cold_reset_fd = openat(slot_fd, "power", O_WRONLY);
> > +
> > + if (cold_reset_fd < 0)
> > + return false;
> > +
> > + rc = fstat(cold_reset_fd, &st);
> > + close(cold_reset_fd);
> > +
> > + if (rc || !S_ISREG(st.st_mode))
> > + return false;
> > +
> > + return true;
> > +}
> > /* Unbind the driver from the device */ static void
> > driver_unbind(struct device_fds *dev) { @@ -231,8 +303,12 @@ static
> > void initiate_device_reset(struct device_fds *dev, enum reset type) {
> > igt_debug("reset device\n");
> >
> > - if (type == FLR_RESET)
> > + if (type == FLR_RESET) {
> > igt_assert(igt_sysfs_set(dev->fds.dev_dir, "reset", "1"));
> > + } else if (type == COLD_RESET) {
> > + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "0"));
> > + igt_assert(igt_sysfs_set(dev->fds.slot_dir, "power", "1"));
> you need to confirm whether slot is powered down before powering up again,
> otherwise COLD reset is not guaranteed.
Thanks for review comment, I will address this.
BR,
Anshuman
>
> Thanks,
> Aravind.
> > + }
> >
> > }
> >
> > @@ -311,17 +387,45 @@ igt_main
> > igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
> > }
> >
> > - igt_describe("Unbinds driver from device, initiates reset"
> > - " then rebinds driver to device");
> > - igt_subtest("unbind-reset-rebind") {
> > - unbind_reset_rebind(&dev, FLR_RESET);
> > - healthcheck(&dev);
> > + igt_subtest_group {
> > + igt_describe("Unbinds driver from device, initiates reset"
> > + " then rebinds driver to device");
> > + igt_subtest("unbind-reset-rebind") {
> > + unbind_reset_rebind(&dev, FLR_RESET);
> > + healthcheck(&dev);
> > + }
> > +
> > + igt_describe("Resets device with bound driver");
> > + igt_subtest("reset-bound") {
> > + initiate_device_reset(&dev, FLR_RESET);
> > + /*
> > + * Cold reset will initiate card boot sequence again,
> > + * therefore let healthcheck() re-epen the dev fd.
> > + */
> > + dev.fds.dev = -1;
> > + healthcheck(&dev);
> > + }
> > }
> >
> > - igt_describe("Resets device with bound driver");
> > - igt_subtest("reset-bound") {
> > - initiate_device_reset(&dev, FLR_RESET);
> > - healthcheck(&dev);
> > + igt_subtest_group {
> > + igt_fixture {
> > + igt_skip_on_f(dev.fds.slot_dir < 0, "Gfx Card does not
> support any "
> > + "pcie slot for cold reset\n");
> > +
> igt_skip_on(!is_sysfs_cold_reset_supported(dev.fds.slot_dir));
> > + }
> > +
> > + igt_describe("Unbinds driver from device, initiates cold reset"
> > + " then rebinds driver to device");
> > + igt_subtest("unbind-cold-reset-rebind") {
> > + unbind_reset_rebind(&dev, COLD_RESET);
> > + healthcheck(&dev);
> > + }
> > +
> > + igt_describe("Cold Resets device with bound driver");
> > + igt_subtest("cold-reset-bound") {
> > + initiate_device_reset(&dev, COLD_RESET);
> > + healthcheck(&dev);
> > + }
> > }
> >
> > igt_fixture {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
@ 2022-11-23 12:55 ` Kamil Konieczny
0 siblings, 0 replies; 11+ messages in thread
From: Kamil Konieczny @ 2022-11-23 12:55 UTC (permalink / raw)
To: igt-dev; +Cc: badal.nilawar, rodrigo.vivi
Hi,
On 2022-11-16 at 13:53:33 +0530, Anshuman Gupta wrote:
> Created igt_pm_open_pci_firmware_node() to refactor
> the retrieving the firmware_node fd code.
>
> igt_pm_open_pci_firmware_node() will be used by other
> firmware_node consumers.
>
> While doing that fixed the leaked fd as well.
>
> v2:
> - return false instead of igt_require on no firmware_node_fd. [Kamil]
> - use igt_assert() when failed to open 'real_power_state' on error
> other then ENONET.
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> lib/igt_pm.c | 36 +++++++++++++++++++++++++-----------
> 1 file changed, 25 insertions(+), 11 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 1e6e9ed3ff..4f0cfbdd10 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -863,6 +863,20 @@ bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output)
> return strstr(buf, "LPSP: capable");
> }
>
> +static int igt_pm_open_pci_firmware_node(struct pci_device *pci_dev)
> +{
> + char name[PATH_MAX];
> + int dir;
> +
> + snprintf(name, PATH_MAX,
> + "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/firmware_node",
> + pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
> +
> + dir = open(name, O_RDONLY);
> +
> + return dir;
> +}
> +
> /**
> * igt_pm_acpi_d3cold_supported:
> * @pci_dev: root port pci_dev.
> @@ -873,23 +887,23 @@ bool i915_output_is_lpsp_capable(int drm_fd, igt_output_t *output)
> */
> bool igt_pm_acpi_d3cold_supported(struct pci_device *pci_dev)
> {
> - char name[PATH_MAX];
> - int dir, fd;
> -
> - snprintf(name, PATH_MAX,
> - "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/firmware_node",
> - pci_dev->domain, pci_dev->bus, pci_dev->dev, pci_dev->func);
> + int firmware_node_fd, fd;
>
> - dir = open(name, O_RDONLY);
> - igt_require(dir > 0);
> + firmware_node_fd = igt_pm_open_pci_firmware_node(pci_dev);
> + if (firmware_node_fd < 0)
> + return false;
>
> /* BIOS need to enable ACPI D3Cold Support.*/
> - fd = openat(dir, "real_power_state", O_RDONLY);
> - if (fd < 0 && errno == ENOENT)
> + fd = openat(firmware_node_fd, "real_power_state", O_RDONLY);
> + if (fd < 0 && errno == ENOENT) {
> + close(firmware_node_fd);
> return false;
> + }
>
> - igt_require(fd > 0);
> + igt_assert(errno > 0);
------------------------ ^
This should be == , so
igt_assert(errno == 0);
Regards,
Kamil
>
> + close(firmware_node_fd);
> + close(fd);
> return true;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-23 12:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 8:23 [igt-dev] [PATCH i-g-t v2 0/3] Cold Reset IGT Test Anshuman Gupta
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_pm: Refactor get firmware_node fd Anshuman Gupta
2022-11-23 12:55 ` Kamil Konieczny
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 2/3] test/device_reset: Refactor initiate_device_reset Anshuman Gupta
2022-11-16 19:58 ` Rodrigo Vivi
2022-11-16 8:23 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/device_reset: Add cold reset IGT test Anshuman Gupta
2022-11-17 9:43 ` Iddamsetty, Aravind
2022-11-17 10:31 ` Iddamsetty, Aravind
2022-11-17 12:09 ` Gupta, Anshuman
2022-11-16 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Cold Reset IGT Test (rev2) Patchwork
2022-11-16 18:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.