[PATCH 1/3] drm/tests: Include helpers header

[PATCH 1/3] drm/tests: Include helpers header

[Maxime Ripard]

The kunit helpers code weren't including its header, leading to a
warning that no previous prototype had been defined for public
functions.

Include the matching header to fix the warning.

Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index d3f0d681b685..dbd8ec24d4be 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -5,6 +5,8 @@
 
 #include <linux/device.h>
 
+#include "drm_kunit_helpers.h"
+
 struct kunit_dev {
 	struct drm_device base;
 };
-- 
2.38.1

[PATCH 2/3] drm/tests: helpers: Add module infos

[Maxime Ripard]

The MODULE_LICENSE macro is missing from the kunit helpers file, thus
leading to a build error.

Let's introduce it along with MODULE_AUTHOR.

Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index dbd8ec24d4be..eea450de7de8 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char
 
 	return drm;
 }
+
+MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>");
+MODULE_LICENSE("GPL");
-- 
2.38.1

[PATCH 3/3] firmware: raspberrypi: Fix type assignment

[Maxime Ripard]

We silently cast an unsigned int into a __le32 which makes sparse
complain. Moreover, we never actually convert endianness between the
CPU's and the expected little-endian value. Fix both at once by calling
cpu_to_le32().

Fixes: 40c31955e4e9 ("firmware: raspberrypi: Provide a helper to query a clock max rate")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 include/soc/bcm2835/raspberrypi-firmware.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
index ab955591cb72..73cac8d0287e 100644
--- a/include/soc/bcm2835/raspberrypi-firmware.h
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
@@ -170,7 +170,7 @@ struct rpi_firmware_clk_rate_request {
 
 #define RPI_FIRMWARE_CLK_RATE_REQUEST(_id)	\
 	{					\
-		.id = _id,			\
+		.id = cpu_to_le32(_id),		\
 	}
 
 #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE)
-- 
2.38.1

Re: [PATCH 1/3] drm/tests: Include helpers header

[Maíra Canal]

Hi Maxime,

On 11/16/22 06:17, Maxime Ripard wrote:
> The kunit helpers code weren't including its header, leading to a
> warning that no previous prototype had been defined for public
> functions.
> 
> Include the matching header to fix the warning.
> 
> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index d3f0d681b685..dbd8ec24d4be 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -5,6 +5,8 @@
>  
>  #include <linux/device.h>
>  
> +#include "drm_kunit_helpers.h"
> +
>  struct kunit_dev {
>  	struct drm_device base;
>  };

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

[Maíra Canal]

Hi Maxime,

On 11/16/22 06:17, Maxime Ripard wrote:
> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> leading to a build error.
> 
> Let's introduce it along with MODULE_AUTHOR.
> 
> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

It would be nice to add the SPDX-License-Identifier tag in the source
file as well. Besides that,

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index dbd8ec24d4be..eea450de7de8 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, char
>  
>  	return drm;
>  }
> +
> +MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>");
> +MODULE_LICENSE("GPL");

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

[Jani Nikula]

On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote:
> Hi Maxime,
>
> On 11/16/22 06:17, Maxime Ripard wrote:
>> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
>> leading to a build error.
>> 
>> Let's introduce it along with MODULE_AUTHOR.
>> 
>> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> It would be nice to add the SPDX-License-Identifier tag in the source
> file as well. Besides that,

It's not just nice, it's basically mandatory to add license boilerplate.

Checkpatch would've warned about this. And actually about a lot of stuff
in the series.

(And our CI checkpatch did too, although we don't send the replies to
the world, just intel-gfx [1].)

BR,
Jani.


[1] https://lore.kernel.org/r/166846421165.32750.1193593124785451784@emeril.freedesktop.org



-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote:
> On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote:
> > Hi Maxime,
> >
> > On 11/16/22 06:17, Maxime Ripard wrote:
> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> >> leading to a build error.
> >> 
> >> Let's introduce it along with MODULE_AUTHOR.
> >> 
> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> >
> > It would be nice to add the SPDX-License-Identifier tag in the source
> > file as well. Besides that,
> 
> It's not just nice, it's basically mandatory to add license boilerplate.
> 
> Checkpatch would've warned about this. And actually about a lot of stuff
> in the series.

Right, sorry about that. I'll send additional patches to address the
issues already in.

> (And our CI checkpatch did too, although we don't send the replies to
> the world, just intel-gfx [1].)

I'm not sure how helpful it is though if the author is not a recipient
of the report

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: (subset) [PATCH 1/3] drm/tests: Include helpers header

[Maxime Ripard]

On Wed, 16 Nov 2022 10:17:10 +0100, Maxime Ripard wrote:
> The kunit helpers code weren't including its header, leading to a
> warning that no previous prototype had been defined for public
> functions.
> 
> Include the matching header to fix the warning.
> 
> 
> [...]

Applied to local tree (tmp).

Thanks!
Maxime

Re: (subset) [PATCH 2/3] drm/tests: helpers: Add module infos

[Maxime Ripard]

On Wed, 16 Nov 2022 10:17:11 +0100, Maxime Ripard wrote:
> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> leading to a build error.
> 
> Let's introduce it along with MODULE_AUTHOR.
> 
> 

Applied to local tree (tmp).

Thanks!
Maxime

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

[Jani Nikula]

On Wed, 16 Nov 2022, Maxime Ripard <maxime@cerno.tech> wrote:
> On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote:
>> On Wed, 16 Nov 2022, Maíra Canal <mairacanal@riseup.net> wrote:
>> > Hi Maxime,
>> >
>> > On 11/16/22 06:17, Maxime Ripard wrote:
>> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
>> >> leading to a build error.
>> >> 
>> >> Let's introduce it along with MODULE_AUTHOR.
>> >> 
>> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
>> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> >> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>> >
>> > It would be nice to add the SPDX-License-Identifier tag in the source
>> > file as well. Besides that,
>> 
>> It's not just nice, it's basically mandatory to add license boilerplate.
>> 
>> Checkpatch would've warned about this. And actually about a lot of stuff
>> in the series.
>
> Right, sorry about that. I'll send additional patches to address the
> issues already in.
>
>> (And our CI checkpatch did too, although we don't send the replies to
>> the world, just intel-gfx [1].)
>
> I'm not sure how helpful it is though if the author is not a recipient
> of the report

It actually should be, but I have absolutely no idea why in this case it
decided to do

	To: "Mateusz Kwiatkowski" <kfyatek@gmail.com>

instead of you. Baffled.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center