[PATCH 1/2] drm/tests: client: Remove extra blank lines

[PATCH 1/2] drm/tests: client: Remove extra blank lines

[Maxime Ripard]

Some extra blank lines slipped through, remove them.

Fixes: 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/tests/drm_client_modeset_test.c b/drivers/gpu/drm/tests/drm_client_modeset_test.c
index 558c098b0384..362a5fbd82f5 100644
--- a/drivers/gpu/drm/tests/drm_client_modeset_test.c
+++ b/drivers/gpu/drm/tests/drm_client_modeset_test.c
@@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)
 	drm_connector_helper_add(&priv->connector, &drm_client_modeset_connector_helper_funcs);
 
 	return 0;
-
 }
 
 static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
@@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
 	KUNIT_EXPECT_TRUE(test, drm_mode_equal(expected_mode, mode));
 }
 
-
 static struct kunit_case drm_test_pick_cmdline_tests[] = {
 	KUNIT_CASE(drm_test_pick_cmdline_res_1920_1080_60),
 	{}
-- 
2.38.1

[PATCH 2/2] drm/tests: helpers: Add SPDX header

[Maxime Ripard]

The SPDX header is missing, let's add it and fix the corresponding
checkpatch warning.

Suggested-by: Maíra Canal <mairacanal@riseup.net>
Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
index eea450de7de8..f1662091f250 100644
--- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
+++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0
+
 #include <drm/drm_drv.h>
 #include <drm/drm_managed.h>
 
-- 
2.38.1

Re: [PATCH 1/2] drm/tests: client: Remove extra blank lines

[Maíra Canal]

On 11/16/22 12:18, Maxime Ripard wrote:
> Some extra blank lines slipped through, remove them.
> 
> Fixes: 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_client_modeset_test.c b/drivers/gpu/drm/tests/drm_client_modeset_test.c
> index 558c098b0384..362a5fbd82f5 100644
> --- a/drivers/gpu/drm/tests/drm_client_modeset_test.c
> +++ b/drivers/gpu/drm/tests/drm_client_modeset_test.c
> @@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)
>  	drm_connector_helper_add(&priv->connector, &drm_client_modeset_connector_helper_funcs);
>  
>  	return 0;
> -
>  }
>  
>  static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
> @@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
>  	KUNIT_EXPECT_TRUE(test, drm_mode_equal(expected_mode, mode));
>  }
>  
> -
>  static struct kunit_case drm_test_pick_cmdline_tests[] = {
>  	KUNIT_CASE(drm_test_pick_cmdline_res_1920_1080_60),
>  	{}

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

[Maíra Canal]

Hi Maxime,

On 11/16/22 12:18, Maxime Ripard wrote:
> The SPDX header is missing, let's add it and fix the corresponding
> checkpatch warning.
> 
> Suggested-by: Maíra Canal <mairacanal@riseup.net>
> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Could you add the SPDX-License-Identifier tag on the header file as
well? With the SPDX header on both files, this is:

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index eea450de7de8..f1662091f250 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
>  #include <drm/drm_drv.h>
>  #include <drm/drm_managed.h>
>  

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Hi Maira,

On Wed, Nov 16, 2022 at 01:48:13PM -0300, Maíra Canal wrote:
> Hi Maxime,
> 
> On 11/16/22 12:18, Maxime Ripard wrote:
> > The SPDX header is missing, let's add it and fix the corresponding
> > checkpatch warning.
> > 
> > Suggested-by: Maíra Canal <mairacanal@riseup.net>
> > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> 
> Could you add the SPDX-License-Identifier tag on the header file as
> well? With the SPDX header on both files, this is:
> 
> Reviewed-by: Maíra Canal <mairacanal@riseup.net>

I applied those patches yesterday, with the fix you suggested

Thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]