* [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
@ 2022-11-16 17:17 August Wikerfors
2022-11-16 17:19 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: August Wikerfors @ 2022-11-16 17:17 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: linux-nvme, linux-kernel, August Wikerfors
The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
reports eui as 0001000200030004 when resuming from s2idle, causing the
device to be removed with this error in dmesg:
nvme nvme0: identifiers changed for nsid 1
To fix this, add a quirk to ignore namespace identifiers for this device.
Signed-off-by: August Wikerfors <git@augustwikerfors.se>
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index f4335519399d..0af51b85c323 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3500,7 +3500,8 @@ static const struct pci_device_id nvme_id_table[] = {
{ PCI_DEVICE(0x1d97, 0x2263), /* SPCC */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x144d, 0xa80b), /* Samsung PM9B1 256G and 512G */
- .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES |
+ NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x144d, 0xa809), /* Samsung MZALQ256HBJD 256G */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x1cc4, 0x6303), /* UMIS RPJTJ512MGE1QDY 512G */
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-16 17:17 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G August Wikerfors
@ 2022-11-16 17:19 ` Christoph Hellwig
2022-11-16 17:42 ` August Wikerfors
2022-11-17 3:19 ` Kanchan Joshi
0 siblings, 2 replies; 9+ messages in thread
From: Christoph Hellwig @ 2022-11-16 17:19 UTC (permalink / raw)
To: August Wikerfors
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme, linux-kernel
On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
> reports eui as 0001000200030004 when resuming from s2idle, causing the
> device to be removed with this error in dmesg:
>
> nvme nvme0: identifiers changed for nsid 1
What EUI did it report before? Is the identifier stable after
multiple resume cycles?
Can some of the Samsung folks here reach out to the relevant firmware
team to see if they have any clues?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-16 17:19 ` Christoph Hellwig
@ 2022-11-16 17:42 ` August Wikerfors
2022-11-17 7:13 ` Kanchan Joshi
2022-11-17 3:19 ` Kanchan Joshi
1 sibling, 1 reply; 9+ messages in thread
From: August Wikerfors @ 2022-11-16 17:42 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel
On 2022-11-16 18:19, Christoph Hellwig wrote:
> On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
>> reports eui as 0001000200030004 when resuming from s2idle, causing the
>> device to be removed with this error in dmesg:
>>
>> nvme nvme0: identifiers changed for nsid 1
>
> What EUI did it report before? Is the identifier stable after
> multiple resume cycles?
The original EUI is "002538e621b440e5". Using the patches from [1] and
[2] for debugging I consistently get this output on every resume:
> eui changed from 002538e621b440e5 to 0001000200030004
[1] https://lore.kernel.org/all/20220408025704.6352-1-me@kingtous.cn/
[2] https://lore.kernel.org/all/20220408062210.GA410@lst.de/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-16 17:42 ` August Wikerfors
@ 2022-11-17 7:13 ` Kanchan Joshi
2022-11-17 9:09 ` August Wikerfors
0 siblings, 1 reply; 9+ messages in thread
From: Kanchan Joshi @ 2022-11-17 7:13 UTC (permalink / raw)
To: August Wikerfors
Cc: Christoph Hellwig, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Wed, Nov 16, 2022 at 06:42:43PM +0100, August Wikerfors wrote:
>On 2022-11-16 18:19, Christoph Hellwig wrote:
>>On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
>>>reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>device to be removed with this error in dmesg:
>>>
>>>nvme nvme0: identifiers changed for nsid 1
>>
>>What EUI did it report before? Is the identifier stable after
>>multiple resume cycles?
>The original EUI is "002538e621b440e5". Using the patches from [1] and
>[2] for debugging I consistently get this output on every resume:
>>eui changed from 002538e621b440e5 to 0001000200030004
Can you please share the firmware version of this SSD?
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-17 7:13 ` Kanchan Joshi
@ 2022-11-17 9:09 ` August Wikerfors
0 siblings, 0 replies; 9+ messages in thread
From: August Wikerfors @ 2022-11-17 9:09 UTC (permalink / raw)
To: Kanchan Joshi
Cc: Christoph Hellwig, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
On 2022-11-17 08:13, Kanchan Joshi wrote:
> On Wed, Nov 16, 2022 at 06:42:43PM +0100, August Wikerfors wrote:
>> On 2022-11-16 18:19, Christoph Hellwig wrote:
>>> On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop
>>>> units
>>>> reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>> device to be removed with this error in dmesg:
>>>>
>>>> nvme nvme0: identifiers changed for nsid 1
>>>
>>> What EUI did it report before? Is the identifier stable after
>>> multiple resume cycles?
>> The original EUI is "002538e621b440e5". Using the patches from [1] and
>> [2] for debugging I consistently get this output on every resume:
>>> eui changed from 002538e621b440e5 to 0001000200030004
>
> Can you please share the firmware version of this SSD?
The firmware version is 7L1QHXC7.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-16 17:19 ` Christoph Hellwig
2022-11-16 17:42 ` August Wikerfors
@ 2022-11-17 3:19 ` Kanchan Joshi
2022-12-06 5:59 ` Kanchan Joshi
1 sibling, 1 reply; 9+ messages in thread
From: Kanchan Joshi @ 2022-11-17 3:19 UTC (permalink / raw)
To: Christoph Hellwig
Cc: August Wikerfors, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Wed, Nov 16, 2022 at 06:19:35PM +0100, Christoph Hellwig wrote:
>On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
>> reports eui as 0001000200030004 when resuming from s2idle, causing the
>> device to be removed with this error in dmesg:
>>
>> nvme nvme0: identifiers changed for nsid 1
>
>What EUI did it report before? Is the identifier stable after
>multiple resume cycles?
>
>Can some of the Samsung folks here reach out to the relevant firmware
>team to see if they have any clues?
I will check.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-11-17 3:19 ` Kanchan Joshi
@ 2022-12-06 5:59 ` Kanchan Joshi
2022-12-20 11:30 ` August Wikerfors
0 siblings, 1 reply; 9+ messages in thread
From: Kanchan Joshi @ 2022-12-06 5:59 UTC (permalink / raw)
To: Christoph Hellwig
Cc: August Wikerfors, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
On Thu, Nov 17, 2022 at 08:49:51AM +0530, Kanchan Joshi wrote:
>On Wed, Nov 16, 2022 at 06:19:35PM +0100, Christoph Hellwig wrote:
>>On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
>>>reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>device to be removed with this error in dmesg:
>>>
>>>nvme nvme0: identifiers changed for nsid 1
>>
>>What EUI did it report before? Is the identifier stable after
>>multiple resume cycles?
>>
>>Can some of the Samsung folks here reach out to the relevant firmware
>>team to see if they have any clues?
>
>I will check.
Took more time than I wanted. Firmware team mentioned that issue existed
in this firmware. This is fixed in new firmware, but bit of travel time
is involved when official release from OEM (Lenovo) comes out.
Hope the information is sufficient, and quirk can go in.
If required,
Acked-by: Kanchan Joshi <joshi.k@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-12-06 5:59 ` Kanchan Joshi
@ 2022-12-20 11:30 ` August Wikerfors
2022-12-21 8:31 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: August Wikerfors @ 2022-12-20 11:30 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel,
Kanchan Joshi
On 2022-12-06 06:59, Kanchan Joshi wrote:
> On Thu, Nov 17, 2022 at 08:49:51AM +0530, Kanchan Joshi wrote:
>> On Wed, Nov 16, 2022 at 06:19:35PM +0100, Christoph Hellwig wrote:
>>> On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop
>>>> units
>>>> reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>> device to be removed with this error in dmesg:
>>>>
>>>> nvme nvme0: identifiers changed for nsid 1
>>>
>>> What EUI did it report before? Is the identifier stable after
>>> multiple resume cycles?
>>>
>>> Can some of the Samsung folks here reach out to the relevant firmware
>>> team to see if they have any clues?
>>
>> I will check.
>
> Took more time than I wanted. Firmware team mentioned that issue existed
> in this firmware. This is fixed in new firmware, but bit of travel time
> is involved when official release from OEM (Lenovo) comes out.
>
> Hope the information is sufficient, and quirk can go in.
>
> If required, Acked-by: Kanchan Joshi <joshi.k@samsung.com>
Ping, anything left for me to do before this can be merged?
Regards,
August Wikerfors
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G
2022-12-20 11:30 ` August Wikerfors
@ 2022-12-21 8:31 ` Christoph Hellwig
0 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2022-12-21 8:31 UTC (permalink / raw)
To: August Wikerfors
Cc: Christoph Hellwig, Keith Busch, Jens Axboe, Sagi Grimberg,
linux-nvme, linux-kernel, Kanchan Joshi
On Tue, Dec 20, 2022 at 12:30:39PM +0100, August Wikerfors wrote:
>> Took more time than I wanted. Firmware team mentioned that issue existed
>> in this firmware. This is fixed in new firmware, but bit of travel time
>> is involved when official release from OEM (Lenovo) comes out.
>>
>> Hope the information is sufficient, and quirk can go in.
>>
>> If required, Acked-by: Kanchan Joshi <joshi.k@samsung.com>
>
> Ping, anything left for me to do before this can be merged?
We don't want to add quirks for things fixed by firmware updates,
see the recently posted features and quirks policy.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-21 8:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 17:17 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G August Wikerfors
2022-11-16 17:19 ` Christoph Hellwig
2022-11-16 17:42 ` August Wikerfors
2022-11-17 7:13 ` Kanchan Joshi
2022-11-17 9:09 ` August Wikerfors
2022-11-17 3:19 ` Kanchan Joshi
2022-12-06 5:59 ` Kanchan Joshi
2022-12-20 11:30 ` August Wikerfors
2022-12-21 8:31 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.