* [PATCH] perf: arm_cspmu: Fix module cyclic dependency
@ 2022-11-16 20:39 ` Besar Wicaksono
0 siblings, 0 replies; 6+ messages in thread
From: Besar Wicaksono @ 2022-11-16 20:39 UTC (permalink / raw)
To: suzuki.poulose, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh,
vsethi, ywan, Besar Wicaksono
Build on arm64 allmodconfig failed with:
| depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
| depmod: ERROR: Found 2 modules in dependency cycles!
The arm_cspmu.c provides standard functions to operate the PMU and the
vendor code provides vendor specific attributes. Both need to be built as
single kernel module.
Update the makefile to compile sources under arm_cspmu into one module.
Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
---
drivers/perf/arm_cspmu/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile
index 641db85c018b..fedb17df982d 100644
--- a/drivers/perf/arm_cspmu/Makefile
+++ b/drivers/perf/arm_cspmu/Makefile
@@ -2,6 +2,5 @@
#
# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \
- arm_cspmu.o \
- nvidia_cspmu.o
+obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o
+arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] perf: arm_cspmu: Fix module cyclic dependency
@ 2022-11-16 20:39 ` Besar Wicaksono
0 siblings, 0 replies; 6+ messages in thread
From: Besar Wicaksono @ 2022-11-16 20:39 UTC (permalink / raw)
To: suzuki.poulose, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh,
vsethi, ywan, Besar Wicaksono
Build on arm64 allmodconfig failed with:
| depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
| depmod: ERROR: Found 2 modules in dependency cycles!
The arm_cspmu.c provides standard functions to operate the PMU and the
vendor code provides vendor specific attributes. Both need to be built as
single kernel module.
Update the makefile to compile sources under arm_cspmu into one module.
Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
---
drivers/perf/arm_cspmu/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile
index 641db85c018b..fedb17df982d 100644
--- a/drivers/perf/arm_cspmu/Makefile
+++ b/drivers/perf/arm_cspmu/Makefile
@@ -2,6 +2,5 @@
#
# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \
- arm_cspmu.o \
- nvidia_cspmu.o
+obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o
+arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency
2022-11-16 20:39 ` Besar Wicaksono
@ 2022-11-17 9:19 ` Suzuki K Poulose
-1 siblings, 0 replies; 6+ messages in thread
From: Suzuki K Poulose @ 2022-11-17 9:19 UTC (permalink / raw)
To: Besar Wicaksono, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh,
vsethi, ywan
On 16/11/2022 20:39, Besar Wicaksono wrote:
> Build on arm64 allmodconfig failed with:
> | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
> | depmod: ERROR: Found 2 modules in dependency cycles!
>
> The arm_cspmu.c provides standard functions to operate the PMU and the
> vendor code provides vendor specific attributes. Both need to be built as
> single kernel module.
>
> Update the makefile to compile sources under arm_cspmu into one module.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
> ---
> drivers/perf/arm_cspmu/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile
> index 641db85c018b..fedb17df982d 100644
> --- a/drivers/perf/arm_cspmu/Makefile
> +++ b/drivers/perf/arm_cspmu/Makefile
> @@ -2,6 +2,5 @@
> #
> # SPDX-License-Identifier: GPL-2.0
>
> -obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \
> - arm_cspmu.o \
> - nvidia_cspmu.o
> +obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o
> +arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
>
Reviewed-and-Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency
@ 2022-11-17 9:19 ` Suzuki K Poulose
0 siblings, 0 replies; 6+ messages in thread
From: Suzuki K Poulose @ 2022-11-17 9:19 UTC (permalink / raw)
To: Besar Wicaksono, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh,
vsethi, ywan
On 16/11/2022 20:39, Besar Wicaksono wrote:
> Build on arm64 allmodconfig failed with:
> | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
> | depmod: ERROR: Found 2 modules in dependency cycles!
>
> The arm_cspmu.c provides standard functions to operate the PMU and the
> vendor code provides vendor specific attributes. Both need to be built as
> single kernel module.
>
> Update the makefile to compile sources under arm_cspmu into one module.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
> ---
> drivers/perf/arm_cspmu/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile
> index 641db85c018b..fedb17df982d 100644
> --- a/drivers/perf/arm_cspmu/Makefile
> +++ b/drivers/perf/arm_cspmu/Makefile
> @@ -2,6 +2,5 @@
> #
> # SPDX-License-Identifier: GPL-2.0
>
> -obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \
> - arm_cspmu.o \
> - nvidia_cspmu.o
> +obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o
> +arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
>
Reviewed-and-Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency
2022-11-16 20:39 ` Besar Wicaksono
@ 2022-11-18 19:40 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2022-11-18 19:40 UTC (permalink / raw)
To: suzuki.poulose, mark.rutland, catalin.marinas, Besar Wicaksono
Cc: kernel-team, Will Deacon, ywan, linux-kernel, linux-arm-kernel,
vsethi, linux-tegra, jonathanh, treding
On Wed, 16 Nov 2022 14:39:52 -0600, Besar Wicaksono wrote:
> Build on arm64 allmodconfig failed with:
> | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
> | depmod: ERROR: Found 2 modules in dependency cycles!
>
> The arm_cspmu.c provides standard functions to operate the PMU and the
> vendor code provides vendor specific attributes. Both need to be built as
> single kernel module.
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf: arm_cspmu: Fix module cyclic dependency
https://git.kernel.org/will/c/a91bbd5c9984
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency
@ 2022-11-18 19:40 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2022-11-18 19:40 UTC (permalink / raw)
To: suzuki.poulose, mark.rutland, catalin.marinas, Besar Wicaksono
Cc: kernel-team, Will Deacon, ywan, linux-kernel, linux-arm-kernel,
vsethi, linux-tegra, jonathanh, treding
On Wed, 16 Nov 2022 14:39:52 -0600, Besar Wicaksono wrote:
> Build on arm64 allmodconfig failed with:
> | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
> | depmod: ERROR: Found 2 modules in dependency cycles!
>
> The arm_cspmu.c provides standard functions to operate the PMU and the
> vendor code provides vendor specific attributes. Both need to be built as
> single kernel module.
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf: arm_cspmu: Fix module cyclic dependency
https://git.kernel.org/will/c/a91bbd5c9984
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-18 19:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 20:39 [PATCH] perf: arm_cspmu: Fix module cyclic dependency Besar Wicaksono
2022-11-16 20:39 ` Besar Wicaksono
2022-11-17 9:19 ` Suzuki K Poulose
2022-11-17 9:19 ` Suzuki K Poulose
2022-11-18 19:40 ` Will Deacon
2022-11-18 19:40 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.