All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] SM6350 SMMUv2
@ 2022-11-17  9:44 Konrad Dybcio
  2022-11-17  9:44   ` Konrad Dybcio
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17  9:44 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio

Hi,

SM6350 has a SMMUv2-compatible(-ish, obviously) instance that
is responsible for working with Adreno and its GMU.

Recently, it was decided that there is no point in adding more
mmu-500 compatibles to the driver, however after chatting with
Dmitry on IRC, it was concluded that it's okay to add that for v2, as
these older implementations can vary so much from SoC to SoC that
having a common compatible is really not feasible..

Konrad Dybcio (2):
  dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
  iommu/arm-smmu-qcom: Add SM6350 SMMUv2

 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 ++
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c            | 1 +
 2 files changed, 3 insertions(+)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
  2022-11-17  9:44 [PATCH 0/2] SM6350 SMMUv2 Konrad Dybcio
@ 2022-11-17  9:44   ` Konrad Dybcio
  2022-11-17  9:44   ` Konrad Dybcio
  2022-11-18 19:40 ` [PATCH 0/2] " Will Deacon
  2 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17  9:44 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Will Deacon, Robin Murphy, Joerg Roedel,
	Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, iommu,
	devicetree, linux-kernel

SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
Document it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 348a73f3e5f0..895ec8418465 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -94,6 +94,7 @@ properties:
               - qcom,sc7180-smmu-v2
               - qcom,sdm630-smmu-v2
               - qcom,sdm845-smmu-v2
+              - qcom,sm6350-smmu-v2
           - const: qcom,adreno-smmu
           - const: qcom,smmu-v2
       - description: Qcom Adreno GPUs on Google Cheza platform
@@ -347,6 +348,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,sm6350-smmu-v2
               - qcom,sm8150-smmu-500
               - qcom,sm8250-smmu-500
     then:
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
@ 2022-11-17  9:44   ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17  9:44 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Will Deacon, Robin Murphy, Joerg Roedel,
	Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, iommu,
	devicetree, linux-kernel

SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
Document it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 348a73f3e5f0..895ec8418465 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -94,6 +94,7 @@ properties:
               - qcom,sc7180-smmu-v2
               - qcom,sdm630-smmu-v2
               - qcom,sdm845-smmu-v2
+              - qcom,sm6350-smmu-v2
           - const: qcom,adreno-smmu
           - const: qcom,smmu-v2
       - description: Qcom Adreno GPUs on Google Cheza platform
@@ -347,6 +348,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,sm6350-smmu-v2
               - qcom,sm8150-smmu-500
               - qcom,sm8250-smmu-500
     then:
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] iommu/arm-smmu-qcom: Add SM6350 SMMUv2
  2022-11-17  9:44 [PATCH 0/2] SM6350 SMMUv2 Konrad Dybcio
@ 2022-11-17  9:44   ` Konrad Dybcio
  2022-11-17  9:44   ` Konrad Dybcio
  2022-11-18 19:40 ` [PATCH 0/2] " Will Deacon
  2 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17  9:44 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Will Deacon, Robin Murphy, Joerg Roedel,
	Konrad Dybcio, Rob Clark, Emma Anholt, Vinod Koul,
	Sai Prakash Ranjan, linux-arm-kernel, iommu, linux-kernel

SM6350 uses a qcom,smmu-v2-style SMMU just for Adreno and friends.
Add a compatible for it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index fd97db178696..fa84a69b9439 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -513,6 +513,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
 	{ .compatible = "qcom,sdm845-smmu-500", .data = &sdm845_smmu_500_data },
 	{ .compatible = "qcom,sm6115-smmu-500", .data = &qcom_smmu_500_impl0_data},
 	{ .compatible = "qcom,sm6125-smmu-500", .data = &qcom_smmu_500_impl0_data },
+	{ .compatible = "qcom,sm6350-smmu-v2", .data = &qcom_smmu_v2_data },
 	{ .compatible = "qcom,sm6350-smmu-500", .data = &qcom_smmu_500_impl0_data },
 	{ .compatible = "qcom,sm6375-smmu-500", .data = &qcom_smmu_500_impl0_data },
 	{ .compatible = "qcom,sm8150-smmu-500", .data = &qcom_smmu_500_impl0_data },
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] iommu/arm-smmu-qcom: Add SM6350 SMMUv2
@ 2022-11-17  9:44   ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17  9:44 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Will Deacon, Robin Murphy, Joerg Roedel,
	Konrad Dybcio, Rob Clark, Emma Anholt, Vinod Koul,
	Sai Prakash Ranjan, linux-arm-kernel, iommu, linux-kernel

SM6350 uses a qcom,smmu-v2-style SMMU just for Adreno and friends.
Add a compatible for it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index fd97db178696..fa84a69b9439 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -513,6 +513,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
 	{ .compatible = "qcom,sdm845-smmu-500", .data = &sdm845_smmu_500_data },
 	{ .compatible = "qcom,sm6115-smmu-500", .data = &qcom_smmu_500_impl0_data},
 	{ .compatible = "qcom,sm6125-smmu-500", .data = &qcom_smmu_500_impl0_data },
+	{ .compatible = "qcom,sm6350-smmu-v2", .data = &qcom_smmu_v2_data },
 	{ .compatible = "qcom,sm6350-smmu-500", .data = &qcom_smmu_500_impl0_data },
 	{ .compatible = "qcom,sm6375-smmu-500", .data = &qcom_smmu_500_impl0_data },
 	{ .compatible = "qcom,sm8150-smmu-500", .data = &qcom_smmu_500_impl0_data },
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
  2022-11-17  9:44   ` Konrad Dybcio
@ 2022-11-17 12:55     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-17 12:55 UTC (permalink / raw)
  To: Konrad Dybcio, linux-arm-msm, andersson, agross
  Cc: patches, Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
	Krzysztof Kozlowski, linux-arm-kernel, iommu, devicetree,
	linux-kernel

On 17/11/2022 10:44, Konrad Dybcio wrote:
> SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
> Document it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

(although this might need rebase later on Dmitry's refactoring)


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
@ 2022-11-17 12:55     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-17 12:55 UTC (permalink / raw)
  To: Konrad Dybcio, linux-arm-msm, andersson, agross
  Cc: patches, Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
	Krzysztof Kozlowski, linux-arm-kernel, iommu, devicetree,
	linux-kernel

On 17/11/2022 10:44, Konrad Dybcio wrote:
> SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
> Document it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

(although this might need rebase later on Dmitry's refactoring)


Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
  2022-11-17 12:55     ` Krzysztof Kozlowski
@ 2022-11-17 13:07       ` Konrad Dybcio
  -1 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17 13:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-arm-msm, andersson, agross
  Cc: patches, Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
	Krzysztof Kozlowski, linux-arm-kernel, iommu, devicetree,
	linux-kernel



On 17/11/2022 13:55, Krzysztof Kozlowski wrote:
> On 17/11/2022 10:44, Konrad Dybcio wrote:
>> SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
>> Document it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> (although this might need rebase later on Dmitry's refactoring)
Oh, I forgot to mention this patch was made on top of Dmitry's work. But 
it's good that you pointed that out!

Konrad
> 
> 
> Best regards,
> Krzysztof
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
@ 2022-11-17 13:07       ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-11-17 13:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-arm-msm, andersson, agross
  Cc: patches, Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
	Krzysztof Kozlowski, linux-arm-kernel, iommu, devicetree,
	linux-kernel



On 17/11/2022 13:55, Krzysztof Kozlowski wrote:
> On 17/11/2022 10:44, Konrad Dybcio wrote:
>> SM6350 has a qcom,smmu-v2-style SMMU just for Adreno and friends.
>> Document it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> (although this might need rebase later on Dmitry's refactoring)
Oh, I forgot to mention this patch was made on top of Dmitry's work. But 
it's good that you pointed that out!

Konrad
> 
> 
> Best regards,
> Krzysztof
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/2] SM6350 SMMUv2
  2022-11-17  9:44 [PATCH 0/2] SM6350 SMMUv2 Konrad Dybcio
  2022-11-17  9:44   ` Konrad Dybcio
  2022-11-17  9:44   ` Konrad Dybcio
@ 2022-11-18 19:40 ` Will Deacon
  2 siblings, 0 replies; 10+ messages in thread
From: Will Deacon @ 2022-11-18 19:40 UTC (permalink / raw)
  To: agross, andersson, krzysztof.kozlowski, Konrad Dybcio, linux-arm-msm
  Cc: catalin.marinas, kernel-team, Will Deacon, patches

On Thu, 17 Nov 2022 10:44:20 +0100, Konrad Dybcio wrote:
> SM6350 has a SMMUv2-compatible(-ish, obviously) instance that
> is responsible for working with Adreno and its GMU.
> 
> Recently, it was decided that there is no point in adding more
> mmu-500 compatibles to the driver, however after chatting with
> Dmitry on IRC, it was concluded that it's okay to add that for v2, as
> these older implementations can vary so much from SoC to SoC that
> having a common compatible is really not feasible..
> 
> [...]

Applied to will (for-joerg/arm-smmu/bindings), thanks!

[1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2
      https://git.kernel.org/will/c/5a47cb4df38b
[2/2] iommu/arm-smmu-qcom: Add SM6350 SMMUv2
      https://git.kernel.org/will/c/3811a7283a0a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-11-18 19:41 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17  9:44 [PATCH 0/2] SM6350 SMMUv2 Konrad Dybcio
2022-11-17  9:44 ` [PATCH 1/2] dt-bindings: arm-smmu: Add SM6350 GPU SMMUv2 Konrad Dybcio
2022-11-17  9:44   ` Konrad Dybcio
2022-11-17 12:55   ` Krzysztof Kozlowski
2022-11-17 12:55     ` Krzysztof Kozlowski
2022-11-17 13:07     ` Konrad Dybcio
2022-11-17 13:07       ` Konrad Dybcio
2022-11-17  9:44 ` [PATCH 2/2] iommu/arm-smmu-qcom: Add SM6350 SMMUv2 Konrad Dybcio
2022-11-17  9:44   ` Konrad Dybcio
2022-11-18 19:40 ` [PATCH 0/2] " Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.