* [PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file()
@ 2022-11-17 16:58 Andy Shevchenko
2022-11-18 8:07 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-11-17 16:58 UTC (permalink / raw)
To: Andy Shevchenko, linux-pwm, linux-kernel
Cc: Thierry Reding, Uwe Kleine-König
The debugfs_create_file() already has a check and adds S_IFREG
automatically. Remove unneeded flag.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: resent as a standalone patch (Uwe)
drivers/pwm/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 855abd0a776f..8f5cb665940f 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1179,8 +1179,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
static int __init pwm_debugfs_init(void)
{
- debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL,
- &pwm_debugfs_fops);
+ debugfs_create_file("pwm", 0444, NULL, NULL, &pwm_debugfs_fops);
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file()
2022-11-17 16:58 [PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file() Andy Shevchenko
@ 2022-11-18 8:07 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 8:07 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-pwm, linux-kernel, Thierry Reding
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
Hello,
On Thu, Nov 17, 2022 at 06:58:12PM +0200, Andy Shevchenko wrote:
> The debugfs_create_file() already has a check and adds S_IFREG
> automatically. Remove unneeded flag.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: resent as a standalone patch (Uwe)
My idea was that Thierry picks v2 from the initial series, my intention
wasn't to make you resend it alone. Anyhow:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-18 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 16:58 [PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file() Andy Shevchenko
2022-11-18 8:07 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.