* [PATCH v3 1/2] drm/i915/migrate: Account for the reserved_space
@ 2022-11-21 16:54 ` Matthew Auld
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Auld @ 2022-11-21 16:54 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson, Andrzej Hajda, Nirmoy Das, stable
From: Chris Wilson <chris.p.wilson@intel.com>
If the ring is nearly full when calling into emit_pte(), we might
incorrectly trample the reserved_space when constructing the packet to
emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space >
ring->space) when later submitting the request, since the request itself
doesn't have enough space left in the ring to emit things like
workarounds, breadcrumbs etc.
Testcase: igt@i915_selftests@live_emit_pte_full_ring
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7535
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6889
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: <stable@vger.kernel.org> # v5.15+
Tested-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index b405a04135ca..48c3b5168558 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -342,6 +342,16 @@ static int emit_no_arbitration(struct i915_request *rq)
return 0;
}
+static int max_pte_pkt_size(struct i915_request *rq, int pkt)
+{
+ struct intel_ring *ring = rq->ring;
+
+ pkt = min_t(int, pkt, (ring->space - rq->reserved_space) / sizeof(u32) + 5);
+ pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+
+ return pkt;
+}
+
static int emit_pte(struct i915_request *rq,
struct sgt_dma *it,
enum i915_cache_level cache_level,
@@ -388,8 +398,7 @@ static int emit_pte(struct i915_request *rq,
return PTR_ERR(cs);
/* Pack as many PTE updates as possible into a single MI command */
- pkt = min_t(int, dword_length, ring->space / sizeof(u32) + 5);
- pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+ pkt = max_pte_pkt_size(rq, dword_length);
hdr = cs;
*cs++ = MI_STORE_DATA_IMM | REG_BIT(21); /* as qword elements */
@@ -422,8 +431,7 @@ static int emit_pte(struct i915_request *rq,
}
}
- pkt = min_t(int, dword_rem, ring->space / sizeof(u32) + 5);
- pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+ pkt = max_pte_pkt_size(rq, dword_rem);
hdr = cs;
*cs++ = MI_STORE_DATA_IMM | REG_BIT(21);
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] [PATCH v3 1/2] drm/i915/migrate: Account for the reserved_space
@ 2022-11-21 16:54 ` Matthew Auld
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Auld @ 2022-11-21 16:54 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Andrzej Hajda, Chris Wilson, Nirmoy Das
From: Chris Wilson <chris.p.wilson@intel.com>
If the ring is nearly full when calling into emit_pte(), we might
incorrectly trample the reserved_space when constructing the packet to
emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space >
ring->space) when later submitting the request, since the request itself
doesn't have enough space left in the ring to emit things like
workarounds, breadcrumbs etc.
Testcase: igt@i915_selftests@live_emit_pte_full_ring
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7535
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6889
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: <stable@vger.kernel.org> # v5.15+
Tested-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index b405a04135ca..48c3b5168558 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -342,6 +342,16 @@ static int emit_no_arbitration(struct i915_request *rq)
return 0;
}
+static int max_pte_pkt_size(struct i915_request *rq, int pkt)
+{
+ struct intel_ring *ring = rq->ring;
+
+ pkt = min_t(int, pkt, (ring->space - rq->reserved_space) / sizeof(u32) + 5);
+ pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+
+ return pkt;
+}
+
static int emit_pte(struct i915_request *rq,
struct sgt_dma *it,
enum i915_cache_level cache_level,
@@ -388,8 +398,7 @@ static int emit_pte(struct i915_request *rq,
return PTR_ERR(cs);
/* Pack as many PTE updates as possible into a single MI command */
- pkt = min_t(int, dword_length, ring->space / sizeof(u32) + 5);
- pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+ pkt = max_pte_pkt_size(rq, dword_length);
hdr = cs;
*cs++ = MI_STORE_DATA_IMM | REG_BIT(21); /* as qword elements */
@@ -422,8 +431,7 @@ static int emit_pte(struct i915_request *rq,
}
}
- pkt = min_t(int, dword_rem, ring->space / sizeof(u32) + 5);
- pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);
+ pkt = max_pte_pkt_size(rq, dword_rem);
hdr = cs;
*cs++ = MI_STORE_DATA_IMM | REG_BIT(21);
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] [PATCH v3 2/2] drm/i915/selftests: exercise emit_pte() with nearly full ring
2022-11-21 16:54 ` [Intel-gfx] " Matthew Auld
(?)
@ 2022-11-21 16:54 ` Matthew Auld
-1 siblings, 0 replies; 5+ messages in thread
From: Matthew Auld @ 2022-11-21 16:54 UTC (permalink / raw)
To: intel-gfx; +Cc: Andrzej Hajda, Chris Wilson, Nirmoy Das
Simple regression test to check that we don't trample the
rq->reserved_space when returning from emit_pte(), if the ring is nearly
full.
v2: Make spinner_kill() static
v3: Reduce the ring size further, which should mean we need to execute less
noops; hopefully this appeases bsw. Also add some debug logging.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/7535
References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 6 +-
drivers/gpu/drm/i915/gt/selftest_migrate.c | 156 +++++++++++++++++++++
2 files changed, 160 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 48c3b5168558..6df728b82a73 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -352,6 +352,8 @@ static int max_pte_pkt_size(struct i915_request *rq, int pkt)
return pkt;
}
+#define I915_EMIT_PTE_NUM_DWORDS 6
+
static int emit_pte(struct i915_request *rq,
struct sgt_dma *it,
enum i915_cache_level cache_level,
@@ -393,7 +395,7 @@ static int emit_pte(struct i915_request *rq,
offset += (u64)rq->engine->instance << 32;
- cs = intel_ring_begin(rq, 6);
+ cs = intel_ring_begin(rq, I915_EMIT_PTE_NUM_DWORDS);
if (IS_ERR(cs))
return PTR_ERR(cs);
@@ -416,7 +418,7 @@ static int emit_pte(struct i915_request *rq,
intel_ring_advance(rq, cs);
intel_ring_update_space(ring);
- cs = intel_ring_begin(rq, 6);
+ cs = intel_ring_begin(rq, I915_EMIT_PTE_NUM_DWORDS);
if (IS_ERR(cs))
return PTR_ERR(cs);
diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/gt/selftest_migrate.c
index 0dc5309c90a4..347487699264 100644
--- a/drivers/gpu/drm/i915/gt/selftest_migrate.c
+++ b/drivers/gpu/drm/i915/gt/selftest_migrate.c
@@ -8,6 +8,7 @@
#include "gem/i915_gem_internal.h"
#include "gem/i915_gem_lmem.h"
+#include "selftests/igt_spinner.h"
#include "selftests/i915_random.h"
static const unsigned int sizes[] = {
@@ -527,6 +528,160 @@ static int live_migrate_clear(void *arg)
return 0;
}
+static int spinner_kill(void *arg)
+{
+ struct igt_spinner *spin = arg;
+
+ msleep(2000); /* Should be plenty */
+ igt_spinner_end(spin);
+ pr_info("%s\n", __func__);
+ return 0;
+}
+
+static int live_emit_pte_full_ring(void *arg)
+{
+ struct intel_migrate *migrate = arg;
+ struct drm_i915_private *i915 = migrate->context->engine->i915;
+ struct drm_i915_gem_object *obj;
+ struct intel_context *ce;
+ struct i915_request *rq, *prev;
+ struct igt_spinner spin;
+ struct task_struct *tsk = NULL;
+ struct sgt_dma it;
+ int len, sz, err;
+ int status;
+ u32 *cs;
+
+ /*
+ * Simple regression test to check that we don't trample the
+ * rq->reserved_space when returning from emit_pte(), if the ring is
+ * nearly full.
+ */
+
+ if (igt_spinner_init(&spin, to_gt(i915)))
+ return -ENOMEM;
+
+ obj = i915_gem_object_create_internal(i915, 2 * PAGE_SIZE);
+ if (IS_ERR(obj)) {
+ err = PTR_ERR(obj);
+ goto out_spinner;
+ }
+
+ err = i915_gem_object_pin_pages_unlocked(obj);
+ if (err)
+ goto out_obj;
+
+ ce = intel_migrate_create_context(migrate);
+ if (IS_ERR(ce)) {
+ err = PTR_ERR(ce);
+ goto out_obj;
+ }
+
+ ce->ring_size = SZ_1K; /* Not too big */
+
+ err = intel_context_pin(ce);
+ if (err)
+ goto out_put;
+
+ rq = igt_spinner_create_request(&spin, ce, MI_ARB_CHECK);
+ if (IS_ERR(rq)) {
+ err = PTR_ERR(rq);
+ goto out_unpin;
+ }
+
+ i915_request_add(rq);
+ if (!igt_wait_for_spinner(&spin, rq)) {
+ err = -EIO;
+ goto out_unpin;
+ }
+
+ /*
+ * Fill the ring leaving I915_EMIT_PTE_NUM_DWORDS + ring->reserved_space
+ * at the end. To actually emit the PTEs we require slightly more than
+ * I915_EMIT_PTE_NUM_DWORDS, since our object size is greater than
+ * PAGE_SIZE. The correct behaviour is to wait for more ring space in
+ * emit_pte(), otherwise we trample on the reserved_space resulting in
+ * crashes when later submitting the rq.
+ */
+
+ prev = NULL;
+ do {
+ if (prev)
+ i915_request_add(rq);
+
+ rq = i915_request_create(ce);
+ if (IS_ERR(rq)) {
+ err = PTR_ERR(rq);
+ goto out_unpin;
+ }
+
+ sz = (rq->ring->space - rq->reserved_space) / sizeof(u32) -
+ I915_EMIT_PTE_NUM_DWORDS;
+ sz = min_t(u32, sz, 256 / sizeof(u32));
+ cs = intel_ring_begin(rq, sz);
+ if (IS_ERR(cs)) {
+ err = PTR_ERR(cs);
+ goto out_rq;
+ }
+
+ memset32(cs, MI_NOOP, sz);
+ cs += sz;
+ intel_ring_advance(rq, cs);
+
+ pr_info("%s sz=%d\n", __func__, sz);
+
+ prev = rq;
+ } while (rq->ring->space > (rq->reserved_space +
+ I915_EMIT_PTE_NUM_DWORDS * sizeof(u32)));
+
+ it = sg_sgt(obj->mm.pages->sgl);
+
+ tsk = kthread_run(spinner_kill, &spin, "igt-kill-spinner");
+ if (IS_ERR(tsk)) {
+ err = PTR_ERR(tsk);
+ goto out_rq;
+ }
+
+ get_task_struct(tsk);
+
+ msleep(10); /* start all threads before we kthread_stop() */
+
+ /*
+ * This should wait for the spinner to be killed, otherwise we should go
+ * down in flames when doing i915_request_add().
+ */
+ pr_info("%s emite_pte ring space=%u\n", __func__, rq->ring->space);
+ len = emit_pte(rq, &it, obj->cache_level, false, 0, CHUNK_SZ);
+ if (!len) {
+ err = -EINVAL;
+ goto out_rq;
+ }
+ if (len < 0) {
+ err = len;
+ goto out_rq;
+ }
+
+out_rq:
+ i915_request_add(rq); /* GEM_BUG_ON(rq->reserved_space > ring->space)? */
+
+ if (!IS_ERR_OR_NULL(tsk)) {
+ status = kthread_stop(tsk);
+ if (status && !err)
+ err = status;
+
+ put_task_struct(tsk);
+ }
+out_unpin:
+ intel_context_unpin(ce);
+out_put:
+ intel_context_put(ce);
+out_obj:
+ i915_gem_object_put(obj);
+out_spinner:
+ igt_spinner_fini(&spin);
+ return err;
+}
+
struct threaded_migrate {
struct intel_migrate *migrate;
struct task_struct *tsk;
@@ -637,6 +792,7 @@ int intel_migrate_live_selftests(struct drm_i915_private *i915)
static const struct i915_subtest tests[] = {
SUBTEST(live_migrate_copy),
SUBTEST(live_migrate_clear),
+ SUBTEST(live_emit_pte_full_ring),
SUBTEST(thread_migrate_copy),
SUBTEST(thread_migrate_clear),
SUBTEST(thread_global_copy),
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space
2022-11-21 16:54 ` [Intel-gfx] " Matthew Auld
(?)
(?)
@ 2022-11-21 22:06 ` Patchwork
-1 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-11-21 22:06 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space
URL : https://patchwork.freedesktop.org/series/111155/
State : warning
== Summary ==
Error: dim checkpatch failed
889967ecb7d7 drm/i915/migrate: Account for the reserved_space
-:35: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#35: FILE: drivers/gpu/drm/i915/gt/intel_migrate.c:347:
+ struct intel_ring *ring = rq->ring;$
-:37: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#37: FILE: drivers/gpu/drm/i915/gt/intel_migrate.c:349:
+ pkt = min_t(int, pkt, (ring->space - rq->reserved_space) / sizeof(u32) + 5);$
-:38: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: drivers/gpu/drm/i915/gt/intel_migrate.c:350:
+ pkt = min_t(int, pkt, (ring->size - ring->emit) / sizeof(u32) + 5);$
-:40: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: drivers/gpu/drm/i915/gt/intel_migrate.c:352:
+ return pkt;$
total: 0 errors, 4 warnings, 0 checks, 34 lines checked
73339f787e99 drm/i915/selftests: exercise emit_pte() with nearly full ring
-:74: WARNING:TRACING_LOGGING: Unnecessary ftrace-like logging - prefer using ftrace
#74: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:537:
+ pr_info("%s\n", __func__);
-:184: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#184: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:647:
+ msleep(10); /* start all threads before we kthread_stop() */
total: 0 errors, 2 warnings, 0 checks, 198 lines checked
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space
2022-11-21 16:54 ` [Intel-gfx] " Matthew Auld
` (2 preceding siblings ...)
(?)
@ 2022-11-21 23:35 ` Patchwork
-1 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-11-21 23:35 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 17111 bytes --]
== Series Details ==
Series: series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space
URL : https://patchwork.freedesktop.org/series/111155/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12409 -> Patchwork_111155v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111155v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111155v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/index.html
Participating hosts (35 -> 37)
------------------------------
Additional (6): fi-kbl-soraka bat-adls-5 fi-tgl-dsi bat-atsm-1 bat-rpls-2 bat-dg2-11
Missing (4): fi-ilk-m540 bat-kbl-2 bat-jsl-3 bat-dg1-5
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111155v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@migrate:
- fi-glk-j4005: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-glk-j4005/igt@i915_selftest@live@migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-glk-j4005/igt@i915_selftest@live@migrate.html
- fi-rkl-guc: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-rkl-guc/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-rkl-guc/igt@i915_selftest@live@migrate.html
- fi-skl-guc: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-skl-guc/igt@i915_selftest@live@migrate.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-skl-guc/igt@i915_selftest@live@migrate.html
- bat-dg1-6: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-dg1-6/igt@i915_selftest@live@migrate.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-dg1-6/igt@i915_selftest@live@migrate.html
- fi-skl-6700k2: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-skl-6700k2/igt@i915_selftest@live@migrate.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-skl-6700k2/igt@i915_selftest@live@migrate.html
- fi-kbl-7567u: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-kbl-7567u/igt@i915_selftest@live@migrate.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-7567u/igt@i915_selftest@live@migrate.html
- fi-cfl-8700k: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-cfl-8700k/igt@i915_selftest@live@migrate.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-cfl-8700k/igt@i915_selftest@live@migrate.html
- fi-bsw-nick: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-bsw-nick/igt@i915_selftest@live@migrate.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bsw-nick/igt@i915_selftest@live@migrate.html
- fi-rkl-11600: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-rkl-11600/igt@i915_selftest@live@migrate.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-rkl-11600/igt@i915_selftest@live@migrate.html
- fi-bsw-kefka: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-bsw-kefka/igt@i915_selftest@live@migrate.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bsw-kefka/igt@i915_selftest@live@migrate.html
- fi-cfl-8109u: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-cfl-8109u/igt@i915_selftest@live@migrate.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-cfl-8109u/igt@i915_selftest@live@migrate.html
- bat-adlp-4: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-adlp-4/igt@i915_selftest@live@migrate.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adlp-4/igt@i915_selftest@live@migrate.html
- fi-icl-u2: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-icl-u2/igt@i915_selftest@live@migrate.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-icl-u2/igt@i915_selftest@live@migrate.html
- fi-apl-guc: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-apl-guc/igt@i915_selftest@live@migrate.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-apl-guc/igt@i915_selftest@live@migrate.html
- fi-bdw-gvtdvm: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-bdw-gvtdvm/igt@i915_selftest@live@migrate.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bdw-gvtdvm/igt@i915_selftest@live@migrate.html
* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][31]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-icl-u2/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: NOTRUN -> [INCOMPLETE][32]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
- {bat-adln-1}: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-adln-1/igt@i915_selftest@live@migrate.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adln-1/igt@i915_selftest@live@migrate.html
- {bat-adlm-1}: [PASS][35] -> [INCOMPLETE][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-adlm-1/igt@i915_selftest@live@migrate.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adlm-1/igt@i915_selftest@live@migrate.html
- {bat-rplp-1}: [PASS][37] -> [INCOMPLETE][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-rplp-1/igt@i915_selftest@live@migrate.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-rplp-1/igt@i915_selftest@live@migrate.html
- {bat-atsm-1}: NOTRUN -> [INCOMPLETE][39]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-atsm-1/igt@i915_selftest@live@migrate.html
- {bat-dg2-9}: [PASS][40] -> [INCOMPLETE][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-dg2-9/igt@i915_selftest@live@migrate.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-dg2-9/igt@i915_selftest@live@migrate.html
- {bat-rpls-2}: NOTRUN -> [INCOMPLETE][42]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-rpls-2/igt@i915_selftest@live@migrate.html
- {bat-dg2-8}: [PASS][43] -> [INCOMPLETE][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-dg2-8/igt@i915_selftest@live@migrate.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-dg2-8/igt@i915_selftest@live@migrate.html
- {bat-jsl-1}: [PASS][45] -> [INCOMPLETE][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-jsl-1/igt@i915_selftest@live@migrate.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-jsl-1/igt@i915_selftest@live@migrate.html
- {bat-adlp-6}: [PASS][47] -> [INCOMPLETE][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/bat-adlp-6/igt@i915_selftest@live@migrate.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adlp-6/igt@i915_selftest@live@migrate.html
- {fi-ehl-2}: [PASS][49] -> [INCOMPLETE][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12409/fi-ehl-2/igt@i915_selftest@live@migrate.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-ehl-2/igt@i915_selftest@live@migrate.html
- {bat-adls-5}: NOTRUN -> [INCOMPLETE][51]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adls-5/igt@i915_selftest@live@migrate.html
Known issues
------------
Here are the changes found in Patchwork_111155v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][52] ([fdo#109271]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2190])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#4613]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_module_load@reload:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][55] ([i915#1982])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][56] ([i915#1886])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][57] ([i915#7363])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@i915_selftest@live@migrate.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +7 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@runner@aborted:
- fi-skl-6700k2: NOTRUN -> [FAIL][59] ([i915#4312])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-skl-6700k2/igt@runner@aborted.html
- fi-cfl-8109u: NOTRUN -> [FAIL][60] ([i915#4312])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-cfl-8109u/igt@runner@aborted.html
- bat-adlp-4: NOTRUN -> [FAIL][61] ([i915#4312])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-adlp-4/igt@runner@aborted.html
- fi-apl-guc: NOTRUN -> [FAIL][62] ([fdo#109271] / [i915#4312])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-apl-guc/igt@runner@aborted.html
- fi-glk-j4005: NOTRUN -> [FAIL][63] ([i915#4312])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-glk-j4005/igt@runner@aborted.html
- fi-rkl-guc: NOTRUN -> [FAIL][64] ([i915#4312])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-rkl-guc/igt@runner@aborted.html
- fi-skl-guc: NOTRUN -> [FAIL][65] ([i915#4312])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-skl-guc/igt@runner@aborted.html
- fi-kbl-soraka: NOTRUN -> [FAIL][66] ([i915#4312] / [i915#4991])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-soraka/igt@runner@aborted.html
- bat-dg1-6: NOTRUN -> [FAIL][67] ([i915#4312])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/bat-dg1-6/igt@runner@aborted.html
- fi-kbl-7567u: NOTRUN -> [FAIL][68] ([i915#4312])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-kbl-7567u/igt@runner@aborted.html
- fi-cfl-8700k: NOTRUN -> [FAIL][69] ([i915#4312])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-cfl-8700k/igt@runner@aborted.html
- fi-bsw-nick: NOTRUN -> [FAIL][70] ([fdo#109271] / [i915#4312])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bsw-nick/igt@runner@aborted.html
- fi-rkl-11600: NOTRUN -> [FAIL][71] ([i915#4312])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-rkl-11600/igt@runner@aborted.html
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][72] ([i915#4312])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bdw-gvtdvm/igt@runner@aborted.html
- fi-bsw-kefka: NOTRUN -> [FAIL][73] ([fdo#109271] / [i915#4312])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/fi-bsw-kefka/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7363]: https://gitlab.freedesktop.org/drm/intel/issues/7363
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12409 -> Patchwork_111155v1
CI-20190529: 20190529
CI_DRM_12409: ab70218208c05b2a68a1143438a56c3d494eb529 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7069: 40a2de5cc6a6b43af7da7905bfe1ede9d9a3200c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111155v1: ab70218208c05b2a68a1143438a56c3d494eb529 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
89b829c3e78e drm/i915/selftests: exercise emit_pte() with nearly full ring
d4a35532c6d1 drm/i915/migrate: Account for the reserved_space
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111155v1/index.html
[-- Attachment #2: Type: text/html, Size: 17310 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-21 23:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 16:54 [PATCH v3 1/2] drm/i915/migrate: Account for the reserved_space Matthew Auld
2022-11-21 16:54 ` [Intel-gfx] " Matthew Auld
2022-11-21 16:54 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/selftests: exercise emit_pte() with nearly full ring Matthew Auld
2022-11-21 22:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/i915/migrate: Account for the reserved_space Patchwork
2022-11-21 23:35 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.