All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: rawnand: orion: use   devm_platform_get_and_ioremap_resource()
@ 2022-11-22  1:33 ` ye.xingchen
  0 siblings, 0 replies; 4+ messages in thread
From: ye.xingchen @ 2022-11-22  1:33 UTC (permalink / raw)
  To: miquel.raynal; +Cc: richard, vigneshr, linux-mtd, linux-kernel, chi.minghao

From: Minghao Chi <chi.minghao@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/mtd/nand/raw/orion_nand.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c
index 1bfecf502216..00bd7be76e07 100644
--- a/drivers/mtd/nand/raw/orion_nand.c
+++ b/drivers/mtd/nand/raw/orion_nand.c
@@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	struct mtd_info *mtd;
 	struct nand_chip *nc;
 	struct orion_nand_data *board;
-	struct resource *res;
 	void __iomem *io_base;
 	int ret = 0;
 	u32 val = 0;
@@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	info->controller.ops = &orion_nand_ops;
 	nc->controller = &info->controller;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(&pdev->dev, res);
+	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] mtd: rawnand: orion: use   devm_platform_get_and_ioremap_resource()
@ 2022-11-22  1:33 ` ye.xingchen
  0 siblings, 0 replies; 4+ messages in thread
From: ye.xingchen @ 2022-11-22  1:33 UTC (permalink / raw)
  To: miquel.raynal; +Cc: richard, vigneshr, linux-mtd, linux-kernel, chi.minghao

From: Minghao Chi <chi.minghao@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/mtd/nand/raw/orion_nand.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c
index 1bfecf502216..00bd7be76e07 100644
--- a/drivers/mtd/nand/raw/orion_nand.c
+++ b/drivers/mtd/nand/raw/orion_nand.c
@@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	struct mtd_info *mtd;
 	struct nand_chip *nc;
 	struct orion_nand_data *board;
-	struct resource *res;
 	void __iomem *io_base;
 	int ret = 0;
 	u32 val = 0;
@@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	info->controller.ops = &orion_nand_ops;
 	nc->controller = &info->controller;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(&pdev->dev, res);
+	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);
-- 
2.25.1

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: rawnand: orion: use   devm_platform_get_and_ioremap_resource()
  2022-11-22  1:33 ` ye.xingchen
@ 2022-11-22 10:02   ` Miquel Raynal
  -1 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-11-22 10:02 UTC (permalink / raw)
  To: ye.xingchen; +Cc: richard, vigneshr, linux-mtd, linux-kernel, chi.minghao

Hello,

ye.xingchen@zte.com.cn wrote on Tue, 22 Nov 2022 09:33:27 +0800 (CST):

> From: Minghao Chi <chi.minghao@zte.com.cn>
> 

Double space in the subject

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/mtd/nand/raw/orion_nand.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c
> index 1bfecf502216..00bd7be76e07 100644
> --- a/drivers/mtd/nand/raw/orion_nand.c
> +++ b/drivers/mtd/nand/raw/orion_nand.c
> @@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  	struct mtd_info *mtd;
>  	struct nand_chip *nc;
>  	struct orion_nand_data *board;
> -	struct resource *res;
>  	void __iomem *io_base;
>  	int ret = 0;
>  	u32 val = 0;
> @@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  	info->controller.ops = &orion_nand_ops;
>  	nc->controller = &info->controller;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	io_base = devm_ioremap_resource(&pdev->dev, res);
> +	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

If we no longer use res, why not just devm_platform_ioremap_resource() ?

> 
>  	if (IS_ERR(io_base))
>  		return PTR_ERR(io_base);


Thanks,
Miquèl

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: rawnand: orion: use   devm_platform_get_and_ioremap_resource()
@ 2022-11-22 10:02   ` Miquel Raynal
  0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-11-22 10:02 UTC (permalink / raw)
  To: ye.xingchen; +Cc: richard, vigneshr, linux-mtd, linux-kernel, chi.minghao

Hello,

ye.xingchen@zte.com.cn wrote on Tue, 22 Nov 2022 09:33:27 +0800 (CST):

> From: Minghao Chi <chi.minghao@zte.com.cn>
> 

Double space in the subject

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/mtd/nand/raw/orion_nand.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/orion_nand.c b/drivers/mtd/nand/raw/orion_nand.c
> index 1bfecf502216..00bd7be76e07 100644
> --- a/drivers/mtd/nand/raw/orion_nand.c
> +++ b/drivers/mtd/nand/raw/orion_nand.c
> @@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  	struct mtd_info *mtd;
>  	struct nand_chip *nc;
>  	struct orion_nand_data *board;
> -	struct resource *res;
>  	void __iomem *io_base;
>  	int ret = 0;
>  	u32 val = 0;
> @@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  	info->controller.ops = &orion_nand_ops;
>  	nc->controller = &info->controller;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	io_base = devm_ioremap_resource(&pdev->dev, res);
> +	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

If we no longer use res, why not just devm_platform_ioremap_resource() ?

> 
>  	if (IS_ERR(io_base))
>  		return PTR_ERR(io_base);


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 10:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22  1:33 [PATCH] mtd: rawnand: orion: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-22  1:33 ` ye.xingchen
2022-11-22 10:02 ` Miquel Raynal
2022-11-22 10:02   ` Miquel Raynal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.