* [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575
@ 2022-11-22 16:05 Vincent Stehlé
2022-11-22 21:32 ` Thomas Petazzoni via buildroot
2022-11-26 18:25 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Vincent Stehlé @ 2022-11-22 16:05 UTC (permalink / raw)
To: buildroot; +Cc: Vincent Stehlé
The edk2 package can be configured for platform Arm Sgi575 but this does
not build correctly. Add the necessary definitions to fix the build.
Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
Cc: Dick Olsson <hi@senzilla.io>
---
Hi,
This is only build-tested.
Alternatively we could remove the BR2_TARGET_EDK2_PLATFORM_ARM_SGI575 from the
Config.in file completely if this is preferred. Just let me know and I will
send a patch.
Best regards,
Vincent.
boot/edk2/edk2.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/boot/edk2/edk2.mk b/boot/edk2/edk2.mk
index 5cbd9d152e7..7d8765c3108 100644
--- a/boot/edk2/edk2.mk
+++ b/boot/edk2/edk2.mk
@@ -75,6 +75,12 @@ EDK2_PACKAGE_NAME = ArmVirtPkg
EDK2_PLATFORM_NAME = ArmVirtQemuKernel
EDK2_BUILD_DIR = $(EDK2_PLATFORM_NAME)-$(EDK2_ARCH)
+else ifeq ($(BR2_TARGET_EDK2_PLATFORM_ARM_SGI575),y)
+EDK2_ARCH = AARCH64
+EDK2_PACKAGE_NAME = Platform/ARM/SgiPkg/Sgi575
+EDK2_PLATFORM_NAME = Sgi575
+EDK2_BUILD_DIR = $(EDK2_PLATFORM_NAME)
+
else ifeq ($(BR2_TARGET_EDK2_PLATFORM_ARM_VEXPRESS_FVP_AARCH64),y)
EDK2_ARCH = AARCH64
EDK2_PACKAGE_NAME = Platform/ARM/VExpressPkg
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575
2022-11-22 16:05 [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575 Vincent Stehlé
@ 2022-11-22 21:32 ` Thomas Petazzoni via buildroot
2022-11-26 18:25 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-11-22 21:32 UTC (permalink / raw)
To: Vincent Stehlé; +Cc: buildroot
On Tue, 22 Nov 2022 17:05:44 +0100
Vincent Stehlé <vincent.stehle@arm.com> wrote:
> The edk2 package can be configured for platform Arm Sgi575 but this does
> not build correctly. Add the necessary definitions to fix the build.
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> Cc: Dick Olsson <hi@senzilla.io>
> ---
Applied to master with an improved commit log that contains details
about the build failure.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575
2022-11-22 16:05 [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575 Vincent Stehlé
2022-11-22 21:32 ` Thomas Petazzoni via buildroot
@ 2022-11-26 18:25 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-11-26 18:25 UTC (permalink / raw)
To: Vincent Stehlé; +Cc: buildroot
>>>>> "Vincent" == Vincent Stehlé <vincent.stehle@arm.com> writes:
> The edk2 package can be configured for platform Arm Sgi575 but this does
> not build correctly. Add the necessary definitions to fix the build.
> Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> Cc: Dick Olsson <hi@senzilla.io>
Committed to 2022.08.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575
@ 2022-11-22 20:22 D. Olsson via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: D. Olsson via buildroot @ 2022-11-22 20:22 UTC (permalink / raw)
To: Vincent Stehlé; +Cc: buildroot
Hi Vincent,
> On 22 Nov 2022, at 18:15, Vincent Stehlé <vincent.stehle@arm.com> wrote:
>
> The edk2 package can be configured for platform Arm Sgi575 but this does
> not build correctly. Add the necessary definitions to fix the build.
Thanks for catching this!
I was using the Sgi575 target a bit for testing when building out this package early on. I must have missed the definitions when assembling the initial patchset.
> Alternatively we could remove the BR2_TARGET_EDK2_PLATFORM_ARM_SGI575 from the
> Config.in file completely if this is preferred. Just let me know and I will
> send a patch.
I think it should be kept. It's a great target for testing and emulation.
> Best regards,
> Vincent.
>
>
> boot/edk2/edk2.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/boot/edk2/edk2.mk b/boot/edk2/edk2.mk
> index 5cbd9d152e7..7d8765c3108 100644
> --- a/boot/edk2/edk2.mk
> +++ b/boot/edk2/edk2.mk
> @@ -75,6 +75,12 @@ EDK2_PACKAGE_NAME = ArmVirtPkg
> EDK2_PLATFORM_NAME = ArmVirtQemuKernel
> EDK2_BUILD_DIR = $(EDK2_PLATFORM_NAME)-$(EDK2_ARCH)
>
> +else ifeq ($(BR2_TARGET_EDK2_PLATFORM_ARM_SGI575),y)
> +EDK2_ARCH = AARCH64
> +EDK2_PACKAGE_NAME = Platform/ARM/SgiPkg/Sgi575
> +EDK2_PLATFORM_NAME = Sgi575
> +EDK2_BUILD_DIR = $(EDK2_PLATFORM_NAME)
> +
> else ifeq ($(BR2_TARGET_EDK2_PLATFORM_ARM_VEXPRESS_FVP_AARCH64),y)
> EDK2_ARCH = AARCH64
> EDK2_PACKAGE_NAME = Platform/ARM/VExpressPkg
> --
> 2.35.1
I won't be able to test this anytime soon. But at a glance the patch looks ok!
Cheers,
D. Olsson
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-26 18:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 16:05 [Buildroot] [PATCH] boot/edk2: fix the build for arm sgi575 Vincent Stehlé
2022-11-22 21:32 ` Thomas Petazzoni via buildroot
2022-11-26 18:25 ` Peter Korsgaard
2022-11-22 20:22 D. Olsson via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.