All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>,
	Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH 0/2] ASoC: wm_adsp: Report when a control write changes the value
Date: Wed, 23 Nov 2022 14:51:38 +0000	[thread overview]
Message-ID: <20221123145140.2784030-1-rf@opensource.cirrus.com> (raw)

Writing a firmware control should be returning 1 if the control value
changed, so these two patches add that.

Though this is an ALSA requirement it is also useful for non-ALSA clients
of cs_dsp to know if the control value changed, so the main handling is
implemented in cs_dsp. TLV controls are specifically an ALSA thing so they
are handled specially in wm_adsp.

Simon Trimmer (2):
  firmware: cs_dsp: cs_dsp_coeff_write_ctrl() should report changed
  ASoC: wm_adsp: Return whether changed when writing controls

 drivers/firmware/cirrus/cs_dsp.c | 17 ++++++++++++-----
 sound/soc/codecs/wm_adsp.c       | 26 +++++++++++++++++---------
 2 files changed, 29 insertions(+), 14 deletions(-)

-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] ASoC: wm_adsp: Report when a control write changes the value
Date: Wed, 23 Nov 2022 14:51:38 +0000	[thread overview]
Message-ID: <20221123145140.2784030-1-rf@opensource.cirrus.com> (raw)

Writing a firmware control should be returning 1 if the control value
changed, so these two patches add that.

Though this is an ALSA requirement it is also useful for non-ALSA clients
of cs_dsp to know if the control value changed, so the main handling is
implemented in cs_dsp. TLV controls are specifically an ALSA thing so they
are handled specially in wm_adsp.

Simon Trimmer (2):
  firmware: cs_dsp: cs_dsp_coeff_write_ctrl() should report changed
  ASoC: wm_adsp: Return whether changed when writing controls

 drivers/firmware/cirrus/cs_dsp.c | 17 ++++++++++++-----
 sound/soc/codecs/wm_adsp.c       | 26 +++++++++++++++++---------
 2 files changed, 29 insertions(+), 14 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-11-23 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 14:51 Richard Fitzgerald [this message]
2022-11-23 14:51 ` [PATCH 0/2] ASoC: wm_adsp: Report when a control write changes the value Richard Fitzgerald
2022-11-23 14:51 ` [PATCH 1/2] firmware: cs_dsp: cs_dsp_coeff_write_ctrl() should report changed Richard Fitzgerald
2022-11-23 14:51   ` Richard Fitzgerald
2022-11-23 14:51 ` [PATCH 2/2] ASoC: wm_adsp: Return whether changed when writing controls Richard Fitzgerald
2022-11-23 14:51   ` Richard Fitzgerald
2022-11-23 16:47   ` kernel test robot
2022-11-25 14:26 ` [PATCH 0/2] ASoC: wm_adsp: Report when a control write changes the value Mark Brown
2022-11-25 14:26   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123145140.2784030-1-rf@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.