[PATCH v2 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[PATCH v2 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Sriranjani P]

FSD has few system controller register blocks. This patch series intends to
add support of device node for system controller registers group that
resides in PERIC, FSYS0 and FSYS1 blocks of FSD SoC. As these will be used
by PCIE and EQoS module. Patches for adding support for PCIE and EQoS are
already under review at [1] and [2].

Also this patch series add required DT bindings for such system controller
of FSD SoC.

[1]: https://lkml.org/lkml/2022/11/21/463
[2]: https://lkml.org/lkml/2022/11/4/420

Changes since v1:
1. Fixed SoB in [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
found on FSD SoC.
2. Address review comments from Krzysztof on [PATCH 2/2] and aligned sysreg
node near to respective blocks sorted in order of unit address.

Sriranjani P (2):
  dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC
  arm64: dts: fsd: add sysreg device node

 Documentation/devicetree/bindings/mfd/syscon.yaml |  1 +
 arch/arm64/boot/dts/tesla/fsd.dtsi                | 15 +++++++++++++++
 2 files changed, 16 insertions(+)

-- 
2.17.1

[PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Sriranjani P]

Add compatible for Tesla SYSREG controllers found on FSD SoC.

Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 4e4baf53796d..8c3334999bec 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -69,6 +69,7 @@ properties:
               - samsung,exynos5433-sysreg
               - samsung,exynos850-sysreg
               - samsung,exynosautov9-sysreg
+              - tesla,fsd-sysreg
 
           - const: syscon
 
-- 
2.17.1

[PATCH v2 2/2] arm64: dts: fsd: add sysreg device node

[Sriranjani P]

Add SYSREG controller device node, which is available in PERIC, FSYS0 and
FSYS1 block of FSD SoC.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..76d08d9fa01d 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -492,6 +492,11 @@
 				"dout_cmu_peric_shared1div4_dmaclk";
 		};
 
+		sysreg_peric: system-controller@14030000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x14030000 0x0 0x1000>;
+		};
+
 		clock_fsys0: clock-controller@15010000 {
 			compatible = "tesla,fsd-clock-fsys0";
 			reg = <0x0 0x15010000 0x0 0x3000>;
@@ -506,6 +511,11 @@
 				"dout_cmu_fsys0_shared0div4";
 		};
 
+		sysreg_fsys0: system-controller@15030000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x15030000 0x0 0x1000>;
+		};
+
 		clock_fsys1: clock-controller@16810000 {
 			compatible = "tesla,fsd-clock-fsys1";
 			reg = <0x0 0x16810000 0x0 0x3000>;
@@ -518,6 +528,11 @@
 				"dout_cmu_fsys1_shared0div4";
 		};
 
+		sysreg_fsys1: system-controller@16830000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x16830000 0x0 0x1000>;
+		};
+
 		mdma0: dma-controller@10100000 {
 			compatible = "arm,pl330", "arm,primecell";
 			reg = <0x0 0x10100000 0x0 0x1000>;
-- 
2.17.1

Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Krzysztof Kozlowski]

On 25/11/2022 08:06, Sriranjani P wrote:
> Add compatible for Tesla SYSREG controllers found on FSD SoC.
> 
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---

Thank you for your patch. There is something to discuss/improve.

>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 4e4baf53796d..8c3334999bec 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
>                - samsung,exynos5433-sysreg
>                - samsung,exynos850-sysreg
>                - samsung,exynosautov9-sysreg
> +              - tesla,fsd-sysreg

I think we made mistake starting from 5433. Before (Exynos3/4/5) there
was only one block called actually SYSREG. For example on Exynos5433 we
have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
should have dedicated compatibles. The same for Tesla - please provide
dedicated compatibles per each block.

I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Krzysztof Kozlowski]

On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> On 25/11/2022 08:06, Sriranjani P wrote:
>> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>> ---
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 4e4baf53796d..8c3334999bec 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -69,6 +69,7 @@ properties:
>>                - samsung,exynos5433-sysreg
>>                - samsung,exynos850-sysreg
>>                - samsung,exynosautov9-sysreg
>> +              - tesla,fsd-sysreg
> 
> I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> was only one block called actually SYSREG. For example on Exynos5433 we
> have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> should have dedicated compatibles. The same for Tesla - please provide
> dedicated compatibles per each block.
> 
> I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.

To clarify - in case of Tesla, you do not need the fallbacks, so you
just add few of:
   - tesla,fsd-xxx-sysreg
within the enum.

For Exynos850 and Autov9, just like for Exynso5433, we should keep it
backwards compatible, so we need fallbacks.

Best regards,
Krzysztof

RE: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Sriranjani P]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 17:10
> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com; Sam Protsenko
> <semen.protsenko@linaro.org>; Chanho Park
> <chanho61.park@samsung.com>
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
> found on FSD SoC
> 
> On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> > On 25/11/2022 08:06, Sriranjani P wrote:
> >> Add compatible for Tesla SYSREG controllers found on FSD SoC.
> >>
> >> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> >> ---
> >
> > Thank you for your patch. There is something to discuss/improve.
> >
> >>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> index 4e4baf53796d..8c3334999bec 100644
> >> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> @@ -69,6 +69,7 @@ properties:
> >>                - samsung,exynos5433-sysreg
> >>                - samsung,exynos850-sysreg
> >>                - samsung,exynosautov9-sysreg
> >> +              - tesla,fsd-sysreg
> >
> > I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> > was only one block called actually SYSREG. For example on Exynos5433
> > we have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> > should have dedicated compatibles. The same for Tesla - please provide
> > dedicated compatibles per each block.
> >
> > I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.
> 
> To clarify - in case of Tesla, you do not need the fallbacks, so you just add few
> of:
>    - tesla,fsd-xxx-sysreg
> within the enum.

Thanks for improvement idea and clarification. I'll update accordingly in the
next version.

> 
> For Exynos850 and Autov9, just like for Exynso5433, we should keep it
> backwards compatible, so we need fallbacks.

I will update for Exynos850 and Autov9 as like Exynos5433 and post the patch.

> 
> Best regards,
> Krzysztof
Thank you.