* =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?=
@ 2022-11-24 14:17 ` =?gb18030?B?zfW66bvU?=
0 siblings, 0 replies; 8+ messages in thread
From: =?gb18030?B?zfW66bvU?= @ 2022-11-24 14:17 UTC (permalink / raw)
To: =?gb18030?B?U3VkZWVwIEhvbGxh?=
Cc: =?gb18030?B?TWFyayBSdXRsYW5k?=,
=?gb18030?B?Q3Jpc3RpYW4gTWFydXNz?=,
=?gb18030?B?U3VkZWVwIEhvbGxh?=, =?gb18030?B?SmFzc2kgQnJhcg==?=,
=?gb18030?B?bGludXgtYXJtLWtlcm5lbA==?=,
=?gb18030?B?bGludXgta2VybmVs?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 666 bytes --]
Thanks!
The uefi firmware was built include ACPI/AML, but current kernel code is not able to extract the info, the ACPI/AML driver of kernel is not enough for majority of devices , but fdt driver is. I think there's a lot of work to support more acpi driver.
Best Regards!
Wang Honghui
---ÔʼÓʼþ---
·¢¼þÈË:"Sudeep Holla"<sudeep.holla@arm.com>
·¢ËÍʱ¼ä:2022Äê11ÔÂ24ÈÕ(ÐÇÆÚËÄ) ÍíÉÏ9:46
ÊÕ¼þÈË:"Íõºé»Ô"<honghui.wang@ucas.com.cn>;
Ö÷Ìâ: [PATCH 3/3] arm_scpi: modify to support acpi
On T
^ permalink raw reply [flat|nested] 8+ messages in thread
* =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?=
@ 2022-11-24 14:17 ` =?gb18030?B?zfW66bvU?=
0 siblings, 0 replies; 8+ messages in thread
From: =?gb18030?B?zfW66bvU?= @ 2022-11-24 14:17 UTC (permalink / raw)
To: =?gb18030?B?U3VkZWVwIEhvbGxh?=
Cc: =?gb18030?B?TWFyayBSdXRsYW5k?=,
=?gb18030?B?Q3Jpc3RpYW4gTWFydXNz?=,
=?gb18030?B?U3VkZWVwIEhvbGxh?=, =?gb18030?B?SmFzc2kgQnJhcg==?=,
=?gb18030?B?bGludXgtYXJtLWtlcm5lbA==?=,
=?gb18030?B?bGludXgta2VybmVs?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 843 bytes --]
Thanks!
The uefi firmware was built include ACPI/AML, but current kernel code is not able to extract the info, the ACPI/AML driver of kernel is not enough for majority of devices , but fdt driver is. I think there's a lot of work to support more acpi driver.
Best Regards!
Wang Honghui
---ÔʼÓʼþ---
·¢¼þÈË:"Sudeep Holla"<sudeep.holla@arm.com>
·¢ËÍʱ¼ä:2022Äê11ÔÂ24ÈÕ(ÐÇÆÚËÄ) ÍíÉÏ9:46
ÊÕ¼þÈË:"Íõºé»Ô"<honghui.wang@ucas.com.cn>;
Ö÷Ìâ: [PATCH 3/3] arm_scpi: modify to support acpi
On T
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
2022-11-24 14:17 ` =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?= =?gb18030?B?zfW66bvU?=
@ 2022-11-25 1:38 ` Hanjun Guo
-1 siblings, 0 replies; 8+ messages in thread
From: Hanjun Guo @ 2022-11-25 1:38 UTC (permalink / raw)
To: 王洪辉, Sudeep Holla
Cc: Mark Rutland, Cristian Maruss, Jassi Brar, linux-arm-kernel,
linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030"; Format="flowed", Size: 651 bytes --]
Hi Honghui,
On 2022/11/24 22:17, Íõºé»Ô wrote:
> Thanks!
>
> The uefi firmware was built include ACPI/AML, but current kernel code is not able to extract the info, the ACPI/AML driver of kernel is not enough for majority of devices , but fdt driver is. I think there's a lot of work to support more acpi driver.
I think the firmware did the wrong thing about SCPI support,
please take a look at ACPI 6.5, chapter 14 Platform Communications
Channel (PCC).
Thanks
Hanjun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
@ 2022-11-25 1:38 ` Hanjun Guo
0 siblings, 0 replies; 8+ messages in thread
From: Hanjun Guo @ 2022-11-25 1:38 UTC (permalink / raw)
To: 王洪辉, Sudeep Holla
Cc: Mark Rutland, Cristian Maruss, Jassi Brar, linux-arm-kernel,
linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030"; format=flowed, Size: 474 bytes --]
Hi Honghui,
On 2022/11/24 22:17, Íõºé»Ô wrote:
> Thanks!
>
> The uefi firmware was built include ACPI/AML, but current kernel code is not able to extract the info, the ACPI/AML driver of kernel is not enough for majority of devices , but fdt driver is. I think there's a lot of work to support more acpi driver.
I think the firmware did the wrong thing about SCPI support,
please take a look at ACPI 6.5, chapter 14 Platform Communications
Channel (PCC).
Thanks
Hanjun
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
2022-11-25 1:38 ` Hanjun Guo
@ 2022-11-25 9:54 ` Sudeep Holla
-1 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2022-11-25 9:54 UTC (permalink / raw)
To: 王洪辉
Cc: Hanjun Guo, Mark Rutland, Sudeep Holla, Cristian Maruss,
Jassi Brar, linux-arm-kernel, linux-kernel
On Fri, Nov 25, 2022 at 09:38:42AM +0800, Hanjun Guo wrote:
> Hi Honghui,
>
> On 2022/11/24 22:17, 锟斤拷锟斤拷锟? wrote:
> > Thanks!
> >
> > The uefi firmware was built include ACPI/AML, but current kernel code is
> > not able to extract the info, the ACPI/AML driver of kernel is not enough
> > for majority of devices , but fdt driver is. I think there's a lot of
> > work to support more acpi driver.
>
> I think the firmware did the wrong thing about SCPI support,
> please take a look at ACPI 6.5, chapter 14 Platform Communications
> Channel (PCC).
>
Thanks Hanjun for pin pointing the exact references in the ACPI spec.
Hi Wang,
You seemed to be posting random patches to add SCPI support in ACPI.
You will get a NACK on all unless you explore PCC and PCC OpRegion in
ACPI and update your firmware to make it work on your platform.
You had sent a patch updating the mailbox driver which is not present
in the upstream. You must not need that driver when you use PCCT in
the ACPI firmware, so please drop the driver and any changes to that
as well. Without seeing the actual driver you are using with SCPI, I
can't help much on how to use it with PCC. Please refer chapter 14 as
Hanjun mention and check how to write one to your platform. Think
PCCT as mailbox node equivalent in DT and you *must not* just add similar
node in your ACPI DSDT with some custom HID/CID.
Hope this helps and gives you better idea on the suggestions made so far.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
@ 2022-11-25 9:54 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2022-11-25 9:54 UTC (permalink / raw)
To: 王洪辉
Cc: Hanjun Guo, Mark Rutland, Sudeep Holla, Cristian Maruss,
Jassi Brar, linux-arm-kernel, linux-kernel
On Fri, Nov 25, 2022 at 09:38:42AM +0800, Hanjun Guo wrote:
> Hi Honghui,
>
> On 2022/11/24 22:17, 锟斤拷锟斤拷锟? wrote:
> > Thanks!
> >
> > The uefi firmware was built include ACPI/AML, but current kernel code is
> > not able to extract the info, the ACPI/AML driver of kernel is not enough
> > for majority of devices , but fdt driver is. I think there's a lot of
> > work to support more acpi driver.
>
> I think the firmware did the wrong thing about SCPI support,
> please take a look at ACPI 6.5, chapter 14 Platform Communications
> Channel (PCC).
>
Thanks Hanjun for pin pointing the exact references in the ACPI spec.
Hi Wang,
You seemed to be posting random patches to add SCPI support in ACPI.
You will get a NACK on all unless you explore PCC and PCC OpRegion in
ACPI and update your firmware to make it work on your platform.
You had sent a patch updating the mailbox driver which is not present
in the upstream. You must not need that driver when you use PCCT in
the ACPI firmware, so please drop the driver and any changes to that
as well. Without seeing the actual driver you are using with SCPI, I
can't help much on how to use it with PCC. Please refer chapter 14 as
Hanjun mention and check how to write one to your platform. Think
PCCT as mailbox node equivalent in DT and you *must not* just add similar
node in your ACPI DSDT with some custom HID/CID.
Hope this helps and gives you better idea on the suggestions made so far.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
[not found] <tencent_6578975367ED7DB20B7903C3@qq.com>
@ 2022-11-24 11:57 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2022-11-24 11:57 UTC (permalink / raw)
To: 王洪辉
Cc: Cristian Maruss, Jassi Brar, linux-arm-kernel, linux-kernel
Hi Wang,
Please use text for your emails. I think it is html and I can't read it.
On Thu, Nov 24, 2022 at 07:17:32PM +0800, 王洪辉 wrote:
> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU temp & freq, This patch is for the case, I had test ok on Phytium FT2000/4 plantform. And please append Patch V2 3/3.
>
> ---原始邮件---
> 发件人:"Sudeep Holla"<sudeep.holla@arm.com>
> 发送时间:2022年11月24日(星期四) 晚上7:10
> 收件人:"Wang Honghui"<honghui.wang@ucas.com.cn>;
> 主题: [PATCH 3/3] arm_scpi: modify to support acpi
> Hi W
> ------------------ Original ------------------
> From: "Sudeep Holla"<sudeep.holla@arm.com>
> Date: Thu, Nov 24, 2022 07:10 PM
> To: "Wang Honghui"<honghui.wang@ucas.com.cn>;
> Cc: "Cristian Maruss"<cristian.marussi@arm.com>;"Jassi Brar"<jassisinghbrar@gmail.com>;"Sudeep Holla"<sudeep.holla@arm.com>;"linux-arm-kernel"<linux-arm-kernel@lists.infradead.org>;"linux-kernel"<linux-kernel@vger.kernel.org>;
> Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Doing %s/ / /g gave me:
> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU
> temp & freq, This patch is for the case, I had test ok on Phytium
> FT2000/4 plantform. And please append Patch V2 3/3.
Let me repeat. You must use PCC driver without any phytium ft2000/4 platform
code. All platform specific code and SCPI protocol must be hidden/abstracted
in ACPI AML.
Your changes are not acceptable for upstream. No change will be allowed in
SCPI for ACPI as it needs to go in the firmware tables.
Also I noticed drivers/mailbox/phytium_mailbox.c doesn't exist. So this patch
is wrong in so many ways. Please check on how to represent phytium_mailbox
hardware using ACPI PCC and add AML code that uses SCPI to achieve whatever
you want. You may want to check on how to use PCC OpRegion as well in ACPI.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi
@ 2022-11-24 11:57 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2022-11-24 11:57 UTC (permalink / raw)
To: 王洪辉
Cc: Cristian Maruss, Jassi Brar, linux-arm-kernel, linux-kernel
Hi Wang,
Please use text for your emails. I think it is html and I can't read it.
On Thu, Nov 24, 2022 at 07:17:32PM +0800, 王洪辉 wrote:
> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU temp & freq, This patch is for the case, I had test ok on Phytium FT2000/4 plantform. And please append Patch V2 3/3.
>
> ---原始邮件---
> 发件人:"Sudeep Holla"<sudeep.holla@arm.com>
> 发送时间:2022年11月24日(星期四) 晚上7:10
> 收件人:"Wang Honghui"<honghui.wang@ucas.com.cn>;
> 主题: [PATCH 3/3] arm_scpi: modify to support acpi
> Hi W
> ------------------ Original ------------------
> From: "Sudeep Holla"<sudeep.holla@arm.com>
> Date: Thu, Nov 24, 2022 07:10 PM
> To: "Wang Honghui"<honghui.wang@ucas.com.cn>;
> Cc: "Cristian Maruss"<cristian.marussi@arm.com>;"Jassi Brar"<jassisinghbrar@gmail.com>;"Sudeep Holla"<sudeep.holla@arm.com>;"linux-arm-kernel"<linux-arm-kernel@lists.infradead.org>;"linux-kernel"<linux-kernel@vger.kernel.org>;
> Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Doing %s/ / /g gave me:
> For ARM64, If boot from uefi, SCPI driver should support ACPI to show CPU
> temp & freq, This patch is for the case, I had test ok on Phytium
> FT2000/4 plantform. And please append Patch V2 3/3.
Let me repeat. You must use PCC driver without any phytium ft2000/4 platform
code. All platform specific code and SCPI protocol must be hidden/abstracted
in ACPI AML.
Your changes are not acceptable for upstream. No change will be allowed in
SCPI for ACPI as it needs to go in the firmware tables.
Also I noticed drivers/mailbox/phytium_mailbox.c doesn't exist. So this patch
is wrong in so many ways. Please check on how to represent phytium_mailbox
hardware using ACPI PCC and add AML code that uses SCPI to achieve whatever
you want. You may want to check on how to use PCC OpRegion as well in ACPI.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-25 10:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 14:17 =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?= =?gb18030?B?zfW66bvU?=
2022-11-24 14:17 ` =?gb18030?B?UmWjulJlOiBbUEFUQ0ggMy8zXSBhcm1fc2NwaTogbW9kaWZ5IHRvIHN1cHBvcnQgYWNwaQ==?= =?gb18030?B?zfW66bvU?=
2022-11-25 1:38 ` Re：Re: [PATCH 3/3] arm_scpi: modify to support acpi Hanjun Guo
2022-11-25 1:38 ` Hanjun Guo
2022-11-25 9:54 ` Sudeep Holla
2022-11-25 9:54 ` Sudeep Holla
[not found] <tencent_6578975367ED7DB20B7903C3@qq.com>
2022-11-24 11:57 ` Sudeep Holla
2022-11-24 11:57 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.