* [chrome-os:chromeos-5.15 21/58] drivers/thunderbolt/ctl.c:165:22: warning: Uninitialized variables: iter.kref, iter.ctl, iter.request, iter.request_size, iter.request_type, iter.response, iter.response_size, iter.response_type, iter.npackets, iter.match, iter.copy, iter.callback, iter.c...
@ 2022-11-27 6:38 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-11-27 6:38 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/thunderbolt/ctl.c:165:22: warning: Uninitialized variables: iter.kref, iter.ctl, iter.request, iter.request_size, iter.request_type, iter.response, iter.response_size, iter.response_type, iter.npackets, iter.match, iter.copy, iter.callback, iter.callback_data, iter.flags, iter.work, iter.result, iter.list [uninitvar]"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com
TO: Guenter Roeck <groeck@google.com>
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.15
head: 09eeb75bf6b178e4d1263e53e4726b8ce027a596
commit: efc6f20079bd5596c6dcc4211fdbd91f57904742 [21/58] UPSTREAM: thunderbolt: Replace usage of found with dedicated list iterator variable
:::::: branch date: 31 hours ago
:::::: commit date: 3 days ago
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
# apt-get install cppcheck
git checkout efc6f20079bd5596c6dcc4211fdbd91f57904742
cppcheck --quiet --enable=style,performance,portability --template=gcc FILE
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/thunderbolt/eeprom.c:200:23: warning: Parameter 'data' can be declared as pointer to const [constParameter]
static u8 tb_crc8(u8 *data, int len)
^
--
>> drivers/thunderbolt/ctl.c:165:22: warning: Uninitialized variables: iter.kref, iter.ctl, iter.request, iter.request_size, iter.request_type, iter.response, iter.response_size, iter.response_type, iter.npackets, iter.match, iter.copy, iter.callback, iter.callback_data, iter.flags, iter.work, iter.result, iter.list [uninitvar]
tb_cfg_request_get(iter);
^
vim +165 drivers/thunderbolt/ctl.c
d7f781bfdbf4eb Mika Westerberg 2017-06-06 157
d7f781bfdbf4eb Mika Westerberg 2017-06-06 158 static struct tb_cfg_request *
d7f781bfdbf4eb Mika Westerberg 2017-06-06 159 tb_cfg_request_find(struct tb_ctl *ctl, struct ctl_pkg *pkg)
d7f781bfdbf4eb Mika Westerberg 2017-06-06 160 {
efc6f20079bd55 Jakob Koschel 2022-03-24 161 struct tb_cfg_request *req = NULL, *iter;
d7f781bfdbf4eb Mika Westerberg 2017-06-06 162
d7f781bfdbf4eb Mika Westerberg 2017-06-06 163 mutex_lock(&pkg->ctl->request_queue_lock);
efc6f20079bd55 Jakob Koschel 2022-03-24 164 list_for_each_entry(iter, &pkg->ctl->request_queue, list) {
efc6f20079bd55 Jakob Koschel 2022-03-24 @165 tb_cfg_request_get(iter);
efc6f20079bd55 Jakob Koschel 2022-03-24 166 if (iter->match(iter, pkg)) {
efc6f20079bd55 Jakob Koschel 2022-03-24 167 req = iter;
d7f781bfdbf4eb Mika Westerberg 2017-06-06 168 break;
d7f781bfdbf4eb Mika Westerberg 2017-06-06 169 }
efc6f20079bd55 Jakob Koschel 2022-03-24 170 tb_cfg_request_put(iter);
d7f781bfdbf4eb Mika Westerberg 2017-06-06 171 }
d7f781bfdbf4eb Mika Westerberg 2017-06-06 172 mutex_unlock(&pkg->ctl->request_queue_lock);
d7f781bfdbf4eb Mika Westerberg 2017-06-06 173
efc6f20079bd55 Jakob Koschel 2022-03-24 174 return req;
d7f781bfdbf4eb Mika Westerberg 2017-06-06 175 }
d7f781bfdbf4eb Mika Westerberg 2017-06-06 176
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-27 6:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 6:38 [chrome-os:chromeos-5.15 21/58] drivers/thunderbolt/ctl.c:165:22: warning: Uninitialized variables: iter.kref, iter.ctl, iter.request, iter.request_size, iter.request_type, iter.response, iter.response_size, iter.response_type, iter.npackets, iter.match, iter.copy, iter.callback, iter.c kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.