From: Rob Herring <robh@kernel.org> To: Tony Lindgren <tony@atomide.com> Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org, "Thierry Reding" <thierry.reding@gmail.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Nishanth Menon" <nm@ti.com>, "Vignesh Raghavendra" <vigneshr@ti.com> Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Date: Sun, 27 Nov 2022 12:22:32 -0600 [thread overview] Message-ID: <20221127182232.GA128974-robh@kernel.org> (raw) In-Reply-To: <Y33ErrigR4II6EYH@atomide.com> On Wed, Nov 23, 2022 at 08:58:54AM +0200, Tony Lindgren wrote: > * Rob Herring <robh@kernel.org> [221123 02:31]: > > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote: > > > Let's allow node numbering in decimal format too. > > > > > > Simple human-readable increments/IDs are usually decimal, hex is only for > > > addresses as noted by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>. > > > > > > Let's use an improved match suggested by Krzysztof Kozlowski > > > <krzysztof.kozlowski@linaro.org> and improved a bit by Uwe Kleine-König > > > <u.kleine-koenig@pengutronix.de>. > > > > > > Cc: linux-pwm@vger.kernel.org > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > > > > Changes since v2: > > > > > > - Use pattern suggested by Krzysztof and Uwe > > > > > > Changes since v1: > > > > > > - New patch added to deal with pwm-omap-dmtimer binding > > > > > > --- > > > Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > @@ -13,7 +13,7 @@ select: false > > > > > > properties: > > > $nodename: > > > - pattern: "^pwm(@.*|-[0-9a-f])*$" > > > + pattern: "^pwm(@.+|-[0-9a-f]+)?$" > > > > So now pwm-10 could be either? > > Yes. > > > I'm fine with decimal, but can we do that everywhere we do this -N > > naming? > > Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'? No, I mean for all cases of <nodename>-N, can be we consistent. Either we use hex or we use decimal. > > These can be found with: > > $ find Documentation/devicetree/bindings/ -name \*.yaml | \ > xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Not quite. It's just cases of '-N': $ find Documentation/devicetree/bindings/ -name \*.yaml | xargs grep pattern: | grep '\-\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Documentation/devicetree/bindings/phy/intel,combo-phy.yaml: pattern: "combophy(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/pwm/pwm.yaml: pattern: "^pwm(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml: pattern: "^timestamp(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/watchdog/watchdog.yaml: pattern: "^watchdog(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/spi/spi-controller.yaml: pattern: "^spi(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/rtc/rtc.yaml: pattern: "^rtc(@.*|-[0-9a-f])*$" And there's probably some more in dtschema. > > Not sure if some of these need to intentionally limit the node numbering > to 15. No, I think it was all just cases of 15 should be enough for anyone. > > If you have some other criteria in mind, let me know :) If the numbering is hex, then it is as you have it. (Though we can't enforce that. If it is decimal, then the regex should be ([0-9]|[1-9][0-9]+). Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Tony Lindgren <tony@atomide.com> Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org, "Thierry Reding" <thierry.reding@gmail.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Nishanth Menon" <nm@ti.com>, "Vignesh Raghavendra" <vigneshr@ti.com> Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Date: Sun, 27 Nov 2022 12:22:32 -0600 [thread overview] Message-ID: <20221127182232.GA128974-robh@kernel.org> (raw) In-Reply-To: <Y33ErrigR4II6EYH@atomide.com> On Wed, Nov 23, 2022 at 08:58:54AM +0200, Tony Lindgren wrote: > * Rob Herring <robh@kernel.org> [221123 02:31]: > > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote: > > > Let's allow node numbering in decimal format too. > > > > > > Simple human-readable increments/IDs are usually decimal, hex is only for > > > addresses as noted by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>. > > > > > > Let's use an improved match suggested by Krzysztof Kozlowski > > > <krzysztof.kozlowski@linaro.org> and improved a bit by Uwe Kleine-König > > > <u.kleine-koenig@pengutronix.de>. > > > > > > Cc: linux-pwm@vger.kernel.org > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > > > > Changes since v2: > > > > > > - Use pattern suggested by Krzysztof and Uwe > > > > > > Changes since v1: > > > > > > - New patch added to deal with pwm-omap-dmtimer binding > > > > > > --- > > > Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > @@ -13,7 +13,7 @@ select: false > > > > > > properties: > > > $nodename: > > > - pattern: "^pwm(@.*|-[0-9a-f])*$" > > > + pattern: "^pwm(@.+|-[0-9a-f]+)?$" > > > > So now pwm-10 could be either? > > Yes. > > > I'm fine with decimal, but can we do that everywhere we do this -N > > naming? > > Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'? No, I mean for all cases of <nodename>-N, can be we consistent. Either we use hex or we use decimal. > > These can be found with: > > $ find Documentation/devicetree/bindings/ -name \*.yaml | \ > xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Not quite. It's just cases of '-N': $ find Documentation/devicetree/bindings/ -name \*.yaml | xargs grep pattern: | grep '\-\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Documentation/devicetree/bindings/phy/intel,combo-phy.yaml: pattern: "combophy(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/pwm/pwm.yaml: pattern: "^pwm(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml: pattern: "^timestamp(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/watchdog/watchdog.yaml: pattern: "^watchdog(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/spi/spi-controller.yaml: pattern: "^spi(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/rtc/rtc.yaml: pattern: "^rtc(@.*|-[0-9a-f])*$" And there's probably some more in dtschema. > > Not sure if some of these need to intentionally limit the node numbering > to 15. No, I think it was all just cases of 15 should be enough for anyone. > > If you have some other criteria in mind, let me know :) If the numbering is hex, then it is as you have it. (Though we can't enforce that. If it is decimal, then the regex should be ([0-9]|[1-9][0-9]+). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-27 18:22 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-22 12:32 [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Tony Lindgren 2022-11-22 12:32 ` Tony Lindgren 2022-11-22 12:32 ` [PATCH v3 2/2] dt-bindings: pwm: ti,pwm-omap-dmtimer: Update binding for yaml Tony Lindgren 2022-11-22 12:32 ` Tony Lindgren 2022-11-22 12:49 ` [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Krzysztof Kozlowski 2022-11-22 12:49 ` Krzysztof Kozlowski 2022-11-22 13:38 ` Uwe Kleine-König 2022-11-22 13:38 ` Uwe Kleine-König 2022-11-22 13:41 ` Tony Lindgren 2022-11-22 13:41 ` Tony Lindgren 2022-11-22 20:26 ` Uwe Kleine-König 2022-11-22 20:26 ` Uwe Kleine-König 2022-11-23 2:38 ` Rob Herring 2022-11-23 2:38 ` Rob Herring 2022-11-23 2:41 ` Rob Herring 2022-11-23 2:41 ` Rob Herring 2022-11-23 6:58 ` Tony Lindgren 2022-11-23 6:58 ` Tony Lindgren 2022-11-27 18:22 ` Rob Herring [this message] 2022-11-27 18:22 ` Rob Herring 2023-01-13 7:06 ` Tony Lindgren 2023-01-13 7:06 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221127182232.GA128974-robh@kernel.org \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=nm@ti.com \ --cc=thierry.reding@gmail.com \ --cc=tony@atomide.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.