All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name
@ 2022-11-28  5:53 Samuel Holland
  2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Samuel Holland @ 2022-11-28  5:53 UTC (permalink / raw)
  To: Lukasz Majewski, Sean Anderson; +Cc: Samuel Holland, u-boot

This allows devm_clock_get(dev, NULL) to work and get the first clock,
which is common in code ported from Linux.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/clk/clk-uclass.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
index 2f9635524cf..bfacafb2eef 100644
--- a/drivers/clk/clk-uclass.c
+++ b/drivers/clk/clk-uclass.c
@@ -399,13 +399,14 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
 
 int clk_get_by_name_nodev(ofnode node, const char *name, struct clk *clk)
 {
-	int index;
+	int index = 0;
 
 	debug("%s(node=%p, name=%s, clk=%p)\n", __func__,
 		ofnode_get_name(node), name, clk);
 	clk->dev = NULL;
 
-	index = ofnode_stringlist_search(node, "clock-names", name);
+	if (name)
+		index = ofnode_stringlist_search(node, "clock-names", name);
 	if (index < 0) {
 		debug("fdt_stringlist_search() failed: %d\n", index);
 		return index;
-- 
2.37.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] reset: Allow reset_get_by_name() with NULL name
  2022-11-28  5:53 [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name Samuel Holland
@ 2022-11-28  5:53 ` Samuel Holland
  2023-01-04 17:24   ` Sean Anderson
  2023-01-04 20:01   ` Simon Glass
  2023-01-04 17:23 ` [PATCH 1/2] clk: Allow clk_get_by_name() " Sean Anderson
  2023-01-04 20:01 ` Simon Glass
  2 siblings, 2 replies; 6+ messages in thread
From: Samuel Holland @ 2022-11-28  5:53 UTC (permalink / raw)
  To: Lukasz Majewski, Sean Anderson
  Cc: Samuel Holland, u-boot, Alexander Dahl, Marek Vasut, Simon Glass

This allows devm_reset_control_get(dev, NULL) to work and get the first
reset control, which is common in code ported from Linux.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/reset/reset-uclass.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
index bcef46039c2..a26c623a77e 100644
--- a/drivers/reset/reset-uclass.c
+++ b/drivers/reset/reset-uclass.c
@@ -147,13 +147,14 @@ int reset_get_bulk(struct udevice *dev, struct reset_ctl_bulk *bulk)
 int reset_get_by_name(struct udevice *dev, const char *name,
 		     struct reset_ctl *reset_ctl)
 {
-	int index;
+	int index = 0;
 
 	debug("%s(dev=%p, name=%s, reset_ctl=%p)\n", __func__, dev, name,
 	      reset_ctl);
 	reset_ctl->dev = NULL;
 
-	index = dev_read_stringlist_search(dev, "reset-names", name);
+	if (name)
+		index = dev_read_stringlist_search(dev, "reset-names", name);
 	if (index < 0) {
 		debug("fdt_stringlist_search() failed: %d\n", index);
 		return index;
-- 
2.37.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name
  2022-11-28  5:53 [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name Samuel Holland
  2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
@ 2023-01-04 17:23 ` Sean Anderson
  2023-01-04 20:01 ` Simon Glass
  2 siblings, 0 replies; 6+ messages in thread
From: Sean Anderson @ 2023-01-04 17:23 UTC (permalink / raw)
  To: Samuel Holland, Lukasz Majewski; +Cc: u-boot

On 11/28/22 00:53, Samuel Holland wrote:
> This allows devm_clock_get(dev, NULL) to work and get the first clock,

nit: devm_clk_get

> which is common in code ported from Linux.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>   drivers/clk/clk-uclass.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 2f9635524cf..bfacafb2eef 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -399,13 +399,14 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
>   
>   int clk_get_by_name_nodev(ofnode node, const char *name, struct clk *clk)
>   {
> -	int index;
> +	int index = 0;
>   
>   	debug("%s(node=%p, name=%s, clk=%p)\n", __func__,
>   		ofnode_get_name(node), name, clk);
>   	clk->dev = NULL;
>   
> -	index = ofnode_stringlist_search(node, "clock-names", name);
> +	if (name)
> +		index = ofnode_stringlist_search(node, "clock-names", name);
>   	if (index < 0) {
>   		debug("fdt_stringlist_search() failed: %d\n", index);
>   		return index;

Reviewed-by: Sean Anderson <seanga2@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] reset: Allow reset_get_by_name() with NULL name
  2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
@ 2023-01-04 17:24   ` Sean Anderson
  2023-01-04 20:01   ` Simon Glass
  1 sibling, 0 replies; 6+ messages in thread
From: Sean Anderson @ 2023-01-04 17:24 UTC (permalink / raw)
  To: Samuel Holland, Lukasz Majewski
  Cc: u-boot, Alexander Dahl, Marek Vasut, Simon Glass

On 11/28/22 00:53, Samuel Holland wrote:
> This allows devm_reset_control_get(dev, NULL) to work and get the first
> reset control, which is common in code ported from Linux.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>   drivers/reset/reset-uclass.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
> index bcef46039c2..a26c623a77e 100644
> --- a/drivers/reset/reset-uclass.c
> +++ b/drivers/reset/reset-uclass.c
> @@ -147,13 +147,14 @@ int reset_get_bulk(struct udevice *dev, struct reset_ctl_bulk *bulk)
>   int reset_get_by_name(struct udevice *dev, const char *name,
>   		     struct reset_ctl *reset_ctl)
>   {
> -	int index;
> +	int index = 0;
>   
>   	debug("%s(dev=%p, name=%s, reset_ctl=%p)\n", __func__, dev, name,
>   	      reset_ctl);
>   	reset_ctl->dev = NULL;
>   
> -	index = dev_read_stringlist_search(dev, "reset-names", name);
> +	if (name)
> +		index = dev_read_stringlist_search(dev, "reset-names", name);
>   	if (index < 0) {
>   		debug("fdt_stringlist_search() failed: %d\n", index);
>   		return index;

Reviewed-by: Sean Anderson <seanga2@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] reset: Allow reset_get_by_name() with NULL name
  2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
  2023-01-04 17:24   ` Sean Anderson
@ 2023-01-04 20:01   ` Simon Glass
  1 sibling, 0 replies; 6+ messages in thread
From: Simon Glass @ 2023-01-04 20:01 UTC (permalink / raw)
  To: Samuel Holland
  Cc: Lukasz Majewski, Sean Anderson, u-boot, Alexander Dahl, Marek Vasut

Hi Samuel,

On Sun, 27 Nov 2022 at 22:54, Samuel Holland <samuel@sholland.org> wrote:
>
> This allows devm_reset_control_get(dev, NULL) to work and get the first
> reset control, which is common in code ported from Linux.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
>  drivers/reset/reset-uclass.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
> index bcef46039c2..a26c623a77e 100644
> --- a/drivers/reset/reset-uclass.c
> +++ b/drivers/reset/reset-uclass.c
> @@ -147,13 +147,14 @@ int reset_get_bulk(struct udevice *dev, struct reset_ctl_bulk *bulk)
>  int reset_get_by_name(struct udevice *dev, const char *name,
>                      struct reset_ctl *reset_ctl)
>  {
> -       int index;
> +       int index = 0;
>
>         debug("%s(dev=%p, name=%s, reset_ctl=%p)\n", __func__, dev, name,
>               reset_ctl);
>         reset_ctl->dev = NULL;
>
> -       index = dev_read_stringlist_search(dev, "reset-names", name);
> +       if (name)
> +               index = dev_read_stringlist_search(dev, "reset-names", name);
>         if (index < 0) {
>                 debug("fdt_stringlist_search() failed: %d\n", index);
>                 return index;

The above three lines should only be used when name is NULL.

> --
> 2.37.4
>

Please update the function comment in the header file and add a test
for this to test/dm/reset.c

Regards,
Simon

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name
  2022-11-28  5:53 [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name Samuel Holland
  2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
  2023-01-04 17:23 ` [PATCH 1/2] clk: Allow clk_get_by_name() " Sean Anderson
@ 2023-01-04 20:01 ` Simon Glass
  2 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2023-01-04 20:01 UTC (permalink / raw)
  To: Samuel Holland; +Cc: Lukasz Majewski, Sean Anderson, u-boot

Hi Samuel,

On Sun, 27 Nov 2022 at 22:54, Samuel Holland <samuel@sholland.org> wrote:
>
> This allows devm_clock_get(dev, NULL) to work and get the first clock,
> which is common in code ported from Linux.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
>  drivers/clk/clk-uclass.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 2f9635524cf..bfacafb2eef 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -399,13 +399,14 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
>
>  int clk_get_by_name_nodev(ofnode node, const char *name, struct clk *clk)
>  {
> -       int index;
> +       int index = 0;
>
>         debug("%s(node=%p, name=%s, clk=%p)\n", __func__,
>                 ofnode_get_name(node), name, clk);
>         clk->dev = NULL;
>
> -       index = ofnode_stringlist_search(node, "clock-names", name);
> +       if (name)
> +               index = ofnode_stringlist_search(node, "clock-names", name);
>         if (index < 0) {
>                 debug("fdt_stringlist_search() failed: %d\n", index);
>                 return index;
> --
> 2.37.4
>

Same comments as for the reset patch.

Regards,
Simon

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-04 20:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28  5:53 [PATCH 1/2] clk: Allow clk_get_by_name() with NULL name Samuel Holland
2022-11-28  5:53 ` [PATCH 2/2] reset: Allow reset_get_by_name() " Samuel Holland
2023-01-04 17:24   ` Sean Anderson
2023-01-04 20:01   ` Simon Glass
2023-01-04 17:23 ` [PATCH 1/2] clk: Allow clk_get_by_name() " Sean Anderson
2023-01-04 20:01 ` Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.