[PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes

[PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes

[Jonathan Neuschäfer]

My recently merged nuvoton,wpcm450-fiu DT binding caused some
dt_binding_check issues in linux-next. This series attempts to fix them
before the breakage spreads any further.

Thanks to Conor Dooley, who notified me.

Jonathan Neuschäfer (2):
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus
    include)
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing
    reg property)

 .../devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.35.1

[PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes

[Jonathan Neuschäfer]

My recently merged nuvoton,wpcm450-fiu DT binding caused some
dt_binding_check issues in linux-next. This series attempts to fix them
before the breakage spreads any further.

Thanks to Conor Dooley, who notified me.

Jonathan Neuschäfer (2):
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus
    include)
  spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing
    reg property)

 .../devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.35.1

[PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

[Jonathan Neuschäfer]

The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@ unevaluatedProperties: false

 examples:
   - |
-    #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
     spi@c8000000 {
       compatible = "nuvoton,wpcm450-fiu";
       reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
       #address-cells = <1>;
       #size-cells = <0>;
       reg-names = "control", "memory";
-      clocks = <&clk WPCM450_CLK_FIU>;
+      clocks = <&clk 0>;
       nuvoton,shm = <&shm>;

       flash@0 {
--
2.35.1

[PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

[Jonathan Neuschäfer]

The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@ unevaluatedProperties: false

 examples:
   - |
-    #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
     spi@c8000000 {
       compatible = "nuvoton,wpcm450-fiu";
       reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
       #address-cells = <1>;
       #size-cells = <0>;
       reg-names = "control", "memory";
-      clocks = <&clk WPCM450_CLK_FIU>;
+      clocks = <&clk 0>;
       nuvoton,shm = <&shm>;

       flash@0 {
--
2.35.1

[PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

[Jonathan Neuschäfer]

I forgot to add a "reg = <0>;" property to the flash@0 node while
writing the example. Fix this.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index e4162845fcc1d..4e0d391e1d697 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -56,6 +56,7 @@ examples:

       flash@0 {
         compatible = "jedec,spi-nor";
+        reg = <0>;
       };
     };

--
2.35.1

[PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

[Jonathan Neuschäfer]

I forgot to add a "reg = <0>;" property to the flash@0 node while
writing the example. Fix this.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index e4162845fcc1d..4e0d391e1d697 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -56,6 +56,7 @@ examples:

       flash@0 {
         compatible = "jedec,spi-nor";
+        reg = <0>;
       };
     };

--
2.35.1

Re: [PATCH 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

[Krzysztof Kozlowski]

On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> The nuvoton,wpcm450-fiu binding's example includes
> nuvoton,wpcm450-clk.h, which has not been merged yet,
> thus causing a dt_binding_check error on -next.
> 
> Fix this error by simply hardcoding the clock index in the example,
> before the breakage spreads any further.
> 
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Reported-by: Conor Dooley <conor.dooley@microchip.com>

Report came from Rob:

Reported-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

[Krzysztof Kozlowski]

On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> I forgot to add a "reg = <0>;" property to the flash@0 node while
> writing the example. Fix this.

Don't be personal in commit messages. Instead:
   Add missing "reg = <0>;" property to the flash@0 node in the example.

which has the same amount of information and is even shorter.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> 
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>


Best regards,
Krzysztof

Re: [PATCH 0/2] nuvoton,wpcm450-fiu binding example fixes

[Mark Brown]

On Mon, 28 Nov 2022 22:49:26 +0100, Jonathan Neuschäfer wrote:
> My recently merged nuvoton,wpcm450-fiu DT binding caused some
> dt_binding_check issues in linux-next. This series attempts to fix them
> before the breakage spreads any further.
> 
> Thanks to Conor Dooley, who notified me.
> 
> Jonathan Neuschäfer (2):
>   spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus
>     include)
>   spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing
>     reg property)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)
      commit: 1e2872f5912fbc87a00d00d49af98e428f4ff8b7
[2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)
      commit: c771b4eabd6a52afff0b6f01c361a9d04fa8cd9d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark