* [PATCH] hwmon: (oxp-sensors) Bugfix pwm reading
@ 2022-11-28 18:52 Joaquín Ignacio Aramendía
2022-11-28 22:19 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Joaquín Ignacio Aramendía @ 2022-11-28 18:52 UTC (permalink / raw)
To: w_armin
Cc: hdegoede, jdelvare, linux-hwmon, linux, markgross,
platform-driver-x86, pobrn, Joaquín Ignacio Aramendía
PWM reading is only 1 register long.
Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
---
drivers/hwmon/oxp-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index c04277676b72..f84ec8f8eda9 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -158,7 +158,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
case hwmon_pwm:
switch (attr) {
case hwmon_pwm_input:
- ret = read_from_ec(OXP_SENSOR_PWM_REG, 2, val);
+ ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
if (ret)
return ret;
if (board == oxp_mini_amd)
base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (oxp-sensors) Bugfix pwm reading
2022-11-28 18:52 [PATCH] hwmon: (oxp-sensors) Bugfix pwm reading Joaquín Ignacio Aramendía
@ 2022-11-28 22:19 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-11-28 22:19 UTC (permalink / raw)
To: Joaquín Ignacio Aramendía
Cc: w_armin, hdegoede, jdelvare, linux-hwmon, markgross,
platform-driver-x86, pobrn
On Mon, Nov 28, 2022 at 03:52:06PM -0300, Joaquín Ignacio Aramendía wrote:
> PWM reading is only 1 register long.
>
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/oxp-sensors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: 9494c53e1389b120ba461899207ac8a3aab2632c
>
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index c04277676b72..f84ec8f8eda9 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -158,7 +158,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
> case hwmon_pwm:
> switch (attr) {
> case hwmon_pwm_input:
> - ret = read_from_ec(OXP_SENSOR_PWM_REG, 2, val);
> + ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
> if (ret)
> return ret;
> if (board == oxp_mini_amd)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-28 22:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 18:52 [PATCH] hwmon: (oxp-sensors) Bugfix pwm reading Joaquín Ignacio Aramendía
2022-11-28 22:19 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.