From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Thierry Reding <thierry.reding@gmail.com> Cc: Conor Dooley <conor.dooley@microchip.com>, Matthias Brugger <matthias.bgg@gmail.com>, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 08/11] pwm: mtk-disp: Propagate errors in .get_state() to the caller Date: Wed, 30 Nov 2022 16:21:45 +0100 [thread overview] Message-ID: <20221130152148.2769768-9-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> .get_state() can return an error indication. Make use of it to propagate failing hardware accesses. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-mtk-disp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c index 9a6bb334a31b..67e5799dd157 100644 --- a/drivers/pwm/pwm-mtk-disp.c +++ b/drivers/pwm/pwm-mtk-disp.c @@ -184,14 +184,14 @@ static int mtk_disp_pwm_get_state(struct pwm_chip *chip, err = clk_prepare_enable(mdp->clk_main); if (err < 0) { dev_err(chip->dev, "Can't enable mdp->clk_main: %pe\n", ERR_PTR(err)); - return 0; + return err; } err = clk_prepare_enable(mdp->clk_mm); if (err < 0) { dev_err(chip->dev, "Can't enable mdp->clk_mm: %pe\n", ERR_PTR(err)); clk_disable_unprepare(mdp->clk_main); - return 0; + return err; } rate = clk_get_rate(mdp->clk_main); -- 2.38.1
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Thierry Reding <thierry.reding@gmail.com> Cc: Conor Dooley <conor.dooley@microchip.com>, Matthias Brugger <matthias.bgg@gmail.com>, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 08/11] pwm: mtk-disp: Propagate errors in .get_state() to the caller Date: Wed, 30 Nov 2022 16:21:45 +0100 [thread overview] Message-ID: <20221130152148.2769768-9-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> .get_state() can return an error indication. Make use of it to propagate failing hardware accesses. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pwm/pwm-mtk-disp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c index 9a6bb334a31b..67e5799dd157 100644 --- a/drivers/pwm/pwm-mtk-disp.c +++ b/drivers/pwm/pwm-mtk-disp.c @@ -184,14 +184,14 @@ static int mtk_disp_pwm_get_state(struct pwm_chip *chip, err = clk_prepare_enable(mdp->clk_main); if (err < 0) { dev_err(chip->dev, "Can't enable mdp->clk_main: %pe\n", ERR_PTR(err)); - return 0; + return err; } err = clk_prepare_enable(mdp->clk_mm); if (err < 0) { dev_err(chip->dev, "Can't enable mdp->clk_mm: %pe\n", ERR_PTR(err)); clk_disable_unprepare(mdp->clk_main); - return 0; + return err; } rate = clk_get_rate(mdp->clk_main); -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-30 15:22 UTC|newest] Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-30 15:21 [PATCH v2 00/11] pwm: Allow .get_state to fail Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 18:36 ` Heiko Stübner 2022-11-30 18:36 ` Heiko Stübner 2022-11-30 18:36 ` Heiko Stübner 2022-11-30 18:36 ` Heiko Stübner 2022-11-30 18:36 ` Heiko Stübner 2022-12-01 1:17 ` Baolin Wang 2022-12-01 1:17 ` Baolin Wang 2022-12-01 1:17 ` Baolin Wang 2022-12-01 1:17 ` Baolin Wang 2022-12-01 1:17 ` Baolin Wang 2022-12-01 2:41 ` Tzung-Bi Shih 2022-12-01 2:41 ` Tzung-Bi Shih 2022-12-01 2:41 ` Tzung-Bi Shih 2022-12-01 2:41 ` Tzung-Bi Shih 2022-12-01 2:41 ` Tzung-Bi Shih 2022-12-01 8:03 ` Neil Armstrong 2022-12-01 8:03 ` Neil Armstrong 2022-12-01 8:03 ` Neil Armstrong 2022-12-01 8:03 ` Neil Armstrong 2022-12-01 8:03 ` Neil Armstrong 2022-12-01 9:30 ` nobuhiro1.iwamatsu 2022-12-01 9:30 ` nobuhiro1.iwamatsu 2022-12-01 9:30 ` nobuhiro1.iwamatsu 2022-12-01 9:30 ` nobuhiro1.iwamatsu 2022-12-01 9:30 ` nobuhiro1.iwamatsu 2022-12-01 10:22 ` Andre Przywara 2022-12-01 10:22 ` Andre Przywara 2022-12-01 10:22 ` Andre Przywara 2022-12-01 10:22 ` Andre Przywara 2022-12-01 10:22 ` Andre Przywara 2022-12-01 13:16 ` Uwe Kleine-König 2022-12-01 13:16 ` Uwe Kleine-König 2022-12-01 13:16 ` Uwe Kleine-König 2022-12-01 13:16 ` Uwe Kleine-König 2022-12-01 13:16 ` Uwe Kleine-König 2022-12-01 14:17 ` Andre Przywara 2022-12-01 14:17 ` Andre Przywara 2022-12-01 14:17 ` Andre Przywara 2022-12-01 14:17 ` Andre Przywara 2022-12-01 14:17 ` Andre Przywara 2022-12-01 10:43 ` Dave Stevenson 2022-12-01 10:43 ` Dave Stevenson 2022-12-01 10:43 ` Dave Stevenson 2022-12-01 10:43 ` Dave Stevenson 2022-12-01 10:43 ` Dave Stevenson 2022-12-01 15:37 ` Doug Anderson 2022-12-01 15:37 ` Doug Anderson 2022-12-01 15:37 ` Doug Anderson 2022-12-01 15:37 ` Doug Anderson 2022-12-01 15:37 ` Doug Anderson 2022-12-05 20:50 ` Jernej Škrabec 2022-12-05 20:50 ` Jernej Škrabec 2022-12-05 20:50 ` Jernej Škrabec 2022-12-05 20:50 ` Jernej Škrabec 2022-12-05 20:50 ` Jernej Škrabec 2022-12-05 22:30 ` Pavel Machek 2022-12-05 22:30 ` Pavel Machek 2022-12-05 22:30 ` Pavel Machek 2022-12-05 22:30 ` Pavel Machek 2022-12-05 22:30 ` Pavel Machek 2022-11-30 15:21 ` [PATCH v2 02/11] pwm/tracing: Also record trace events for failed API calls Uwe Kleine-König 2022-11-30 20:15 ` Steven Rostedt 2022-12-01 7:09 ` Uwe Kleine-König 2022-11-30 15:21 ` [PATCH v2 03/11] drm/bridge: ti-sn65dsi86: Propagate errors in .get_state() to the caller Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-12-01 15:37 ` Doug Anderson 2022-12-01 15:37 ` Doug Anderson 2022-12-04 21:09 ` Uwe Kleine-König 2022-12-04 21:09 ` Uwe Kleine-König 2022-12-04 21:31 ` Laurent Pinchart 2022-12-04 21:31 ` Laurent Pinchart 2022-12-05 15:25 ` Doug Anderson 2022-12-05 15:25 ` Doug Anderson 2022-11-30 15:21 ` [PATCH v2 04/11] leds: qcom-lpg: " Uwe Kleine-König 2022-12-04 21:04 ` Uwe Kleine-König 2022-12-04 22:28 ` Pavel Machek 2022-12-05 22:31 ` Pavel Machek 2023-01-04 16:56 ` Lee Jones 2023-01-05 13:54 ` Uwe Kleine-König 2023-01-05 16:29 ` Lee Jones 2022-11-30 15:21 ` [PATCH v2 05/11] pwm: crc: " Uwe Kleine-König 2022-11-30 15:21 ` [PATCH v2 06/11] pwm: cros-ec: " Uwe Kleine-König 2022-12-01 2:41 ` Tzung-Bi Shih 2022-11-30 15:21 ` [PATCH v2 07/11] pwm: imx27: " Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König [this message] 2022-11-30 15:21 ` [PATCH v2 08/11] pwm: mtk-disp: " Uwe Kleine-König 2022-12-01 13:11 ` AngeloGioacchino Del Regno 2022-12-01 13:11 ` AngeloGioacchino Del Regno 2022-11-30 15:21 ` [PATCH v2 09/11] pwm: rockchip: " Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 15:21 ` Uwe Kleine-König 2022-11-30 18:37 ` Heiko Stübner 2022-11-30 18:37 ` Heiko Stübner 2022-11-30 18:37 ` Heiko Stübner 2022-11-30 15:21 ` [PATCH v2 10/11] pwm: sprd: " Uwe Kleine-König 2022-12-01 1:18 ` Baolin Wang 2022-11-30 15:21 ` [PATCH v2 11/11] pwm: Handle .get_state() failures Uwe Kleine-König 2022-12-01 11:11 ` [PATCH v2 00/11] pwm: Allow .get_state to fail Conor Dooley 2022-12-01 11:11 ` Conor Dooley 2022-12-01 11:11 ` Conor Dooley 2022-12-01 11:11 ` Conor Dooley 2022-12-01 11:11 ` Conor Dooley 2022-12-01 13:19 ` Uwe Kleine-König 2022-12-01 13:19 ` Uwe Kleine-König 2022-12-01 13:19 ` Uwe Kleine-König 2022-12-01 13:19 ` Uwe Kleine-König 2022-12-01 13:19 ` Uwe Kleine-König 2022-12-01 13:28 ` Conor Dooley 2022-12-01 13:28 ` Conor Dooley 2022-12-01 13:28 ` Conor Dooley 2022-12-01 13:28 ` Conor Dooley 2022-12-01 13:28 ` Conor Dooley 2022-12-09 21:47 ` Andy Shevchenko 2022-12-09 21:47 ` Andy Shevchenko 2022-12-09 21:47 ` Andy Shevchenko 2022-12-09 21:47 ` Andy Shevchenko 2022-12-09 21:47 ` Andy Shevchenko 2022-12-09 21:47 ` Andy Shevchenko 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 9:18 ` Uwe Kleine-König 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 20:57 ` Andy Shevchenko 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-10 22:41 ` Uwe Kleine-König 2022-12-11 13:31 ` Andy Shevchenko 2022-12-11 13:31 ` Andy Shevchenko 2022-12-11 13:31 ` Andy Shevchenko 2022-12-11 13:31 ` Andy Shevchenko 2022-12-11 13:31 ` Andy Shevchenko 2022-12-11 13:31 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221130152148.2769768-9-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=conor.dooley@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pwm@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.