* [merged mm-stable] mm-add-sys-class-bdi-bdi-min_bytes-knob.patch removed from -mm tree
@ 2022-12-01 0:02 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-12-01 0:02 UTC (permalink / raw)
To: mm-commits, clm, axboe, shr, akpm
The quilt patch titled
Subject: mm: add /sys/class/bdi/<bdi>/min_bytes knob
has been removed from the -mm tree. Its filename was
mm-add-sys-class-bdi-bdi-min_bytes-knob.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Stefan Roesch <shr@devkernel.io>
Subject: mm: add /sys/class/bdi/<bdi>/min_bytes knob
Date: Fri, 18 Nov 2022 16:52:08 -0800
bdi has two existing knobs to limit the amount of dirty memory:
min_ratio and max_ratio. However the granularity of the knobs is limited
and often it is more convenient to specify limits in terms of bytes.
This change adds the min_bytes knob.
It does not store the min_bytes value, instead it converts the max_bytes
value to a ratio. The value is therefore more an approximation than an
absolute value.
It also maintains the sum over all the bdi min_ratio values stored in
the variable bdi_min_ratio.
Link: https://lkml.kernel.org/r/20221119005215.3052436-14-shr@devkernel.io
Signed-off-by: Stefan Roesch <shr@devkernel.io>
Cc: Chris Mason <clm@meta.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/backing-dev.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
--- a/mm/backing-dev.c~mm-add-sys-class-bdi-bdi-min_bytes-knob
+++ a/mm/backing-dev.c
@@ -199,6 +199,34 @@ static ssize_t max_ratio_store(struct de
}
BDI_SHOW(max_ratio, bdi->max_ratio / BDI_RATIO_SCALE)
+static ssize_t min_bytes_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+
+ return sysfs_emit(buf, "%llu\n", bdi_get_min_bytes(bdi));
+}
+
+static ssize_t min_bytes_store(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+ u64 bytes;
+ ssize_t ret;
+
+ ret = kstrtoull(buf, 10, &bytes);
+ if (ret < 0)
+ return ret;
+
+ ret = bdi_set_min_bytes(bdi, bytes);
+ if (!ret)
+ ret = count;
+
+ return ret;
+}
+DEVICE_ATTR_RW(min_bytes);
+
static ssize_t max_bytes_show(struct device *dev,
struct device_attribute *attr,
char *buf)
@@ -269,6 +297,7 @@ static struct attribute *bdi_dev_attrs[]
&dev_attr_read_ahead_kb.attr,
&dev_attr_min_ratio.attr,
&dev_attr_max_ratio.attr,
+ &dev_attr_min_bytes.attr,
&dev_attr_max_bytes.attr,
&dev_attr_stable_pages_required.attr,
&dev_attr_strict_limit.attr,
_
Patches currently in -mm which might be from shr@devkernel.io are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-01 0:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-01 0:02 [merged mm-stable] mm-add-sys-class-bdi-bdi-min_bytes-knob.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.