* [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay
@ 2022-11-24 7:09 Arun R Murthy
2022-11-24 7:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (24 more replies)
0 siblings, 25 replies; 42+ messages in thread
From: Arun R Murthy @ 2022-11-24 7:09 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
AUX HW timeout is being set to max(4000ms), consider AUX SW timeout to
be 200ms more to avoid AUX boundary read//write.
HSDES: 1409498780
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 664bebdecea7..6c1c9602518b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -293,14 +293,13 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
DP_AUX_CH_CTL_RECEIVE_ERROR);
/*
- * DP CTS 1.2 Core Rev 1.1, 4.2.1.1 & 4.2.1.2
- * 400us delay required for errors and timeouts
- * Timeout errors from the HW already meet this
- * requirement so skip to next iteration
+ * Once the hw timeouts, before next try
+ * need to add a sw timeout of 200usec(HSD: 1409498780).
*/
- if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
+ if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
+ usleep_range(200, 300);
continue;
-
+ }
if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
usleep_range(400, 500);
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
@ 2022-11-24 7:45 ` Patchwork
2022-11-24 8:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (23 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-11-24 7:45 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay
URL : https://patchwork.freedesktop.org/series/111303/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
2022-11-24 7:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
@ 2022-11-24 8:48 ` Patchwork
2022-11-25 15:48 ` [Intel-gfx] [PATCH] " Imre Deak
` (22 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-11-24 8:48 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3138 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12427 -> Patchwork_111303v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v1/index.html
Participating hosts (38 -> 35)
------------------------------
Missing (3): fi-ctg-p8600 fi-bdw-gvtdvm fi-rkl-11600
Known issues
------------
Here are the changes found in Patchwork_111303v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- {bat-adln-1}: [INCOMPLETE][1] -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12427/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v1/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][3] ([i915#4258]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12427/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][5] ([i915#6257]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12427/bat-rpls-1/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v1/bat-rpls-1/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
Build changes
-------------
* Linux: CI_DRM_12427 -> Patchwork_111303v1
CI-20190529: 20190529
CI_DRM_12427: 24694cd2b234fb097fda693f13be131116f1a79f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7072: 69ba7163475925cdc69aebbdfa0e87453ae165c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v1: 24694cd2b234fb097fda693f13be131116f1a79f @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c26cf159f605 drm/i915/dp: wait on timeout before retry include sw delay
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v1/index.html
[-- Attachment #2: Type: text/html, Size: 3269 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
2022-11-24 7:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-11-24 8:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-11-25 15:48 ` Imre Deak
2022-12-01 6:44 ` [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
` (21 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Imre Deak @ 2022-11-25 15:48 UTC (permalink / raw)
To: Arun R Murthy; +Cc: jani.nikula, intel-gfx
On Thu, Nov 24, 2022 at 12:39:25PM +0530, Arun R Murthy wrote:
> AUX HW timeout is being set to max(4000ms), consider AUX SW timeout to
^ 4ms
> be 200ms more to avoid AUX boundary read//write.
The HSD mentions a 200us extension.
> HSDES: 1409498780
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 664bebdecea7..6c1c9602518b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -293,14 +293,13 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> DP_AUX_CH_CTL_RECEIVE_ERROR);
>
> /*
> - * DP CTS 1.2 Core Rev 1.1, 4.2.1.1 & 4.2.1.2
> - * 400us delay required for errors and timeouts
> - * Timeout errors from the HW already meet this
> - * requirement so skip to next iteration
I think keeping the above still makes sense to explain why the 400us
explicit delay described in the CTS is not needed.
> + * Once the hw timeouts, before next try
> + * need to add a sw timeout of 200usec(HSD: 1409498780).
The HSD is for ICL, I can't see the bspec entry for it at bspec/33450.
WAs should have a "Wa_<lineage>:<platform(s)>" tag.
> */
> - if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
> + if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
> + usleep_range(200, 300);
The HSD ticket implies that the WA is to increase the timeout when
polling for the BUSY flag to clear from 600us to 800us for the non-LTTPR
case and from 4ms to 4.2ms in the LTTPR case (regardless of why the BUSY
flag is cleared). This seems to match what the Windows driver does now.
i915 waits for the same condition for 10ms, so to me it looks like the
waiting here already complies with the change described by the HSD.
One difference I see is that Windows just polls for the BUSY flag
without enabling the interrupt-on-done for this, not sure if this could
cause a problem.
> continue;
> -
> + }
> if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
> usleep_range(400, 500);
> continue;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (2 preceding siblings ...)
2022-11-25 15:48 ` [Intel-gfx] [PATCH] " Imre Deak
@ 2022-12-01 6:44 ` Arun R Murthy
2022-12-05 10:38 ` Jani Nikula
2022-12-01 7:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev2) Patchwork
` (20 subsequent siblings)
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-01 6:44 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY set
and fails.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period.
v2: replace interrupt with polling read
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 24 ++++++++++++---------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 664bebdecea7..22c0a59850df 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -40,20 +40,24 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
u32 status;
- bool done;
-
-#define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ int try;
+ for (try = 0; try < 10; try++) {
+ status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
+ break;
+ msleep(1);
+ }
/* just trace the final value */
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
- if (!done)
- drm_err(&i915->drm,
- "%s: did not complete or timeout within %ums (status 0x%08x)\n",
- intel_dp->aux.name, timeout_ms, status);
-#undef C
+ if (try == 3) {
+ status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
+ drm_err(&i915->drm,
+ "%s: did not complete or timeout within %ums (status 0x%08x)\n",
+ intel_dp->aux.name, timeout_ms, status);
+ }
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev2)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (3 preceding siblings ...)
2022-12-01 6:44 ` [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-01 7:14 ` Patchwork
2022-12-01 7:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (19 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-01 7:14 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev2)
URL : https://patchwork.freedesktop.org/series/111303/
State : warning
== Summary ==
Error: dim checkpatch failed
7b8a6c674948 drm/i915/dp: Change aux_ctl reg read to polling read
-:35: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#35: FILE: drivers/gpu/drm/i915/display/intel_dp_aux.c:49:
+ msleep(1);
total: 0 errors, 1 warnings, 0 checks, 34 lines checked
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev2)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (4 preceding siblings ...)
2022-12-01 7:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev2) Patchwork
@ 2022-12-01 7:34 ` Patchwork
2022-12-01 17:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (18 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-01 7:34 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6654 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev2)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12457 -> Patchwork_111303v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/index.html
Participating hosts (38 -> 36)
------------------------------
Additional (1): bat-atsm-1
Missing (3): bat-rpls-1 fi-ilk-m540 fi-kbl-x1275
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-atsm-1}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/bat-atsm-1/igt@gem_exec_suspend@basic-s0@smem.html
Known issues
------------
Here are the changes found in Patchwork_111303v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][2] -> [DMESG-FAIL][3] ([i915#5334])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][4] ([fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-rkl-guc/igt@kms_chamelium@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- {fi-ehl-2}: [INCOMPLETE][5] ([i915#2940]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/fi-ehl-2/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-ehl-2/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][7] ([i915#5334] / [i915#7433]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [INCOMPLETE][9] ([i915#4983]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][11] ([i915#4258]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][13] ([i915#4983]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/bat-rpls-2/igt@i915_selftest@live@reset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7355]: https://gitlab.freedesktop.org/drm/intel/issues/7355
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7433]: https://gitlab.freedesktop.org/drm/intel/issues/7433
Build changes
-------------
* Linux: CI_DRM_12457 -> Patchwork_111303v2
CI-20190529: 20190529
CI_DRM_12457: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7076: 888725538e0d6bbb94bbbb1ac278d4afcbbbdad0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v2: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5c60df6ff667 drm/i915/dp: Change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/index.html
[-- Attachment #2: Type: text/html, Size: 6202 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev2)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (5 preceding siblings ...)
2022-12-01 7:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-12-01 17:06 ` Patchwork
2022-12-09 8:35 ` [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
` (17 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-01 17:06 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 31850 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev2)
URL : https://patchwork.freedesktop.org/series/111303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12457_full -> Patchwork_111303v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111303v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111303v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_sysfs_edid_timing:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl8/igt@kms_sysfs_edid_timing.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-apl8/igt@kms_sysfs_edid_timing.html
Known issues
------------
Here are the changes found in Patchwork_111303v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-queued:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-snb4/igt@gem_ctx_persistence@engines-queued.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb5/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][8] -> [SKIP][9] ([i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb5/igt@gem_huc_copy@huc-copy.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#3297])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@gem_userptr_blits@unsync-unmap.html
* igt@gem_vm_create@invalid-create:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271]) +76 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-snb4/igt@gem_vm_create@invalid-create.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][12] -> [FAIL][13] ([i915#6991])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl9/igt@i915_pm_sseu@full-enable.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl10/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][14] ([fdo#110723])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#3886])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl9/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][16] ([fdo#109278]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium@dp-edid-read:
- shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109284] / [fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-snb4/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html
* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2346]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#79])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#2587] / [i915#2672]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][26] -> [SKIP][27] ([i915#3555]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2672])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#3555]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#2672] / [i915#3555]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109280]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#1839])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#4573]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl9/igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#111068] / [i915#658])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][35] ([i915#5939]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109642] / [fdo#111068] / [i915#658])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb6/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-iclb: [PASS][39] -> [SKIP][40] ([i915#5519])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#7404])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_vrr@flipline:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271]) +29 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl9/igt@kms_vrr@flipline.html
* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2437])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl10/igt@kms_writeback@writeback-check-output.html
* igt@perf@blocking:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#1542]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl9/igt@perf@blocking.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl4/igt@perf@blocking.html
#### Possible fixes ####
* igt@api_intel_bb@object-reloc-keep-cache:
- {shard-rkl}: [SKIP][47] ([i915#3281]) -> [PASS][48] +11 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-6/igt@api_intel_bb@object-reloc-keep-cache.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@api_intel_bb@object-reloc-keep-cache.html
* igt@drm_read@short-buffer-nonblock:
- {shard-rkl}: [SKIP][49] ([i915#4098]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@drm_read@short-buffer-nonblock.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@drm_read@short-buffer-nonblock.html
* igt@fbdev@unaligned-write:
- {shard-rkl}: [SKIP][51] ([i915#2582]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@fbdev@unaligned-write.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@fbdev@unaligned-write.html
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][53] ([i915#6252]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-1/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][55] ([i915#4525]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@gem_exec_balancer@parallel-out-fence.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][57] ([i915#2842]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-iclb: [INCOMPLETE][59] ([i915#6453]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb1/igt@gem_exec_whisper@basic-contexts-forked.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb1/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][61] ([i915#3282]) -> [PASS][62] +7 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-6/igt@gem_pwrite@basic-self.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@gem_pwrite@basic-self.html
* igt@gen9_exec_parse@bb-chained:
- {shard-rkl}: [SKIP][63] ([i915#2527]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-4/igt@gen9_exec_parse@bb-chained.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][65] ([i915#3361]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][67] ([i915#6537]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@i915_pm_rps@engine-order.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][69] ([i915#5591]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb1/igt@i915_selftest@live@hangcheck.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-tglb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-iclb: [FAIL][71] ([i915#79]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1:
- shard-apl: [FAIL][73] ([i915#2122]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-apl2/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][75] ([i915#1849] / [i915#4098]) -> [PASS][76] +22 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][77] ([i915#7255]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@kms_frontbuffer_tracking@psr-suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl9/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_prime@basic-crc-vgem@second-to-first:
- shard-skl: [DMESG-WARN][79] ([i915#1982]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl7/igt@kms_prime@basic-crc-vgem@second-to-first.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl7/igt@kms_prime@basic-crc-vgem@second-to-first.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][83] ([i915#1072]) -> [PASS][84] +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-4/igt@kms_psr@sprite_mmap_gtt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][85] ([i915#5519]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
- {shard-rkl}: [SKIP][87] ([i915#5461]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_rotation_crc@exhaust-fences:
- {shard-rkl}: [SKIP][89] ([i915#1845] / [i915#4098]) -> [PASS][90] +28 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@kms_rotation_crc@exhaust-fences.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-6/igt@kms_rotation_crc@exhaust-fences.html
* igt@kms_sysfs_edid_timing:
- shard-skl: [FAIL][91] ([i915#6493]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl4/igt@kms_sysfs_edid_timing.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-skl1/igt@kms_sysfs_edid_timing.html
* igt@perf@mi-rpc:
- {shard-rkl}: [SKIP][93] ([i915#2434]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-4/igt@perf@mi-rpc.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@perf@mi-rpc.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][95] ([i915#1722]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-1/igt@perf@polling-small-buf.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-rkl-5/igt@perf@polling-small-buf.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][97] ([i915#588]) -> [SKIP][98] ([i915#658])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- shard-iclb: [FAIL][99] ([i915#2684]) -> [WARN][100] ([i915#2684])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][101] ([i915#658]) -> [SKIP][102] ([i915#2920])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][103] ([i915#2920]) -> [SKIP][104] ([i915#658])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb6/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][105] ([fdo#111068] / [i915#658]) -> [SKIP][106] ([i915#2920])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6991]: https://gitlab.freedesktop.org/drm/intel/issues/6991
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7255]: https://gitlab.freedesktop.org/drm/intel/issues/7255
[i915#7404]: https://gitlab.freedesktop.org/drm/intel/issues/7404
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12457 -> Patchwork_111303v2
CI-20190529: 20190529
CI_DRM_12457: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7076: 888725538e0d6bbb94bbbb1ac278d4afcbbbdad0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v2: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v2/index.html
[-- Attachment #2: Type: text/html, Size: 30568 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read
2022-12-01 6:44 ` [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-05 10:38 ` Jani Nikula
2022-12-07 5:23 ` Murthy, Arun R
0 siblings, 1 reply; 42+ messages in thread
From: Jani Nikula @ 2022-12-05 10:38 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Thu, 01 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY set
> and fails.
That's inaccurate. It checks for busy, waits for the gmbus irq, and on
timeout or irq, whichever happens first, checks busy again.
The commit message fails to explain what is wrong with that. The
rationale is missing.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period.
Again, what's the problem that this addresses? Are you not getting an
irq, and often hitting the timeout? Or do you think there's too much
delay between getting the irq and continuing? Or what?
>
> v2: replace interrupt with polling read
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 24 ++++++++++++---------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 664bebdecea7..22c0a59850df 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -40,20 +40,24 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
> -
> -#define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + int try;
>
> + for (try = 0; try < 10; try++) {
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> + break;
> + msleep(1);
I believe msleep(1), while used quite a bit in the kernel, is considered
bad style. You don't really know how long it's going to sleep, it's not
that accurate. It could be 10-20 ms I think. (IIRC I've seen 100+ ms
sleeps on busy systems.) So if the condition never happens, you might be
looping for 100-200 ms here instead of the 10 ms.
And you might wait for 20+ ms before the 2nd read of the register.
If your problem is the delay between the irq calling wake_up_all() and
this actually waking up (which I believe is subject to the same
latencies as msleep()) then this is all pretty random. You need to
analyze and describe the problem better.
> + }
> /* just trace the final value */
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
This should continue to trace the final value. Now you read status once
more after this.
BR,
Jani.
>
> - if (!done)
> - drm_err(&i915->drm,
> - "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> - intel_dp->aux.name, timeout_ms, status);
> -#undef C
> + if (try == 3) {
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> + drm_err(&i915->drm,
> + "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> + intel_dp->aux.name, timeout_ms, status);
> + }
>
> return status;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read
2022-12-05 10:38 ` Jani Nikula
@ 2022-12-07 5:23 ` Murthy, Arun R
0 siblings, 0 replies; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-07 5:23 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx, ville.syrjala, Deak, Imre
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Monday, December 5, 2022 4:08 PM
> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
> <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: Re: [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read
>
> On Thu, 01 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> > The busy timeout logic checks for the AUX BUSY, then waits for the
> > timeout period and then after timeout reads the register for BUSY set
> > and fails.
>
> That's inaccurate. It checks for busy, waits for the gmbus irq, and on timeout
> or irq, whichever happens first, checks busy again.
>
> The commit message fails to explain what is wrong with that. The rationale is
> missing.
>
Sure will elaborate more windows found some issue with this interrupt on read and hence
are using polling read with timeout. Hence we are trying to bring the same over here.
> > Instead replace interrupt with polling so as to read the AUX CTL
> > register often before the timeout period.
>
> Again, what's the problem that this addresses? Are you not getting an irq,
> and often hitting the timeout? Or do you think there's too much delay
> between getting the irq and continuing? Or what?
>
As explained above windows also had some issue on interrupt on read and using polling read.
> >
> > v2: replace interrupt with polling read
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 24
> > ++++++++++++---------
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > index 664bebdecea7..22c0a59850df 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > @@ -40,20 +40,24 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> > const unsigned int timeout_ms = 10;
> > u32 status;
> > - bool done;
> > -
> > -#define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> > - msecs_to_jiffies_timeout(timeout_ms));
> > + int try;
> >
> > + for (try = 0; try < 10; try++) {
> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > + break;
> > + msleep(1);
>
> I believe msleep(1), while used quite a bit in the kernel, is considered bad
> style. You don't really know how long it's going to sleep, it's not that
> accurate. It could be 10-20 ms I think. (IIRC I've seen 100+ ms sleeps on busy
> systems.) So if the condition never happens, you might be looping for 100-
> 200 ms here instead of the 10 ms.
Sure, I agree will change this to 500usleep range.
>
> And you might wait for 20+ ms before the 2nd read of the register.
>
> If your problem is the delay between the irq calling wake_up_all() and this
> actually waking up (which I believe is subject to the same latencies as
> msleep()) then this is all pretty random. You need to analyze and describe
> the problem better.
Yes agree, in the same function just above this where a check is being done for
any previous AUX channel activity, similar polling read is being done. So will replace
both of these to usleep.
>
> > + }
> > /* just trace the final value */
> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> This should continue to trace the final value. Now you read status once more
> after this.
Sorry my bad missed it. Will correct.
Thanks and Regards,
Arun R Murthy
--------------------
>
>
> BR,
> Jani.
>
> >
> > - if (!done)
> > - drm_err(&i915->drm,
> > - "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> > - intel_dp->aux.name, timeout_ms, status);
> > -#undef C
> > + if (try == 3) {
> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> > + drm_err(&i915->drm,
> > + "%s: did not complete or timeout within
> %ums (status 0x%08x)\n",
> > + intel_dp->aux.name, timeout_ms, status);
> > + }
> >
> > return status;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (6 preceding siblings ...)
2022-12-01 17:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-12-09 8:35 ` Arun R Murthy
2022-12-09 10:45 ` Jani Nikula
2022-12-09 9:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3) Patchwork
` (16 subsequent siblings)
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-09 8:35 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 24 ++++++++++++---------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..230f27d75846 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -41,21 +41,25 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
u32 status;
- bool done;
+ int try;
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ for (try = 0; try < 10; try++) {
+ status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
+ break;
+ usleep_range(400, 500);
+ }
+ if (try == 3) {
+ status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
+ drm_err(&i915->drm,
+ "%s: did not complete or timeout within %ums (status 0x%08x)\n",
+ intel_dp->aux.name, timeout_ms, status);
+ }
/* just trace the final value */
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
- if (!done)
- drm_err(&i915->drm,
- "%s: did not complete or timeout within %ums (status 0x%08x)\n",
- intel_dp->aux.name, timeout_ms, status);
-#undef C
-
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (7 preceding siblings ...)
2022-12-09 8:35 ` [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-09 9:23 ` Patchwork
2022-12-09 15:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (15 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-09 9:23 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11518 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev3)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12487 -> Patchwork_111303v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/index.html
Participating hosts (25 -> 31)
------------------------------
Additional (6): bat-adls-5 bat-adlp-9 bat-dg1-5 bat-adlp-6 bat-adlp-4 bat-dg2-11
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v3:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {bat-dg2-11}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg2-11/boot.html
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@module-reload:
- {bat-adlp-6}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-6/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in Patchwork_111303v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@debugfs_test@basic-hwmon.html
* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][8] ([i915#3282])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#7561])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#6621])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@i915_pm_rps@basic-api.html
- bat-adlp-4: NOTRUN -> [SKIP][11] ([i915#6621])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@migrate:
- bat-adlp-4: NOTRUN -> [INCOMPLETE][12] ([i915#7308] / [i915#7348])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4212]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#4215])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([fdo#111827]) +7 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-adlp-4: NOTRUN -> [SKIP][17] ([i915#4103])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4103] / [i915#4213])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][20] ([i915#4093]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([i915#1072] / [i915#4078]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#3555])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#4579])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#3708]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4077]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][26] ([fdo#109295] / [i915#3301] / [i915#3708])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#3708] / [i915#4873])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-dg1-5/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][28] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][29] ([i915#4312])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/bat-adlp-4/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][30] ([i915#7229]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live@mman:
- fi-rkl-guc: [TIMEOUT][32] ([i915#6794]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/fi-rkl-guc/igt@i915_selftest@live@mman.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/fi-rkl-guc/igt@i915_selftest@live@mman.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12487 -> Patchwork_111303v3
CI-20190529: 20190529
CI_DRM_12487: 1a2f5d78c35eb1b8812e3258dadb0d7e1027d710 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7088: 4b999091b8ee9cdea0dc35f48f1ee2ed415d6902 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v3: 1a2f5d78c35eb1b8812e3258dadb0d7e1027d710 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
fa262fed272a drm/i915/dp: Change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/index.html
[-- Attachment #2: Type: text/html, Size: 13013 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read
2022-12-09 8:35 ` [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-09 10:45 ` Jani Nikula
2022-12-13 5:44 ` Murthy, Arun R
0 siblings, 1 reply; 42+ messages in thread
From: Jani Nikula @ 2022-12-09 10:45 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Fri, 09 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period. Looks like there might be some
> issue with interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 24 ++++++++++++---------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..230f27d75846 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -41,21 +41,25 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
> + int try;
>
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + for (try = 0; try < 10; try++) {
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> + break;
> + usleep_range(400, 500);
> + }
> + if (try == 3) {
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> + drm_err(&i915->drm,
> + "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> + intel_dp->aux.name, timeout_ms, status);
> + }
>
> /* just trace the final value */
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
Okay, so there are still a bunch of issues above. For example, try < 10
vs. try == 3, reverting back to intel_uncore_* functions after conflict
resolution, having duplicated reads and conditions.
Now, I should've taken a step back earlier and realized you should use
the helper we already have for this: intel_de_wait_for_register().
All of the above shrinks to just a few lines:
ret = intel_de_wait_for_register(i915, ch_ctl, DP_AUX_CH_CTL_SEND_BUSY, 0, timeout_ms);
if (ret)
drm_err(...);
Sorry for missing this earlier.
BR,
Jani.
>
> - if (!done)
> - drm_err(&i915->drm,
> - "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> - intel_dp->aux.name, timeout_ms, status);
> -#undef C
> -
> return status;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (8 preceding siblings ...)
2022-12-09 9:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3) Patchwork
@ 2022-12-09 15:11 ` Patchwork
2022-12-14 3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
` (14 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-09 15:11 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 39652 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev3)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12487_full -> Patchwork_111303v3_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (14 -> 14)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v3_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@i2c:
- {shard-dg1}: [DMESG-WARN][1] ([i915#4391]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-dg1-18/igt@i915_pm_rpm@i2c.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-dg1-19/igt@i915_pm_rpm@i2c.html
* igt@kms_async_flips@async-flip-with-page-flip-events:
- {shard-tglu-9}: NOTRUN -> [SKIP][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-tglu-9/igt@kms_async_flips@async-flip-with-page-flip-events.html
Known issues
------------
Here are the changes found in Patchwork_111303v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#658])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb2/igt@feature_discovery@psr2.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb6/igt@feature_discovery@psr2.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-glk: [PASS][6] -> [TIMEOUT][7] ([i915#3063])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-glk4/igt@gem_eio@in-flight-contexts-10ms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-glk6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][8] -> [SKIP][9] ([i915#4525])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb1/igt@gem_exec_balancer@parallel-out-fence.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb3/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][10] ([i915#2846])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@gem_lmem_swapping@basic.html
* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][13] ([i915#2658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][14] ([i915#3318])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl2/igt@gem_userptr_blits@vma-merge.html
* igt@gem_wait@await@vecs0:
- shard-skl: NOTRUN -> [DMESG-WARN][15] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@gem_wait@await@vecs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#5566] / [i915#716])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl8/igt@gen9_exec_parse@allowed-single.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl6/igt@gen9_exec_parse@allowed-single.html
- shard-glk: [PASS][18] -> [DMESG-WARN][19] ([i915#5566] / [i915#716])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-glk3/igt@gen9_exec_parse@allowed-single.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: NOTRUN -> [WARN][20] ([i915#1804])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl1/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][21] -> [DMESG-FAIL][22] ([i915#5334])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][23] ([i915#1886])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][24] -> [DMESG-WARN][25] ([i915#5591])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-tglb6/igt@i915_selftest@live@hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-tglb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][26] ([i915#3763])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +22 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl2/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271]) +33 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl2/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +23 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl1/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl2/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][32] -> [FAIL][33] ([i915#2346]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#79])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [PASS][36] -> [FAIL][37] ([i915#79])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl8/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][38] -> [DMESG-WARN][39] ([i915#180])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][40] -> [FAIL][41] ([i915#2122])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#2672]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#3555]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#2672] / [i915#3555]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#2587] / [i915#2672]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][46] -> [SKIP][47] ([i915#3555])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#5776]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl2/igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][49] -> [SKIP][50] ([i915#5176]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb3/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-edp-1:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271]) +368 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl1/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][52] -> [SKIP][53] ([i915#5235]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658]) +8 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl4/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][55] ([i915#5939]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109642] / [fdo#111068] / [i915#658])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb6/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][57] -> [SKIP][58] ([fdo#109441]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#533])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2437]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@kms_writeback@writeback-fb-id.html
* igt@sysfs_clients@sema-25:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2994])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl2/igt@sysfs_clients@sema-25.html
* igt@sysfs_clients@split-25:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994]) +6 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl6/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][63] ([i915#4525]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][65] ([i915#2842]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][69] ([i915#2842]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-3/igt@gem_exec_fair@basic-throttle@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][71] ([i915#3281]) -> [PASS][72] +12 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][73] ([i915#3282]) -> [PASS][74] +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-1/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gen9_exec_parse@valid-registers:
- {shard-rkl}: [SKIP][75] ([i915#2527]) -> [PASS][76] +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-3/igt@gen9_exec_parse@valid-registers.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-5/igt@gen9_exec_parse@valid-registers.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-iclb: [WARN][77] ([i915#2684]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-rkl}: [SKIP][79] ([i915#1397]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@i915_pm_rpm@modeset-lpsp-stress.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_pm_sseu@full-enable:
- shard-skl: [FAIL][81] ([i915#7084]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-skl6/igt@i915_pm_sseu@full-enable.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl3/igt@i915_pm_sseu@full-enable.html
* igt@i915_suspend@basic-s2idle-without-i915:
- {shard-rkl}: [FAIL][83] ([fdo#103375]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-3/igt@i915_suspend@basic-s2idle-without-i915.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-5/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_cursor_legacy@cursor-vs-flip@atomic:
- shard-iclb: [FAIL][85] ([i915#5072]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@atomic.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb8/igt@kms_cursor_legacy@cursor-vs-flip@atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-iclb: [FAIL][87] ([i915#2346]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][89] ([i915#2122]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff:
- {shard-rkl}: [SKIP][91] ([i915#1849] / [i915#4098]) -> [PASS][92] +9 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl6/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl2/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_plane@plane-panning-top-left@pipe-a-planes:
- {shard-rkl}: [SKIP][95] ([i915#3558]) -> [PASS][96] +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][97] ([i915#5235]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr@primary_render:
- {shard-rkl}: [SKIP][99] ([i915#1072]) -> [PASS][100] +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@kms_psr@primary_render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@kms_psr@primary_render.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][101] ([fdo#109441]) -> [PASS][102] +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_rotation_crc@exhaust-fences:
- {shard-rkl}: [SKIP][103] ([i915#1845] / [i915#4098]) -> [PASS][104] +17 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@kms_rotation_crc@exhaust-fences.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@kms_rotation_crc@exhaust-fences.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- {shard-rkl}: [SKIP][105] ([i915#4070] / [i915#4098]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-1/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
* igt@sysfs_heartbeat_interval@precise@bcs0:
- {shard-dg1}: [FAIL][107] ([i915#1755]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-dg1-17/igt@sysfs_heartbeat_interval@precise@bcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-dg1-13/igt@sysfs_heartbeat_interval@precise@bcs0.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][109] ([i915#4098]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-rkl-4/igt@testdisplay.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-rkl-6/igt@testdisplay.html
#### Warnings ####
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [DMESG-FAIL][111] ([IGT#6]) -> [FAIL][112] ([i915#4573]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl3/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl1/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][113] ([i915#658]) -> [SKIP][114] ([i915#2920])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb1/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][115] ([i915#2920]) -> [SKIP][116] ([i915#658]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb1/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][117] ([fdo#111068] / [i915#658]) -> [SKIP][118] ([i915#2920])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][119] ([i915#2920]) -> [SKIP][120] ([fdo#111068] / [i915#658])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][121], [FAIL][122], [FAIL][123]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl8/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl1/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12487/shard-apl6/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl8/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl3/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl3/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/shard-apl6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5776]: https://gitlab.freedesktop.org/drm/intel/issues/5776
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7084]: https://gitlab.freedesktop.org/drm/intel/issues/7084
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7672]: https://gitlab.freedesktop.org/drm/intel/issues/7672
[i915#7681]: https://gitlab.freedesktop.org/drm/intel/issues/7681
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12487 -> Patchwork_111303v3
CI-20190529: 20190529
CI_DRM_12487: 1a2f5d78c35eb1b8812e3258dadb0d7e1027d710 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7088: 4b999091b8ee9cdea0dc35f48f1ee2ed415d6902 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v3: 1a2f5d78c35eb1b8812e3258dadb0d7e1027d710 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v3/index.html
[-- Attachment #2: Type: text/html, Size: 38146 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read
2022-12-09 10:45 ` Jani Nikula
@ 2022-12-13 5:44 ` Murthy, Arun R
2022-12-13 8:08 ` Jani Nikula
0 siblings, 1 reply; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-13 5:44 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx, ville.syrjala, Deak, Imre
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Friday, December 9, 2022 4:16 PM
> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
> <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: Re: [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to
> polling read
>
> On Fri, 09 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> > The busy timeout logic checks for the AUX BUSY, then waits for the
> > timeout period and then after timeout reads the register for BUSY or
> > Success.
> > Instead replace interrupt with polling so as to read the AUX CTL
> > register often before the timeout period. Looks like there might be
> > some issue with interrupt-on-read. Hence changing the logic to polling
> read.
> >
> > v2: replace interrupt with polling read
> > v3: use usleep_rang instead of msleep, updated commit msg
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 24
> > ++++++++++++---------
> > 1 file changed, 14 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > index 91c93c93e5fc..230f27d75846 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > @@ -41,21 +41,25 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> > const unsigned int timeout_ms = 10;
> > u32 status;
> > - bool done;
> > + int try;
> >
> > -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> > - msecs_to_jiffies_timeout(timeout_ms));
> > + for (try = 0; try < 10; try++) {
> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > + break;
> > + usleep_range(400, 500);
> > + }
> > + if (try == 3) {
> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> > + drm_err(&i915->drm,
> > + "%s: did not complete or timeout within
> %ums (status 0x%08x)\n",
> > + intel_dp->aux.name, timeout_ms, status);
> > + }
> >
> > /* just trace the final value */
> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> Okay, so there are still a bunch of issues above. For example, try < 10 vs. try
> == 3, reverting back to intel_uncore_* functions after conflict resolution,
> having duplicated reads and conditions.
The logic tries to read in a loop for 10 times with a sleep of 500usec between each reads.
Finally after the 10th iteration for the last time the register is read again and the status is returned.
>
> Now, I should've taken a step back earlier and realized you should use the
> helper we already have for this: intel_de_wait_for_register().
I checked this earlier. The reason for not opting this is this function is its
interrupt-on-read, but we need a polling read with timeout.
Thanks and Regards,
Arun R Murthy
--------------------
>
> All of the above shrinks to just a few lines:
>
> ret = intel_de_wait_for_register(i915, ch_ctl,
> DP_AUX_CH_CTL_SEND_BUSY, 0, timeout_ms);
> if (ret)
> drm_err(...);
>
> Sorry for missing this earlier.
>
> BR,
> Jani.
>
> >
> > - if (!done)
> > - drm_err(&i915->drm,
> > - "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> > - intel_dp->aux.name, timeout_ms, status);
> > -#undef C
> > -
> > return status;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read
2022-12-13 5:44 ` Murthy, Arun R
@ 2022-12-13 8:08 ` Jani Nikula
0 siblings, 0 replies; 42+ messages in thread
From: Jani Nikula @ 2022-12-13 8:08 UTC (permalink / raw)
To: Murthy, Arun R, intel-gfx, ville.syrjala, Deak, Imre
On Tue, 13 Dec 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> -----Original Message-----
>> From: Nikula, Jani <jani.nikula@intel.com>
>> Sent: Friday, December 9, 2022 4:16 PM
>> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
>> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
>> <imre.deak@intel.com>
>> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
>> Subject: Re: [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to
>> polling read
>>
>> On Fri, 09 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
>> > The busy timeout logic checks for the AUX BUSY, then waits for the
>> > timeout period and then after timeout reads the register for BUSY or
>> > Success.
>> > Instead replace interrupt with polling so as to read the AUX CTL
>> > register often before the timeout period. Looks like there might be
>> > some issue with interrupt-on-read. Hence changing the logic to polling
>> read.
>> >
>> > v2: replace interrupt with polling read
>> > v3: use usleep_rang instead of msleep, updated commit msg
>> >
>> > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 24
>> > ++++++++++++---------
>> > 1 file changed, 14 insertions(+), 10 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> > index 91c93c93e5fc..230f27d75846 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> > @@ -41,21 +41,25 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
>> > i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
>> > const unsigned int timeout_ms = 10;
>> > u32 status;
>> > - bool done;
>> > + int try;
>> >
>> > -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
>> DP_AUX_CH_CTL_SEND_BUSY) == 0)
>> > - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
>> > - msecs_to_jiffies_timeout(timeout_ms));
>> > + for (try = 0; try < 10; try++) {
>> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
>> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
>> > + break;
>> > + usleep_range(400, 500);
>> > + }
>> > + if (try == 3) {
>> > + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
>> > + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
>> > + drm_err(&i915->drm,
>> > + "%s: did not complete or timeout within
>> %ums (status 0x%08x)\n",
>> > + intel_dp->aux.name, timeout_ms, status);
>> > + }
>> >
>> > /* just trace the final value */
>> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>>
>> Okay, so there are still a bunch of issues above. For example, try < 10 vs. try
>> == 3, reverting back to intel_uncore_* functions after conflict resolution,
>> having duplicated reads and conditions.
> The logic tries to read in a loop for 10 times with a sleep of 500usec between each reads.
> Finally after the 10th iteration for the last time the register is read again and the status is returned.
Yeah, but the condition is (try == 3).
>
>>
>> Now, I should've taken a step back earlier and realized you should use the
>> helper we already have for this: intel_de_wait_for_register().
>
> I checked this earlier. The reason for not opting this is this function is its
> interrupt-on-read, but we need a polling read with timeout.
It *is* a polling read with a timeout, with a bunch of smarts.
BR,
Jani.
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
>>
>> All of the above shrinks to just a few lines:
>>
>> ret = intel_de_wait_for_register(i915, ch_ctl,
>> DP_AUX_CH_CTL_SEND_BUSY, 0, timeout_ms);
>> if (ret)
>> drm_err(...);
>>
>> Sorry for missing this earlier.
>>
>> BR,
>> Jani.
>>
>> >
>> > - if (!done)
>> > - drm_err(&i915->drm,
>> > - "%s: did not complete or timeout within %ums
>> (status 0x%08x)\n",
>> > - intel_dp->aux.name, timeout_ms, status);
>> > -#undef C
>> > -
>> > return status;
>> > }
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (9 preceding siblings ...)
2022-12-09 15:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-12-14 3:29 ` Arun R Murthy
2022-12-14 5:36 ` Murthy, Arun R
2022-12-14 9:29 ` Jani Nikula
2022-12-14 5:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev4) Patchwork
` (13 subsequent siblings)
24 siblings, 2 replies; 42+ messages in thread
From: Arun R Murthy @ 2022-12-14 3:29 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
v4: use intel_wait_for_regiter internal function
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..fe5ed432a66a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -41,20 +41,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
u32 status;
- bool done;
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ __intel_wait_for_register(&i915->uncore, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY,
+ DP_AUX_CH_CTL_SEND_BUSY,
+ 500, timeout_ms, &status);
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-
- if (!done)
+ status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
drm_err(&i915->drm,
"%s: did not complete or timeout within %ums (status 0x%08x)\n",
intel_dp->aux.name, timeout_ms, status);
-#undef C
+
+ /* just trace the final value */
+ trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev4)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (10 preceding siblings ...)
2022-12-14 3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-14 5:11 ` Patchwork
2022-12-14 16:21 ` [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
` (12 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-14 5:11 UTC (permalink / raw)
To: Murthy, Arun R; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 20916 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev4)
URL : https://patchwork.freedesktop.org/series/111303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12502 -> Patchwork_111303v4
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111303v4 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111303v4, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/index.html
Participating hosts (39 -> 38)
------------------------------
Additional (1): bat-atsm-1
Missing (2): bat-jsl-1 bat-jsl-3
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v4:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- bat-adlp-4: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-adlp-4/igt@i915_module_load@load.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adlp-4/igt@i915_module_load@load.html
* igt@i915_selftest@live@vma:
- fi-kbl-soraka: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@i915_selftest@live@vma.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@i915_selftest@live@vma.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-skl-6700k2: [PASS][5] -> [DMESG-WARN][6] +58 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6700k2/igt@i915_suspend@basic-s2idle-without-i915.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6700k2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- fi-bsw-kefka: [PASS][7] -> [DMESG-WARN][8] +27 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-bsw-kefka/igt@kms_addfb_basic@basic-y-tiled-legacy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-bsw-kefka/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@bo-too-small-due-to-tiling:
- fi-bsw-n3050: [PASS][9] -> [DMESG-WARN][10] +75 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-bsw-n3050/igt@kms_addfb_basic@bo-too-small-due-to-tiling.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-bsw-n3050/igt@kms_addfb_basic@bo-too-small-due-to-tiling.html
* igt@kms_addfb_basic@clobberred-modifier:
- fi-elk-e7500: [PASS][11] -> [DMESG-WARN][12] +57 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-elk-e7500/igt@kms_addfb_basic@clobberred-modifier.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-elk-e7500/igt@kms_addfb_basic@clobberred-modifier.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- fi-rkl-11600: [PASS][13] -> [DMESG-WARN][14] +50 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-rkl-11600/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-rkl-11600/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_addfb_basic@invalid-set-prop-any:
- fi-skl-guc: [PASS][15] -> [DMESG-WARN][16] +55 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-guc/igt@kms_addfb_basic@invalid-set-prop-any.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-guc/igt@kms_addfb_basic@invalid-set-prop-any.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1:
- fi-snb-2600: [PASS][17] -> [DMESG-WARN][18] +56 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-snb-2600/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-snb-2600/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-hdmi-a-2:
- fi-skl-guc: NOTRUN -> [DMESG-WARN][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-guc/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-hdmi-a-2.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-1:
- fi-skl-6700k2: NOTRUN -> [DMESG-WARN][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_module_load@load:
- {bat-adlp-6}: [PASS][21] -> [DMESG-WARN][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-adlp-6/igt@i915_module_load@load.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adlp-6/igt@i915_module_load@load.html
- {bat-adln-1}: [PASS][23] -> [DMESG-WARN][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-adln-1/igt@i915_module_load@load.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adln-1/igt@i915_module_load@load.html
- {bat-rplp-1}: [PASS][25] -> [DMESG-WARN][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-rplp-1/igt@i915_module_load@load.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-rplp-1/igt@i915_module_load@load.html
* igt@i915_selftest@live@uncore:
- {fi-jsl-1}: [PASS][27] -> [DMESG-FAIL][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-jsl-1/igt@i915_selftest@live@uncore.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-jsl-1/igt@i915_selftest@live@uncore.html
* igt@kms_addfb_basic@addfb25-bad-modifier:
- {bat-adlp-9}: [PASS][29] -> [DMESG-WARN][30] +87 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-adlp-9/igt@kms_addfb_basic@addfb25-bad-modifier.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adlp-9/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_addfb_basic@bad-pitch-63:
- {bat-adlm-1}: [PASS][31] -> [DMESG-WARN][32] +44 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-adlm-1/igt@kms_addfb_basic@bad-pitch-63.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adlm-1/igt@kms_addfb_basic@bad-pitch-63.html
* igt@kms_addfb_basic@clobberred-modifier:
- {bat-kbl-2}: [PASS][33] -> [DMESG-WARN][34] +88 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-kbl-2/igt@kms_addfb_basic@clobberred-modifier.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-kbl-2/igt@kms_addfb_basic@clobberred-modifier.html
* igt@kms_addfb_basic@invalid-set-prop-any:
- {bat-dg2-9}: [PASS][35] -> [DMESG-WARN][36] +49 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-dg2-9/igt@kms_addfb_basic@invalid-set-prop-any.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-dg2-9/igt@kms_addfb_basic@invalid-set-prop-any.html
- {bat-dg2-11}: [PASS][37] -> [DMESG-WARN][38] +48 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-dg2-11/igt@kms_addfb_basic@invalid-set-prop-any.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-dg2-11/igt@kms_addfb_basic@invalid-set-prop-any.html
* igt@kms_flip@basic-plain-flip@c-edp1:
- {fi-jsl-1}: [PASS][39] -> [DMESG-WARN][40] +98 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-jsl-1/igt@kms_flip@basic-plain-flip@c-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-jsl-1/igt@kms_flip@basic-plain-flip@c-edp1.html
Known issues
------------
Here are the changes found in Patchwork_111303v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-soraka: [PASS][41] -> [DMESG-WARN][42] ([i915#1982] / [i915#4391]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html
* igt@i915_module_load@load:
- fi-icl-u2: [PASS][43] -> [INCOMPLETE][44] ([i915#4391])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-icl-u2/igt@i915_module_load@load.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-icl-u2/igt@i915_module_load@load.html
- fi-skl-6700k2: [PASS][45] -> [DMESG-WARN][46] ([i915#92])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6700k2/igt@i915_module_load@load.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6700k2/igt@i915_module_load@load.html
- fi-kbl-8809g: [PASS][47] -> [DMESG-WARN][48] ([i915#4391]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-8809g/igt@i915_module_load@load.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-8809g/igt@i915_module_load@load.html
- fi-bsw-kefka: [PASS][49] -> [DMESG-WARN][50] ([i915#1982])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-bsw-kefka/igt@i915_module_load@load.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-bsw-kefka/igt@i915_module_load@load.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][51] -> [DMESG-FAIL][52] ([i915#4391] / [i915#5334])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [PASS][53] -> [DMESG-WARN][54] ([i915#4391]) +88 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@kms_addfb_basic@small-bo:
- fi-skl-6600u: [PASS][55] -> [DMESG-WARN][56] ([i915#4391]) +91 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6600u/igt@kms_addfb_basic@small-bo.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@kms_addfb_basic@small-bo.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][57] ([fdo#111827])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-rkl-guc/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_flip@basic-flip-vs-dpms@c-edp1:
- fi-kbl-soraka: [PASS][58] -> [DMESG-WARN][59] ([i915#4391] / [i915#62] / [i915#92]) +19 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@kms_flip@basic-flip-vs-dpms@c-edp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@kms_flip@basic-flip-vs-dpms@c-edp1.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-bsw-n3050: [PASS][60] -> [DMESG-WARN][61] ([i915#1982]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-edp-1:
- fi-skl-6600u: [PASS][62] -> [DMESG-WARN][63] ([i915#4391] / [i915#92]) +40 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6600u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-edp-1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-edp-1.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-edp-1:
- fi-kbl-soraka: [PASS][64] -> [DMESG-WARN][65] ([i915#4391]) +86 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-edp-1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-edp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- fi-skl-6600u: NOTRUN -> [SKIP][66] ([fdo#109271])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_psr@cursor_plane_move:
- fi-skl-6600u: [PASS][67] -> [SKIP][68] ([fdo#109271]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6600u/igt@kms_psr@cursor_plane_move.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_page_flip:
- fi-kbl-soraka: [PASS][69] -> [DMESG-WARN][70] ([i915#1982] / [i915#4391] / [i915#62] / [i915#92])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@kms_psr@primary_page_flip.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- bat-adlp-4: NOTRUN -> [FAIL][71] ([i915#4312])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-adlp-4/igt@runner@aborted.html
- fi-icl-u2: NOTRUN -> [FAIL][72] ([i915#4312])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-icl-u2/igt@runner@aborted.html
- fi-bsw-kefka: NOTRUN -> [FAIL][73] ([i915#4312])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-bsw-kefka/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][74] ([i915#7229]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [INCOMPLETE][76] ([i915#4983]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
- bat-dg1-5: [FAIL][78] ([fdo#103375]) -> [PASS][79] +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
#### Warnings ####
* igt@gem_lmem_swapping@basic:
- fi-skl-6600u: [SKIP][80] ([fdo#109271] / [i915#4613]) -> [SKIP][81] ([fdo#109271] / [i915#4613] / [i915#92])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6600u/igt@gem_lmem_swapping@basic.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@gem_lmem_swapping@basic.html
* igt@i915_module_load@reload:
- fi-kbl-8809g: [DMESG-WARN][82] ([i915#6899]) -> [DMESG-WARN][83] ([i915#4391] / [i915#6899])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-8809g/igt@i915_module_load@reload.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-8809g/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: [DMESG-FAIL][84] ([i915#1886]) -> [DMESG-FAIL][85] ([i915#1886] / [i915#4391])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6600u: [SKIP][86] ([fdo#109271] / [fdo#111827]) -> [SKIP][87] ([fdo#109271] / [fdo#111827] / [i915#92]) +7 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12502/fi-skl-6600u/igt@kms_chamelium@hdmi-crc-fast.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/fi-skl-6600u/igt@kms_chamelium@hdmi-crc-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6899]: https://gitlab.freedesktop.org/drm/intel/issues/6899
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_12502 -> Patchwork_111303v4
CI-20190529: 20190529
CI_DRM_12502: cc44a1e87ea6b788868878295119398966f98a81 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7092: 59e3bf83f6bae0918276f880f969a10d279c657a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v4: cc44a1e87ea6b788868878295119398966f98a81 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
dfcbc94fc459 drm/i915/dp: change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v4/index.html
[-- Attachment #2: Type: text/html, Size: 22790 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-14 3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-14 5:36 ` Murthy, Arun R
2022-12-14 9:29 ` Jani Nikula
1 sibling, 0 replies; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-14 5:36 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, Nikula, Jani, Deak, Imre
> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy@intel.com>
> Sent: Wednesday, December 14, 2022 9:00 AM
> To: intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Nikula, Jani
> <jani.nikula@intel.com>; Deak, Imre <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read
>
> The busy timeout logic checks for the AUX BUSY, then waits for the timeout
> period and then after timeout reads the register for BUSY or Success.
> Instead replace interrupt with polling so as to read the AUX CTL register often
> before the timeout period. Looks like there might be some issue with
> interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function(Jani N)
>
BAT is failing with using this intel_wait_for_register/intel_de_wait_for_register, this function does something more than required.
Thanks and Regards,
Arun R Murthy
---------------------
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..fe5ed432a66a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -41,20 +41,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
>
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + __intel_wait_for_register(&i915->uncore, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY,
> + DP_AUX_CH_CTL_SEND_BUSY,
> + 500, timeout_ms, &status);
>
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> -
> - if (!done)
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> drm_err(&i915->drm,
> "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> intel_dp->aux.name, timeout_ms, status); -#undef C
> +
> + /* just trace the final value */
> + trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> return status;
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-14 3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-14 5:36 ` Murthy, Arun R
@ 2022-12-14 9:29 ` Jani Nikula
1 sibling, 0 replies; 42+ messages in thread
From: Jani Nikula @ 2022-12-14 9:29 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Wed, 14 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period. Looks like there might be some
> issue with interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..fe5ed432a66a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -41,20 +41,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
>
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + __intel_wait_for_register(&i915->uncore, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY,
> + DP_AUX_CH_CTL_SEND_BUSY,
> + 500, timeout_ms, &status);
This waits for DP_AUX_CH_CTL_SEND_BUSY to be set, not cleared.
Please use intel_de_wait_for_register().
>
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> -
> - if (!done)
> + status = intel_uncore_read_notrace(&i915->uncore, ch_ctl);
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
Please check intel_de_wait_for_register()'s return value here instead of
reading the register once more.
You might read the register the register again just to log the value, if
intel_de_wait_for_register() returned != 0. But no need to trace log
that again.
> drm_err(&i915->drm,
> "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> intel_dp->aux.name, timeout_ms, status);
> -#undef C
> +
> + /* just trace the final value */
> + trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
intel_de_wait_for_register() already does the tracing of the final
value.
>
> return status;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (11 preceding siblings ...)
2022-12-14 5:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev4) Patchwork
@ 2022-12-14 16:21 ` Arun R Murthy
2022-12-15 9:05 ` Jani Nikula
2022-12-14 18:12 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev5) Patchwork
` (11 subsequent siblings)
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-14 16:21 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
v4: use intel_wait_for_regiter internal function
v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 35 ++++++---------------
1 file changed, 9 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..772da38b451f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -34,31 +34,6 @@ static void intel_dp_aux_unpack(u32 src, u8 *dst, int dst_bytes)
dst[i] = src >> ((3 - i) * 8);
}
-static u32
-intel_dp_aux_wait_done(struct intel_dp *intel_dp)
-{
- struct drm_i915_private *i915 = dp_to_i915(intel_dp);
- i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
- const unsigned int timeout_ms = 10;
- u32 status;
- bool done;
-
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
-
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-
- if (!done)
- drm_err(&i915->drm,
- "%s: did not complete or timeout within %ums (status 0x%08x)\n",
- intel_dp->aux.name, timeout_ms, status);
-#undef C
-
- return status;
-}
-
static u32 g4x_get_aux_clock_divider(struct intel_dp *intel_dp, int index)
{
struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
@@ -264,6 +239,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
}
while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) {
+ u32 timeout_ms = 10;
u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
send_bytes,
aux_clock_divider);
@@ -281,7 +257,14 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
/* Send the command and wait for it to complete */
intel_de_write(i915, ch_ctl, send_ctl);
- status = intel_dp_aux_wait_done(intel_dp);
+ __intel_de_wait_for_register(i915, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY, 0,
+ 500, timeout_ms, &status);
+
+ if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
+ drm_err(&i915->drm,
+ "%s: did not complete or timeout within %ums (status 0x%08x)\n",
+ intel_dp->aux.name, timeout_ms, status);
/* Clear done status and any errors */
intel_de_write(i915, ch_ctl,
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev5)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (12 preceding siblings ...)
2022-12-14 16:21 ` [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-14 18:12 ` Patchwork
2022-12-14 18:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (10 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-14 18:12 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev5)
URL : https://patchwork.freedesktop.org/series/111303/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Function parameter or member 'dsb' not described in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev5)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (13 preceding siblings ...)
2022-12-14 18:12 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev5) Patchwork
@ 2022-12-14 18:36 ` Patchwork
2022-12-15 9:55 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
` (9 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-14 18:36 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3667 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev5)
URL : https://patchwork.freedesktop.org/series/111303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12505 -> Patchwork_111303v5
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111303v5 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111303v5, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/index.html
Participating hosts (19 -> 19)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v5:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@toggle:
- fi-bsw-kefka: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12505/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@toggle.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@toggle.html
Known issues
------------
Here are the changes found in Patchwork_111303v5 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: NOTRUN -> [FAIL][3] ([fdo#103375])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][4] -> [INCOMPLETE][5] ([i915#4785])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12505/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][7] ([i915#4817]) -> [FAIL][8] ([fdo#103375])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12505/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
Build changes
-------------
* Linux: CI_DRM_12505 -> Patchwork_111303v5
CI-20190529: 20190529
CI_DRM_12505: ea0a9ea56dd94ef237bcbaf5ee3641474204a536 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7093: 9d8b6db28e504cc780c2c6af721214e18cc5ccd3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v5: ea0a9ea56dd94ef237bcbaf5ee3641474204a536 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
8a54fe5ebd73 drm/i915/dp: change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v5/index.html
[-- Attachment #2: Type: text/html, Size: 4456 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-14 16:21 ` [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-15 9:05 ` Jani Nikula
0 siblings, 0 replies; 42+ messages in thread
From: Jani Nikula @ 2022-12-15 9:05 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Wed, 14 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period. Looks like there might be some
> issue with interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function
> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 35 ++++++---------------
> 1 file changed, 9 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..772da38b451f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -34,31 +34,6 @@ static void intel_dp_aux_unpack(u32 src, u8 *dst, int dst_bytes)
> dst[i] = src >> ((3 - i) * 8);
> }
>
> -static u32
> -intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> -{
> - struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> - i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> - const unsigned int timeout_ms = 10;
> - u32 status;
> - bool done;
> -
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> -
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> -
> - if (!done)
> - drm_err(&i915->drm,
> - "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> - intel_dp->aux.name, timeout_ms, status);
> -#undef C
> -
> - return status;
> -}
> -
Please keep the function.
intel_dp_aux_xfer() is long enough as it is. It really doesn't need the
added lines, quite the opposite.
The intel_dp_aux_wait_done() also gives a name to what's being done.
> static u32 g4x_get_aux_clock_divider(struct intel_dp *intel_dp, int index)
> {
> struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> @@ -264,6 +239,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> }
>
> while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) {
> + u32 timeout_ms = 10;
> u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
> send_bytes,
> aux_clock_divider);
> @@ -281,7 +257,14 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
> /* Send the command and wait for it to complete */
> intel_de_write(i915, ch_ctl, send_ctl);
>
> - status = intel_dp_aux_wait_done(intel_dp);
> + __intel_de_wait_for_register(i915, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY, 0,
> + 500, timeout_ms, &status);
> +
> + if ((status & DP_AUX_CH_CTL_SEND_BUSY) != 0)
> + drm_err(&i915->drm,
> + "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> + intel_dp->aux.name, timeout_ms, status);
Please use the return value of intel_de_wait_for_register() to determine
the timeout instead of duplicating the condition. (Feels like I said
this a few times already?)
BR,
Jani.
>
> /* Clear done status and any errors */
> intel_de_write(i915, ch_ctl,
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (14 preceding siblings ...)
2022-12-14 18:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-12-15 9:55 ` Arun R Murthy
2022-12-15 10:30 ` Jani Nikula
2022-12-15 10:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6) Patchwork
` (8 subsequent siblings)
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-15 9:55 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
v4: use intel_wait_for_regiter internal function
v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
v6: check return value of __intel_de_wait_for_register
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..dec88f41380e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -40,21 +40,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
- u32 status;
- bool done;
-
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ u32 status, ret;
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
+ ret = __intel_de_wait_for_register(i915, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY, 0,
+ 500, timeout_ms, &status);
- if (!done)
+ if (ret == -ETIMEDOUT)
drm_err(&i915->drm,
"%s: did not complete or timeout within %ums (status 0x%08x)\n",
intel_dp->aux.name, timeout_ms, status);
-#undef C
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (15 preceding siblings ...)
2022-12-15 9:55 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-15 10:10 ` Patchwork
2022-12-15 10:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (7 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-15 10:10 UTC (permalink / raw)
To: Murthy, Arun R; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev6)
URL : https://patchwork.freedesktop.org/series/111303/
State : warning
== Summary ==
Error: dim checkpatch failed
244c68782e95 drm/i915/dp: change aux_ctl reg read to polling read
-:40: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#40: FILE: drivers/gpu/drm/i915/display/intel_dp_aux.c:46:
+ ret = __intel_de_wait_for_register(i915, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY, 0,
total: 0 errors, 0 warnings, 1 checks, 26 lines checked
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-15 9:55 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-15 10:30 ` Jani Nikula
2022-12-15 10:37 ` Murthy, Arun R
0 siblings, 1 reply; 42+ messages in thread
From: Jani Nikula @ 2022-12-15 10:30 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Thu, 15 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period. Looks like there might be some
> issue with interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function
> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
> v6: check return value of __intel_de_wait_for_register
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..dec88f41380e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -40,21 +40,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> - u32 status;
> - bool done;
> -
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + u32 status, ret;
>
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> + ret = __intel_de_wait_for_register(i915, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY, 0,
> + 500, timeout_ms, &status);
>
> - if (!done)
> + if (ret == -ETIMEDOUT)
What's wrong with this comparison? Although it probably does work by
coincidence.
BR,
Jani.
> drm_err(&i915->drm,
> "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> intel_dp->aux.name, timeout_ms, status);
> -#undef C
>
> return status;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev6)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (16 preceding siblings ...)
2022-12-15 10:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6) Patchwork
@ 2022-12-15 10:34 ` Patchwork
2022-12-15 11:13 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
` (6 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-15 10:34 UTC (permalink / raw)
To: Murthy, Arun R; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3625 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev6)
URL : https://patchwork.freedesktop.org/series/111303/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12508 -> Patchwork_111303v6
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111303v6 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111303v6, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/index.html
Participating hosts (19 -> 19)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v6:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-snb-2600: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12508/fi-snb-2600/igt@i915_suspend@basic-s2idle-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/fi-snb-2600/igt@i915_suspend@basic-s2idle-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_111303v6 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][3] ([i915#6179])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_softpin@allocator-basic:
- fi-ivb-3770: NOTRUN -> [SKIP][4] ([fdo#109271]) +18 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/fi-ivb-3770/igt@gem_softpin@allocator-basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/fi-ivb-3770/igt@kms_chamelium@common-hpd-after-suspend.html
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][6] ([i915#4817]) -> [FAIL][7] ([fdo#103375])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12508/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#6179]: https://gitlab.freedesktop.org/drm/intel/issues/6179
Build changes
-------------
* Linux: CI_DRM_12508 -> Patchwork_111303v6
CI-20190529: 20190529
CI_DRM_12508: 50bbaf39d655c47685f84dd1fb0c2cb4fb7e5286 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7094: 1763071e9d50c5e992257c9197cb26f166de6fae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v6: 50bbaf39d655c47685f84dd1fb0c2cb4fb7e5286 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a62c9c7447a9 drm/i915/dp: change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v6/index.html
[-- Attachment #2: Type: text/html, Size: 4409 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-15 10:30 ` Jani Nikula
@ 2022-12-15 10:37 ` Murthy, Arun R
0 siblings, 0 replies; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-15 10:37 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx, ville.syrjala, Deak, Imre
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Thursday, December 15, 2022 4:00 PM
> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
> <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: Re: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
>
> On Thu, 15 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> > The busy timeout logic checks for the AUX BUSY, then waits for the
> > timeout period and then after timeout reads the register for BUSY or
> > Success.
> > Instead replace interrupt with polling so as to read the AUX CTL
> > register often before the timeout period. Looks like there might be
> > some issue with interrupt-on-read. Hence changing the logic to polling
> read.
> >
> > v2: replace interrupt with polling read
> > v3: use usleep_rang instead of msleep, updated commit msg
> > v4: use intel_wait_for_regiter internal function
> > v5: use __intel_de_wait_for_register with 500us slow and 10ms fast
> > timeout
> > v6: check return value of __intel_de_wait_for_register
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 15 +++++----------
> > 1 file changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > index 91c93c93e5fc..dec88f41380e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > @@ -40,21 +40,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> > i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> > const unsigned int timeout_ms = 10;
> > - u32 status;
> > - bool done;
> > -
> > -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> > - msecs_to_jiffies_timeout(timeout_ms));
> > + u32 status, ret;
> >
> > - /* just trace the final value */
> > - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> > + ret = __intel_de_wait_for_register(i915, ch_ctl,
> > + DP_AUX_CH_CTL_SEND_BUSY, 0,
> > + 500, timeout_ms, &status);
> >
> > - if (!done)
> > + if (ret == -ETIMEDOUT)
>
> What's wrong with this comparison? Although it probably does work by
> coincidence.
>
If (ret)
dev_err();
Will also work, but for code readability using -ETIMEDOUT(sorry missed the declaration int ret;)
Thanks and Regards,
Arun R Murthy
--------------------
> BR,
> Jani.
>
>
> > drm_err(&i915->drm,
> > "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> > intel_dp->aux.name, timeout_ms, status); -#undef C
> >
> > return status;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (17 preceding siblings ...)
2022-12-15 10:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-12-15 11:13 ` Arun R Murthy
2022-12-19 10:17 ` Murthy, Arun R
2022-12-15 14:14 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8) Patchwork
` (5 subsequent siblings)
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-15 11:13 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
v4: use intel_wait_for_regiter internal function
v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
v6: check return value of __intel_de_wait_for_register
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..973dadecf712 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
u32 status;
- bool done;
-
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ int ret;
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
+ ret = __intel_de_wait_for_register(i915, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY, 0,
+ 500, timeout_ms, &status);
- if (!done)
+ if (ret == -ETIMEDOUT)
drm_err(&i915->drm,
"%s: did not complete or timeout within %ums (status 0x%08x)\n",
intel_dp->aux.name, timeout_ms, status);
-#undef C
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (18 preceding siblings ...)
2022-12-15 11:13 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-15 14:14 ` Patchwork
2022-12-15 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-15 14:14 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8)
URL : https://patchwork.freedesktop.org/series/111303/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Function parameter or member 'dsb' not described in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev8)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (19 preceding siblings ...)
2022-12-15 14:14 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8) Patchwork
@ 2022-12-15 14:37 ` Patchwork
2022-12-16 13:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-15 14:37 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 18190 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12510 -> Patchwork_111303v8
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/index.html
Participating hosts (19 -> 40)
------------------------------
Additional (21): fi-kbl-soraka bat-dg1-6 bat-dg1-5 bat-adlp-6 bat-rpls-1 bat-rpls-2 fi-skl-6600u fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adln-1 bat-atsm-1 bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick bat-dg1-7 bat-kbl-2 bat-adlp-9 bat-adlp-4
Known issues
------------
Here are the changes found in Patchwork_111303v8 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-snb-2600: [PASS][1] -> [FAIL][2] ([i915#4338])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/fi-snb-2600/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-snb-2600/boot.html
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@debugfs_test@basic-hwmon.html
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +7 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
- fi-pnv-d510: [PASS][5] -> [FAIL][6] ([i915#7229])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bsw-nick: NOTRUN -> [SKIP][10] ([fdo#109271]) +39 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-bsw-nick/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][11] ([fdo#109271]) +20 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html
- fi-skl-6600u: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-skl-6600u/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][13] ([i915#4613]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#4083])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@gem_mmap@basic.html
- bat-dg1-6: NOTRUN -> [SKIP][15] ([i915#4083])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][16] ([i915#4079]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][17] ([i915#4077]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html
- bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4077]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#4079]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][20] ([i915#3282])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][21] ([i915#7561])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#7561])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: NOTRUN -> [SKIP][23] ([i915#6621])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@i915_pm_rps@basic-api.html
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#6621])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@i915_pm_rps@basic-api.html
- bat-adlp-4: NOTRUN -> [SKIP][25] ([i915#6621])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][26] ([i915#7156])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][27] ([i915#1886])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][28] ([i915#4212]) +7 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][29] ([i915#4215])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
- bat-dg1-6: NOTRUN -> [SKIP][30] ([i915#4215])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][31] ([i915#4212]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][32] ([fdo#111827]) +8 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-edid-read:
- fi-bsw-n3050: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +8 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-bsw-n3050/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6600u: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +8 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-skl-6600u/igt@kms_chamelium@hdmi-crc-fast.html
- bat-dg1-6: NOTRUN -> [SKIP][35] ([fdo#111827]) +8 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bsw-nick: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +8 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-bsw-nick/igt@kms_chamelium@hdmi-hpd-fast.html
- bat-dg1-5: NOTRUN -> [SKIP][37] ([fdo#111827]) +8 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-soraka: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +7 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-adlp-4: NOTRUN -> [SKIP][39] ([i915#4103])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- bat-dg1-5: NOTRUN -> [SKIP][40] ([i915#4103] / [i915#4213])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- bat-dg1-6: NOTRUN -> [SKIP][41] ([i915#4103] / [i915#4213])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][42] ([fdo#109285])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-6: NOTRUN -> [SKIP][43] ([fdo#109285])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][44] ([i915#4093]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][45] ([i915#1072] / [i915#4078]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
- bat-dg1-5: NOTRUN -> [SKIP][46] ([i915#1072] / [i915#4078]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-6: NOTRUN -> [SKIP][47] ([i915#3555])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg1-5: NOTRUN -> [SKIP][48] ([i915#3555])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][49] ([i915#3555] / [i915#4579])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][50] ([i915#3708]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][51] ([i915#3708] / [i915#4077]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@prime_vgem@basic-gtt.html
- bat-dg1-6: NOTRUN -> [SKIP][52] ([i915#3708] / [i915#4077]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-dg1-6: NOTRUN -> [SKIP][53] ([i915#3708]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][54] ([fdo#109295] / [i915#3301] / [i915#3708])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- fi-skl-6600u: NOTRUN -> [SKIP][55] ([fdo#109271]) +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-skl-6600u/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][56] ([i915#3708] / [i915#4873])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-5/igt@prime_vgem@basic-userptr.html
- bat-dg1-6: NOTRUN -> [SKIP][57] ([i915#3708] / [i915#4873])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-dg1-6/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][58] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/bat-adlp-4/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][59] ([i915#6298]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4338]: https://gitlab.freedesktop.org/drm/intel/issues/4338
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7498]: https://gitlab.freedesktop.org/drm/intel/issues/7498
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12510 -> Patchwork_111303v8
CI-20190529: 20190529
CI_DRM_12510: e7a0d02714edf5ceac30b8da5ed7151d7dadbd40 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7094: 1763071e9d50c5e992257c9197cb26f166de6fae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v8: e7a0d02714edf5ceac30b8da5ed7151d7dadbd40 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
fe77b559f946 drm/i915/dp: change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/index.html
[-- Attachment #2: Type: text/html, Size: 21619 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev8)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (20 preceding siblings ...)
2022-12-15 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-12-16 13:42 ` Patchwork
2022-12-21 3:32 ` [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
` (2 subsequent siblings)
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-16 13:42 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10756 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev8)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12510_full -> Patchwork_111303v8_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (14 -> 9)
------------------------------
Missing (5): shard-tglu shard-tglu-10 shard-tglu-9 shard-rkl shard-dg1
Known issues
------------
Here are the changes found in Patchwork_111303v8_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][3] -> [SKIP][4] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-tglb2/igt@gem_huc_copy@huc-copy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][9] ([i915#2587] / [i915#2672]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#2672]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][11] ([i915#2672] / [i915#3555])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109441])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][14] -> [SKIP][15] ([i915#5519])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [SKIP][16] ([i915#4525]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb3/igt@gem_exec_balancer@parallel-contexts.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb2/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][20] ([i915#3989] / [i915#454]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][22] ([i915#5235]) -> [PASS][23] +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][24] ([fdo#109441]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][26] ([i915#5519]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-tglb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
- shard-iclb: [SKIP][28] ([i915#5519]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb3/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
#### Warnings ####
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [FAIL][30] ([i915#4573]) -> [DMESG-FAIL][31] ([IGT#6]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-apl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl2/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][32] ([i915#2920]) -> [SKIP][33] ([i915#658])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb6/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][34] ([fdo#111068] / [i915#658]) -> [SKIP][35] ([i915#2920])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][36], [FAIL][37]) ([i915#3002] / [i915#4312]) -> ([FAIL][38], [FAIL][39], [FAIL][40], [FAIL][41], [FAIL][42]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-apl8/igt@runner@aborted.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/shard-apl3/igt@runner@aborted.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl8/igt@runner@aborted.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl8/igt@runner@aborted.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl6/igt@runner@aborted.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl1/igt@runner@aborted.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/shard-apl1/igt@runner@aborted.html
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
Build changes
-------------
* Linux: CI_DRM_12510 -> Patchwork_111303v8
CI-20190529: 20190529
CI_DRM_12510: e7a0d02714edf5ceac30b8da5ed7151d7dadbd40 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7094: 1763071e9d50c5e992257c9197cb26f166de6fae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v8: e7a0d02714edf5ceac30b8da5ed7151d7dadbd40 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v8/index.html
[-- Attachment #2: Type: text/html, Size: 12728 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-15 11:13 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-19 10:17 ` Murthy, Arun R
2022-12-20 16:02 ` Jani Nikula
0 siblings, 1 reply; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-19 10:17 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, Nikula, Jani, Deak, Imre
Any comments?
Thanks and Regards,
Arun R Murthy
--------------------
> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy@intel.com>
> Sent: Thursday, December 15, 2022 4:44 PM
> To: intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Nikula, Jani
> <jani.nikula@intel.com>; Deak, Imre <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
>
> The busy timeout logic checks for the AUX BUSY, then waits for the timeout
> period and then after timeout reads the register for BUSY or Success.
> Instead replace interrupt with polling so as to read the AUX CTL register often
> before the timeout period. Looks like there might be some issue with
> interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function
> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
> v6: check return value of __intel_de_wait_for_register
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..973dadecf712 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
> -
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + int ret;
>
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> + ret = __intel_de_wait_for_register(i915, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY, 0,
> + 500, timeout_ms, &status);
>
> - if (!done)
> + if (ret == -ETIMEDOUT)
> drm_err(&i915->drm,
> "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> intel_dp->aux.name, timeout_ms, status); -#undef C
>
> return status;
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-19 10:17 ` Murthy, Arun R
@ 2022-12-20 16:02 ` Jani Nikula
2022-12-20 16:54 ` Murthy, Arun R
0 siblings, 1 reply; 42+ messages in thread
From: Jani Nikula @ 2022-12-20 16:02 UTC (permalink / raw)
To: Murthy, Arun R, intel-gfx, ville.syrjala, Deak, Imre
On Mon, 19 Dec 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
> Any comments?
From #intel-gfx:
<vsyrjala> bashing the hw for 500 usec seems a bit harsh
Which is true. The default for intel_de_wait_for_register() is 2
us. Should probably stick to that.
BR,
Jani.
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
>
>> -----Original Message-----
>> From: Murthy, Arun R <arun.r.murthy@intel.com>
>> Sent: Thursday, December 15, 2022 4:44 PM
>> To: intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Nikula, Jani
>> <jani.nikula@intel.com>; Deak, Imre <imre.deak@intel.com>
>> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
>> Subject: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
>>
>> The busy timeout logic checks for the AUX BUSY, then waits for the timeout
>> period and then after timeout reads the register for BUSY or Success.
>> Instead replace interrupt with polling so as to read the AUX CTL register often
>> before the timeout period. Looks like there might be some issue with
>> interrupt-on-read. Hence changing the logic to polling read.
>>
>> v2: replace interrupt with polling read
>> v3: use usleep_rang instead of msleep, updated commit msg
>> v4: use intel_wait_for_regiter internal function
>> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
>> v6: check return value of __intel_de_wait_for_register
>>
>> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
>> 1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> index 91c93c93e5fc..973dadecf712 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
>> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
>> const unsigned int timeout_ms = 10;
>> u32 status;
>> - bool done;
>> -
>> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
>> DP_AUX_CH_CTL_SEND_BUSY) == 0)
>> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
>> - msecs_to_jiffies_timeout(timeout_ms));
>> + int ret;
>>
>> - /* just trace the final value */
>> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>> + ret = __intel_de_wait_for_register(i915, ch_ctl,
>> + DP_AUX_CH_CTL_SEND_BUSY, 0,
>> + 500, timeout_ms, &status);
>>
>> - if (!done)
>> + if (ret == -ETIMEDOUT)
>> drm_err(&i915->drm,
>> "%s: did not complete or timeout within %ums
>> (status 0x%08x)\n",
>> intel_dp->aux.name, timeout_ms, status); -#undef C
>>
>> return status;
>> }
>> --
>> 2.25.1
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-20 16:02 ` Jani Nikula
@ 2022-12-20 16:54 ` Murthy, Arun R
2022-12-20 20:58 ` Jani Nikula
0 siblings, 1 reply; 42+ messages in thread
From: Murthy, Arun R @ 2022-12-20 16:54 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx, ville.syrjala, Deak, Imre
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Tuesday, December 20, 2022 9:33 PM
> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
> <imre.deak@intel.com>
> Subject: RE: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
>
> On Mon, 19 Dec 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
> > Any comments?
>
> From #intel-gfx:
>
> <vsyrjala> bashing the hw for 500 usec seems a bit harsh
>
> Which is true. The default for intel_de_wait_for_register() is 2 us. Should
> probably stick to that.
Recommendation as per windows code base is 50us interval for polling the register, so will change it to 50us.
Thanks and Regards,
Arun R Murthy
--------------------
>
> BR,
> Jani.
>
>
> >
> > Thanks and Regards,
> > Arun R Murthy
> > --------------------
> >
> >> -----Original Message-----
> >> From: Murthy, Arun R <arun.r.murthy@intel.com>
> >> Sent: Thursday, December 15, 2022 4:44 PM
> >> To: intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com;
> >> Nikula, Jani <jani.nikula@intel.com>; Deak, Imre
> >> <imre.deak@intel.com>
> >> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> >> Subject: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling
> >> read
> >>
> >> The busy timeout logic checks for the AUX BUSY, then waits for the
> >> timeout period and then after timeout reads the register for BUSY or
> Success.
> >> Instead replace interrupt with polling so as to read the AUX CTL
> >> register often before the timeout period. Looks like there might be
> >> some issue with interrupt-on-read. Hence changing the logic to polling
> read.
> >>
> >> v2: replace interrupt with polling read
> >> v3: use usleep_rang instead of msleep, updated commit msg
> >> v4: use intel_wait_for_regiter internal function
> >> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast
> >> timeout
> >> v6: check return value of __intel_de_wait_for_register
> >>
> >> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
> >> 1 file changed, 5 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> >> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> >> index 91c93c93e5fc..973dadecf712 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> >> @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp
> *intel_dp)
> >> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> >> const unsigned int timeout_ms = 10;
> >> u32 status;
> >> - bool done;
> >> -
> >> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> >> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> >> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> >> - msecs_to_jiffies_timeout(timeout_ms));
> >> + int ret;
> >>
> >> - /* just trace the final value */
> >> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> >> + ret = __intel_de_wait_for_register(i915, ch_ctl,
> >> + DP_AUX_CH_CTL_SEND_BUSY, 0,
> >> + 500, timeout_ms, &status);
> >>
> >> - if (!done)
> >> + if (ret == -ETIMEDOUT)
> >> drm_err(&i915->drm,
> >> "%s: did not complete or timeout within %ums
> >> (status 0x%08x)\n",
> >> intel_dp->aux.name, timeout_ms, status);
> >> -#undef C
> >>
> >> return status;
> >> }
> >> --
> >> 2.25.1
> >
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-20 16:54 ` Murthy, Arun R
@ 2022-12-20 20:58 ` Jani Nikula
0 siblings, 0 replies; 42+ messages in thread
From: Jani Nikula @ 2022-12-20 20:58 UTC (permalink / raw)
To: Murthy, Arun R, intel-gfx, ville.syrjala, Deak, Imre
On Tue, 20 Dec 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> -----Original Message-----
>> From: Nikula, Jani <jani.nikula@intel.com>
>> Sent: Tuesday, December 20, 2022 9:33 PM
>> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
>> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
>> <imre.deak@intel.com>
>> Subject: RE: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read
>>
>> On Mon, 19 Dec 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> > Any comments?
>>
>> From #intel-gfx:
>>
>> <vsyrjala> bashing the hw for 500 usec seems a bit harsh
>>
>> Which is true. The default for intel_de_wait_for_register() is 2 us. Should
>> probably stick to that.
>
> Recommendation as per windows code base is 50us interval for polling
> the register, so will change it to 50us.
The parameter is *not* the interval. It's the timeout for fast wait in a
loop with just cpu_relax() in between. So please keep it 2 us.
If the condition doesn't happen in the fast timeout, it'll fall back to
the slow wait (in this case 10 ms timeout), which starts off with 10 us
interval, doubling on every poll until it's above 1000 us.
BR,
Jani.
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
>>
>> BR,
>> Jani.
>>
>>
>> >
>> > Thanks and Regards,
>> > Arun R Murthy
>> > --------------------
>> >
>> >> -----Original Message-----
>> >> From: Murthy, Arun R <arun.r.murthy@intel.com>
>> >> Sent: Thursday, December 15, 2022 4:44 PM
>> >> To: intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com;
>> >> Nikula, Jani <jani.nikula@intel.com>; Deak, Imre
>> >> <imre.deak@intel.com>
>> >> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
>> >> Subject: [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling
>> >> read
>> >>
>> >> The busy timeout logic checks for the AUX BUSY, then waits for the
>> >> timeout period and then after timeout reads the register for BUSY or
>> Success.
>> >> Instead replace interrupt with polling so as to read the AUX CTL
>> >> register often before the timeout period. Looks like there might be
>> >> some issue with interrupt-on-read. Hence changing the logic to polling
>> read.
>> >>
>> >> v2: replace interrupt with polling read
>> >> v3: use usleep_rang instead of msleep, updated commit msg
>> >> v4: use intel_wait_for_regiter internal function
>> >> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast
>> >> timeout
>> >> v6: check return value of __intel_de_wait_for_register
>> >>
>> >> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>> >> ---
>> >> drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
>> >> 1 file changed, 5 insertions(+), 9 deletions(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> >> b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> >> index 91c93c93e5fc..973dadecf712 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
>> >> @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp
>> *intel_dp)
>> >> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
>> >> const unsigned int timeout_ms = 10;
>> >> u32 status;
>> >> - bool done;
>> >> -
>> >> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
>> >> DP_AUX_CH_CTL_SEND_BUSY) == 0)
>> >> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
>> >> - msecs_to_jiffies_timeout(timeout_ms));
>> >> + int ret;
>> >>
>> >> - /* just trace the final value */
>> >> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>> >> + ret = __intel_de_wait_for_register(i915, ch_ctl,
>> >> + DP_AUX_CH_CTL_SEND_BUSY, 0,
>> >> + 500, timeout_ms, &status);
>> >>
>> >> - if (!done)
>> >> + if (ret == -ETIMEDOUT)
>> >> drm_err(&i915->drm,
>> >> "%s: did not complete or timeout within %ums
>> >> (status 0x%08x)\n",
>> >> intel_dp->aux.name, timeout_ms, status);
>> >> -#undef C
>> >>
>> >> return status;
>> >> }
>> >> --
>> >> 2.25.1
>> >
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (21 preceding siblings ...)
2022-12-16 13:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-12-21 3:32 ` Arun R Murthy
2023-01-04 13:27 ` Jani Nikula
2022-12-22 1:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9) Patchwork
2022-12-22 5:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
24 siblings, 1 reply; 42+ messages in thread
From: Arun R Murthy @ 2022-12-21 3:32 UTC (permalink / raw)
To: intel-gfx, ville.syrjala, jani.nikula, imre.deak
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with interrupt-on-read. Hence changing the logic to polling read.
v2: replace interrupt with polling read
v3: use usleep_rang instead of msleep, updated commit msg
v4: use intel_wait_for_regiter internal function
v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
v6: check return value of __intel_de_wait_for_register
v7: using default 2us for intel_de_wait_for_register
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 91c93c93e5fc..5a176bfb10a2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
const unsigned int timeout_ms = 10;
u32 status;
- bool done;
-
-#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
- done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
- msecs_to_jiffies_timeout(timeout_ms));
+ int ret;
- /* just trace the final value */
- trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
+ ret = __intel_de_wait_for_register(i915, ch_ctl,
+ DP_AUX_CH_CTL_SEND_BUSY, 0,
+ 2, timeout_ms, &status);
- if (!done)
+ if (ret == -ETIMEDOUT)
drm_err(&i915->drm,
"%s: did not complete or timeout within %ums (status 0x%08x)\n",
intel_dp->aux.name, timeout_ms, status);
-#undef C
return status;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (22 preceding siblings ...)
2022-12-21 3:32 ` [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2022-12-22 1:35 ` Patchwork
2022-12-22 5:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-22 1:35 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3839 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev9)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12519 -> Patchwork_111303v9
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/index.html
Participating hosts (47 -> 45)
------------------------------
Missing (2): bat-atsm-1 fi-tgl-dsi
Known issues
------------
Here are the changes found in Patchwork_111303v9 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-ilk-650: [PASS][1] -> [FAIL][2] ([i915#7350])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/fi-ilk-650/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/fi-ilk-650/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: NOTRUN -> [FAIL][3] ([fdo#103375])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- {bat-adlp-6}: [INCOMPLETE][5] ([i915#4983] / [i915#6257]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/bat-adlp-6/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/bat-adlp-6/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][7] ([i915#4817]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7350]: https://gitlab.freedesktop.org/drm/intel/issues/7350
[i915#7351]: https://gitlab.freedesktop.org/drm/intel/issues/7351
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
Build changes
-------------
* Linux: CI_DRM_12519 -> Patchwork_111303v9
CI-20190529: 20190529
CI_DRM_12519: 55945e9eb4ad6f1273f70e54c805c0965f23c547 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7101: bd33b4c060eb6b2e24c5784b2aa817ae5840f84f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v9: 55945e9eb4ad6f1273f70e54c805c0965f23c547 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
31edded26885 drm/i915/dp: change aux_ctl reg read to polling read
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/index.html
[-- Attachment #2: Type: text/html, Size: 4088 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9)
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
` (23 preceding siblings ...)
2022-12-22 1:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9) Patchwork
@ 2022-12-22 5:27 ` Patchwork
24 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2022-12-22 5:27 UTC (permalink / raw)
To: Arun R Murthy; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 25521 bytes --]
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev9)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_111303v9_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/index.html
Participating hosts (13 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111303v9_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-dg1-17/igt@gem_ctx_freq@sysfs.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-dg1-13/igt@gem_ctx_freq@sysfs.html
* igt@vc4/vc4_perfmon@create-two-perfmon:
- {shard-rkl}: [SKIP][3] ([i915#7711]) -> [SKIP][4] +43 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-4/igt@vc4/vc4_perfmon@create-two-perfmon.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-1/igt@vc4/vc4_perfmon@create-two-perfmon.html
* igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem:
- {shard-dg1}: [SKIP][5] ([i915#7711]) -> [SKIP][6] +44 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-dg1-13/igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-dg1-19/igt@vc4/vc4_purgeable_bo@access-purgeable-bo-mem.html
Known issues
------------
Here are the changes found in Patchwork_111303v9_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk7/igt@gem_huc_copy@huc-copy.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3323])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@gem_userptr_blits@dmabuf-sync.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#7205])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk7/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][18] -> [INCOMPLETE][19] ([i915#5213])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk9/igt@perf@stress-open-close.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk1/igt@perf@stress-open-close.html
* igt@sysfs_clients@recycle:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#2994])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@sysfs_clients@recycle.html
* igt@vc4/vc4_perfmon@create-perfmon-exceed:
- shard-glk: NOTRUN -> [SKIP][21] ([fdo#109271]) +66 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@vc4/vc4_perfmon@create-perfmon-exceed.html
#### Possible fixes ####
* igt@fbdev@info:
- {shard-rkl}: [SKIP][22] ([i915#2582]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-2/igt@fbdev@info.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@fbdev@info.html
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][24] ([i915#658]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@feature_discovery@psr1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][26] ([i915#6252]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-3/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][28] ([fdo#103375]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-5/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_nop@basic-series:
- shard-glk: [DMESG-WARN][30] ([i915#118]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk9/igt@gem_exec_nop@basic-series.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk1/igt@gem_exec_nop@basic-series.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][32] ([i915#3281]) -> [PASS][33] +9 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@gem_exec_reloc@basic-wc-read-noreloc.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-5/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][34] ([i915#3282]) -> [PASS][35] +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][36] ([i915#5566] / [i915#716]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk5/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][38] ([i915#2527]) -> [PASS][39] +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-4/igt@gen9_exec_parse@bb-start-out.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][40] ([i915#3361]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-tglu}: [SKIP][42] ([i915#3547]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@i915_pm_rpm@drm-resources-equal.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_rpm@fences:
- {shard-rkl}: [SKIP][44] ([i915#1849]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@i915_pm_rpm@fences.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@i915_pm_rpm@fences.html
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-tglu}: [SKIP][46] ([i915#1397]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@i915_pm_rpm@modeset-lpsp.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][48] ([i915#1397]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- {shard-tglu}: [SKIP][50] ([i915#1845] / [i915#7651]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][52] ([i915#2346]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_draw_crc@fill-fb:
- {shard-tglu}: [SKIP][54] ([i915#1845]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@kms_draw_crc@fill-fb.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@kms_draw_crc@fill-fb.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- {shard-rkl}: [SKIP][56] ([i915#1849] / [i915#4098]) -> [PASS][57] +15 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- {shard-tglu}: [SKIP][58] ([i915#1849]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][60] ([i915#3558]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@cursor_mmap_cpu:
- {shard-rkl}: [SKIP][62] ([i915#1072]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-1/igt@kms_psr@cursor_mmap_cpu.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_rotation_crc@bad-tiling:
- {shard-tglu}: [SKIP][64] ([i915#7651]) -> [PASS][65] +8 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@kms_rotation_crc@bad-tiling.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@kms_rotation_crc@bad-tiling.html
* igt@kms_rotation_crc@primary-rotation-90:
- {shard-rkl}: [SKIP][66] ([i915#1845] / [i915#4098]) -> [PASS][67] +20 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-3/igt@kms_rotation_crc@primary-rotation-90.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-b:
- {shard-tglu}: [SKIP][68] ([fdo#109274]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-tglu-6/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- {shard-rkl}: [SKIP][70] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-2/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][72] ([fdo#109289]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-3/igt@perf@gen12-oa-tlb-invalidate.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][74] ([i915#4349]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-dg1-15/igt@perf_pmu@idle@rcs0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-dg1-17/igt@perf_pmu@idle@rcs0.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][76] ([i915#4098]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12519/shard-rkl-2/igt@testdisplay.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7205]: https://gitlab.freedesktop.org/drm/intel/issues/7205
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7681]: https://gitlab.freedesktop.org/drm/intel/issues/7681
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
Build changes
-------------
* Linux: CI_DRM_12519 -> Patchwork_111303v9
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12519: 55945e9eb4ad6f1273f70e54c805c0965f23c547 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7101: bd33b4c060eb6b2e24c5784b2aa817ae5840f84f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111303v9: 55945e9eb4ad6f1273f70e54c805c0965f23c547 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111303v9/index.html
[-- Attachment #2: Type: text/html, Size: 21553 bytes --]
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read
2022-12-21 3:32 ` [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
@ 2023-01-04 13:27 ` Jani Nikula
2023-01-04 15:21 ` Murthy, Arun R
0 siblings, 1 reply; 42+ messages in thread
From: Jani Nikula @ 2023-01-04 13:27 UTC (permalink / raw)
To: Arun R Murthy, intel-gfx, ville.syrjala, imre.deak
On Wed, 21 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout period. Looks like there might be some
> issue with interrupt-on-read. Hence changing the logic to polling read.
>
> v2: replace interrupt with polling read
> v3: use usleep_rang instead of msleep, updated commit msg
> v4: use intel_wait_for_regiter internal function
> v5: use __intel_de_wait_for_register with 500us slow and 10ms fast timeout
> v6: check return value of __intel_de_wait_for_register
> v7: using default 2us for intel_de_wait_for_register
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Pushed to drm-intel-next, thanks for the patch.
How about replacing the other open coded try loop in intel_dp_aux_xfer()
with intel_de_wait_for_register() too?
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 91c93c93e5fc..5a176bfb10a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> const unsigned int timeout_ms = 10;
> u32 status;
> - bool done;
> -
> -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> - msecs_to_jiffies_timeout(timeout_ms));
> + int ret;
>
> - /* just trace the final value */
> - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> + ret = __intel_de_wait_for_register(i915, ch_ctl,
> + DP_AUX_CH_CTL_SEND_BUSY, 0,
> + 2, timeout_ms, &status);
>
> - if (!done)
> + if (ret == -ETIMEDOUT)
> drm_err(&i915->drm,
> "%s: did not complete or timeout within %ums (status 0x%08x)\n",
> intel_dp->aux.name, timeout_ms, status);
> -#undef C
>
> return status;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read
2023-01-04 13:27 ` Jani Nikula
@ 2023-01-04 15:21 ` Murthy, Arun R
0 siblings, 0 replies; 42+ messages in thread
From: Murthy, Arun R @ 2023-01-04 15:21 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx, ville.syrjala, Deak, Imre
> -----Original Message-----
> From: Nikula, Jani <jani.nikula@intel.com>
> Sent: Wednesday, January 4, 2023 6:58 PM
> To: Murthy, Arun R <arun.r.murthy@intel.com>; intel-
> gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; Deak, Imre
> <imre.deak@intel.com>
> Cc: Murthy, Arun R <arun.r.murthy@intel.com>
> Subject: Re: [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read
>
> On Wed, 21 Dec 2022, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> > The busy timeout logic checks for the AUX BUSY, then waits for the
> > timeout period and then after timeout reads the register for BUSY or
> > Success.
> > Instead replace interrupt with polling so as to read the AUX CTL
> > register often before the timeout period. Looks like there might be
> > some issue with interrupt-on-read. Hence changing the logic to polling
> read.
> >
> > v2: replace interrupt with polling read
> > v3: use usleep_rang instead of msleep, updated commit msg
> > v4: use intel_wait_for_regiter internal function
> > v5: use __intel_de_wait_for_register with 500us slow and 10ms fast
> > timeout
> > v6: check return value of __intel_de_wait_for_register
> > v7: using default 2us for intel_de_wait_for_register
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
>
> Pushed to drm-intel-next, thanks for the patch.
Thanks!
>
> How about replacing the other open coded try loop in intel_dp_aux_xfer()
> with intel_de_wait_for_register() too?
Sure will float a patch for that too.
Thanks and Regards,
Arun R Murthy
--------------------
>
> BR,
> Jani.
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux.c | 14 +++++---------
> > 1 file changed, 5 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > index 91c93c93e5fc..5a176bfb10a2 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> > @@ -41,20 +41,16 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
> > const unsigned int timeout_ms = 10;
> > u32 status;
> > - bool done;
> > -
> > -#define C (((status = intel_de_read_notrace(i915, ch_ctl)) &
> DP_AUX_CH_CTL_SEND_BUSY) == 0)
> > - done = wait_event_timeout(i915->display.gmbus.wait_queue, C,
> > - msecs_to_jiffies_timeout(timeout_ms));
> > + int ret;
> >
> > - /* just trace the final value */
> > - trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> > + ret = __intel_de_wait_for_register(i915, ch_ctl,
> > + DP_AUX_CH_CTL_SEND_BUSY, 0,
> > + 2, timeout_ms, &status);
> >
> > - if (!done)
> > + if (ret == -ETIMEDOUT)
> > drm_err(&i915->drm,
> > "%s: did not complete or timeout within %ums
> (status 0x%08x)\n",
> > intel_dp->aux.name, timeout_ms, status); -#undef C
> >
> > return status;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2023-01-04 15:21 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 7:09 [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay Arun R Murthy
2022-11-24 7:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-11-24 8:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-25 15:48 ` [Intel-gfx] [PATCH] " Imre Deak
2022-12-01 6:44 ` [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
2022-12-05 10:38 ` Jani Nikula
2022-12-07 5:23 ` Murthy, Arun R
2022-12-01 7:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev2) Patchwork
2022-12-01 7:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-01 17:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-09 8:35 ` [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
2022-12-09 10:45 ` Jani Nikula
2022-12-13 5:44 ` Murthy, Arun R
2022-12-13 8:08 ` Jani Nikula
2022-12-09 9:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3) Patchwork
2022-12-09 15:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-14 3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-14 5:36 ` Murthy, Arun R
2022-12-14 9:29 ` Jani Nikula
2022-12-14 5:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev4) Patchwork
2022-12-14 16:21 ` [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-15 9:05 ` Jani Nikula
2022-12-14 18:12 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev5) Patchwork
2022-12-14 18:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-15 9:55 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-15 10:30 ` Jani Nikula
2022-12-15 10:37 ` Murthy, Arun R
2022-12-15 10:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6) Patchwork
2022-12-15 10:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-15 11:13 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-19 10:17 ` Murthy, Arun R
2022-12-20 16:02 ` Jani Nikula
2022-12-20 16:54 ` Murthy, Arun R
2022-12-20 20:58 ` Jani Nikula
2022-12-15 14:14 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8) Patchwork
2022-12-15 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-16 13:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-21 3:32 ` [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2023-01-04 13:27 ` Jani Nikula
2023-01-04 15:21 ` Murthy, Arun R
2022-12-22 1:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9) Patchwork
2022-12-22 5:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.