* [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf()
@ 2022-12-02 9:05 ye.xingchen
2022-12-02 17:48 ` Ernst, Justin
2022-12-08 15:54 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2022-12-02 9:05 UTC (permalink / raw)
To: hdegoede; +Cc: justin.ernst, markgross, platform-driver-x86, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/platform/x86/uv_sysfs.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
index 625b0b79d185..73fc38ee7430 100644
--- a/drivers/platform/x86/uv_sysfs.c
+++ b/drivers/platform/x86/uv_sysfs.c
@@ -119,12 +119,12 @@ struct uv_hub {
static ssize_t hub_name_show(struct uv_bios_hub_info *hub_info, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->name);
+ return sysfs_emit(buf, "%s\n", hub_info->name);
}
static ssize_t hub_location_show(struct uv_bios_hub_info *hub_info, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->location);
+ return sysfs_emit(buf, "%s\n", hub_info->location);
}
static ssize_t hub_partition_show(struct uv_bios_hub_info *hub_info, char *buf)
@@ -460,12 +460,12 @@ struct uv_pci_top_obj {
static ssize_t uv_pci_type_show(struct uv_pci_top_obj *top_obj, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->type);
+ return sysfs_emit(buf, "%s\n", top_obj->type);
}
static ssize_t uv_pci_location_show(struct uv_pci_top_obj *top_obj, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->location);
+ return sysfs_emit(buf, "%s\n", top_obj->location);
}
static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
@@ -475,7 +475,7 @@ static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
static ssize_t uv_pci_ppb_addr_show(struct uv_pci_top_obj *top_obj, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->ppb_addr);
+ return sysfs_emit(buf, "%s\n", top_obj->ppb_addr);
}
static ssize_t uv_pci_slot_show(struct uv_pci_top_obj *top_obj, char *buf)
@@ -737,7 +737,7 @@ static ssize_t coherence_id_show(struct kobject *kobj,
static ssize_t uv_type_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "%s\n", uv_type_string());
+ return sysfs_emit(buf, "%s\n", uv_type_string());
}
static ssize_t uv_archtype_show(struct kobject *kobj,
@@ -749,13 +749,13 @@ static ssize_t uv_archtype_show(struct kobject *kobj,
static ssize_t uv_hub_type_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_hub_type());
+ return sysfs_emit(buf, "0x%x\n", uv_hub_type());
}
static ssize_t uv_hubless_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
- return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_get_hubless_system());
+ return sysfs_emit(buf, "0x%x\n", uv_get_hubless_system());
}
static struct kobj_attribute partition_id_attr =
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf()
2022-12-02 9:05 [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf() ye.xingchen
@ 2022-12-02 17:48 ` Ernst, Justin
2022-12-08 15:54 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Ernst, Justin @ 2022-12-02 17:48 UTC (permalink / raw)
To: ye.xingchen, hdegoede; +Cc: markgross, platform-driver-x86, linux-kernel
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Thank you for the patch and for keeping me informed.
Reviewed-by: Justin Ernst <justin.ernst@hpe.com>
> ---
> drivers/platform/x86/uv_sysfs.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 625b0b79d185..73fc38ee7430 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -119,12 +119,12 @@ struct uv_hub {
>
> static ssize_t hub_name_show(struct uv_bios_hub_info *hub_info, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->name);
> + return sysfs_emit(buf, "%s\n", hub_info->name);
> }
>
> static ssize_t hub_location_show(struct uv_bios_hub_info *hub_info, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->location);
> + return sysfs_emit(buf, "%s\n", hub_info->location);
> }
>
> static ssize_t hub_partition_show(struct uv_bios_hub_info *hub_info, char *buf)
> @@ -460,12 +460,12 @@ struct uv_pci_top_obj {
>
> static ssize_t uv_pci_type_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->type);
> + return sysfs_emit(buf, "%s\n", top_obj->type);
> }
>
> static ssize_t uv_pci_location_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->location);
> + return sysfs_emit(buf, "%s\n", top_obj->location);
> }
>
> static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
> @@ -475,7 +475,7 @@ static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
>
> static ssize_t uv_pci_ppb_addr_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->ppb_addr);
> + return sysfs_emit(buf, "%s\n", top_obj->ppb_addr);
> }
>
> static ssize_t uv_pci_slot_show(struct uv_pci_top_obj *top_obj, char *buf)
> @@ -737,7 +737,7 @@ static ssize_t coherence_id_show(struct kobject *kobj,
> static ssize_t uv_type_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", uv_type_string());
> + return sysfs_emit(buf, "%s\n", uv_type_string());
> }
>
> static ssize_t uv_archtype_show(struct kobject *kobj,
> @@ -749,13 +749,13 @@ static ssize_t uv_archtype_show(struct kobject *kobj,
> static ssize_t uv_hub_type_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_hub_type());
> + return sysfs_emit(buf, "0x%x\n", uv_hub_type());
> }
>
> static ssize_t uv_hubless_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_get_hubless_system());
> + return sysfs_emit(buf, "0x%x\n", uv_get_hubless_system());
> }
>
> static struct kobj_attribute partition_id_attr =
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf()
2022-12-02 9:05 [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-02 17:48 ` Ernst, Justin
@ 2022-12-08 15:54 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2022-12-08 15:54 UTC (permalink / raw)
To: ye.xingchen; +Cc: justin.ernst, markgross, platform-driver-x86, linux-kernel
Hi,
On 12/2/22 10:05, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/uv_sysfs.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 625b0b79d185..73fc38ee7430 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -119,12 +119,12 @@ struct uv_hub {
>
> static ssize_t hub_name_show(struct uv_bios_hub_info *hub_info, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->name);
> + return sysfs_emit(buf, "%s\n", hub_info->name);
> }
>
> static ssize_t hub_location_show(struct uv_bios_hub_info *hub_info, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", hub_info->location);
> + return sysfs_emit(buf, "%s\n", hub_info->location);
> }
>
> static ssize_t hub_partition_show(struct uv_bios_hub_info *hub_info, char *buf)
> @@ -460,12 +460,12 @@ struct uv_pci_top_obj {
>
> static ssize_t uv_pci_type_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->type);
> + return sysfs_emit(buf, "%s\n", top_obj->type);
> }
>
> static ssize_t uv_pci_location_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->location);
> + return sysfs_emit(buf, "%s\n", top_obj->location);
> }
>
> static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
> @@ -475,7 +475,7 @@ static ssize_t uv_pci_iio_stack_show(struct uv_pci_top_obj *top_obj, char *buf)
>
> static ssize_t uv_pci_ppb_addr_show(struct uv_pci_top_obj *top_obj, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", top_obj->ppb_addr);
> + return sysfs_emit(buf, "%s\n", top_obj->ppb_addr);
> }
>
> static ssize_t uv_pci_slot_show(struct uv_pci_top_obj *top_obj, char *buf)
> @@ -737,7 +737,7 @@ static ssize_t coherence_id_show(struct kobject *kobj,
> static ssize_t uv_type_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "%s\n", uv_type_string());
> + return sysfs_emit(buf, "%s\n", uv_type_string());
> }
>
> static ssize_t uv_archtype_show(struct kobject *kobj,
> @@ -749,13 +749,13 @@ static ssize_t uv_archtype_show(struct kobject *kobj,
> static ssize_t uv_hub_type_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_hub_type());
> + return sysfs_emit(buf, "0x%x\n", uv_hub_type());
> }
>
> static ssize_t uv_hubless_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> - return scnprintf(buf, PAGE_SIZE, "0x%x\n", uv_get_hubless_system());
> + return sysfs_emit(buf, "0x%x\n", uv_get_hubless_system());
> }
>
> static struct kobj_attribute partition_id_attr =
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 9:05 [PATCH] platform/x86: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-02 17:48 ` Ernst, Justin
2022-12-08 15:54 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.