* [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx()
@ 2022-12-03 9:42 Liu Jian
2022-12-03 9:42 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() Liu Jian
2022-12-06 11:50 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Liu Jian @ 2022-12-03 9:42 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, edumazet, kuba, pabeni, zhangfei.gao
Cc: netdev, liujian56
The skb is delivered to napi_gro_receive() which may free it, after
calling this, dereferencing skb may trigger use-after-free.
Fixes: 542ae60af24f ("net: hisilicon: Add Fast Ethernet MAC driver")
Signed-off-by: Liu Jian <liujian56@huawei.com>
---
drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
index 93846bace028..ce2571c16e43 100644
--- a/drivers/net/ethernet/hisilicon/hisi_femac.c
+++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
@@ -283,7 +283,7 @@ static int hisi_femac_rx(struct net_device *dev, int limit)
skb->protocol = eth_type_trans(skb, dev);
napi_gro_receive(&priv->napi, skb);
dev->stats.rx_packets++;
- dev->stats.rx_bytes += skb->len;
+ dev->stats.rx_bytes += len;
next:
pos = (pos + 1) % rxq->num;
if (rx_pkts_num >= limit)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx()
2022-12-03 9:42 [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() Liu Jian
@ 2022-12-03 9:42 ` Liu Jian
2022-12-06 12:00 ` patchwork-bot+netdevbpf
2022-12-06 11:50 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Liu Jian @ 2022-12-03 9:42 UTC (permalink / raw)
To: yisen.zhuang, salil.mehta, davem, edumazet, kuba, pabeni, zhangfei.gao
Cc: netdev, liujian56
The skb is delivered to napi_gro_receive() which may free it, after
calling this, dereferencing skb may trigger use-after-free.
Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
Signed-off-by: Liu Jian <liujian56@huawei.com>
---
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
index ffcf797dfa90..f867e9531117 100644
--- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
@@ -550,7 +550,7 @@ static int hix5hd2_rx(struct net_device *dev, int limit)
skb->protocol = eth_type_trans(skb, dev);
napi_gro_receive(&priv->napi, skb);
dev->stats.rx_packets++;
- dev->stats.rx_bytes += skb->len;
+ dev->stats.rx_bytes += len;
next:
pos = dma_ring_incr(pos, RX_DESC_NUM);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx()
2022-12-03 9:42 [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() Liu Jian
2022-12-03 9:42 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() Liu Jian
@ 2022-12-06 11:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-06 11:50 UTC (permalink / raw)
To: Liu Jian
Cc: yisen.zhuang, salil.mehta, davem, edumazet, kuba, pabeni,
zhangfei.gao, netdev
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sat, 3 Dec 2022 17:42:39 +0800 you wrote:
> The skb is delivered to napi_gro_receive() which may free it, after
> calling this, dereferencing skb may trigger use-after-free.
>
> Fixes: 542ae60af24f ("net: hisilicon: Add Fast Ethernet MAC driver")
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> ---
> drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx()
https://git.kernel.org/netdev/net/c/464017704954
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx()
2022-12-03 9:42 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() Liu Jian
@ 2022-12-06 12:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-06 12:00 UTC (permalink / raw)
To: Liu Jian
Cc: yisen.zhuang, salil.mehta, davem, edumazet, kuba, pabeni,
zhangfei.gao, netdev
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sat, 3 Dec 2022 17:42:40 +0800 you wrote:
> The skb is delivered to napi_gro_receive() which may free it, after
> calling this, dereferencing skb may trigger use-after-free.
>
> Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> ---
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx()
https://git.kernel.org/netdev/net/c/433c07a13f59
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-06 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-03 9:42 [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() Liu Jian
2022-12-03 9:42 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hix5hd2_rx() Liu Jian
2022-12-06 12:00 ` patchwork-bot+netdevbpf
2022-12-06 11:50 ` [PATCH net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.