* [PATCH linux-next] accessibility: speakup: use strscpy() to instead of strncpy()
@ 2022-12-03 6:21 yang.yang29
2022-12-03 9:56 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2022-12-03 6:21 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, kirk, samuel.thibault, mushi.shar, speakup, linux-kernel,
xu.panda, yang.yang29
From: Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
drivers/accessibility/speakup/kobjects.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/accessibility/speakup/kobjects.c b/drivers/accessibility/speakup/kobjects.c
index a7522d409802..273c076b661a 100644
--- a/drivers/accessibility/speakup/kobjects.c
+++ b/drivers/accessibility/speakup/kobjects.c
@@ -426,8 +426,7 @@ static ssize_t synth_direct_store(struct kobject *kobj,
spin_lock_irqsave(&speakup_info.spinlock, flags);
while (len > 0) {
bytes = min_t(size_t, len, 250);
- strncpy(tmp, ptr, bytes);
- tmp[bytes] = '\0';
+ strscpy(tmp, ptr, bytes);
string_unescape_any_inplace(tmp);
synth_printf("%s", tmp);
ptr += bytes;
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] accessibility: speakup: use strscpy() to instead of strncpy()
2022-12-03 6:21 [PATCH linux-next] accessibility: speakup: use strscpy() to instead of strncpy() yang.yang29
@ 2022-12-03 9:56 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2022-12-03 9:56 UTC (permalink / raw)
To: yang.yang29
Cc: w.d.hubbs, chris, kirk, mushi.shar, speakup, linux-kernel, xu.panda
yang.yang29@zte.com.cn, le sam. 03 déc. 2022 14:21:28 +0800, a ecrit:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
> drivers/accessibility/speakup/kobjects.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/kobjects.c b/drivers/accessibility/speakup/kobjects.c
> index a7522d409802..273c076b661a 100644
> --- a/drivers/accessibility/speakup/kobjects.c
> +++ b/drivers/accessibility/speakup/kobjects.c
> @@ -426,8 +426,7 @@ static ssize_t synth_direct_store(struct kobject *kobj,
> spin_lock_irqsave(&speakup_info.spinlock, flags);
> while (len > 0) {
> bytes = min_t(size_t, len, 250);
> - strncpy(tmp, ptr, bytes);
> - tmp[bytes] = '\0';
> + strscpy(tmp, ptr, bytes);
This needs to be bytes+1, otherwise the trailing `\0` will be put at
bytes-1 instead of bytes as the original code does, thus eating one
character.
> string_unescape_any_inplace(tmp);
> synth_printf("%s", tmp);
> ptr += bytes;
> --
> 2.15.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-03 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-03 6:21 [PATCH linux-next] accessibility: speakup: use strscpy() to instead of strncpy() yang.yang29
2022-12-03 9:56 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.