All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Cc: Vishnu Dasa <vdasa@vmware.com>,
	lvc-project@linuxtesting.org,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Bryan Tan <bryantan@vmware.com>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3] net: vmw_vsock: vmci: Check memcpy_from_msg()
Date: Mon, 5 Dec 2022 14:06:15 +0100	[thread overview]
Message-ID: <20221205130615.jqnno74hnui6527c@sgarzare-redhat> (raw)
In-Reply-To: <20221205115200.2987942-1-artem.chernyshev@red-soft.ru>

On Mon, Dec 05, 2022 at 02:52:00PM +0300, Artem Chernyshev wrote:
>vmci_transport_dgram_enqueue() does not check the return value
>of memcpy_from_msg(). Return with an error if the memcpy fails.
>
>Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>Fixes: 0f7db23a07af ("vmci_transport: switch ->enqeue_dgram, ->enqueue_stream and ->dequeue_stream to msghdr")
>Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
>---
>V1->V2 Fix memory leaking and updates for description
>V2->V3 Return the value of memcpy_from_msg()
>
> net/vmw_vsock/vmci_transport.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Garzarella <sgarzare@redhat.com>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Cc: Vishnu Dasa <vdasa@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Bryan Tan <bryantan@vmware.com>, Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v3] net: vmw_vsock: vmci: Check memcpy_from_msg()
Date: Mon, 5 Dec 2022 14:06:15 +0100	[thread overview]
Message-ID: <20221205130615.jqnno74hnui6527c@sgarzare-redhat> (raw)
In-Reply-To: <20221205115200.2987942-1-artem.chernyshev@red-soft.ru>

On Mon, Dec 05, 2022 at 02:52:00PM +0300, Artem Chernyshev wrote:
>vmci_transport_dgram_enqueue() does not check the return value
>of memcpy_from_msg(). Return with an error if the memcpy fails.
>
>Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>Fixes: 0f7db23a07af ("vmci_transport: switch ->enqeue_dgram, ->enqueue_stream and ->dequeue_stream to msghdr")
>Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
>---
>V1->V2 Fix memory leaking and updates for description
>V2->V3 Return the value of memcpy_from_msg()
>
> net/vmw_vsock/vmci_transport.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


  reply	other threads:[~2022-12-05 13:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 22:58 [PATCH] net: vmw_vsock: vmci: Check memcpy_from_msg() Artem Chernyshev
2022-12-03  1:17 ` Vishnu Dasa
2022-12-03  1:17   ` Vishnu Dasa via Virtualization
2022-12-03  7:56   ` Artem Chernyshev
2022-12-03  8:33   ` [PATCH v2] " Artem Chernyshev
2022-12-05  9:47     ` Stefano Garzarella
2022-12-05  9:47       ` Stefano Garzarella
2022-12-05 11:22       ` Artem Chernyshev
2022-12-05 11:52       ` [PATCH v3] " Artem Chernyshev
2022-12-05 13:06         ` Stefano Garzarella [this message]
2022-12-05 13:06           ` Stefano Garzarella
2022-12-05 23:03         ` Vishnu Dasa
2022-12-05 23:03           ` Vishnu Dasa via Virtualization
2022-12-06  6:52           ` Artem Chernyshev
2022-12-06  6:58           ` [PATCH v4] " Artem Chernyshev
2022-12-09  8:50             ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205130615.jqnno74hnui6527c@sgarzare-redhat \
    --to=sgarzare@redhat.com \
    --cc=artem.chernyshev@red-soft.ru \
    --cc=bryantan@vmware.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=netdev@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=vdasa@vmware.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.