From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: matthias.bgg@gmail.com Cc: mturquette@baylibre.com, sboyd@kernel.org, wenst@chromium.org, miles.chen@mediatek.com, rex-bc.chen@mediatek.com, chun-jie.chen@mediatek.com, jose.exposito89@gmail.com, drinkcat@chromium.org, weiyi.lu@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH v3 01/10] arm64: dts: mt8183: Fix Mali GPU clock Date: Tue, 6 Dec 2022 15:30:37 -0300 [thread overview] Message-ID: <20221206183037.3jnssar4yxcx5hpb@notapiano> (raw) In-Reply-To: <20220927101128.44758-2-angelogioacchino.delregno@collabora.com> On Tue, Sep 27, 2022 at 12:11:19PM +0200, AngeloGioacchino Del Regno wrote: > From: Chen-Yu Tsai <wenst@chromium.org> > > The actual clock feeding into the Mali GPU on the MT8183 is from the > clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN > block, which itself is simply a pass-through placeholder for the MFGPLL > in the APMIXEDSYS block. > > Fix the hardware description with the correct clock reference. > > Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Hi, it seems that while all other patches on this series were applied by Chen-Yu through the clk tree, this commit never made it to the mediatek tree. As a result, MT8183-based machines (or at least mt8183-kukui-jacuzzi, where I tested on) currently hang during boot not only on next, but also on mainline, v6.1-rc8. With this commit applied I've confirmed that the machine boots fine again. Matthias, could you please apply this commit and make sure it makes its way to v6.1? Given the Fixes tag it should eventually make its way there anyway, but if still possible would be good to have it fixed right from v6.1. Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index a70b669c49ba..402136bfd535 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1678,7 +1678,7 @@ gpu: gpu@13040000 { > <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>; > interrupt-names = "job", "mmu", "gpu"; > > - clocks = <&topckgen CLK_TOP_MFGPLL_CK>; > + clocks = <&mfgcfg CLK_MFG_BG3D>; > > power-domains = > <&spm MT8183_POWER_DOMAIN_MFG_CORE0>, > -- > 2.37.2 > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: matthias.bgg@gmail.com Cc: mturquette@baylibre.com, sboyd@kernel.org, wenst@chromium.org, miles.chen@mediatek.com, rex-bc.chen@mediatek.com, chun-jie.chen@mediatek.com, jose.exposito89@gmail.com, drinkcat@chromium.org, weiyi.lu@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH v3 01/10] arm64: dts: mt8183: Fix Mali GPU clock Date: Tue, 6 Dec 2022 15:30:37 -0300 [thread overview] Message-ID: <20221206183037.3jnssar4yxcx5hpb@notapiano> (raw) In-Reply-To: <20220927101128.44758-2-angelogioacchino.delregno@collabora.com> On Tue, Sep 27, 2022 at 12:11:19PM +0200, AngeloGioacchino Del Regno wrote: > From: Chen-Yu Tsai <wenst@chromium.org> > > The actual clock feeding into the Mali GPU on the MT8183 is from the > clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN > block, which itself is simply a pass-through placeholder for the MFGPLL > in the APMIXEDSYS block. > > Fix the hardware description with the correct clock reference. > > Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Hi, it seems that while all other patches on this series were applied by Chen-Yu through the clk tree, this commit never made it to the mediatek tree. As a result, MT8183-based machines (or at least mt8183-kukui-jacuzzi, where I tested on) currently hang during boot not only on next, but also on mainline, v6.1-rc8. With this commit applied I've confirmed that the machine boots fine again. Matthias, could you please apply this commit and make sure it makes its way to v6.1? Given the Fixes tag it should eventually make its way there anyway, but if still possible would be good to have it fixed right from v6.1. Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index a70b669c49ba..402136bfd535 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1678,7 +1678,7 @@ gpu: gpu@13040000 { > <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>; > interrupt-names = "job", "mmu", "gpu"; > > - clocks = <&topckgen CLK_TOP_MFGPLL_CK>; > + clocks = <&mfgcfg CLK_MFG_BG3D>; > > power-domains = > <&spm MT8183_POWER_DOMAIN_MFG_CORE0>, > -- > 2.37.2 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-06 18:33 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-27 10:11 [PATCH v3 00/10] MediaTek SoC safe clock muxing and GPU clocks AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 01/10] arm64: dts: mt8183: Fix Mali GPU clock AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-12-06 18:30 ` Nícolas F. R. A. Prado [this message] 2022-12-06 18:30 ` Nícolas F. R. A. Prado 2022-12-16 10:46 ` Matthias Brugger 2022-12-16 10:46 ` Matthias Brugger 2022-12-16 11:23 ` Matthias Brugger 2022-12-16 11:23 ` Matthias Brugger 2022-09-27 10:11 ` [PATCH v3 02/10] clk: mediatek: mt8183: mfgcfg: Propagate rate changes to parent AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 03/10] clk: mediatek: mux: add clk notifier functions AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 04/10] clk: mediatek: mt8183: Add clk mux notifier for MFG mux AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 05/10] clk: mediatek: clk-mt8195-mfg: Reparent mfg_bg3d and propagate rate changes AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 06/10] clk: mediatek: clk-mt8195-topckgen: Register mfg_ck_fast_ref as generic mux AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 07/10] clk: mediatek: clk-mt8195-topckgen: Add GPU clock mux notifier AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 08/10] clk: mediatek: clk-mt8195-topckgen: Drop univplls from mfg mux parents AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-30 5:59 ` MandyJH Liu (劉人僖) 2022-09-30 5:59 ` MandyJH Liu (劉人僖) 2022-09-30 8:29 ` AngeloGioacchino Del Regno 2022-09-30 8:29 ` AngeloGioacchino Del Regno 2022-09-30 8:44 ` Chen-Yu Tsai 2022-09-30 8:44 ` Chen-Yu Tsai 2022-09-30 8:58 ` AngeloGioacchino Del Regno 2022-09-30 8:58 ` AngeloGioacchino Del Regno 2022-09-30 9:02 ` Chen-Yu Tsai 2022-09-30 9:02 ` Chen-Yu Tsai 2022-09-30 9:04 ` AngeloGioacchino Del Regno 2022-09-30 9:04 ` AngeloGioacchino Del Regno 2022-09-30 9:07 ` Chen-Yu Tsai 2022-09-30 9:07 ` Chen-Yu Tsai 2022-09-27 10:11 ` [PATCH v3 09/10] clk: mediatek: clk-mt8192-mfg: Propagate rate changes to parent AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-27 10:11 ` [PATCH v3 10/10] clk: mediatek: clk-mt8192: Add clock mux notifier for mfg_pll_sel AngeloGioacchino Del Regno 2022-09-27 10:11 ` AngeloGioacchino Del Regno 2022-09-29 4:24 ` [PATCH v3 00/10] MediaTek SoC safe clock muxing and GPU clocks Chen-Yu Tsai 2022-09-29 4:24 ` Chen-Yu Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221206183037.3jnssar4yxcx5hpb@notapiano \ --to=nfraprado@collabora.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=chun-jie.chen@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=drinkcat@chromium.org \ --cc=jose.exposito89@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=miles.chen@mediatek.com \ --cc=mturquette@baylibre.com \ --cc=rex-bc.chen@mediatek.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=weiyi.lu@mediatek.com \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.