[PATCH] iio: accel: Convert to use sysfs_emit_at() API

[PATCH] iio: accel: Convert to use sysfs_emit_at() API

[ye.xingchen]

From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/iio/accel/adxl372.c | 3 +--
 drivers/iio/accel/bma180.c  | 3 +--
 drivers/iio/accel/mma8452.c | 5 ++---
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
index c4193286eb05..15bcb0d75b8f 100644
--- a/drivers/iio/accel/adxl372.c
+++ b/drivers/iio/accel/adxl372.c
@@ -970,8 +970,7 @@ static ssize_t adxl372_show_filter_freq_avail(struct device *dev,
 	size_t len = 0;

 	for (i = 0; i <= st->odr; i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len,
-				 "%d ", adxl372_bw_freq_tbl[i]);
+		len += sysfs_emit_at(buf, len, "%d ", adxl372_bw_freq_tbl[i]);

 	buf[len - 1] = '\n';

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index eb697eeb4301..9e3e5dfdded7 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -488,8 +488,7 @@ static ssize_t bma180_show_avail(char *buf, const int *vals, unsigned int n,
 	for (i = 0; i < n; i++) {
 		if (!vals[i])
 			continue;
-		len += scnprintf(buf + len, PAGE_SIZE - len,
-			micros ? "0.%06d " : "%d ", vals[i]);
+		len += sysfs_emit_at(buf, len, micros ? "0.%06d " : "%d ", vals[i]);
 	}
 	buf[len - 1] = '\n';

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index f97fb68e3a71..7ba3c743e6f6 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -266,8 +266,7 @@ static ssize_t mma8452_show_int_plus_micros(char *buf, const int (*vals)[2],
 	size_t len = 0;

 	while (n-- > 0)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06d ",
-				 vals[n][0], vals[n][1]);
+		len += sysfs_emit_at(buf, len, "%d.%06d ", vals[n][0], vals[n][1]);

 	/* replace trailing space by newline */
 	buf[len - 1] = '\n';
@@ -423,7 +422,7 @@ static ssize_t mma8452_show_os_ratio_avail(struct device *dev,

 		val = mma8452_os_ratio[j][i];

-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d ", val);
+		len += sysfs_emit_at(buf, len, "%d ", val);
 	}
 	buf[len - 1] = '\n';

-- 
2.25.1

Re: [PATCH] iio: accel: Convert to use sysfs_emit_at() API

[Andy Shevchenko]

On Tue, Dec 06, 2022 at 07:53:20PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

Please split on per device driver basis (3 patches here).

The code looks fine to me, thanks.

-- 
With Best Regards,
Andy Shevchenko