new: b4 send --reflect

new: b4 send --reflect

[Konstantin Ryabitsev]

Hi, all:

Final feature before 0.11 (hopefully) -- there is a new test mode for b4 send
that will only email the series to yourself instead of the actual destinations
listed in "To" or "Cc" headers.

This should be particularly useful to anyone using the web submission
endpoint, because this will allow them to see any post-processing that the
remote will do to their patches (such as rewriting From: for DMARC purposes).

If you're using b4 from git, I recommend that you get the latest master so it
can see some testing before the 0.11 release later in the week. 
The main notable new features in 0.11 as compared to 0.10.y are:

- b4 prep --compare-to N: shows a range-diff between your current prep branch
  and the previously submitted revision N

- b4 ty: can be configured to always send mail without requiring the -S switch
  (via setting b4.ty-send-mail=yes)

- b4 send will no longer send the entire series to the addresses found in
  individual commit Cc: trailers; such addresses will only receive the cover
  letter and the patches where they are explicitly Cc'd

- you can now set extra [PATCH] prefixes permanently either via b4 prep
  --set-prefixes or via the cover letter subject line

- internal changes to ensure that we generate 7-bit-clean headers for all
  outgoing mail

- b4 send --reflect: prepares the patches but only sends them to yourself

If all goes well, I will release 0.11 either Thursday or Friday.

Best wishes,
Konstantin

Re: new: b4 send --reflect

[Noralf Trønnes]

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]



Den 06.12.2022 22.53, skrev Konstantin Ryabitsev:
> Hi, all:
> 
> Final feature before 0.11 (hopefully) -- there is a new test mode for b4 send
> that will only email the series to yourself instead of the actual destinations
> listed in "To" or "Cc" headers.
> 
> This should be particularly useful to anyone using the web submission
> endpoint, because this will allow them to see any post-processing that the
> remote will do to their patches (such as rewriting From: for DMARC purposes).
> 

I've always sent the patches to myself for a final check before sending
them off, so this is perfect.

But it doesn't work for me yet:

$ ~/projects/b4/b4.sh send --hide-cover-to-cc --reflect
Converted the branch to 1 messages
---
To: dri-devel@lists.freedesktop.org
    tzimmermann@suse.de
    kernel test robot <lkp@intel.com>
    Noralf Trønnes <noralf@tronnes.org>
---
  [PATCH] drm/gud: Fix missing include
---
Ready to:
  - send the above messages to just noralf@tronnes.org (REFLECT MODE)
  - via web endpoint: https://lkml.kernel.org/_b4_submit

Press Enter to proceed or Ctrl-C to abort
---
Reflecting via web endpoint https://lkml.kernel.org/_b4_submit
Error from endpoint: This service only accepts patches
---
CRITICAL: Was not able to send messages.

$ ~/projects/b4/b4.sh --version
0.11.0-dev-b77ec

Cover letter:

$ git show 6c2812de7efe
commit 6c2812de7efe27951c95c9f736215675009da3fb
Author: Noralf Trønnes <noralf@tronnes.org>
Date:   Wed Dec 7 12:58:01 2022 +0100

    dummy
    Cc: dri-devel@lists.freedesktop.org
    Cc: tzimmermann@suse.de

    --- b4-submit-tracking ---
    # This section is used internally by b4 prep for tracking purposes.
    {
      "series": {
        "revision": 1,
        "change-id": "20221207-gud-missing-include-9ccf56382f8a",
        "base-branch": null
      }
    }

I've attached the 'b4 send --hide-cover-to-cc -o' output.

Noralf.

[-- Attachment #2: b4-gud-missing-include-1.tar.gz --]
[-- Type: application/x-gzip, Size: 1125 bytes --]

Re: new: b4 send --reflect

[Noralf Trønnes]

Den 07.12.2022 17.39, skrev Noralf Trønnes:
> 
> 
> Den 06.12.2022 22.53, skrev Konstantin Ryabitsev:
>> Hi, all:
>>
>> Final feature before 0.11 (hopefully) -- there is a new test mode for b4 send
>> that will only email the series to yourself instead of the actual destinations
>> listed in "To" or "Cc" headers.
>>
>> This should be particularly useful to anyone using the web submission
>> endpoint, because this will allow them to see any post-processing that the
>> remote will do to their patches (such as rewriting From: for DMARC purposes).
>>
> 
> I've always sent the patches to myself for a final check before sending
> them off, so this is perfect.
> 
> But it doesn't work for me yet:
> 
> $ ~/projects/b4/b4.sh send --hide-cover-to-cc --reflect
> Converted the branch to 1 messages
> ---
> To: dri-devel@lists.freedesktop.org
>     tzimmermann@suse.de
>     kernel test robot <lkp@intel.com>
>     Noralf Trønnes <noralf@tronnes.org>
> ---
>   [PATCH] drm/gud: Fix missing include
> ---
> Ready to:
>   - send the above messages to just noralf@tronnes.org (REFLECT MODE)
>   - via web endpoint: https://lkml.kernel.org/_b4_submit
> 
> Press Enter to proceed or Ctrl-C to abort
> ---
> Reflecting via web endpoint https://lkml.kernel.org/_b4_submit
> Error from endpoint: This service only accepts patches
> ---
> CRITICAL: Was not able to send messages.
> 
> $ ~/projects/b4/b4.sh --version
> 0.11.0-dev-b77ec
> 
> Cover letter:
> 
> $ git show 6c2812de7efe
> commit 6c2812de7efe27951c95c9f736215675009da3fb
> Author: Noralf Trønnes <noralf@tronnes.org>
> Date:   Wed Dec 7 12:58:01 2022 +0100
> 
>     dummy
>     Cc: dri-devel@lists.freedesktop.org
>     Cc: tzimmermann@suse.de
> 
>     --- b4-submit-tracking ---
>     # This section is used internally by b4 prep for tracking purposes.
>     {
>       "series": {
>         "revision": 1,
>         "change-id": "20221207-gud-missing-include-9ccf56382f8a",
>         "base-branch": null
>       }
>     }
> 
> I've attached the 'b4 send --hide-cover-to-cc -o' output.
> 

I wanted to get this patch out so I dropped the --reflect, but I got the
same error.

Noralf.

Re: new: b4 send --reflect

[Konstantin Ryabitsev]

On Wed, Dec 07, 2022 at 05:39:40PM +0100, Noralf Trønnes wrote:
> Error from endpoint: This service only accepts patches

Stupidly, I never tested it with a single patch, always with a series.
Please try again.

-K

Re: new: b4 send --reflect

[Noralf Trønnes]

Den 07.12.2022 19.21, skrev Konstantin Ryabitsev:
> On Wed, Dec 07, 2022 at 05:39:40PM +0100, Noralf Trønnes wrote:
>> Error from endpoint: This service only accepts patches
> 
> Stupidly, I never tested it with a single patch, always with a series.
> Please try again.
> 

Getting closer ;)

$ ~/projects/b4/b4.sh send --hide-cover-to-cc --reflect
Converted the branch to 1 messages
---
To: dri-devel@lists.freedesktop.org
    tzimmermann@suse.de
    kernel test robot <lkp@intel.com>
    Noralf Trønnes <noralf@tronnes.org>
---
  [PATCH] drm/gud: Fix missing include
---
Ready to:
  - send the above messages to just noralf@tronnes.org (REFLECT MODE)
  - via web endpoint: https://lkml.kernel.org/_b4_submit

Press Enter to proceed or Ctrl-C to abort
---
Reflecting via web endpoint https://lkml.kernel.org/_b4_submit
Error from endpoint: Destinations must include a mailing list we recognize.
---
CRITICAL: Was not able to send messages.

I'm getting the same without --reflect

Noralf.

Re: new: b4 send --reflect

[Konstantin Ryabitsev]

On Wed, Dec 07, 2022 at 08:36:44PM +0100, Noralf Trønnes wrote:
> > On Wed, Dec 07, 2022 at 05:39:40PM +0100, Noralf Trønnes wrote:
> >> Error from endpoint: This service only accepts patches
> > 
> > Stupidly, I never tested it with a single patch, always with a series.
> > Please try again.
> > 
> 
> Getting closer ;)

You're tripping up all the corner-cases, this is great! :)

> Reflecting via web endpoint https://lkml.kernel.org/_b4_submit
> Error from endpoint: Destinations must include a mailing list we recognize.

One of my goals is to make sure that this service can't be abused to send
spam, so we're running a bunch of checks to verify that it's a legitimate
patch sent to a sane set of destinations. In this particular case, we weren't
expecting the only list to be lists.freedesktop.org (usually there's always a
kernel.org address there somewhere).

Please try again.

-K

Re: new: b4 send --reflect

[Noralf Trønnes]

Den 07.12.2022 20.45, skrev Konstantin Ryabitsev:
> On Wed, Dec 07, 2022 at 08:36:44PM +0100, Noralf Trønnes wrote:
>>> On Wed, Dec 07, 2022 at 05:39:40PM +0100, Noralf Trønnes wrote:
>>>> Error from endpoint: This service only accepts patches
>>>
>>> Stupidly, I never tested it with a single patch, always with a series.
>>> Please try again.
>>>
>>
>> Getting closer ;)
> 
> You're tripping up all the corner-cases, this is great! :)
> 
>> Reflecting via web endpoint https://lkml.kernel.org/_b4_submit
>> Error from endpoint: Destinations must include a mailing list we recognize.
> 
> One of my goals is to make sure that this service can't be abused to send
> spam, so we're running a bunch of checks to verify that it's a legitimate
> patch sent to a sane set of destinations. In this particular case, we weren't
> expecting the only list to be lists.freedesktop.org (usually there's always a
> kernel.org address there somewhere).
> 
> Please try again.
> 

It's working now, thanks.

Noralf.

Re: new: b4 send --reflect

[Konstantin Ryabitsev]

On Wed, Dec 07, 2022 at 08:54:20PM +0100, Noralf Trønnes wrote:
> It's working now, thanks.

Great. Thanks again for being a willing test subject!

-K