All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/gud: Fix missing include
@ 2022-12-07 19:46 Noralf Trønnes
  0 siblings, 0 replies; 5+ messages in thread
From: Noralf Trønnes @ 2022-12-07 19:46 UTC (permalink / raw)
  To: dri-devel, tzimmermann, kernel test robot, Noralf Trønnes

Add missing vmalloc.h include.

Fixes: c17d048609bf ("drm/gud: Use the shadow plane helper")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/gud/gud_pipe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
index 62c43d3632d4..dc16a92625d4 100644
--- a/drivers/gpu/drm/gud/gud_pipe.c
+++ b/drivers/gpu/drm/gud/gud_pipe.c
@@ -5,6 +5,7 @@
 
 #include <linux/lz4.h>
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic.h>

---
base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,
-- 
Noralf Trønnes <noralf@tronnes.org>

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/gud: Fix missing include
  2022-12-08  8:15 ` Thomas Zimmermann
@ 2022-12-08 11:20   ` Noralf Trønnes
  0 siblings, 0 replies; 5+ messages in thread
From: Noralf Trønnes @ 2022-12-08 11:20 UTC (permalink / raw)
  To: Thomas Zimmermann, dri-devel; +Cc: Noralf Trønnes



Den 08.12.2022 09.15, skrev Thomas Zimmermann:
> Hi
> 
> Am 07.12.22 um 20:51 schrieb Noralf Trønnes via B4 Submission Endpoint:
>> From: Noralf Trønnes <noralf@tronnes.org>
>>
>> Add missing vmalloc.h include.
>>
>> Fixes: c17d048609bf ("drm/gud: Use the shadow plane helper")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 

Thanks.

> The missing-vmalloc() error is a real classic. :( Some architectures
> declare the function and some don't.
> 

Yeah, I think I've seen this before. Good we have the bots to cover the
corner cases.

Noralf.

> Best regards
> Thomas
> 
>> ---
>>   drivers/gpu/drm/gud/gud_pipe.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/gud/gud_pipe.c
>> b/drivers/gpu/drm/gud/gud_pipe.c
>> index 62c43d3632d4..dc16a92625d4 100644
>> --- a/drivers/gpu/drm/gud/gud_pipe.c
>> +++ b/drivers/gpu/drm/gud/gud_pipe.c
>> @@ -5,6 +5,7 @@
>>     #include <linux/lz4.h>
>>   #include <linux/usb.h>
>> +#include <linux/vmalloc.h>
>>   #include <linux/workqueue.h>
>>     #include <drm/drm_atomic.h>
>>
>> ---
>> base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
>> change-id: 20221207-gud-missing-include-9ccf56382f8a
>>
>> Best regards,
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/gud: Fix missing include
  2022-12-07 19:51 ` Noralf Trønnes
  (?)
@ 2022-12-08  8:15 ` Thomas Zimmermann
  2022-12-08 11:20   ` Noralf Trønnes
  -1 siblings, 1 reply; 5+ messages in thread
From: Thomas Zimmermann @ 2022-12-08  8:15 UTC (permalink / raw)
  To: noralf, dri-devel, kernel test robot


[-- Attachment #1.1: Type: text/plain, Size: 1341 bytes --]

Hi

Am 07.12.22 um 20:51 schrieb Noralf Trønnes via B4 Submission Endpoint:
> From: Noralf Trønnes <noralf@tronnes.org>
> 
> Add missing vmalloc.h include.
> 
> Fixes: c17d048609bf ("drm/gud: Use the shadow plane helper")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

The missing-vmalloc() error is a real classic. :( Some architectures 
declare the function and some don't.

Best regards
Thomas

> ---
>   drivers/gpu/drm/gud/gud_pipe.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
> index 62c43d3632d4..dc16a92625d4 100644
> --- a/drivers/gpu/drm/gud/gud_pipe.c
> +++ b/drivers/gpu/drm/gud/gud_pipe.c
> @@ -5,6 +5,7 @@
>   
>   #include <linux/lz4.h>
>   #include <linux/usb.h>
> +#include <linux/vmalloc.h>
>   #include <linux/workqueue.h>
>   
>   #include <drm/drm_atomic.h>
> 
> ---
> base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
> change-id: 20221207-gud-missing-include-9ccf56382f8a
> 
> Best regards,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/gud: Fix missing include
@ 2022-12-07 19:51 ` Noralf Trønnes
  0 siblings, 0 replies; 5+ messages in thread
From: Noralf Trønnes via B4 Submission Endpoint @ 2022-12-07 19:51 UTC (permalink / raw)
  To: dri-devel, tzimmermann, kernel test robot, Noralf Trønnes

From: Noralf Trønnes <noralf@tronnes.org>

Add missing vmalloc.h include.

Fixes: c17d048609bf ("drm/gud: Use the shadow plane helper")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/gud/gud_pipe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
index 62c43d3632d4..dc16a92625d4 100644
--- a/drivers/gpu/drm/gud/gud_pipe.c
+++ b/drivers/gpu/drm/gud/gud_pipe.c
@@ -5,6 +5,7 @@
 
 #include <linux/lz4.h>
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic.h>

---
base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,
-- 
Noralf Trønnes <noralf@tronnes.org>

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/gud: Fix missing include
@ 2022-12-07 19:51 ` Noralf Trønnes
  0 siblings, 0 replies; 5+ messages in thread
From: Noralf Trønnes @ 2022-12-07 19:51 UTC (permalink / raw)
  To: dri-devel, tzimmermann, kernel test robot, Noralf Trønnes

Add missing vmalloc.h include.

Fixes: c17d048609bf ("drm/gud: Use the shadow plane helper")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/gud/gud_pipe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
index 62c43d3632d4..dc16a92625d4 100644
--- a/drivers/gpu/drm/gud/gud_pipe.c
+++ b/drivers/gpu/drm/gud/gud_pipe.c
@@ -5,6 +5,7 @@
 
 #include <linux/lz4.h>
 #include <linux/usb.h>
+#include <linux/vmalloc.h>
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic.h>

---
base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c
change-id: 20221207-gud-missing-include-9ccf56382f8a

Best regards,
-- 
Noralf Trønnes <noralf@tronnes.org>

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-08 11:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 19:46 [PATCH] drm/gud: Fix missing include Noralf Trønnes
2022-12-07 19:51 Noralf Trønnes via B4 Submission Endpoint
2022-12-07 19:51 ` Noralf Trønnes
2022-12-08  8:15 ` Thomas Zimmermann
2022-12-08 11:20   ` Noralf Trønnes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.