* [PATCH v2 0/3] Fix some issues in QCOM UFS bindings
@ 2022-12-30 7:42 Luca Weiss
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Luca Weiss @ 2022-12-30 7:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Luca Weiss
The patches depend on the following patch adding SM6115:
* https://lore.kernel.org/linux-arm-msm/20221030094258.486428-2-iskren.chernev@gmail.com/
The only remaining validation issues I see in the UFS bindings are solved with
the following patches, but this series doesn't depend on them:
* https://lore.kernel.org/linux-arm-msm/20221228124331.258416-1-krzysztof.kozlowski@linaro.org/
* https://lore.kernel.org/linux-arm-msm/20221205100837.29212-2-johan+linaro@kernel.org/
To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Alim Akhtar <alim.akhtar@samsung.com>
To: Avri Altman <avri.altman@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Iskren Chernev <me@iskren.info>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht
Cc: phone-devel@vger.kernel.org
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- Add new patch adding reg-names to sm6115 & rebase series on top of sm6115
addition
- Fix binding example after sm8450 move, split this patch from original patch
since it became too big
- Move reg-names definition to top-level
- Link to v1: https://lore.kernel.org/r/20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com
---
Luca Weiss (3):
arm64: dts: qcom: sm6115: Add missing reg-names property for UFS
dt-bindings: ufs: qcom: Add reg-names property for ICE
dt-bindings: ufs: qcom: Fix sm8450 bindings
.../devicetree/bindings/ufs/qcom,ufs.yaml | 35 ++++++++++++++++++----
arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
2 files changed, 31 insertions(+), 5 deletions(-)
---
base-commit: 98d95cb05f231dd0f155f912ec7823475b112f6e
change-id: 20221209-dt-binding-ufs-2d7f64797ff2
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS
2022-12-30 7:42 [PATCH v2 0/3] Fix some issues in QCOM UFS bindings Luca Weiss
@ 2022-12-30 7:42 ` Luca Weiss
2022-12-30 9:12 ` Konrad Dybcio
2022-12-30 7:42 ` [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE Luca Weiss
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
2 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2022-12-30 7:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Luca Weiss
The UFS driver expects the second reg to be named "ice" otherwise the
Inline Crypto Engine won't get enabled.
Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index 572bf04adf90..85673d562723 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -704,6 +704,7 @@ opp-202000000 {
ufs_mem_hc: ufs@4804000 {
compatible = "qcom,sm6115-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
reg = <0x04804000 0x3000>, <0x04810000 0x8000>;
+ reg-names = "std", "ice";
interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
phys = <&ufs_mem_phy_lanes>;
phy-names = "ufsphy";
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE
2022-12-30 7:42 [PATCH v2 0/3] Fix some issues in QCOM UFS bindings Luca Weiss
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
@ 2022-12-30 7:42 ` Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
2 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2022-12-30 7:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Luca Weiss
The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this
in the bindings so the existing dts can validate successfully.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index b517d76215e3..a8d896e1617b 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -72,6 +72,10 @@ properties:
minItems: 1
maxItems: 2
+ reg-names:
+ minItems: 1
+ maxItems: 2
+
resets:
maxItems: 1
@@ -122,6 +126,8 @@ allOf:
reg:
minItems: 1
maxItems: 1
+ reg-names:
+ maxItems: 1
- if:
properties:
@@ -150,6 +156,12 @@ allOf:
reg:
minItems: 2
maxItems: 2
+ reg-names:
+ items:
+ - const: std
+ - const: ice
+ required:
+ - reg-names
- if:
properties:
@@ -178,6 +190,8 @@ allOf:
reg:
minItems: 1
maxItems: 1
+ reg-names:
+ maxItems: 1
- if:
properties:
@@ -203,6 +217,12 @@ allOf:
reg:
minItems: 2
maxItems: 2
+ reg-names:
+ items:
+ - const: std
+ - const: ice
+ required:
+ - reg-names
# TODO: define clock bindings for qcom,msm8994-ufshc
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings
2022-12-30 7:42 [PATCH v2 0/3] Fix some issues in QCOM UFS bindings Luca Weiss
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
2022-12-30 7:42 ` [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE Luca Weiss
@ 2022-12-30 7:42 ` Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 16:34 ` Rob Herring
2 siblings, 2 replies; 9+ messages in thread
From: Luca Weiss @ 2022-12-30 7:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Luca Weiss
SM8450 actually supports ICE (Inline Crypto Engine) so adjust the
bindings and the example to match.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index a8d896e1617b..2f73a84fcf41 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -107,7 +107,6 @@ allOf:
- qcom,sc8280xp-ufshc
- qcom,sm8250-ufshc
- qcom,sm8350-ufshc
- - qcom,sm8450-ufshc
then:
properties:
clocks:
@@ -137,6 +136,7 @@ allOf:
- qcom,sdm845-ufshc
- qcom,sm6350-ufshc
- qcom,sm8150-ufshc
+ - qcom,sm8450-ufshc
then:
properties:
clocks:
@@ -243,7 +243,9 @@ examples:
ufs@1d84000 {
compatible = "qcom,sm8450-ufshc", "qcom,ufshc",
"jedec,ufs-2.0";
- reg = <0 0x01d84000 0 0x3000>;
+ reg = <0 0x01d84000 0 0x3000>,
+ <0 0x01d88000 0 0x8000>;
+ reg-names = "std", "ice";
interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
phys = <&ufs_mem_phy_lanes>;
phy-names = "ufsphy";
@@ -271,7 +273,8 @@ examples:
"ref_clk",
"tx_lane0_sync_clk",
"rx_lane0_sync_clk",
- "rx_lane1_sync_clk";
+ "rx_lane1_sync_clk",
+ "ice_core_clk";
clocks = <&gcc GCC_UFS_PHY_AXI_CLK>,
<&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
<&gcc GCC_UFS_PHY_AHB_CLK>,
@@ -279,7 +282,8 @@ examples:
<&rpmhcc RPMH_CXO_CLK>,
<&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>,
<&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>,
- <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>;
+ <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>,
+ <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
freq-table-hz = <75000000 300000000>,
<0 0>,
<0 0>,
@@ -287,6 +291,7 @@ examples:
<75000000 300000000>,
<0 0>,
<0 0>,
- <0 0>;
+ <0 0>,
+ <75000000 300000000>;
};
};
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE
2022-12-30 7:42 ` [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE Luca Weiss
@ 2022-12-30 7:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-30 7:54 UTC (permalink / raw)
To: Luca Weiss, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Alim Akhtar, Avri Altman, Bart Van Assche, Rob Herring,
Krzysztof Kozlowski, Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 30/12/2022 08:42, Luca Weiss wrote:
> The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this
> in the bindings so the existing dts can validate successfully.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
@ 2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 16:34 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-30 7:54 UTC (permalink / raw)
To: Luca Weiss, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Alim Akhtar, Avri Altman, Bart Van Assche, Rob Herring,
Krzysztof Kozlowski, Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 30/12/2022 08:42, Luca Weiss wrote:
> SM8450 actually supports ICE (Inline Crypto Engine) so adjust the
> bindings and the example to match.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
@ 2022-12-30 9:12 ` Konrad Dybcio
2022-12-30 9:17 ` Luca Weiss
0 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2022-12-30 9:12 UTC (permalink / raw)
To: Luca Weiss, Andy Gross, Bjorn Andersson, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 30.12.2022 08:42, Luca Weiss wrote:
> The UFS driver expects the second reg to be named "ice" otherwise the
> Inline Crypto Engine won't get enabled.
>
> Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=01b6041454e8bc4f5feb76e6bcdc83a48cea21f2
Konrad
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 572bf04adf90..85673d562723 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -704,6 +704,7 @@ opp-202000000 {
> ufs_mem_hc: ufs@4804000 {
> compatible = "qcom,sm6115-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
> reg = <0x04804000 0x3000>, <0x04810000 0x8000>;
> + reg-names = "std", "ice";
> interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&ufs_mem_phy_lanes>;
> phy-names = "ufsphy";
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS
2022-12-30 9:12 ` Konrad Dybcio
@ 2022-12-30 9:17 ` Luca Weiss
0 siblings, 0 replies; 9+ messages in thread
From: Luca Weiss @ 2022-12-30 9:17 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Alim Akhtar,
Avri Altman, Bart Van Assche, Rob Herring, Krzysztof Kozlowski,
Iskren Chernev
Cc: linux-arm-msm, linux-scsi, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On Fri Dec 30, 2022 at 10:12 AM CET, Konrad Dybcio wrote:
>
>
> On 30.12.2022 08:42, Luca Weiss wrote:
> > The UFS driver expects the second reg to be named "ice" otherwise the
> > Inline Crypto Engine won't get enabled.
> >
> > Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi")
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
>
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=01b6041454e8bc4f5feb76e6bcdc83a48cea21f2
Oh, thanks!
Disregard this patch then please.
>
> Konrad
> > arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > index 572bf04adf90..85673d562723 100644
> > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> > @@ -704,6 +704,7 @@ opp-202000000 {
> > ufs_mem_hc: ufs@4804000 {
> > compatible = "qcom,sm6115-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
> > reg = <0x04804000 0x3000>, <0x04810000 0x8000>;
> > + reg-names = "std", "ice";
> > interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>;
> > phys = <&ufs_mem_phy_lanes>;
> > phy-names = "ufsphy";
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
@ 2022-12-30 16:34 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-30 16:34 UTC (permalink / raw)
To: Luca Weiss
Cc: Krzysztof Kozlowski, Avri Altman, Bart Van Assche, linux-scsi,
Alim Akhtar, Konrad Dybcio, phone-devel, Rob Herring,
Bjorn Andersson, linux-arm-msm, ~postmarketos/upstreaming,
devicetree, Andy Gross, linux-kernel, Iskren Chernev
On Fri, 30 Dec 2022 08:42:07 +0100, Luca Weiss wrote:
> SM8450 actually supports ICE (Inline Crypto Engine) so adjust the
> bindings and the example to match.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221209-dt-binding-ufs-v2-3-dc7a04699579@fairphone.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-30 16:34 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 7:42 [PATCH v2 0/3] Fix some issues in QCOM UFS bindings Luca Weiss
2022-12-30 7:42 ` [PATCH v2 1/3] arm64: dts: qcom: sm6115: Add missing reg-names property for UFS Luca Weiss
2022-12-30 9:12 ` Konrad Dybcio
2022-12-30 9:17 ` Luca Weiss
2022-12-30 7:42 ` [PATCH v2 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 7:42 ` [PATCH v2 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings Luca Weiss
2022-12-30 7:54 ` Krzysztof Kozlowski
2022-12-30 16:34 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.