* [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support
@ 2022-12-11 19:52 Rob Clark
2022-12-11 20:37 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-12-12 5:44 ` [igt-dev] [PATCH igt] " Shankar, Uma
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2022-12-11 19:52 UTC (permalink / raw)
To: igt-dev; +Cc: Rob Clark
From: Rob Clark <robdclark@chromium.org>
Some qcom devices support CTM but not gamma/degamma LUT.
Note, the remaining failures on msm are due to CTM being supported on
one CRTC but not the other. But the property is exposed on both.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
tests/kms_color.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index d016cefb..cf9c27fe 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -230,6 +230,8 @@ static bool test_pipe_legacy_gamma(data_t *data,
legacy_lut_size = kms_crtc->gamma_size;
drmModeFreeCrtc(kms_crtc);
+ igt_require(legacy_lut_size > 0);
+
red_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
green_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
blue_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Gamma tests should require hw support
2022-12-11 19:52 [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support Rob Clark
@ 2022-12-11 20:37 ` Patchwork
2022-12-12 5:44 ` [igt-dev] [PATCH igt] " Shankar, Uma
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-12-11 20:37 UTC (permalink / raw)
To: Rob Clark; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 6417 bytes --]
== Series Details ==
Series: tests/kms_color: Gamma tests should require hw support
URL : https://patchwork.freedesktop.org/series/111826/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12491 -> IGTPW_8217
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8217 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8217, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html
Participating hosts (41 -> 39)
------------------------------
Missing (2): bat-rpls-2 bat-atsm-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8217:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-kbl-soraka/igt@i915_selftest@live@requests.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@i915_selftest@live@requests.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@slpc:
- {bat-adlp-9}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adlp-9/igt@i915_selftest@live@slpc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adlp-9/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
Known issues
------------
Here are the changes found in IGTPW_8217 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-adlp-4: [PASS][7] -> [DMESG-WARN][8] ([i915#2867])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adlp-4/igt@gem_exec_suspend@basic-s0@smem.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adlp-4/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][9] -> [DMESG-FAIL][10] ([i915#5334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][11] -> [INCOMPLETE][12] ([i915#4785])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][13] -> [INCOMPLETE][14] ([i915#4817])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#4312] / [i915#5594])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-hsw-4770/igt@runner@aborted.html
- fi-kbl-soraka: NOTRUN -> [FAIL][16] ([i915#4312] / [i915#4991])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-kbl-soraka/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- {bat-adln-1}: [DMESG-FAIL][17] ([i915#4258]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/bat-adln-1/igt@i915_selftest@live@gt_pm.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/bat-adln-1/igt@i915_selftest@live@gt_pm.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][19] ([i915#6298]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12491/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7090 -> IGTPW_8217
CI-20190529: 20190529
CI_DRM_12491: d322881f7e33af24901ee8ccaec3beef82f21203 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8217: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html
IGT_7090: 5aafcf060b6dfbb2fa7aace76c8074d98ac7da8f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@i915_hwmon@hwmon-read
-igt@i915_hwmon@hwmon-write
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8217/index.html
[-- Attachment #2: Type: text/html, Size: 7246 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support
2022-12-11 19:52 [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support Rob Clark
2022-12-11 20:37 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-12-12 5:44 ` Shankar, Uma
1 sibling, 0 replies; 3+ messages in thread
From: Shankar, Uma @ 2022-12-12 5:44 UTC (permalink / raw)
To: Rob Clark, igt-dev; +Cc: Rob Clark
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Rob Clark
> Sent: Monday, December 12, 2022 1:22 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Rob Clark <robdclark@chromium.org>
> Subject: [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw
> support
>
> From: Rob Clark <robdclark@chromium.org>
>
> Some qcom devices support CTM but not gamma/degamma LUT.
>
> Note, the remaining failures on msm are due to CTM being supported on one CRTC
> but not the other. But the property is exposed on both.
Looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> tests/kms_color.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_color.c b/tests/kms_color.c index d016cefb..cf9c27fe 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -230,6 +230,8 @@ static bool test_pipe_legacy_gamma(data_t *data,
> legacy_lut_size = kms_crtc->gamma_size;
> drmModeFreeCrtc(kms_crtc);
>
> + igt_require(legacy_lut_size > 0);
> +
> red_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
> green_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
> blue_lut = malloc(sizeof(uint16_t) * legacy_lut_size);
> --
> 2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-12 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-11 19:52 [igt-dev] [PATCH igt] tests/kms_color: Gamma tests should require hw support Rob Clark
2022-12-11 20:37 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-12-12 5:44 ` [igt-dev] [PATCH igt] " Shankar, Uma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.