* [PATCH ulogd2] build: fix pgsql fall-back configuration of CFLAGS
@ 2022-12-11 16:46 Jeremy Sowden
2022-12-13 11:19 ` [PATCH ulogd2 v2] " Jeremy Sowden
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Sowden @ 2022-12-11 16:46 UTC (permalink / raw)
To: Netfilter Devel
When using mysql_config and pcap_config to configure `CFLAGS`, one
requests the actual flags:
$mysql_config --cflags
$pcap_config --cflags
By constrast, when using pg_config, one requests the include-directory:
$pg_config --includedir
Therefore, the `-I` option has to be explicitly added.
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6ee29ce321d0..70eed9dc1745 100644
--- a/configure.ac
+++ b/configure.ac
@@ -92,7 +92,7 @@ AS_IF([test "x$enable_pgsql" != "xno"], [
AS_IF([command -v "$pg_config" >/dev/null], [
- libpq_CFLAGS="`$pg_config --includedir`"
+ libpq_CFLAGS="-I`$pg_config --includedir`"
libpq_LIBS="`$pg_config --libdir` -lpq"
AC_SUBST([libpq_CFLAGS])
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH ulogd2 v2] build: fix pgsql fall-back configuration of CFLAGS
2022-12-11 16:46 [PATCH ulogd2] build: fix pgsql fall-back configuration of CFLAGS Jeremy Sowden
@ 2022-12-13 11:19 ` Jeremy Sowden
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Sowden @ 2022-12-13 11:19 UTC (permalink / raw)
To: Netfilter Devel
When using mysql_config and pcap_config to configure `CFLAGS`, one
requests the actual flags:
$mysql_config --cflags
$pcap_config --cflags
By constrast, when using pg_config, one requests the include-directory:
$pg_config --includedir
Therefore, the `-I` option has to be explicitly added.
Fixes: 20727ab8b9fc ("build: use pkg-config or pg_config for libpq")
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
In v1, I forgot to add the `Fixes:` tag.
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6ee29ce321d0..70eed9dc1745 100644
--- a/configure.ac
+++ b/configure.ac
@@ -92,7 +92,7 @@ AS_IF([test "x$enable_pgsql" != "xno"], [
AS_IF([command -v "$pg_config" >/dev/null], [
- libpq_CFLAGS="`$pg_config --includedir`"
+ libpq_CFLAGS="-I`$pg_config --includedir`"
libpq_LIBS="`$pg_config --libdir` -lpq"
AC_SUBST([libpq_CFLAGS])
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-13 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-11 16:46 [PATCH ulogd2] build: fix pgsql fall-back configuration of CFLAGS Jeremy Sowden
2022-12-13 11:19 ` [PATCH ulogd2 v2] " Jeremy Sowden
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.